From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B041CC3ABAA for ; Mon, 5 May 2025 17:07:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ADFDB6B0085; Mon, 5 May 2025 13:07:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A8F906B0089; Mon, 5 May 2025 13:07:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 955FB6B008A; Mon, 5 May 2025 13:07:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 754926B0085 for ; Mon, 5 May 2025 13:07:47 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 72FB6140395 for ; Mon, 5 May 2025 17:07:48 +0000 (UTC) X-FDA: 83409486216.26.19225C8 Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) by imf09.hostedemail.com (Postfix) with ESMTP id 753CD14000E for ; Mon, 5 May 2025 17:07:46 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=owq4cqJp; dmarc=none; spf=pass (imf09.hostedemail.com: domain of gourry@gourry.net designates 209.85.160.176 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746464866; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=O9SZ6hDle3mFYLwdSqev9ZHk8hZbU5Mq9wO4mHZ7LZg=; b=D1l/QdvTbqNk92nnYa5g98hBA6MRoS8odMjWSBTcxaKobj7zMZM86FFHOFyjqo4z+CC4zD zTVSqAWsKBbHKoIfUpqDZxz+rNhLflwX2kOGCcDLM7v6pZxsxyfTaokaxRqv2mUQD9Hj9+ TQ7SEdUZzXrdcboIKQG7Cx+KVghQNzk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746464866; a=rsa-sha256; cv=none; b=WdesDisN8hJdRy4a2F5NARbsskiwWseHXuxoIzq33299Za4zDNlA/bOTXGMVLGwtl1Eve0 sVHfHYyhdgJzmj9Cm78xrV8zxNIoRvhjpEuqWZknSY2ZaGNAmGnPoesobnFEOIfwgn9KAa pm4IiEg3t7tbH7B8vRo4ATMHQnH8NnM= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=owq4cqJp; dmarc=none; spf=pass (imf09.hostedemail.com: domain of gourry@gourry.net designates 209.85.160.176 as permitted sender) smtp.mailfrom=gourry@gourry.net Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-4775ccf3e56so67519201cf.0 for ; Mon, 05 May 2025 10:07:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1746464865; x=1747069665; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=O9SZ6hDle3mFYLwdSqev9ZHk8hZbU5Mq9wO4mHZ7LZg=; b=owq4cqJpTr1Wz9jiFbu2iV3c7bFUHFkLlrgMFUkvH0LHtvidQre28hdNejEIThPBnQ Rl9nXPFlg6iftVfSgs5dszyS1ED9IkcIg2WdiO0PxJvGwNNdnVTQFRIa1LkhUmm0ur6G ZUlgLc0iMt+c0TiyT4nTSUTE+EWoo2OFZnltZ1FGk6ER7mlAHHr19VCfv/IpU2642v2G cMMNXzbAgQPARla/Qigg6VETvT8KiNe2szXisgryjE4AqLOS94scvWBp5NuqZdI3p9Wn itsUmgV8H990r7jtFXW742r/C7RT+/SM1fSaSLNj4gznDnlycrKiZbbpYhuu7ClGMT+B AcNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746464865; x=1747069665; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=O9SZ6hDle3mFYLwdSqev9ZHk8hZbU5Mq9wO4mHZ7LZg=; b=Z+MVK/+Ic9wEJrGJacK2+DFBkxA4ggLedgzj8RxVTBPObK3SrCaE7GgbhvJEzN/QZb rFAMVv9sQc8J5wR/wOXJ4vOkfrVrezFxofcl13WxZqnA59S5mrERFSQg7JSqgap1P8pB Li5mINQYEx7TLKiyRnHw14c6Sr+gplws4HsJWLDDb3XxvduVpQhRZeCPt0zdPousi1v9 wd6YG+iqQu1bU4dYes2hi/9b7zPIktgsoTsW2eZgI5VAhL2rSOVPnKF7tn7+q9yIycbb 86ZbJeiecmbBTEKoO+5TQFXJtBQtt834m3q7pRnde9iljLIOC+j+D++pmHlQLK2W0BN4 hsjw== X-Forwarded-Encrypted: i=1; AJvYcCUMGBaD25jNX426quNTRy4yKDx2YWd7wuRB/ue8c8obG9KkwuQlkdLsq4IgiaP99dfNn2d1zFOhwA==@kvack.org X-Gm-Message-State: AOJu0YzXXqjGCTyZG7o53VLDd2LoSqoav8VpDl+TkNRQSSyVb9U/PZJP lNKX4wenwEMLbrlW4CyZSISrUIhVVZergxNhQdquwAENPCYWlunz90FFOninDmQ= X-Gm-Gg: ASbGncv36vD/U8NChvnkCuyQ+lYk+xcGeJcQOvjwNqKcNyIyWQpt4+z13+9ZvSfaPYx vmqtw3wDPjc767lRDtKn9tTrpXxacJ9UOs87tSWt3xnYrkYFFBUudQcb12EWbKY9uhsr43e60pb JPd8a3oH5Q6wMKFq1nW0vySzgF5Md+9vpcemTybR7Sm4QN1Lmev86BhFwLDz4vS7nMX9E3GZHsv 9Kl9rUFlr9yLhPeK2bqFr0wCjoGpoip7bEOJ42X9rd1JRVikIWBaOmF35Xj7d5CkddhIYAJDjNx GH38JMxXzuca3Eocj+u+/0bfDtejiTOfJR9YuSRb2bSLprX22skFTe+Ghrgp74WT3cTPqcKw8XH g9Ap915Vx4dkGyVdTNOfg X-Google-Smtp-Source: AGHT+IFVEarldhbR4I+f9BMRzsRJwuDgMxfpCmFIHaeu17RGFuLoNo98m5TIGfII++0tO+OLdzUI2Q== X-Received: by 2002:ac8:5fce:0:b0:476:fd4a:e885 with SMTP id d75a77b69052e-490e27ac1c5mr3375391cf.20.1746464865541; Mon, 05 May 2025 10:07:45 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-96-255-20-42.washdc.ftas.verizon.net. [96.255.20.42]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-48b960cf0b3sm59914081cf.2.2025.05.05.10.07.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 May 2025 10:07:45 -0700 (PDT) Date: Mon, 5 May 2025 13:07:43 -0400 From: Gregory Price To: Oscar Salvador Cc: Andrew Morton , David Hildenbrand , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vlastimil Babka , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Jonathan Cameron , Rakie Kim Subject: Re: [PATCH v3 0/3] Implement numa node notifier Message-ID: References: <20250502083624.49849-1-osalvador@suse.de> <20250503200334.3f912eeb7ca484bca4eec7fd@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 753CD14000E X-Rspam-User: X-Stat-Signature: rdz5nam75xwqxgc8penengecnt7e65xd X-HE-Tag: 1746464866-10995 X-HE-Meta: U2FsdGVkX18s0m+jR1JPpKBmJ3Cwcs5V1KWuU5Ue6U1nNd7+i6do/vFMJy7CbHMF7oFk4yuMiJFTBTKHX/gQzI+r+di9Oq0rb8cGMysxpO4ycxBJtWdu2JRqORG7HL6SvNo14qajFdxm213b71RkYedWG49DRuVFSqWgf2zo0MMpAfLT5lyd4dzIzMSCQ6UktMMugcUz5GttIL6b7ZckL8hP+ltxmDxVLc9nLCQlpUUVE43p9iPazZdg4InaCiRJ3kYipHYMMQ85CC594Th1eh19rS3SCr3TH1GP8gZXOxFRXuzDQpMyvHD2Mezf3oA945xxa84ZInS0k6snApcdzCanxVMvJyWtlM/7VsY/PcNbEwjhTqPitfrSKsjgoIrm8SD9xDeTAV47qkxB7HRJm5F3y6suk/IqDBphjEprFhIYlCKfw7rk34V6euEnWP22SFa2IJBJQ3bmuiwf7Vq1i3wstmy4SyTAYSB1wK4Q11ViLXKlG7IyYr5xqj8aa3hSU08PwYtG37a6p814w99DmZCj+8TXCJBfVlpQlUt5Jy+iDZ/9WMw20ZSGbfdsdWPcoqCa+tpLyE+qGqMHJjmBY1WFuCsic+tXawBoNyg8BoY9pLTZlBJrSZGADteDmmhMhJEg0AfeWT4oIGQPdhT3bfLmjGmszbHQ0HBqJ7/aCIjmkOj7Va+iJyLW3vt+iXVC2aoHiDM2+YDC13XQV2F8BvTqAIzVTOQaagV4zUvzthbDkzTF5URXTQT8vg1ofb/AtFj6kWvAfJr4cpvsr4BZKmlKu6oSZMOKyadztZo4RO+F+Tdizco5gufC4Q1lmjljYaXEf6IgjiFk8YSm9/feIYf1aoHqtz02LVQUUl4ZLedeaUI5Mt7Y1nat9vfRvQmtMoocGaDqoWSTVWx0aqhYU+OtbViA3WuhMRp9ugHfbBOiKTq97H/UN4Sio0ON+3AG1YuIVeBmyWzjqC7TSBn mGNilCRd u3SpXyNm03ZRHv700n5o39Dlxav0yWGpD0zCTyPJ7ycao4sgw/q3sA+XEUUKk+G6XRwn2Ue4d9N7Q6y6YobtUZLYVgfGkh85X89oXT31KV9FW5BBz5wF7M3G9+IPiO+V13zKPfTHqPN64u79QNbU7FGOr5X3Qwfrjd51fln5Psdnc5ewydZKI0fuBtQk7viM9RL4YrPla5d7uqy3eY2zMKqF2etnARD8aQG+XGc7h/EJwyNN0x5Thl17aASo0BJf/C3hJdpPdLRzNDcCUywHoQcj3B55bZMWsTRHkX2/FaTcoPf9aCYo8CsIZ3LkEBXATHRWGQ4DdU4VHjubKBsGUh/LYLRQsc3n8MGGKFG1PMX8rw7z/n3O21pg+Q/CP2/ihmHcKMVrhrbuSaD1gGkGH3fBbGg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, May 04, 2025 at 07:44:40AM +0200, Oscar Salvador wrote: > > Further down-thread, Gregory tells us that Dan's patch "seems to fix > > the underlying problem", but nobody (including Dan) told us about any > > "problem" at all. > > That is related to auto-weight mempolicy patches, not to this one. > I _think_ Gregory means that I take it in as part of the series. > Yes, sorry for the imprecise language. The two patches address similar issues, but one without the other leaves us in an odd state. 1) Returning an error without this patch is an un-desired behavior because the current behavior can produce duplicate online notifications - which is expected but odd. So instead of returning an error, we should just continue with the callback stack. 2) This patch makes it so that there won't be duplicates - and so returning an error if probably appropriate, as something is actually wrong if that happens. So it makes sense to pull these changes together. Thanks, ~Gregory