From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75FBAC3ABAA for ; Mon, 5 May 2025 14:32:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 97BF06B0096; Mon, 5 May 2025 10:32:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 92B016B0098; Mon, 5 May 2025 10:32:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F4B06B0099; Mon, 5 May 2025 10:32:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5E7C36B0096 for ; Mon, 5 May 2025 10:32:21 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6EC5A5B639 for ; Mon, 5 May 2025 14:32:21 +0000 (UTC) X-FDA: 83409094482.20.91FE870 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by imf17.hostedemail.com (Postfix) with ESMTP id 5ACE940016 for ; Mon, 5 May 2025 14:32:19 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=zekUT4R0; spf=pass (imf17.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.49 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746455539; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=a+ecdvXRp9B7lDrSJDnwst1YRnJE0a6dpkQ8An/AD48=; b=e6FaGPR+wP2hVHePFvraObajUtdhW8u+hPWdIU4klPLFsCWHShV45NyTRaiKEaG3uqaa1V voENOJ3tLsUExqyhTP0k95c1TzF05Z02W11i10lr92D01vBix5nLhrq5HtcmkeKkJeszoH oPOci0iqMrYu/DHbdV117LKHBq9elOk= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=zekUT4R0; spf=pass (imf17.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.49 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746455539; a=rsa-sha256; cv=none; b=l8dvCYm6yfh5lOU8KxGQnTF5DHMpt1ThLhxsISuds99dMGMvM0+fxEBfIyQTty/7aC3UH7 LdbghXWZUMYGjrwkgHYfxzqLYajdXbBnZ4hgLwpl2n+DGAXStb9izr3t/DxEWIxLCrn8EQ ab7kYEYAPE3FJeSMAZfrWNf4Ci1X09M= Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-43cf0d787eeso41187135e9.3 for ; Mon, 05 May 2025 07:32:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746455538; x=1747060338; darn=kvack.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=a+ecdvXRp9B7lDrSJDnwst1YRnJE0a6dpkQ8An/AD48=; b=zekUT4R0JZ/LXCUvPhIsYofK5yqQ2BFvIhRaLasaTSgPDGMagfvQworEI8EvCAvmej 9ZS6KjvMZNk8uYyqRJCi7eG6gnp3jUCcZNlfYpiBnd1XvO005wuPorifzDT1Wkfjm0PL 82NhmhraPwW0EeiwtRtEYPHgxl5EkITH3+yIyGNZR8vvPKgjqjy3chbMWKIAeqSM7uIu CdFHpxPCgZi00gKKPNzP7Ihb1s1P9BRBHA82z8odJPRUz1gjW3CgWKpYKLzzgYZi4fTj V4KV3B3H8+/Ohscvv2NXIKF/RnWTExEU/JAxeFMM0+eprNOD0JUGLHPmAvl36GF0oa9B Lhiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746455538; x=1747060338; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=a+ecdvXRp9B7lDrSJDnwst1YRnJE0a6dpkQ8An/AD48=; b=uZs/kYryPtBcH2h+ISpixB+/84OwsnfifV9mYDkb7yqSZ850w3ti8UPvBGRNjgpTTj NlV6X8i2JF2Y5TunjVkMSjS87VRnG6/JR1IwFaeusPQq00yiTec893VwxEWwLJSia9qF 4ZzVZBpK4JoZOx7vQ3mqGJMStGZx+w38bt3Dxo/ikAsxtRbbqV4M7vIjVEpCI6qb10ZV C34teb1wYKR0juUvKCLNZPtriltWmamZJOEk4b/Sl2WTveVNlWYtvUGQevonTUmtTXB2 ADHBL76nFzB/8iZWL/VgC6lKb8wmbn3CMN3DeItKvC/LmKl9boeuebXfZ6QXbndqGXMF DOOw== X-Forwarded-Encrypted: i=1; AJvYcCWmujqSWVsWdBpfeHQm3zQlbBMdyISQv1ke6NhSZE+SSQ/qiXl4S8yUnlndxxHI1K/aT0TKvF1ZOw==@kvack.org X-Gm-Message-State: AOJu0Yw5DeWUVXni0x777fNsgHjHO1sATTLjPU0uj8ROrPqP8klyYqSD sYJMq38tAF1ewY86dS6Yfyie9z3Z6imi5k7j7CzHuSCGFwVPDA/LhVj37AuzSjY= X-Gm-Gg: ASbGncu/GDuBxljHWTRreSHTBw2V3Osto932P1SGMKpkOCAGkJOT5KCGpClpex7npaN XlMFi+sHAlqfNuVUxDL1XdtlQZPLy+2DMrIwtnjnjx1xUGXOG0INrHIA6Z/D/ZnWAIW5FiEzC4V J9GT+p05S2S7F+rJhX/z7CY5uIGGTbHCghKLRd4R6WsYI3uagkMoODG7nqEgJ2i7cm/MMQnpDVV iA7SHhXfKOGe45vJfFBLWFiyVdRhlr8jck0g0Zg/AXSs2tZIIurmDzBPA7D8u9edu+glro98Ek7 qVx9MoyvQ8g6uLocebVmAR50gy80YsabIW79dwxzZHSBnw== X-Google-Smtp-Source: AGHT+IGyIpQEeGOI1bpJxkqVYKCv5xmDFxvVhoHPMyQ+WpC+IU6OnU3bGuzYtxbn8Ywflhv/y8WTSQ== X-Received: by 2002:a05:600c:45d1:b0:43a:b0ac:b10c with SMTP id 5b1f17b1804b1-441c49236b0mr63894895e9.26.1746455537718; Mon, 05 May 2025 07:32:17 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-441b2aed5e8sm180265185e9.16.2025.05.05.07.32.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 May 2025 07:32:17 -0700 (PDT) Date: Mon, 5 May 2025 17:32:12 +0300 From: Dan Carpenter To: Rakie Kim Cc: Andrew Morton , Yunjeong Mun , Dan Williams , David Hildenbrand , Joshua Hahn , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH v2 next] mm/mempolicy: Fix error code in sysfs_wi_node_add() Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding X-Stat-Signature: fcfhyeyn9jsoczcnyaetb4r4i6rhgmai X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 5ACE940016 X-Rspam-User: X-HE-Tag: 1746455539-307330 X-HE-Meta: U2FsdGVkX18zAMWGo47ueupSe3ihSUkPX9hVRLtaBzslKk1UBEKPP30XlUZQxFpsP/uGmKkgeQR9XflBaYbKoniW/QU/7UzP2tbYE46DoX3NSIrtxtBax/rjLyMlrrsSILoEdu0WougPTZoOiEOKz880WG/7eLpt/rdshEA1OvofzNyfAAzbtCzBsA55rUmEVHGJ3JCXI23PUEA/oxphVMQ0S/rUrLajviOFSJkgRanipBTbLvH51QvtzoZv83AyeKZAzpfbJed7i8AWVgn2SJcIJAmzda8ePO8HVeHCqFHE5MvEfMhQtSeYC9xic7nndWVoCxucbxZAjGiLiUUAksr8FOc3CUEmZ+hJxZv/VKRZqAhiQYtEREr4ZWSqW6bzB032ybb0fVUwXDR1FqBlCc7EX0VOw4hdaW8ZCaAXHcugHQC5oXKzdozEFgMyVM/1/YOtxgo1OHQwV+D46pWiXyvp0jV80LFPuuqRmRULH1zybTsRJFF71+pWTT4vNhLEcdaxf1H6K4U8Z0btSb8O36RkdyZCCj4RqCww7/wAvrn/2kI7nXJyz4rvOHmLiN5NDLf6rvULjVzxMDwzDO3ywtebC5XhIWM5apFDuorcT6q6QI7ZT52BHDTJqmxYxZpozOgRX29enR85pjtKSAN84Q2lS5VCaPb17jdF3KxaDPZZpxSPxhiBYmI3QoZ35wfIo6TWEATKjUV0pELqrb2vwzL2Z+zJ2/aWS8VGC58/w8vDNYjgmLmSgYfeS0BsPwsb+FJ/yVd+htc/wd4rlRwgsOrBUOc7Esvx4Py0lVtb/Ua3t69wbbIruZoGtm5UD99mSNPCDj7XpH6pGJEioIsuorcaHXX/pISFJWVgNirYKmcsUMkfQw2oRL0kjFzuuExRw2t4Hhjr1siMmS2ZbtlhTE9KEsv2++TipJrYt6HrXJv0f+xNq/HbwH1HAfJecDUZ/VHjFRoCM2yyuvJpTXU grpmhizT eKg8i1tIVxLzYQjVFBHFrqHeV6BQDaFK+pNWbg0PGxyicTz0pkWQLuGZQtSpgyk14B7oNUHpOYzYTHAUVr/pa1sdo5zPHPqgaOdrIRDZ6PT1HCTghIEXx0yh7hYfRgKCBNctxdNbOvUEpEeQNBJmeeyIXxENmPx5JKgiTCS/jAL5nBu39t4ZlWy//J5Ytrfm1ulb4xJJqFXL85Lkxlq0uvgGvyyMbMlc99FHRdNyDM2HKTGQCWyjS/cVkvE1jMqoKb+JRpFD/q+yJPQqfsECHeT6okkzpHP6YCufrXNn+sPJgdUlwf0Ahj+HJ0B/2fdo2BdA3hraNyPFjKkhepatYY+4HLE0Jt/tWoll/O2rVbEHLTcdsSjKJspj0oBExj8yjEgg9y2SgyDHjhc+W2XWH7HZI3gkmXl+FEC0EzHWMPNu88S0whDP3hVlCur1FoRgn86ILVsxPr4qH3J2wS2hbQlbN/r6W83WbF4QacXHP1AI5YNqjv/sJdyKpSKcdQFK2i7yaEQF2nCAbyAIeTDk0lm1zXLijbKIWa8XG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Smatch complains that there is a missing error code here. Arguments could be made either way about what correct behavior should be but in the end we decided that returning -EINVAL probably made sense. The wi_node_notifier() already prints an error so this pr_info() is duplicative so delete it. Fixes: bc7527e0a127 ("mm/mempolicy: support memory hotplug in weighted interleave") Signed-off-by: Dan Carpenter Reviewed-by: Joshua Hahn Reviewed-by: Honggyu Kim Reviewed-by: Rakie Kim --- v2: Delete the pr_info() message as well mm/mempolicy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/mempolicy.c b/mm/mempolicy.c index f43951668c41..9a2b4b36f558 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -3539,7 +3539,7 @@ static const struct kobj_type wi_ktype = { static int sysfs_wi_node_add(int nid) { - int ret = 0; + int ret; char *name; struct iw_node_attr *new_attr; @@ -3568,7 +3568,7 @@ static int sysfs_wi_node_add(int nid) mutex_lock(&wi_group->kobj_lock); if (wi_group->nattrs[nid]) { mutex_unlock(&wi_group->kobj_lock); - pr_info("node%d already exists\n", nid); + ret = -EEXIST; goto out; } -- 2.47.2