From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55BA8C369C2 for ; Mon, 5 May 2025 07:28:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0F0096B008C; Mon, 5 May 2025 03:28:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 09EB56B0092; Mon, 5 May 2025 03:28:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E802E6B0093; Mon, 5 May 2025 03:28:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C9DE56B008C for ; Mon, 5 May 2025 03:28:53 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0C1735FF8D for ; Mon, 5 May 2025 07:28:54 +0000 (UTC) X-FDA: 83408027388.09.92094B6 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf11.hostedemail.com (Postfix) with ESMTP id C71AA40003 for ; Mon, 5 May 2025 07:28:51 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=PneJWDha; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=OohfR+Ag; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=F+8R65GK; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=xJJw1lhk; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf11.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746430132; a=rsa-sha256; cv=none; b=myDY7MO8GEYmqjyKUWcNX2nNYMfATlFvk8F0m8A6su/ygCLSFNb87D1BPN0ETNHUTN21cS caz1lkPNxM7wW9o2wo5ggLpm/3CSx+pAgOUKFyH7u+zLOSpEvE2FADf1V5DFXTNzBtkS8c V1dSAVNLFuennxIcAYBnfqtLm+8qMaI= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=PneJWDha; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=OohfR+Ag; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=F+8R65GK; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=xJJw1lhk; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf11.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746430132; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sEYsB7uW34S76OweS7u+InfeYR/X8HZiTEj8FSKCUN0=; b=KAPVOc8DtzwEIfjZL1//OmYgd2O2gnfrlMyanO0DSvV37tKhDXHMLb+wo5TjJ5O8cWwTfF EPblgnb91hmnZ7dfH3HSKWY/4YiXcmm+gAV/F6AkCl+csW0DzA4A+rxZPubD3GkL+B7WmS ZeO1JbBjvVE/rgAoLoqM57iYmv5xNJM= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D1AFE2125C; Mon, 5 May 2025 07:28:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1746430130; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sEYsB7uW34S76OweS7u+InfeYR/X8HZiTEj8FSKCUN0=; b=PneJWDhayP30w9A8ogY8FM4MU0dpp+8dyuOcoMp2/SJE66T+31kM/LjAkzoqpAaHn+Fuox TrEij4+brhmzLFQWAmER+OauM9ZggUkoryaXY8oTN9Safd6yW7f+/pbzSwvitBu+ki1x/T Zr4UZfM9irliscomy1h4V/RxhFYGUrU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1746430130; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sEYsB7uW34S76OweS7u+InfeYR/X8HZiTEj8FSKCUN0=; b=OohfR+AgslAy42OiwCQAI3Nspb1ZGKRWC9cdpw4g3BZddHDiasqzsFlY2lFxf/Z1appdAj Ubvd/9MeZXRL7ODw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1746430129; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sEYsB7uW34S76OweS7u+InfeYR/X8HZiTEj8FSKCUN0=; b=F+8R65GKXrjkyrxIsalR6m8iv8Vm6RMngEUjzTojPXWIt3XihHrznLgQkVXm9BV3YHLzwQ N2QUWP68Ms/M8foCuDZl06kvVc01XdRXc/MCNIclC0xSXUUyxO0H2KThTRi4UupiP3Ee9m XH3SN6Yd7O6K3Jgo02/f1SMBRt4TucQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1746430129; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sEYsB7uW34S76OweS7u+InfeYR/X8HZiTEj8FSKCUN0=; b=xJJw1lhkhSpiVJbGzextQDrsEnPJD0PRbLyqca4/cN1jOzbYm34ffcqsO3L/xC0/qP4t9l L10UgGwJD4nDDdDg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 0B9A31372E; Mon, 5 May 2025 07:28:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 71ITALFoGGg6SAAAD6G6ig (envelope-from ); Mon, 05 May 2025 07:28:49 +0000 Date: Mon, 5 May 2025 09:28:42 +0200 From: Oscar Salvador To: David Hildenbrand Cc: Donet Tom , Mike Rapoport , Zi Yan , Greg Kroah-Hartman , Andrew Morton , rafael@kernel.org, Danilo Krummrich , Ritesh Harjani , Jonathan Cameron , Alison Schofield , Yury Norov , Dave Jiang , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/3] driver/base: Optimize memory block registration to reduce boot time Message-ID: References: <188fbfba-afb4-4db7-bbba-7689a96be931@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <188fbfba-afb4-4db7-bbba-7689a96be931@redhat.com> X-Rspamd-Action: no action X-Rspamd-Queue-Id: C71AA40003 X-Stat-Signature: xg4zogjj4e5ibz9t1nd5sjgr6asep153 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1746430131-171478 X-HE-Meta: U2FsdGVkX1+3G9m+Uo8rvgliKuf/9wkRonAljaIxXPcsCybv8LyArGuJSok4c6CXZDxR1daUpWhWkDTzq26HuzSjgs/+G6vHysHdUN5tz9QMmWHb3UhjvsvosGXwH7qOSXQ3qp6sm20ggZgfsGgg/7NtnB4Y5oTSCJkAVzCouKAxXV0UW89oIXLuiDk3PRsjcJWMfeiSNc7JoHc4FRM3HEwj53hBD2Ac7BLMcKM4CXGLdhWD7cvuRQApZsuWp9p/uAfcUiTDMAI/g9CoBzFGXwdApooDs5mTELYjdQR+aRbf0SOWbjEfNtZdhZ1XWI4QTBsIY+rgSDPU/6AZPjGAp6eJQYTbEiMEsgeojh97w2521RpfJSqqtYneQbz9FXyUutMxO6krERbY4oZCizT7LDL9qWiYgtPZUuivTvi8494NvpdnkJM/3u7F4wkoI036cVsayy1pDZ5LEKCy/9W9G3GU79XfWUh61Q+2pYBvkPWZdkpVaQEwAGao2SrvPjAiQ49xibKVZRcBdWQl3ofTfrKDKq/1dcA5LqKF6OsIF17K+U1JX5ns9NZSBSeqRl5/eWZ748rC0+mvCPFAYB3BfF3k/5sdkkfmWwFXNiFm+U2lDPHc24efhwPj4I2MqxfQfz3ImWH3pd/ipTFy1cYe5S4igeqnPLhVmiVI4LJkDrYjijbi1IKUNPLuxwUHLB13I9neUEt4isrsdFyQ7rrmKhGj7ifYBIquGvUD7um21b3wmpIlFn+q6DZcN+xG0R9GrI3nR70/Fw9IRESrmz/x+3SNQmssw1Oef833eqV7tl/Bc//xbS9qCOaWJV+0Ay69j5Xp4VJGF4xc19s8Ft4rpKmUTAmx9KkZsoYYuG44bkCGNZWpOTip7vjvwdNpBKXXcgAjiVIpn6y/Hd3piB1WmuWy5zrKOXIs/2JZom1YPguEYgSUJ2j1JMB0KtVmSQtSIcEORbPu91qV6EVSKm0 MubU570h Zy36UupAVl52RzsBcoPcufHUvI760DdzqnOAA0YXXXQ9iTTgeutKq9eUGQaFN+jgChr8jr0S/6EtAdKBdWYVJT3dRoKl9YPm9lZ+YNtEEgpYg3/DxT5BUtA01Xno8NqCQ3X+aezv21Knokf9Tz8fh7PuIez7BR7mdlAPKDC12ecA8jxq6TR6t9wVkx6EHSJkWIddWIMmljegzEwD6+w1C92pG4hy4B54HpZjfZuXrZxwo8hpXVMqM51XU9nsSuTjNifZYhIKOgzgMh7w9iHR3j0Ypw8Z4B4hGuCrmWGUhTj5/HSUmXHlbllay23Y8oYfKrWi/41ykE2pZwmc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, May 05, 2025 at 09:16:48AM +0200, David Hildenbrand wrote: > memory hotplug code never calls register_one_node(), unless I am missing > something. > > During add_memory_resource(), we call __try_online_node(nid, false), meaning > we skip register_one_node(). > > The only caller of __try_online_node(nid, true) is try_online_node(), called > from CPU hotplug code, and I *guess* that is not required. Well, I guess this is because we need to link the cpus to the node. register_one_node() has two jobs: 1) register cpus belonging to the node and 2) register memory-blocks belonging to the node (if any). > I think the reason is simple: memory hotplug onlines the node before it adds > any memory. So, there is no memory yet, consequently nothing to walk / > register. > > This whole code could deserve some cleanups. In particular, I am not sure if > __try_online_node() must ever call register_one_node(). As stated, we need to call in, but maybe we can decouple it somehow (cpu and memory). -- Oscar Salvador SUSE Labs