From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18543C369C2 for ; Mon, 5 May 2025 06:25:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 839C56B0088; Mon, 5 May 2025 02:25:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E9286B0089; Mon, 5 May 2025 02:25:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D6C36B008A; Mon, 5 May 2025 02:25:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 50E4E6B0088 for ; Mon, 5 May 2025 02:25:18 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2F0FBBE620 for ; Mon, 5 May 2025 06:25:19 +0000 (UTC) X-FDA: 83407867158.09.25E9B65 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf15.hostedemail.com (Postfix) with ESMTP id 1D983A000D for ; Mon, 5 May 2025 06:25:15 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=UyZZTM9t; dmarc=none; spf=none (imf15.hostedemail.com: domain of BATV+9b9d72b124a21f5aaaac+7925+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+9b9d72b124a21f5aaaac+7925+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746426317; a=rsa-sha256; cv=none; b=imuPC9S4RW0mFBC8TRBwEGnSDrfxLhDeAh5lbe1DUDGOVGTA66QKNC5xMwxXYTKuqUjLqI k1IhEbLzPr0X6noo14eigJgqQmp1BVj3IVjsnx3DOLVZ3l3nhSQ11hohwLDxZJsiYCr/nB p0EA04bn3oCrw9s11w6HtljgVFUaZg8= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=UyZZTM9t; dmarc=none; spf=none (imf15.hostedemail.com: domain of BATV+9b9d72b124a21f5aaaac+7925+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+9b9d72b124a21f5aaaac+7925+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746426317; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=s/xMaDNLYNBf+TVFwKfhS1jR/jduc9puXHYlUILlFOs=; b=QEinLoWAxQFIMfL7YEcawiiDakgcOYnTIAubYCPcu9FVgdfbO+KdluHMKX8HSmybYHoWUZ DscUXcoWeRk5Vd53kePBJFVdvHDE0zMYasDeWSW04df1qeOZGJakXEZouFw3q7JRY45zuo yudLlNueRJ4wzpp5upj+/6FMGgclTYA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=s/xMaDNLYNBf+TVFwKfhS1jR/jduc9puXHYlUILlFOs=; b=UyZZTM9t1sVwbNQwo9o0qPHIbp xX5VGpqeiifJf8K3OfYglK5GvWTFFVar7iIYS5A7dxwAiz4mUgPsh7iUPcSfx2WYG8oBee6wm7+8N h/kbizK0tlr0RfMhsFrfA+aBVM0jtSMmvaje8tspSqmHU/mWIvX7FA2n6T8SJnChXlOWXaxMdP0cS 5WOSouRgoRqf99PFwdlxGcSSmipCtf+EmkqwaUIfzKadga1RvumUFIqOOHccWs+v9MzAk3rWgjjW8 et593zzrug3y0WUZl8yu5G7P9RZHQhOeY97dnBxZG9QeCcx1VE/ltsrc3190qp1tclg48TDCTn+Sz SZ4qZW4w==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uBpGJ-00000006WA3-45g6; Mon, 05 May 2025 06:25:12 +0000 Date: Sun, 4 May 2025 23:25:11 -0700 From: Christoph Hellwig To: Luis Chamberlain Cc: brauner@kernel.org, akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com Subject: Re: [PATCH] swapfile: disable swapon for bs > ps devices Message-ID: References: <20250502231309.766016-1-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250502231309.766016-1-mcgrof@kernel.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 1D983A000D X-Stat-Signature: jzuytxcrykpccofair757rqa4q36p7kf X-Rspam-User: X-HE-Tag: 1746426315-812506 X-HE-Meta: U2FsdGVkX1/M077g/d/4gd08noIhGpvm1S6crIg4IRWxER5Ymhunjmvt7iU9ZE/obz+DrwAC40gC/zcRThVg+X7yOI6lMevWZgIoS9BzD9F70hjX+ReGnw0awoF0xePgbfvYuZTuT5FG1joBcuaB8r+ok9Y17sueOPBuOC7Qeo/H7dI3XxYUgBsSgy4jf7r5b8RPvXgUCTTY7xxg1U0DRsWUY9uB0IblR+VX2PB+rJ6Eo5UvfOYO+wm27nh1Iar27uBWF5rlvTH77SYCgdr6kaCTlOHzicah49KXmIQprqa0UPICu8zE6Iuv+o/GFhZ3z9JxXRzbrmRP2PaEfWEPms/5vftfKPEKst1ni+Jn6YAakXuOjDEtNh/wNpKn0Er04KU/D4CQwWDO5SygENt50PXdiiMsHYE0ZSy64KzFSsog/ZveeOfzPQy4EXiPyUNgZpMvZNKHv1+0o8mu1iIl1BG9NIPRkOyAo0Y6NJ17XUunsXaMXDSUswCZd3XZYFcKjaObMyjhWyVIpwN7hvM8zFYPJzVAXhVePr1rN1ETzgeYVJZFSry7XdyMalQkpWACgXLAhXPspcVb0shk586ZGhCf6Mo71cUGKhAytWmPbLGvQtQ4qX2wNwU4ertTYGpQt2jGFj1R+Ej8D4VehgzjRbKb0WSvxNdznPIApl8+mo9xJ9lcTBwI0Hql/37VL2kJu08ZvV6yBW6Z6bvOWk97mg556oTFK0p6a5XP4FTwGUGcbzj9xpu/s/8tEhfvzMo60QJBUzCagKI57j0D7yZ7EnaTG9Jf7vjpzYrt7xzUeDJ4ru0CFSW5RZEgBSu8idDEXB3JZ28tOQqXwkSpEQTb2cIzPMN7OnGGiLeWJcUEateI+UHoAnFjVNVTAg/WIjMVHpYFRcoetZRQe/Dq5LWR2Wca8WuvwFk+gJh51qd+tZbJb1f4lqOafAodTETs/GiU8CvVye/Lwvdw94KQ7Ix c12ajlbo 8SbrV+dBceXRnmoCCW7mYwgfDtRpY463lUPvHs8tfqJaN3s0p606NtLnOdiT0fGVvkXmbtHPghTmo3+WPMv8eeloiumqX80J/imxM4Ckz1Atm1Q9j+mfOhfKOfVkKYtboYq4WHO/MFgr06fHYk6RZ0dv8uuiynNVjg+J4KbQqiCjlPFFx8K5rJNXjtRRiepxPtXb21682SFR8j/em2JmpAAdms4KVN3MoHFEAMVb/3rTSzcuSP5x+36Y9+vPYbmp2kmc8NyyMMl0Mw8/LohjAsYF8UiA7n9xrxYjN06KtM8vjOOZ4QTaL210WWkNonTRxvfCh/u0iX95fSWcxt0vQC6PDutnSGrhTjIMiVgQa8Z8WcLTS5yBomK4Ll6ZYUphyIlhBiEYUxhxw0eGCCWEb0A6Q5psS0JzvB92Htxth6fIy/4Ef2caW3gewaYcs+orZZMHfPq4w2qStdlv21zamsV5VkS78yHccyYQ+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 02, 2025 at 04:13:09PM -0700, Luis Chamberlain wrote: > Devices which have a requirement for bs > ps cannot be supported for > swap as swap still needs work. This should work just fine for swap through intelligent enough file systems not using the generic ->bmap based swap path, although performance would still be horrible. So no argument against the check, but please add a detailed comment for it instead of just placing an undocumented check there.