From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75EA2C369DC for ; Sun, 4 May 2025 21:35:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C30776B008A; Sun, 4 May 2025 17:35:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BDEDD6B008C; Sun, 4 May 2025 17:35:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A7F706B0092; Sun, 4 May 2025 17:35:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8A5C96B008A for ; Sun, 4 May 2025 17:35:23 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 2A87AC0D41 for ; Sun, 4 May 2025 21:35:25 +0000 (UTC) X-FDA: 83406531810.27.ACDDF49 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) by imf12.hostedemail.com (Postfix) with ESMTP id 4213640003 for ; Sun, 4 May 2025 21:35:23 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CE8Cf9wQ; spf=pass (imf12.hostedemail.com: domain of nifan.cxl@gmail.com designates 209.85.215.173 as permitted sender) smtp.mailfrom=nifan.cxl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746394523; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LxqAQ4qa4aQrK+Slwlwin69lCuzL8oj2mCF2hCGkFIM=; b=UhZha9BSzmu8P4cIetDR9ZDVE4wm0/Nqrl20X4YhliYktMEDUM9x6wOWfWn8XRgjj1fyE7 FZ1kGnrIxEFbnY99DGmhzgJnHga+eCxbGLzRF+ehCvOGAZUEkvXz15o5zdGLZ2+UVxhI1p JrhjrmqfUxfS5Np3hILdHX+r+XIn4dk= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CE8Cf9wQ; spf=pass (imf12.hostedemail.com: domain of nifan.cxl@gmail.com designates 209.85.215.173 as permitted sender) smtp.mailfrom=nifan.cxl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746394523; a=rsa-sha256; cv=none; b=VP1JO9rUeEsNbMnaP4Mht4IPxdGhM2pITwEgzn8HHFQ73pu9R++WqBXPj9nXUvhcN7TS51 XG5Xh+xRTQNsRnY+O8HxUQ4LwBFzbwBq9ZxBVOnK+0wNGv1xJv0O0xkglhVyw5x+vYO9V1 +QfUJ0avdVqAuN2Qk+lLqgm4wCjEJEs= Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-b0b2d0b2843so2814870a12.2 for ; Sun, 04 May 2025 14:35:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746394522; x=1746999322; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=LxqAQ4qa4aQrK+Slwlwin69lCuzL8oj2mCF2hCGkFIM=; b=CE8Cf9wQ87Gf43mr5x/KBlXDpdkgq3TXiAIWTlA4MSMn9o+GuapFYkbbYOrnjpo2lN TXDR8QzebXnjUkyF7Ps2JOHyJDLPiufhj03s9BNFDKLh/yJpIEfVTx5ZNYU76Zc9tfER ceadqpLkYVkiBWlRU9xghv7Ch91xD418m4KhyM7J04DYYDEn6h6EZF0PvU8geK281Eut yscxU2ryppRPZVum4rlbYQzjyOo5LwP0iDOKyj5y2KCldkzdxcxQT/DSE1ZhpX2gGOrw lJCG1MhGP6lWLwt1/+6hRKdQ0TiJ5Eihn/xPMP8YPi4/eEcmWa7mTDCihTOvtxJXOqVQ bCOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746394522; x=1746999322; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LxqAQ4qa4aQrK+Slwlwin69lCuzL8oj2mCF2hCGkFIM=; b=AZqsCe4rNymRNpxUkloC0paFz7dfZdPxmExnpMW8cRWYDO2gp8FJjqdHA3EWSBIdA2 wSJTeuvBgLgLSdpk6mAZ6ogE0A80vytZRaBTSG/B2YmGX0NC5Vvu100X/ZULQKcygEt3 F937KSBHbbK1n79dctnMwx+JwY0Q5p4+XrDWSyDw8r9XJ6YzO6haEPldGrL62JOs6RkH Yvqq7BRNDPSZQ4EOZlSCGu3rA+ZdwxJiesO/doKWYeZ5ddppkU77K4+Rp3an8FExCPS7 5yp8kn9kVVDCigpIclN+tdrkxVO/buxqkXw0BUoDExK1oebV3ewTxTC6tUoKNX3mbbD9 Tfwg== X-Forwarded-Encrypted: i=1; AJvYcCV9yiKNUTM8BZk/aPU6KKQ8pF21XdwIagEuKELFUfyhHW4G4RVvrQGmplDpW+7jZEpWmW2NcydQNA==@kvack.org X-Gm-Message-State: AOJu0YzWTumRxfaqYjzqtUBg6f2D8+z3pMXmEdAOab+Cc9Xwx2R89Wl+ 8dq7IR+/wm5ZfvgyYhTCGiJXzd2lK/Uu4/7jy6EFSKT5n7Ev6GLQ X-Gm-Gg: ASbGncv2zBMaBZjEwkkEuXGghTuTqHJLZCCePAxl6WQlWyWRK9ywcX1UHss/f8p1V5s 2saXKR4oQgVAxYo+3R1xenDLVGBbXAUgWr1eXybRYETkdRi2wH9RFwoo4X8serRAN4u1dbdpa/r Eoyr5pgm+Lbe4cNMMtKfNMmoeM8lCAWFxPigzdNZs6HLd5jRjdH830yvxQ7VJ0XXPSzgERs/rWZ vd+lh4kIJ6PAKUifyuG28t5JCUbHHLtxKC6grWNNt/6mjA4nKEmYf/zGEnR+SpwLTJR6N5Ygue/ nNVGSkxZT62142lae0B0FLs7MqDzS/kBd5xRj6aS9gclDWH+XcGOgZQuak8L X-Google-Smtp-Source: AGHT+IGh5yw3mRysgad9nxCWDBGbwLoP/iHNRJ5xeJHHf3KeS8OsUZAhtBm7YdHaIidMoULCdiEQ9Q== X-Received: by 2002:a17:90b:5252:b0:301:9f62:a944 with SMTP id 98e67ed59e1d1-30a4e6949a3mr17963223a91.33.1746394522091; Sun, 04 May 2025 14:35:22 -0700 (PDT) Received: from lg (lib-07-subnet-18.rdns.cenic.net. [205.154.222.18]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-30a474921c3sm7292168a91.29.2025.05.04.14.35.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 May 2025 14:35:21 -0700 (PDT) From: Fan Ni X-Google-Original-From: Fan Ni Date: Sun, 4 May 2025 14:35:18 -0700 To: Oscar Salvador Cc: nifan.cxl@gmail.com, muchun.song@linux.dev, willy@infradead.org, mcgrof@kernel.org, a.manzanares@samsung.com, dave@stgolabs.net, akpm@linux-foundation.org, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/4] mm/hugetlb: Refactor __unmap_hugepage_range() to take folio instead of page Message-ID: References: <20250428171608.21111-3-nifan.cxl@gmail.com> <20250428171608.21111-6-nifan.cxl@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 4213640003 X-Stat-Signature: 5q7bn6n77btmiibg7nk1kg3h6y1e333j X-HE-Tag: 1746394523-642695 X-HE-Meta: U2FsdGVkX195Ir3rCSKsM48vGcX77P/WQC1x1L3Wx2mUKyaq5z0/Ef02t1NoKY9NzCJJVegzgLJ7AiJrrZwGPDThCsjeDOjtvY4Hqarzw4M/DBUy+0BVEdsOjeL69nJmpwERsQPqe1hx2YrZtlV/slM/0ynjdk4ZOcN670HSUnuA6BlPQ+Xsgp+spOICkR6aEnqOjNS7tSTJarI6yL4esn6aCawWMoGYo7F0yRtgq3oEBs1Z0JmIL+QFjDY4WfvUEO54yp6xWrf8jJzryLJOrf59fEoKdun97DIILv/kzVCEkfTEYFpesPKHBYtZ95YXCCq75JqmJSu81tmj/wqoZi8fTMadFpgRCkz82EYhvqJZvNO8PBtOhq/ZWCH0Jva+HNJnxxHtFsjkKxsGd5WOjQVduwmUpq7yEPtOauDqow6c82pjFMcqEyz4+mWw1oWBFAD8o2zDcN3Q2smyybpGUepMJjPYD7ad4quqC0qRKl72n7o6AemNiAwC21YEpqLAvt3Frb1YdZE7+jAF9JfL2E8Nvs38r5nwhwjhpTldbHWB0HtGOsbd8OEhAcXzsuk1LD2GtBxA01qS1CroEU8wfLAc97adLAhjbii3nnQrx39+Nk76nZHiiaNYKLMYYMxkptAMpdhpphncN+v3lnoPt0YheX5ePz4HiCbm9fuZ2jpcWHcI6f7NAgjQMDaR0+DP7UL6YaRdrd+7Ak34lp5d3QBv6/Vb8Utj/JmUH9vDu9sYd3rpY+7ivqrIe3sbKNjNcRCfaQWqR5DEjGEFukf/1IDGRE0IhruVs3HyUiX/jkY3jC3YI4uJMrjo5V60QrIrL06H5o/QUn5PYArbFUGse1T6dgSH8kuUK87nHy1mS4r9/3ZoAX6zUXvmnCC+j7cNMJRnb/ca+50//Hxu1BiFI0cGDcHLXlidYdKs3/AQqttWfPdjOyQsbIKpMUKoUCxNZmlzvrtPGyiw2LzGLGu QDtZlFpb KE/qV1QffkDiVnZZgRv/h1acgoOlb9TfcytLRO5z31ltK7mjW+DbjHFWeqvinO7VTYTjRimb/DFI+sUgDaesVBJFSr0f9gZoPosGsNlIttegQ7lq+ig+dKedWHuleTKg46uUdyj0Q7oWKB9zdJuM3k7R1OT96dfbaLuU551Ku30+c4VlY0YE9hcIN/nziobmeaf+2mjVHdnrVBIUweWXj0zOaWdEUqAR8k3cyWBWwDVyVYb/+vKlKfomIWjfUA7x5YFibY5YtSpP26+nhkmKWucwj6VWz0jkx0MVLPq4GDo/UybpUGy4NBLwU1rv+jsptG+59VVxIR6l4ob0RDLtGUKe4CBk8fioICSc0tGHRj+CwmqqwgXBbSuY02WeaWYi6bfuOL7mCBlGrzX8lGxstkLPA+pn6hOdsTQku2saww4wpt/2is3LKGgfHtMI87LsXKlzG/oQQkDi+3MVStB+Cg1NVPv58ODDOzUurLrQaEDQ+FMykzeaqffiHHt8HTP+NUsmt83wrQkVC+F+5/FmlsTtsCpdCMPAwNO9UO8uNPaEPncftFEUaedSpdQ3s4Xkh04Qos3e6hJYv0wYhgDYRD68mQiteSxByoZZAylFjSkqoQY8ADEeIVwpj+mVnGQewxyCj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 30, 2025 at 09:58:35AM +0200, Oscar Salvador wrote: > On Mon, Apr 28, 2025 at 10:11:46AM -0700, nifan.cxl@gmail.com wrote: > > From: Fan Ni > > > > The function __unmap_hugepage_range() has two kinds of users: > > 1) unmap_hugepage_range(), which passes in the head page of a folio. > > Since unmap_hugepage_range() already takes folio and there are no other > > uses of the folio struct in the function, it is natural for > > __unmap_hugepage_range() to take folio also. > > 2) All other uses, which pass in NULL pointer. > > > > In both cases, we can pass in folio. Refactor __unmap_hugepage_range() to > > take folio. > > > > Signed-off-by: Fan Ni > > Reviewed-by: Oscar Salvador > > But: > > > void __unmap_hugepage_range(struct mmu_gather *tlb, struct vm_area_struct *vma, > > unsigned long start, unsigned long end, > > - struct page *ref_page, zap_flags_t zap_flags) > > + struct folio *folio, zap_flags_t zap_flags) > > I think we are kinda losing information here. ref_ was a good hint > and... Hi Oscar, Thanks for the feedback. Since the sugguested change here is minor and does not affect the function, and we do not have a aligned opinion here. https://lore.kernel.org/linux-mm/b23ef51b-1284-4168-8157-432c3e045788@redhat.com/ I will leave it as it is until there are more pushes for the change. > > > struct mm_struct *mm = vma->vm_mm; > > unsigned long address; > > @@ -5885,8 +5885,8 @@ void __unmap_hugepage_range(struct mmu_gather *tlb, struct vm_area_struct *vma, > > * page is being unmapped, not a range. Ensure the page we > > * are about to unmap is the actual page of interest. > > */ > > - if (ref_page) { > > - if (page != ref_page) { > > + if (folio) { > > + if (page_folio(page) != folio) { > > You have to update the comment above, since we are not passing a > reference page anymore but a folio. Will update in the next version. Thanks. Fan > > > > -- > Oscar Salvador > SUSE Labs > -- Fan Ni