From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F734C369DC for ; Sun, 4 May 2025 05:44:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B54B36B0085; Sun, 4 May 2025 01:44:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B041F6B0088; Sun, 4 May 2025 01:44:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A5576B0089; Sun, 4 May 2025 01:44:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 792926B0085 for ; Sun, 4 May 2025 01:44:49 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5E5FB81919 for ; Sun, 4 May 2025 05:44:50 +0000 (UTC) X-FDA: 83404136340.05.BE6A049 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf12.hostedemail.com (Postfix) with ESMTP id 1DC6A40005 for ; Sun, 4 May 2025 05:44:47 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=fv7VsKEV; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=zZpF9GBS; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=fv7VsKEV; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=zZpF9GBS; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf12.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746337488; a=rsa-sha256; cv=none; b=mNSGUcS9MepSS6W9Afi7VrZyhZ1501heg6I0kgx5LW7WVx8MfqwdeygX3CwXJlWLJ8DCB1 R9RGXLAu8KfM9ME1NbuFDpezEMRhPYYrBfETZM2GXJ3N6WIebEqrTtuGA7ILl/W6w0xyHV 7TXoFPGsQPvmHZyikDkHGd+Db/bi9tY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746337488; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=myodQUR3mP8MXaDV62oqd+gulOdS8C/wV8/Sn59oMdI=; b=ILnWCP6hrRbuToK6AdAkHcZYZG9u/XFcE8pgZW8tVjcTEh+EbwCT2wcCsYWW0kc7CpTz4U QeqltFI5UMC1Fw7GKHuDib7uVKXq+w4XRPn0WR5ea2am4zHlRvgSNuqbI2AUXtawiWdUbh myMTTvUaLmCVxRGhCvUOqJvO6k6NwVg= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=fv7VsKEV; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=zZpF9GBS; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=fv7VsKEV; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=zZpF9GBS; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf12.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 59AFA1F792; Sun, 4 May 2025 05:44:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1746337486; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=myodQUR3mP8MXaDV62oqd+gulOdS8C/wV8/Sn59oMdI=; b=fv7VsKEVMNHLPeyk2g3DYvkCx0muDGMjtGx3El4pX42qJkU83Sl+d7zkVvCu2EtQ+CFmpT 7w0yuWizqdyW7cnFqmmLniBC+aJM1GzNEXm+vmcU31BKhGOeU+Ms735mghKMByZzAzdIlN 0L4DiLyVbxcWjHxhaD64f6GEUQ+mqUU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1746337486; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=myodQUR3mP8MXaDV62oqd+gulOdS8C/wV8/Sn59oMdI=; b=zZpF9GBSbQmBiC9rLuCDBfJnL9PvyzrKpqxZFnYlsXMYDEm/wPMZwynUxC/nX6o1TiMCW0 WkprBqyHr+TQz7Cg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1746337486; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=myodQUR3mP8MXaDV62oqd+gulOdS8C/wV8/Sn59oMdI=; b=fv7VsKEVMNHLPeyk2g3DYvkCx0muDGMjtGx3El4pX42qJkU83Sl+d7zkVvCu2EtQ+CFmpT 7w0yuWizqdyW7cnFqmmLniBC+aJM1GzNEXm+vmcU31BKhGOeU+Ms735mghKMByZzAzdIlN 0L4DiLyVbxcWjHxhaD64f6GEUQ+mqUU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1746337486; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=myodQUR3mP8MXaDV62oqd+gulOdS8C/wV8/Sn59oMdI=; b=zZpF9GBSbQmBiC9rLuCDBfJnL9PvyzrKpqxZFnYlsXMYDEm/wPMZwynUxC/nX6o1TiMCW0 WkprBqyHr+TQz7Cg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D0A8F13688; Sun, 4 May 2025 05:44:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id YffDL83+FmhvHgAAD6G6ig (envelope-from ); Sun, 04 May 2025 05:44:45 +0000 Date: Sun, 4 May 2025 07:44:40 +0200 From: Oscar Salvador To: Andrew Morton Cc: David Hildenbrand , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vlastimil Babka , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Jonathan Cameron , Rakie Kim Subject: Re: [PATCH v3 0/3] Implement numa node notifier Message-ID: References: <20250502083624.49849-1-osalvador@suse.de> <20250503200334.3f912eeb7ca484bca4eec7fd@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250503200334.3f912eeb7ca484bca4eec7fd@linux-foundation.org> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 1DC6A40005 X-Stat-Signature: bs58se73tumddqpn3zurbzd1sa8eqrhe X-Rspam-User: X-HE-Tag: 1746337487-846537 X-HE-Meta: U2FsdGVkX18mNk5nKfjeIohi1DLln6ua32Z7S1fvxxpqZvCAfX5evgnCvTKxk29xxLfAyUi6hbjtx5bWNBe1ADIumELa/u7fUwunifS3xRsissSbqJbIUZHNkeYTCvbf/2PvmmYV6yyM+EBKTjQQCvcCqR5P/Q1xisKSfrxODpkveiay63PfZxQdNb/nkXhsEFl0cpxmqm77pNAC60LY5B96nSWddB+EuINaksS34tMnmXKLWM2kiUAdVX9fKKI3dcofB0pKdSrf2IzWdrKMyPVzGqpCfXl6n1NFvpF5xEHNaSk4/H0J9nKbBpKebly6QAXBBo4MlrE7ldqZ6ozz5PO2ebR/3IaOG7XqWFxojEBch7S4Wn6sQeWvjhpsWL5ha+zrjnWUGjF+c2qTXCJarWpQqQ6VhGuZT9hPsxRjFhHGRUUldGexhRcULepahdjVtbu1Yc+U4q5Xke4ZVnv/5MOky6aPav6XcDpkx+YoGAyoIoedOhZtsWuGVxaaHlunoof0owCF8Vt6wDAD14a3CaDD4CDm8MUR63e616MRQ/ed4dHVnx3nBBXzZU7smajAhtMiTSLgUdY5xhl6x6Cv5wHHMxJ8zdrvLkZ3m3AgkCiiNMH4F/s+k3tM2jeZ9NbrHlg9OV0xp5blI7We7sb++E1vANXPPoob9yRLJEXFc7j0AIpQEz0QIPRtGD2O4eAHSd6NZB7AwD+FW/zJdMs33wBc0kmRDnm0X9ic91DztrLwYTbuHdKRIR2PivAvkIhqJkEdlLR4W8ANMfHtJTRsUsWcA5qHPVY/IPHxQ50zqEdiZqwbVMlG7Vg5XoRrySaCbFOyDkRIzF1ToiFjMRPL6vHr065/TNAQTRQiPkXhnQ2NL28srWllCMNQpdTJ/7mrRjIqbGXZ7g5dKxxtHULSr6GMCQr2TlUb4AY5uB+NolaWIp4qkpEYabQnaPS44i/Tc4vZMO2Vw5fLnrMAZAY RnbFTzU0 n1qd63brmLlskXrzSHtIQyJvov18LvJeRXxCr2UfnARmCJQRu6eAcFQBNoELZBkfPfGvDMrgHZi81wiPrWRko7feA8smRBlFgPFw6W9Dh06BkQ7oUFIuWXOby0yWCyXzs/CE2iKwWOr/bmAo4eDuyIcwCP0FZdNQNzz0tLIlDHGEjeX5Uebzfd6IVEXz8GxV6e9mmKjlfeNcrgnwsYoeomscCdMYdUjemtaZH5GPNoHctZGV+d3+zwy2OSc5s0EhGn980GX+sP32EICe7qCTemMtLKyspn0gNQ7CcRPQw9KJKLDdYWTGDPflnKtZl39H2KSgI6xwGkU3GwRE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, May 03, 2025 at 08:03:34PM -0700, Andrew Morton wrote: > Why is this a problem? Is there some bug? Are these notifications so > frequent that there are significant inefficiencies here? hi Andrew, There is no bug, it is just suboptimal. That the numa node state changes were tied to the memory notifier was something hacky and that have us bugged for a while now. Were mean to tidy that up but just never got around it. Actually, first time I brought that up was when I reviewed the first implementation of memory demotion (~ca 3-4 years ago now?). With the addition of yet another consumer (auto-weitght mempolicy) that was only interested in get notified on numa node changes, it became more clear that we really want to split those up. > Further down-thread, Gregory tells us that Dan's patch "seems to fix > the underlying problem", but nobody (including Dan) told us about any > "problem" at all. That is related to auto-weight mempolicy patches, not to this one. I _think_ Gregory means that I take it in as part of the series. -- Oscar Salvador SUSE Labs