From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E185DC3ABAC for ; Fri, 2 May 2025 18:39:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 868536B0098; Fri, 2 May 2025 14:39:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 819AC6B0099; Fri, 2 May 2025 14:39:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B5F56B009A; Fri, 2 May 2025 14:39:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 478696B0098 for ; Fri, 2 May 2025 14:39:44 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7189C12055B for ; Fri, 2 May 2025 18:39:45 +0000 (UTC) X-FDA: 83398831530.24.D0986BC Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf18.hostedemail.com (Postfix) with ESMTP id BE2D31C0002 for ; Fri, 2 May 2025 18:39:43 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=E3Zty5YU; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of tj@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=tj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746211183; a=rsa-sha256; cv=none; b=Ek+iaOpu3Nijctg67QwGXVz23KtbDN59AdiWxZZ4UBa8r1byRTbalyzR7LjTDpxRyoy4Up ka4rFcMKA/g6vDocOe08JRowvdgl/J8b0OCn+DDF8k4LX8OqJCzn7M1Cywun6s4SXgHMws 9FL933fCA3pK7Pa32aU07o5vnuJDmvg= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=E3Zty5YU; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of tj@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=tj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746211183; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RP5eDUX4DVMreKiJxFV8vSbNG62Sl1APLo7aNF5oXPU=; b=YUI3U4+8Go5/CwLGH6k4fxXPvsmM4YsGH5wjUD9SDiwoRtw30woiODt9Eu+TE8AjaFWEiD MPbx8AK7+ljQdlT2JVnWFrLBhvLx2FlBAg/1YRaQ6AcD1ywfB4jBL/mM9tfSQCGxIcKCVZ us6BKdvZALVyze1xACaMzUgrx5MVf08= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id E7F884A458; Fri, 2 May 2025 18:39:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F421C4CEE4; Fri, 2 May 2025 18:39:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746211182; bh=eWeXFUsFqqWiEPqkBtlgn2arWqgAePgxBwoLc+q61HE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=E3Zty5YU1xMsuwMJiRCigUgxNI39PvZ1N4jx+iMe0TG98rOw+D10SZ/8qCZA1nGFb GxikXPlZKLL/qyg8Q5YRuluzxVKFthm+DnWOHyrIk92LuGQ90gjET/Exledj66MVWL 9iXWT5uvP4sV/0u6IpZQ1SeudVmOG5Olti8MfMO7Bj9iV3CLd61yXArnXv8Mc9maaQ 3qo1CiRcgz+ztVAOsa/C12epXmtZTiv2w3DLbBZSaPsAYKF146gCJR/ZLV24ahDjAn 1kjPpgssr4zA7X5otC3WDK+r6xIcjC95bXdU6x9nB/8lpZR3Lrb12WgjNq6joi2iiA j6BwLYBXmCO1w== Date: Fri, 2 May 2025 08:39:41 -1000 From: Tejun Heo To: Waiman Long Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Michal =?iso-8859-1?Q?Koutn=FD?= , Shuah Khan , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v8 0/2] memcg: Fix test_memcg_min/low test failures Message-ID: References: <20250502010443.106022-1-longman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250502010443.106022-1-longman@redhat.com> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: BE2D31C0002 X-Stat-Signature: eh488expaaxij3hd1e7qkcxit5w5jp44 X-Rspam-User: X-HE-Tag: 1746211183-82231 X-HE-Meta: U2FsdGVkX19RJwaI806m7xTkT07xRB02IClnLTMxNt99lxReLWZAe7uClAwl1vTjUwscK8avsezxSkUmY2bWnmGC76KOsJzkxOW/dYxK6u5Xe83cKJlHA8WQ4JHsHJtf85Uja8bncQw8QwNyQNWl+NMWblMJOc1Xo22wQs7rta9gBr8M2cwxNpMsGl8TYGQn2zQk1yGHG8m10ieQKbl9Wa78pvFC9qonvi9OmNzsuEEXgifAe8k8n7j3Vj+EQr4TeqrDzqv4RxEgyU5w8FalBc56Cr2WV5mrXAiU8BVaZQSVQAMm6gxtV1m/c6YE5MVu7A/vWckLyvKrkAY7QAbsw30GtomExI2IY7SLJP+5FETkdR9ZH9c74qS3UBdoD0JBRJRJ2i5YJtAHpm5RYxEn7gxz9/wdt67jUYzOcTrv5co/JguHOjbjF1eW4uYjnwo5nRn2EHwkfPOsflLT+2gozdgOIT9UMgPMrgQjY21CvY1cdHAL0Alz7ROAuWkgoJ/CVlkkVVU/PwxVUpJB9B6zXRRGY85gHflpfDMKgp3So3AeTb2X1hbd850mlFpbFgDTQHxisKvGoBA81KC6S6Fqdex1UXOipKPdJb7Sniw8Zdho7VTEr55OJeLb+IyC62j+ko3H9jDuH2aUQcum+tTKQO4KptqGh1ozPDNw37650pPz5koroXsXvVU/q+sU/xfzfZSQ6RdLA9i8U1eOCwmXJIWyWLfJBuL8JlWRAbRjl03muad8fRjGIjGDQ9i4655nu+Bu391jwqKrf1axHOp3AQ2Xe79pP+QGWCccLdlBQqualThx+uJ1YPFt/QUC/AbM5Y9ppU2uvbNW9e3z6O0Nw46heUJUiKWKaZzso6YZQzrOw7qMA3ykaxJmXIX6WqCnmd2Zp7CMlBMlvHI6F9hYwlscfYruzzGCEXfkwJr/9Ugek5u0yezVMvOP9s9SHbApibAyZgQMDYPBktDLxzm O/NO/p/o M1bPFIThTOAm7XSQO6PU7viZQZ4fGKd3UamZuP4/HgU5pzUJogiiNQDPzOhB2PImGZApHjpvVh3fftI9YDjbqGGREoDA/oCqPkx22x4uLbtBLYpNrvSwwUNgkpTlIDPKDsBalJVK8nHiE3tAkSY1uR5XQZFccRJqozHUwhP6w4zz4e8hyK+nEbM+SBc/gzGAcmnInsTDynRe/DWbZPDh+SOBEz1VOJMH8TGJYGLTn60zTTKRoYqacYLfyxjpGoH/sWD9uaq2NpVEOwbqA3PMPhiDIQYRxkF6e3GJr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 01, 2025 at 09:04:41PM -0400, Waiman Long wrote: > v8: > - Ignore the low event count of child 2 with memory_recursiveprot on > in patch 1 as originally suggested by Michal. > > v7: > - Skip the vmscan change as the mem_cgroup_usage() check for now as > it is currently redundant. > > v6: > - The memcg_test_low failure is indeed due to the memory_recursiveprot > mount option which is enabled by default in systemd cgroup v2 setting. > So adopt Michal's suggestion to adjust the low event checking > according to whether memory_recursiveprot is enabled or not. > > The test_memcontrol selftest consistently fails its test_memcg_low > sub-test (with memory_recursiveprot enabled) and sporadically fails > its test_memcg_min sub-test. This patchset fixes the test_memcg_min > and test_memcg_low failures by adjusting the test_memcontrol selftest > to fix these test failures. > > Waiman Long (2): > selftests: memcg: Allow low event with no memory.low and > memory_recursiveprot on > selftests: memcg: Increase error tolerance of child memory.current > check in test_memcg_protection() Acked-by: Tejun Heo Probably best to go through -mm? If cgroup would be better, please let me know. Thanks. -- tejun