From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B25C5C3ABAC for ; Fri, 2 May 2025 15:28:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2579D6B0082; Fri, 2 May 2025 11:28:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 206496B0093; Fri, 2 May 2025 11:28:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F52D6B0095; Fri, 2 May 2025 11:28:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E4B1F6B0082 for ; Fri, 2 May 2025 11:28:05 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 91653C19DE for ; Fri, 2 May 2025 15:28:07 +0000 (UTC) X-FDA: 83398348614.22.CF4C7F3 Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) by imf24.hostedemail.com (Postfix) with ESMTP id 95327180008 for ; Fri, 2 May 2025 15:28:05 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=TJaIoW9R; dmarc=none; spf=pass (imf24.hostedemail.com: domain of gourry@gourry.net designates 209.85.160.171 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746199685; a=rsa-sha256; cv=none; b=SSa6i1ziqQjv3AY0/+6omcRViQZB0cYnt6uWEiv5ltkIKeiyS0GQU0w/uJ8axwRworpD2X kNoLXaoDV2SKCEnIh7oMItTPqHIS7MUXK7ByurHJQjCfzvFcC8mXU3xFpd6uVFH5ILadBp xw2/MBtvcldaXKh+FV3yvpk7JlIqM+M= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=TJaIoW9R; dmarc=none; spf=pass (imf24.hostedemail.com: domain of gourry@gourry.net designates 209.85.160.171 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746199685; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=42DL1ZP+c01CDP0GIqBUWL1Jk5Vm3sDUPFDs4Yt7wZQ=; b=cp1gG1EkD6sxgDcleG32/bNJikBVUXqf2PpbaalvyQmLnm598F5dbO3n6HoHL5aOWD36qY uAnQYlPy4tPA8cgvhvhl4tGreB4ltDE2ZIgdRBX5g6OoxE5o7m97o09pQTqWoinHFqvT31 BGzRrCM9Dgwnx+dYwkL68fM1Bt6VTCM= Received: by mail-qt1-f171.google.com with SMTP id d75a77b69052e-476a1acf61eso25679671cf.1 for ; Fri, 02 May 2025 08:28:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1746199684; x=1746804484; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=42DL1ZP+c01CDP0GIqBUWL1Jk5Vm3sDUPFDs4Yt7wZQ=; b=TJaIoW9RC+QZivULYUxiDTkgxx1RQkbFpKoGFUngWMImid7MevEKgZWNkCB0BVPTsk y5BmFrxEL+ug8wtT1m8A9k0A8G3fyuvFIoYOc5Db9d89DYZi5dKZu/7Ji36Qp7lHQMMj yWw/hSbs9NZ1ihnJKeifjr7KcDtMCMr50CsECs82PW7ju10sqlJODs0iVblLoP+S/AeX lmy73IIYGAua0tiwGmYjChNITKfmgQii/GCVVpIwf49Ew7tYSZFO3BnKeY+Px0L2LphL fo76PVjKarcxo7S1msQu3egg5UpfBn5N2Xq7p79LlGCSqdTcChdZIKzH3OY7+ncl7cL8 IFXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746199684; x=1746804484; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=42DL1ZP+c01CDP0GIqBUWL1Jk5Vm3sDUPFDs4Yt7wZQ=; b=inDaMwUipu5QyJHx1YX2/pIJ0uXYHqNr5rkVPrlNGcynwYdW+WgDJEpIyM37rKms1L 14jg8vbU9zyckOB4e1y67Y44AQJiVMIOYsclkTa3ujga/likdskBW8aYLcd2BVVnU10f 3WFIQr0fL3AGdWSVYuxKAUD+mCFNOdIGgwXCCW+7g3CHYVXkwtaCG85JsaPp2vxdNc7F JZAL7oiilIiAOmt27SAO+s+hjHetPNKRb+HpPPcIJ+l/H+HkPzUR47erM4TAG4lShSBf qN64h+C0gKlfJ+SrAvyXkKiwqPEyO0vfoVwvNcyFmFJh7YziB/S79xYWtzQq9Ups86Ys 9Xqg== X-Forwarded-Encrypted: i=1; AJvYcCWALt2oDJs5bp9KHqrkXtdGst9WxuGCCsqW2W7VT8kJHI+tHUeTfxa5MlVVxknnmTiAu3JFjYefPw==@kvack.org X-Gm-Message-State: AOJu0YySDgDjkRfkrfat17VczL/U6tMC83hBx62Z6qvK5jGFqHXRi27P C4VmY3tdfdeo37Tv/BeLT2iB0E012G9RUSemzSuWivim1vTZnl84Ca9yW47qLkE= X-Gm-Gg: ASbGncsNzrFsVHLg4Gxp9NHOZpvVls1NKiQUwk5xbhUlnzVPqOzdhgw8Dya/7i50jPe GlJocMlAYhDTD/EGBYTk3U2eProBADvY+RHf4tZI2IHpR6mI2rdGy2HcM1XTI/yuz6qfPUzRcSY 1dNGd3a5Gp6HZpIxzcXomGTWftKI2eMdcKXZqutxszTtjfmYrVUQ3HAi27v5II8wIYdfJkYGLGS 3Y9T9y9cw/C90d3vgGdxP966y7fVH5RTQI0pN248RkU09/r2nTU6yYA57Wy4Az4F2EFAkbsvqG6 yImPWDHnFmF2g5lL2bNdOb8UTQSHR+xNzz09tj5rarEgMG7TAPqmNjjev5UgkXQYZuhR6Q1/saN IBPBSfDqtEPpD88jK1Mcm X-Google-Smtp-Source: AGHT+IGaXH+5tIeyfIuTLwQyATlw4BiXrTVsqaoS6omvSGNhxllI2Khqh3orgpzgkZE1HIIjlXZ59w== X-Received: by 2002:a05:622a:1929:b0:474:fab0:6564 with SMTP id d75a77b69052e-48c32ac7e09mr55484501cf.37.1746199684627; Fri, 02 May 2025 08:28:04 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-69-37.washdc.fios.verizon.net. [173.79.69.37]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-48b96ad3752sm19030211cf.36.2025.05.02.08.28.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 May 2025 08:28:04 -0700 (PDT) Date: Fri, 2 May 2025 11:28:02 -0400 From: Gregory Price To: Oscar Salvador Cc: Andrew Morton , David Hildenbrand , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vlastimil Babka , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Jonathan Cameron , Rakie Kim , Harry Yoo , dan.carpenter@linaro.org, honggyu.kim@sk.com Subject: Re: [PATCH v3 2/3] mm,memory_hotplug: Implement numa node notifier Message-ID: References: <20250502083624.49849-1-osalvador@suse.de> <20250502083624.49849-3-osalvador@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250502083624.49849-3-osalvador@suse.de> X-Rspam-User: X-Rspamd-Queue-Id: 95327180008 X-Rspamd-Server: rspam04 X-Stat-Signature: 3g5unpsbqogsifp3ueghf41omsm4ct84 X-HE-Tag: 1746199685-458401 X-HE-Meta: U2FsdGVkX1+YehmeyKOureddHiE26Gn4yiXhVcMYS+sLv/1jLahlpDtRJA/od7Wnb6gRaBb8wHYNvWYNi50swoD+91pgsGLrpFfS/BF99yeaoA44e0zzUsiddE8fgBE8OGBSWMEXFL5CXeP5oYYER1j6nwIQX7pKYTfaQDaap2l+lH4Lgm0zxlwvvlWMjdik+hNibFumDMAftPQ8/7sVy0//H9RfSltRe3e44L2UqOc0OcKmH4oz4sTxQMNea/bZfRW8ENe+kTl6amaovXfz0LvTib0Pjue83dnzz6V+waevZWuGmLzsxvQ6/dYLJbDD0rnVenjIoL/jyVw4LbEs+QRvqIHYFv0jXD1WRtl/9EDuYrX3hO1JMCZ9EUD9Y80lW2ITrISrRntQrUAAsYvdTff+BoDOsZUhsb+yDDGw1DtMUNefOpLtfnkXHCgK//ki9oNMv1H8BCxm5kH65SC+ZQbqI0z2tNFX+TIxyl2c+nU5nMlXjdzseZ+ZsuPMu1Lq560bYHJX6LsrC6SsZ1GOn49oRRKb+ovhWCsfeFgQ2/GtNY6zacF86nxkKvKJ7k5BnN1M52iVTcf3COp0gjDWrMWUIV2yipmEK0xDvvCDWBS8Gu4Ra5WGV7t5Kir4D2xlZWOhslazaX1479VlctYI3hmXcZYW9l37dGOscmR2Torq0ZgkOmLoubrqBD8ToaFbpN7F5xUp9Wpde6k3wSHS3OGAP2m7TcOqfR70y5iggzO5jSgSlS34Zs9Fr1B1qfSJ2iWhuMFkHGqBBFvY6ryp5t3ZriZhq5It1wmWyo7hNXxeuJpNCqWHEll6FriyF3FGRGwToCFD968OOWkbkjHINgjqSUk07WVaATHWX3OZIcNaJMOQRRXCRqxOp3e1lAPmvaQyTZAZBzZFXmoyh8DSvUDbWdYCvCQJ1KI5KwceC4oyDTM1deBvQllxV/HOC4ooSHY4oHdCstoJiZ1mOdy /TPuBF3b SuMRQgr3oizE9wDCBXzWvozjx9xR9gY4omn4vkGs+mKuVOO1QL/ANgKdDPeec7H/5x62936DWIaJrJcDlNES6OtO4YbeTA/HWWBpiRLwnfpj9XDoDTOR5LlB9PLgqiqhQ4Nz5OjlKDTOa82ls2JToJlYpScGK124uENn4IBcAsIuHIUy2MQP34OIUg3bZRpFhgVQkUdkv19VX8itcRbGSpU8gtqEbKKM+bJHMa8+iEwWNrKKsL2byAALd6u/dSDEOJwVP1tNnGAAZ691Cv4cSUNvuwRHr/EkUm61kldg+tC89OO5XvfNgnIXs+aYk1NtFFLfwFnfZBjtYlcw2uXpApj366Sn2PdPVeENzhc1NED3FN59sImLGHCKq1VLXbt+y9yXZTPxu+j57/0Ch6SF7sspvqkrIqFVFqdebVY6VZr4OLUrVNRyFDjsuoztSWvyqXawhNXP8H8H5kS/4Xykkwsh5FqfONUV+tBzeYOed5MZWEmRdVMCQXP+kAPwwIJlCXZypHASkhlxBTvQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 02, 2025 at 10:36:23AM +0200, Oscar Salvador wrote: > There are at least six consumers of hotplug_memory_notifier that what they > really are interested in is whether any numa node changed its state, e.g: going > from being memory aware to becoming memoryless and vice versa. > > Implement a specific notifier for numa nodes when their state gets changed, > and have those consumers that only care about numa node state changes use it. > > Signed-off-by: Oscar Salvador > Reviewed-by: Harry Yoo > Reviewed-by: Jonathan Cameron > > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > index f43951668c41..b3ad63fb3a2b 100644 > --- a/mm/mempolicy.c > +++ b/mm/mempolicy.c > @@ -3591,20 +3591,20 @@ static int wi_node_notifier(struct notifier_block *nb, > unsigned long action, void *data) > { > int err; > - struct memory_notify *arg = data; > + struct node_notify *arg = data; > int nid = arg->status_change_nid; > > if (nid < 0) > return NOTIFY_OK; > > switch (action) { > - case MEM_ONLINE: > + case NODE_BECAME_MEM_AWARE: > err = sysfs_wi_node_add(nid); > if (err) > pr_err("failed to add sysfs for node%d during hotplug: %d\n", > nid, err); > break; May I suggest rolling this patch in with this change: https://lore.kernel.org/linux-mm/aAij2oUCP1zmcoPv@stanley.mountain/ seems to fix the underlying problem, and returning an error now makes sense given the change. +cc: Honggyu Kim, Dan Carpenter > - case MEM_OFFLINE: > + case NODE_BECAME_MEMORYLESS: > sysfs_wi_node_delete(nid); > break; > } > @@ -3639,7 +3639,7 @@ static int __init add_weighted_interleave_group(struct kobject *mempolicy_kobj) > } > } > > - hotplug_memory_notifier(wi_node_notifier, DEFAULT_CALLBACK_PRI); > + hotplug_node_notifier(wi_node_notifier, DEFAULT_CALLBACK_PRI); > return 0; > > err_cleanup_kobj: