From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA5E6C3ABA3 for ; Fri, 2 May 2025 13:04:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3243E6B0088; Fri, 2 May 2025 09:04:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D2BA6B0089; Fri, 2 May 2025 09:04:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 199BB6B008A; Fri, 2 May 2025 09:04:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id F0E326B0088 for ; Fri, 2 May 2025 09:04:12 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 94031C158B for ; Fri, 2 May 2025 13:04:14 +0000 (UTC) X-FDA: 83397986028.01.5B14E45 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf14.hostedemail.com (Postfix) with ESMTP id 2A0F010000E for ; Fri, 2 May 2025 13:04:09 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=CfBcORtE; dmarc=none; spf=none (imf14.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746191053; a=rsa-sha256; cv=none; b=T2tzhLu05jVCWHw1fl0sxc8pN4bOOWLCgkXF20/eK0DrACDbpLuAAa9+H/rhJk+dC9D7tx 61BzHuELNLI61NIKhyZgkTpr3arWlM+GxC5asKTkTA7w5JV7xdU6kqv9rESya64j4T1pzz qH5fl17wvJOGDLNThZFEn5SoSZYyNBc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746191053; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EXHTi0wkEODS8HPIZd3aLUlx7XjPC9CvhHuCiNFzwS4=; b=xzA+NTsNZBioBF5UKFniwQ6mio3+KaJQ2i26nQ5aWFEwds5n8v6qfNsk+KcRwyYVGVUDHZ PvVVjUas0K0a1RwjeMBR4NBFbFnzcKBU0ZvRjYtom2OicGIUzSDULah2Mwl2OCadkquCOb aV6+yEFreA/3lu+xoHpyi9bVQwh3ziA= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=CfBcORtE; dmarc=none; spf=none (imf14.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=EXHTi0wkEODS8HPIZd3aLUlx7XjPC9CvhHuCiNFzwS4=; b=CfBcORtERcHUouS6CToeHdF1/a GOA1ObdAVZEzq6oGrTEsDk0LP1OjLdSTCY4vGkxFOiAOaeM6k3quLoTGPRBIMsZPDsiYadP3wFZEF gidawGZbWMUQFU3hv+byav1KqRZ7a4gWkE+7V8aBDlEsjwVUj0DT1zRB6BergjwKIgMT6LlGybBD8 Axnlnkzv1BOsuqJgNwQWcFgsRN1lOW4ZMWvT7CIOhRFHxhLhb0iItHk8ILRmfR4X4+Lysrf5acdVI 9ys996M9hElPMkczlzvhNQndcZW+1PPciCqwzZ3e70KvHivZ/QHDJc06Nw6pxBe+PlcSHLj60eLSs Ah2WYhHw==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uAq3Q-00000000Tvj-0u6P; Fri, 02 May 2025 13:03:48 +0000 Date: Fri, 2 May 2025 14:03:48 +0100 From: Matthew Wilcox To: Ignacio.MorenoGonzalez@kuka.com Cc: Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: mmap: map MAP_STACK to VM_NOHUGEPAGE only if THP is enabled Message-ID: References: <20250502-map-map_stack-to-vm_nohugepage-only-if-thp-is-enabled-v1-1-113cc634cd51@kuka.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250502-map-map_stack-to-vm_nohugepage-only-if-thp-is-enabled-v1-1-113cc634cd51@kuka.com> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 2A0F010000E X-Stat-Signature: 1xmkjp7a9fcaf3ytqt9y9dpeogyiqbbd X-Rspam-User: X-HE-Tag: 1746191049-548036 X-HE-Meta: U2FsdGVkX1/5JLDYna1P/KhPfZqTkxUshURSMhgxrQtzxB3t7sh14Q43wL2cyuvpq+OgIRuwCA4CDV0/BqnUnFKCG64k7u+8HFNSM/OIppQNedEinlCOtaK7otVvTfIrHgKRpVzjlnpoYs4WFOMOGsF0OtH1o61vlkWw2+Vi8RALUiVjym9OqiPdAs6zGc8K9huOKpNWYbSMICG2TvAA4N8bHI7k/TymFNdxWITycjS66ySIaqwoC3/h8iFeaU5dTBtr4Ui7dnJCH7aKTIRYSfQYveSxn2p7JdRlB+LrgfbiO52T1NULnyRRtQcb+HKAYsjlpYkoGn/+SIObsfR0UuCY9A+DPXJsN4k679OgslZQjTTvAUnLDddx4chAhIbWdVudhAEXM/xBaWcoZdvODtbLNQLhcT01dW3Oj+kO9dPUcDOSVl5jD7NaIW53IjoOWFCu6+DPI8/jyXXaClvQxmCxhvUJofvN+t0/9q1XiNdqdfnfTo7rV/c2l5jJ+4fyI8lVP9NlttILJYNGGUdaDFOhukMjXDXwW/rXKs6C4lWBYzukL6Xob84lBn/CFy8Yi4vBg0NLVe/Kx3tgAuaELRnoI38ip3j57vMJVNFTeaHZhQpp+dUNsablWFPyrS0qYCsYTAwDwFoB3NpvQS0tj6gO9VV2+XKD9bdJg9GJMPNjBrDTLCeuwisjUepsr3HF4hT1TZ/MV0a5f0YSYzwrNueqJnN+ciEdkOisqv5qwMH6q367w7zNWQKFI7vf1Ba3gZ9PohRl4uAcqQkZuaJ4jMrOBnX9PfO9zgE7dcO2K+EeNrXOumvyG1uCUJCf6+w6NxshJYxdVDNbUKDAtCpQxfLDSomnqFgE4uYSHrodO6W7LRccXgyPofgx3vXEAxLWYE9OIuvkQ3z/jv6zhndWJeOCFBl0Zzr91xEt280fGecmOnGHxVPc1sw6OPUFcjdUvju5vjxhn1FNsJEOML0 cBQM0fcP 57XrU5Jnrf1AnsaDWCPnrbocTrV5RgN70c9FNH6kJAxQXueN5S5ggAFlq5nx6Pu0t7Fm5Gqg8yK9RCcmCYZ98abgX5TqHcGuzamqaYK5+AwmfCwBgLlqKRHOHr656ECDHEDzTVPTHPGDJuqZog/RkElwQxkCKjJQMZb9EAndPL7ekOlixvdDf9XeKYKTbLYYrfQDASL717nJMvAt/ATK4tQ+bUF38P7hrGH1lX6uwEO1/fo3+p9ZJFDohEP3gz0XK/y/f4IZxWm1HZ+4316UWenfEAiTHz/SxiofrEtZUn+Wm6bvRYDhE5xIMKG4ohqxOTZ+QQT2oKrdui10= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 02, 2025 at 11:31:41AM +0200, Ignacio Moreno Gonzalez via B4 Relay wrote: > From: Ignacio Moreno Gonzalez > > commit c4608d1bf7c6 ("mm: mmap: map MAP_STACK to VM_NOHUGEPAGE") maps > the mmap option MAP_STACK to VM_NOHUGEPAGE. This is also done if > CONFIG_TRANSPARENT_HUGETABLES is not defined. But in that case, the > VM_NOHUGEPAGE does not make sense. For instance, when calling madvise() > with MADV_NOHUGEPAGE, an error is always returned. Isn't that the real problem though? +++ b/include/linux/huge_mm.h @@ -596,6 +596,8 @@ static inline bool unmap_huge_pmd_locked(struct vm_area_struct *vma, static inline int hugepage_madvise(struct vm_area_struct *vma, unsigned long *vm_flags, int advice) { + if (advice == MADV_NOHUGEPAGE) + return 0; return -EINVAL; }