From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D845C3ABA3 for ; Fri, 2 May 2025 07:17:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 66BA36B0088; Fri, 2 May 2025 03:17:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 619EC6B0089; Fri, 2 May 2025 03:17:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4BBE46B008A; Fri, 2 May 2025 03:17:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2C68B6B0088 for ; Fri, 2 May 2025 03:17:53 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 6740D1A0BD7 for ; Fri, 2 May 2025 07:17:54 +0000 (UTC) X-FDA: 83397113268.24.C7E7BB6 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf11.hostedemail.com (Postfix) with ESMTP id 1B6CC40005 for ; Fri, 2 May 2025 07:17:51 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="ZvCP/Ax3"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=VWarCpZq; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="ZvCP/Ax3"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=VWarCpZq; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf11.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746170272; a=rsa-sha256; cv=none; b=DBfum58xaLUWiMhzKfmb7Lv9i8eWL23hQmYULDaUBDsoX9Pzu7GGzTVkoK29Zqw6nZfKey +S0Bq4TBCvhlfEwaDw40g34qwayXwJ4jApvUMDw/r2WqtBcpZppJ0M/YGej9sqHDqo1YFZ 77IAIrL3ysJc/8f/lTlS4EebiXKDJpk= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="ZvCP/Ax3"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=VWarCpZq; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="ZvCP/Ax3"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=VWarCpZq; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf11.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746170272; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=S+aj1nfydB2jRLXwDe47DzDLzuPOjgt5COk5TJrFbCE=; b=NBE31+/NU/sgx7eAbUipexg+evHdECMDfvosj2lawQx2InSdrqHm4i5oI78n0ulyn8aMGp lEiHV5lnOToYBES9Dg/tkZWu4Fk7S9dJOR7f3BkaaO0mqilZNnrkWZGdxzcA70t0kUOjTF shZ7zsX/szmmSYobQVaNMHi/kymDzp4= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3CA491F385; Fri, 2 May 2025 07:17:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1746170270; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=S+aj1nfydB2jRLXwDe47DzDLzuPOjgt5COk5TJrFbCE=; b=ZvCP/Ax3H+CHYaZCw5BpVo2Irxd4ek0QponlAkNQXfOIMOqNbG3PYeN7KKIjhUgZtIIelr g9h9LlrpgiyaDnn2CDnsGvrsJaFbzwJO+jykhxEACnXnCL0JlFKH5+p7TZutJ06+nWHh+O qlEHfJuHxIqVrGcHTVSe24A55Uw7ag0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1746170270; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=S+aj1nfydB2jRLXwDe47DzDLzuPOjgt5COk5TJrFbCE=; b=VWarCpZqE6XNPUJ4e9gbI2tcXbpmDrGybbcBfynSVt/C7WX7ELmvgTftKjVJZRYDxyG79E oxa+rIXncN214JCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1746170270; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=S+aj1nfydB2jRLXwDe47DzDLzuPOjgt5COk5TJrFbCE=; b=ZvCP/Ax3H+CHYaZCw5BpVo2Irxd4ek0QponlAkNQXfOIMOqNbG3PYeN7KKIjhUgZtIIelr g9h9LlrpgiyaDnn2CDnsGvrsJaFbzwJO+jykhxEACnXnCL0JlFKH5+p7TZutJ06+nWHh+O qlEHfJuHxIqVrGcHTVSe24A55Uw7ag0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1746170270; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=S+aj1nfydB2jRLXwDe47DzDLzuPOjgt5COk5TJrFbCE=; b=VWarCpZqE6XNPUJ4e9gbI2tcXbpmDrGybbcBfynSVt/C7WX7ELmvgTftKjVJZRYDxyG79E oxa+rIXncN214JCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E47CE13687; Fri, 2 May 2025 07:17:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id xd3wNJ1xFGjQNQAAD6G6ig (envelope-from ); Fri, 02 May 2025 07:17:49 +0000 Date: Fri, 2 May 2025 09:17:44 +0200 From: Oscar Salvador To: Frank van der Linden Cc: akpm@linux-foundation.org, muchun.song@linux.dev, linux-mm@kvack.org Subject: Re: [PATCH] mm/hugetlb: copy the CMA flag when demoting Message-ID: References: <20250501044325.20365-1-fvdl@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250501044325.20365-1-fvdl@google.com> X-Rspamd-Action: no action X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 1B6CC40005 X-Stat-Signature: 7j5shjcn5ekz75yxunxsrmhinhtsdsrx X-Rspam-User: X-HE-Tag: 1746170271-488984 X-HE-Meta: U2FsdGVkX18/lio6w5mg2kLicT2xChX7CHSQyutrc8SWntkFdVg5U3zD/eiOFxvVQDmUt6myc+qkWF6kjoPRyM5EWeMLRjd9kJSFTbE8lu6YlxYXoUdOcIpMgYB+kn1/EW54RnxoGKKkpCau2TGaTQ/HTnSqF36hZOe4ISj8W9eUsVk4Cp3KBeEKVTqlrSWHp6iA3p96JOOjbpAsYPwdLBXMSu9GR7SbN4+TlX0ecJrmYD63aoX2N5bP+Xznm8AkNIwzsn4SaQNZUh7mP8AasrTWzVt9hImQmuMWKbYJkbKatK+lNctFdCTaDLaiE+4F4c9VgqI+9cEpOEMksX/ce1zMidyjea51XkVKJgCSHBhBvQodO4enn7nJyvSZNQsXfqLgsoqthJRQY4rfrAsoAuhOnWe4u7x4gCRlyeRJrKbScrH61HpbHr4RO6t2GyOuznSZb3ltaL9fQTIK4glAWQRxS5TQ5Qn5kHavCyrxGDOUyBSVEO80nxQeciVpkl9TVHYeP0SJL11OaBTb8LltGLprh9FJMckn48XDqVq/JQxrYCGZnaQEkjRCRqwSRIB/XmIesuxucxiP6JMxbAJXW+WhTZvwTMVk6lbaDOE0kekVL7YJNvCtqk6Hj3IKAiJQ3OrzejKnoyPywyuLkDrf/1Td2PzqcnmN1gSuqvV7vICGN8mzSjW5DJwqT07HBzpT8kruqPtLB3cS3jpFBB2ZIeMYXVy14Jd8tyfb9t/dbQNIShelyVAPIP2x1MjZeu9RFudzTL0mEVknm0NbHHLLlHhZatdmcNqeP3lPzveXImQGJ3NepqpnCgv9XTu0dknAB/iLfh4R+oP/a7hzzFFE7z93/9PtKxFmSuExbYIBdNrc6KN1nLWrd+T2n6mbZR/yFoRNndY9CHOBgsY8bPGKk1uGLVD8KpdpCdRFyExnCyoryqgsE2/9+HjcHfpo4bT+o4g0aOzbbdm9ddc0iNG 8VxCKrY5 MJn7aGK2cQJHmHWA98089Vdrk9y0Oom8OJDnmAID5eEmMukyyqvhs6M2rEkIcdCYkbnjPYNVKelNowjmWtzyLVWFR0zArbmrGQFR4DNkf5WP/TXdpYNoDwxmn8/5bn2q8xOs9X/wlqnvJXoo/c9YITrsUUjdTP/j6W8234a34Dzc27BHx0tmjUJJEVfz2eor6+q4mZlzIZejBxuShxXv3gO131DahSQ0VCiKcVHkHD6PvnCXyx/c/gAjeyWbjXj1YKNEvTXKVd/a4o+3Qz1aZziEjJWDkUHeB1LER X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 01, 2025 at 04:43:24AM +0000, Frank van der Linden wrote: > Since commit d2d786714080 ("mm/hugetlb: enable bootmem allocation > from CMA areas"), a flag is used to mark hugetlb folios as allocated > from CMA. This flag is also used to decide if it should be freed > to CMA. > > However, the flag isn't copied to the smaller folios when a hugetlb > folio is broken up for demotion, which would cause it to be freed > incorrectly. > > Fix this by copying the flag to the smaller order hugetlb pages > created from the original one. > > Fixes: d2d786714080 ("mm/hugetlb: enable bootmem allocation from CMA areas") > Signed-off-by: Frank van der Linden Hi Frank, Reviewed-by: Oscar Salvador By the way, AFAICS we are missing some docs for HPG_cma flag in include/linux/hugetlb.h. Could you please add it :-P? Thanks! -- Oscar Salvador SUSE Labs