From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A0C0C3ABA3 for ; Fri, 2 May 2025 07:10:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E1F076B0092; Fri, 2 May 2025 03:10:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DA7226B0093; Fri, 2 May 2025 03:10:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C21A86B0095; Fri, 2 May 2025 03:10:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A0A346B0092 for ; Fri, 2 May 2025 03:10:40 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 25081BB312 for ; Fri, 2 May 2025 07:10:41 +0000 (UTC) X-FDA: 83397095082.08.9E345A6 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by imf20.hostedemail.com (Postfix) with ESMTP id 16A101C0002 for ; Fri, 2 May 2025 07:10:38 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=B0Cov41u; spf=pass (imf20.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.54 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746169839; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=U06ss2HdcwirNeiqMijvgDAm/dg/vsq1Q1L1rApoCb0=; b=JbrWg7BY2zZSSKD4k/8KMiB2UJOTrRdbkjutv/NDhVbTfaO4dkaHDIL7O0XmArPVJorgqO qg+21qdb+QZgUB8zcEpV+sMqwqgSnTRVjnJUyIixNA0r5xUIRAC4LMqyAN7uTKzdrj/1zb sUTSh8Et/hPwqzK3HAg+u2+D/IumDWo= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=B0Cov41u; spf=pass (imf20.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.54 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746169839; a=rsa-sha256; cv=none; b=GYzYPcwRdm/v74c8xojeBAqSpFIF97TnNdvEfkBlrBPR39TWQz43KtzVoO3I0KsH4IfzbQ vzge1g1GC/9goxRxWNCQW+KvetaxlvHf6cvjZnYSQwBV0W3ot0KKEypI/KxoxFP+r4zyuT iPmeSG6LTtxqsG0i76ntwkHGpuJDldA= Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-43ed8d32a95so14094045e9.3 for ; Fri, 02 May 2025 00:10:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746169837; x=1746774637; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=U06ss2HdcwirNeiqMijvgDAm/dg/vsq1Q1L1rApoCb0=; b=B0Cov41uA1kKLWR6fXIwms2TifIy0PCNfQhPZSzZvYgmgswmZn1XlSdd+wHGNZMlK1 bF4zsl3C9RDhrS9cT5JlZWzQcY8eU6vWz93ms7DlU/3mv++0h3NhzlmdhfemmEgS4UHp S/ntvsNLY++LCdvS/+PFk1sFQRO/zohBy+E2AgUI+i5Cwxm5PVZufmupBmlpgSOw0ZUx s6aCmctd5Q8W0OBVLD55lM66kIlASgg2Ck8yClOBQ6yZboIp9iH32YN8QeLZSSz3VuGJ cMzQKZHzyT1tNZjAt5UtsZMXTJxSbCuIC/DfDAgf59/CpzHimOmqSo1KcIJwm8v9bV/c dUcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746169837; x=1746774637; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=U06ss2HdcwirNeiqMijvgDAm/dg/vsq1Q1L1rApoCb0=; b=B+NZYstVSDtxXTTTSMQWFzIsTTIf+R+a4XkXiP3Jc7ZMO0Zl8GbgdERLD3bWneliOG Hm8rgXB28DQ4iGw7MkU/rCcqC2ZrwuIQs3zBIHFcvyKT+eitVPTsY6T8nLzwE/M7xbY4 xfE1H+moJQwENBoAmwQBv61WAuzGLSfbJQsGuVTh+wyaMp0gIBO/geRPLH8I5AM+6x91 7250Ab/UaxhNbsBAQwJoMQy5dgBvkcp57tAm3HXQDB2M7n/CNYvH08u+wLek4v45vo14 xduRic2XJHYI+sfl4maXL9OZVFHhJ8unlA3JENwnr9NX8Z3DwdJBkqe/CYP5l5VQFD+W /x9g== X-Forwarded-Encrypted: i=1; AJvYcCVfwnnF7Tz6WWenD9p0yJ+AnuHoJnW9FjBtMCY5HGafDtGj6v3oDaSPoleVVxkrXMWLWi5k5q4M3g==@kvack.org X-Gm-Message-State: AOJu0YztHwkS/CkEDlceJqtOpEUhauzaQ/Wgdt8HlIfw2wYRnQJqKtDx 77vOXIpjR+Lp4jVPp30mfYV+IGGtaYF7O09lXxH9MtD5A7cnBeyv0f0CV0UCsCBaR3UPH2ouTEO e X-Gm-Gg: ASbGncs4JEbT+3e0W/Yt8QHkYcvpdNYpsftZuMKpgTLcn5JWawDx6RXEYfitM3IDAEm LP3pTIKf8F3tnucGqV8iuPu7jCLqnqbL+xCCdxZgOBfL4PZA3a1kiNJTVgX1De70Od4ia5+GWAs 8wpGr5hiexlwbUEZclJr5yVi5bQorZnD97H2h+LSPka9GJz87mSKsnUXfVT1hMZdR71KA6jzUXa DlCMgeO07njUoFijEgMCpPXYj4JEjsNvYNow1JZ/hkhPbVxHQbpVlTfQJjMx5XSIk1r5Mzh3t8E /0Dr+0Rqw95WA3/JDQ96Hp2CYrydvAguMM2ikvvtCv2/jQ== X-Google-Smtp-Source: AGHT+IHtNfp9BE0awULIWqLBT0upZss91Y/YU3Wv6VlCY1VbHPu43hU9YAJA4Xe2Y6q9r/3mhLUIjA== X-Received: by 2002:a05:600c:4710:b0:43c:fa24:8721 with SMTP id 5b1f17b1804b1-441bbeda9d2mr12759135e9.17.1746169837547; Fri, 02 May 2025 00:10:37 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3a099ae7cc6sm1328988f8f.55.2025.05.02.00.10.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 May 2025 00:10:36 -0700 (PDT) Date: Fri, 2 May 2025 10:10:33 +0300 From: Dan Carpenter To: Honggyu Kim Cc: Rakie Kim , kernel_team@skhynix.com, Andrew Morton , Dan Williams , Joshua Hahn , Gregory Price , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH next] mm/mempolicy: Fix error code in sysfs_wi_node_add() Message-ID: References: <9837bbe0-d494-43bb-8e92-8cbf47a32b68@sk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9837bbe0-d494-43bb-8e92-8cbf47a32b68@sk.com> X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 16A101C0002 X-Stat-Signature: e47bnajuqdcisjebwbdkujwfygtzrpb3 X-HE-Tag: 1746169838-104212 X-HE-Meta: U2FsdGVkX19ZgSEwtDBps1JPCjz5T65gHDxBSyWxaYpDnCJk2mxB+iO0NE6L/NPII7yewQuvTQKZ0agqrZXCtUVLjT4gu+rv/nQB9nmuqougy6ViLs1QY0ZwkhDaBxogcBS7zTacqv77g6QsS2r22rxybRN1wIZE9EL47D/gDtv0ZLE4oJGjveXTMUm5xKsji7qh4aLBaSwFRWMlvtk0I2D1H7iLs+AWiKTSw05s7yulWY5YbIkqn3XX7R6km16hqlj3j2s3lHicVw2I5O8pJW+ILAwTGPI62RIDJKRDqFT7H12/xVYaMc1IAY+Wd1yN8EPCoBdMzUyicGYAaYBJEev+y6MEdflPU7HLN92vh6Wroi9xctbVDvnCsfAFS+U0/OekNd80DwdRtYIgaEtyvkIWGm6XBOCtj9d7jkQ/ObW1PJot2qNzILUh8EujlQn+X+huSR4M59iIc1YeEfWqM0eBYMu80NIVf90vsyvzBFvzzAhglTNFfExKHU8j7YtJeUq+TxJL3zJ1B00EmQk1wWd6C+UsQ0wEaDnBSaPpGF7ixJVZF64j3bRzROTvR0LA7bsRa2YdPmorECeq44OPHZjMtkQamm60K5D1uiPpa8lF2wI4eJWzcN3TxbT+nMxNDxCdPN6YQ3xWIlagws7iXG3Oz3/qeuhvm2mIZEOxc6xFeDjLc/oG/8A1io9gspC/hjcvxpyfQqF5rqEQqjyuj3XfWQDe/U+hrQhQtAk2NI+h09ESAQJLTE3xii2fN939scNz0mrUU7g38Ul6X5Zy1H4UcOM/nIxp2S7vTCNyfUFI+23jghp+KVeVkBY3Vp4/ihc0NswIfJmi2LRCueVrxo5wvcUsFKr67OP/7uzLQU9Fmzbu7ba0ryyKoZYHawJ+SXTy95cM+n5pV1ZUmqScgssZmvjp2iyGDg5fQBDh35hyxS52wN3jE6nCnkXs/IL9ihJUWOEqqn+qfMDPmz/ AQzC+fia 9lbdmKEBsJhPbiizT61QPZCi/hW/K/tj9js3VpyNw74Y/SRJFVsFdGXbYXDkml3q49au1RaZrEgUcRewej8Wg/xeGKv+O/x8JUSV75Uw6+cVh6wS0Nud0lROggO09p7rPaelNKnp1eb73xfv5gvdHT5D4meG7TcBmgpuI9vocgQ0uy99HgPS+GLXywch6EdDHk90TLU1f53FDcLLS/VeibU8A+0rmVKYDwsCuJw+gXYNm0weqIhLxLchNBzIpuDKIN3+Z8qvDaTCjndK3JjPoDetFnGES3pnkfej+N4iaW2H/qvNIKWdU6kO8H/OqH/p7e1YIAsyaca4fMwPtpEslF1mxhtU5P1ZQJNQCmV9ew0fjkXo90+76BEMbGxGzuoFslQonYrHGVy51Zfc+EdLPJSlXpnrIGF88W9SYb5Fq7pa6jUeopg8NJkgVg6Rgcr5G3eIHbLXeOOZmTnDoEOFMGJUexbqqgEBJpwYJFfFD2RwOE1gPkLQ5LtfBpncE+e13SZZRIddYj9x9mmaSrspmgUOG8cdzzSs7GyRH5skBP814q737ep4YDUYd8A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 02, 2025 at 03:46:21PM +0900, Honggyu Kim wrote: > Hi Dan, > > On 4/23/2025 5:24 PM, Dan Carpenter wrote: > > Return -EEXIST if the node already exists. Don't return success. > > > > Fixes: 1bf270ac1b0a ("mm/mempolicy: support memory hotplug in weighted interleave") > > Signed-off-by: Dan Carpenter > > --- > > Potentially returning success was intentional? This is from static > > analysis and I can't be totally sure. > > > > mm/mempolicy.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > > index f43951668c41..0538a994440a 100644 > > --- a/mm/mempolicy.c > > +++ b/mm/mempolicy.c > > @@ -3539,7 +3539,7 @@ static const struct kobj_type wi_ktype = { > > static int sysfs_wi_node_add(int nid) > > { > > - int ret = 0; > > + int ret; > > char *name; > > struct iw_node_attr *new_attr; > > @@ -3569,6 +3569,7 @@ static int sysfs_wi_node_add(int nid) > > if (wi_group->nattrs[nid]) { > > mutex_unlock(&wi_group->kobj_lock); > > pr_info("node%d already exists\n", nid); > > + ret = -EEXIST; > > Returning -EEXIST here looks good to me, but could you remove the above pr_info > as well? I mean the following change is needed. > > - pr_info("node%d already exists\n", nid) > + ret = -EEXIST; > > We don't need the above pr_info here because we delegate a warning message to > its caller wi_node_notifier(). > > This can close another warning report below. > https://lore.kernel.org/all/202505020458.yLHRAaW9-lkp@intel.com > > If you apply my suggestion then please add > > Reviewed-by: Honggyu Kim > Rakie Kim was pretty confident that returning 0 was intentional. Btw, Smatch considers it intentional if the "ret = 0;" is within 5 lines of the goto. Or we could add a comment, which wouldn't silence the warning but it would help people reading the code. regards, dan carpenter