From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2871C3ABA9 for ; Wed, 30 Apr 2025 14:40:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 08D716B009D; Wed, 30 Apr 2025 10:40:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 015FA6B00C4; Wed, 30 Apr 2025 10:40:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD2A66B00C5; Wed, 30 Apr 2025 10:40:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B784F6B009D for ; Wed, 30 Apr 2025 10:40:00 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7D4FFC0107 for ; Wed, 30 Apr 2025 14:40:00 +0000 (UTC) X-FDA: 83390969760.28.8AA2DC0 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf19.hostedemail.com (Postfix) with ESMTP id CC1371A0010 for ; Wed, 30 Apr 2025 14:39:58 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lK+M498k; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf19.hostedemail.com: domain of rppt@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746023998; a=rsa-sha256; cv=none; b=wcpwPgq8nqqAt2Yb+hqWSRdHbEv5BcM/YFc4iPhe9sAHxAOtxxIFeU7FW5oNTIBWGdDY0B jQRXtEaV0rQMkYATn3y+s8VYICcHI7LH2EBrPNSOar+E02HFr7WujsfQqpzRTqWypnapFh EXzM8Fm5s9LDoXHfngNq4CyTdDnEvSU= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lK+M498k; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf19.hostedemail.com: domain of rppt@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746023998; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2O2NUU7UjEskfxEhmA5Gt2zwhpv/XZJlAtibfelIlzI=; b=F66m8X/Ir1ZVRKKJdyAwDLtgwLcp/5eZ7KmJzv0rt1Sba0ousIhpJtHOT59yKmAdF5wzVP vsJOcTeFwBm+Jb6110CywGij4BBvBE4rTQSL/iK8UzBqOE7DU8wCStr4RtLadkpOyqFNW1 gO5uqZSsmgRN+1I2jX3QCA0Nt2N9Ejs= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id D18396842A; Wed, 30 Apr 2025 14:39:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75F64C4CEE7; Wed, 30 Apr 2025 14:39:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746023997; bh=odob20u9gDP5puX+nz314ZVRMvgs918mZ3ed9/j6RPo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lK+M498ksZ2dH6z0RhfSK8AzeE6JHg+SLeElHqJs2cVSeVMVtNHn+iPNmtuz5PA1j cFYGv39PHZNBY91GsDy2+JqSA4RAJ9cqDDFnazFk3IEtQ+0NnQ6V1lmgQduMGjwoNi xF9SVDavuUdgvlGjAP71OAsY0vXQLnUY/iFkKiwRfca/uSdt14aj5g08iHOjs1yMM3 NQN7oZV0+egF5S6HmwuJuDK4YBR73T06k16wi2LIFxlmELvcZIwGvaXaN8diqRqvWR vwsCz/NCURJySTZ6JF4sTWKtqIF0bkn0iOeu7TfDBQ09NBCvivE6Sf6VBDKYh+07M0 jGuswI+IzbVbw== Date: Wed, 30 Apr 2025 17:39:51 +0300 From: Mike Rapoport To: "Kirill A. Shutemov" Cc: David Hildenbrand , Tom Lendacky , Andrew Morton , Vlastimil Babka , Mel Gorman , "Kalra, Ashish" , Rick Edgecombe , linux-mm@kvack.org, linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Roth Subject: Re: SNP guest crash in memblock with unaccepted memory Message-ID: References: <43o2gni2stscuwjfr2cyawn4ikcfhsroact6t7civ3ud3e6sgi@jizmzw7lpzvt> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <43o2gni2stscuwjfr2cyawn4ikcfhsroact6t7civ3ud3e6sgi@jizmzw7lpzvt> X-Rspam-User: X-Rspamd-Queue-Id: CC1371A0010 X-Rspamd-Server: rspam04 X-Stat-Signature: eyckgwym4z9yemp5ic1wkuatn6neij3h X-HE-Tag: 1746023998-803809 X-HE-Meta: U2FsdGVkX19RtdBCSfd8V95LiziJFClA6dEfsB2Sf+Dk9+Glg++LBoyOgm3lAFzojMlkTZDGL1uzGla5QIjn6RwYuLoSt38twHwxXomqfjhTaaMLoOs2mEq9JDkqFEEamXvpwhadpPuiH0jp7HAIHPIsZxrCfstKXot21Id9loL4xXvTxR4V0inslPsPmyvpyDXJ268cC4fdwT8axieTMWDad1ukwwo9RyQaQHbA2MXzx5GpYqlmzThUmHygxatAfr15AbAD9fR+k7GKRirTERT3LhYWcVQSevg4K9tgYiOzEi/8K+ZXVMQ/Qz/30ndg7dZSZD3yuRnx2i0Pdvv1ksOZyXV2oStoqi+5C4af3wR2k+2axFr9Td7QtLisNzYbNICJVccw8ttdg8CGRjtkFy7nI3iUPRli/hFfx+9tRdlEUg9QWes5/tT8QfQI5FEShVt64/B4POZ9e+1JhCggGGQrDdbG9EhaHx7ygzGS2Srlc9Zd8UINbaBqfUcs75ehctVI/l4Z9onm80nl3gnsVudviX9w02yjEb+gc5+0o/QwxSPcrevF6uv3UjAl4pCOZ7/9QK0fKrqkaMFWUhxGpsaCav/imZ49sz99RNou7jZnY+Ij3EH4N7yokn8e47CZ0B3AvXMaDNs+JOPocYWPGcQQAk073PX2hbuoSu6kRQh/5OvkhE19ko0pZJxixJmhRiLqR2GjwYk1EPnWhiAJRJ83eqTRXHRAiMzWycNfsosTwmNZEnQUyqWc/010TmAgbSKa7zI5i8e6X950tTAeurR84TtpUWM/cULu0FDRhFa+AngJMiwQjTQ9BgoomAVpp+QpWfXPkhDcCYq11ezFWGlBI4nILFZkgcoAXCJt1493WGSpj9oDV1t8e7gehSMkXLj7poi05vnyZbAeApe3OFl8JKbqIJ4uiBZsd8UvNkTReW7Leegyoyl9738UVhZDbuDaKM5QpvZoUnL6UPy fT2mRfXN Ls8d1+2Rm9LyhQkYatJ3v4AvEK4QvX+kAHdgRHKcWbdoh7aZwSLJ1kBbiDYp3z7kgXZ7PLDmuK9mNXoczae/RKxuwouBpCrNl5Se9yLna20NShjDbxFEnhtcE0jOIKNNCPFkKh4DxzC+P2uEnfijkTNZ15+0kvBUqNWKj5KLP3dDmLFMKV0kvFKuPxsbMIgbaCr3bXQlytQKlwIjt084vq8ZtWNgorT8LulUBYxFWF8Vli0L9pSFcbihMSW7H8jjLtSN+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 30, 2025 at 12:14:08PM +0300, Kirill A. Shutemov wrote: > On Mon, Apr 28, 2025 at 04:04:50PM +0200, David Hildenbrand wrote: > > On 27.04.25 17:01, Tom Lendacky wrote: > > > Hi Kirill, > > > > > > Every now and then I experience an SNP guest boot failure for accessing > > > memory that hasn't been accepted. I managed to get a back trace: > > > > > > RIP: 0010:memcpy_orig+0x68/0x130 > > > Code: ... > > > RSP: 0000:ffffffff9cc03ce8 EFLAGS: 00010006 > > > RAX: ff11001ff83e5000 RBX: 0000000000000000 RCX: fffffffffffff000 > > > RDX: 0000000000000bc0 RSI: ffffffff9dba8860 RDI: ff11001ff83e5c00 > > > RBP: 0000000000002000 R08: 0000000000000000 R09: 0000000000002000 > > > R10: 000000207fffe000 R11: 0000040000000000 R12: ffffffff9d06ef78 > > > R13: ff11001ff83e5000 R14: ffffffff9dba7c60 R15: 0000000000000c00 > > > memblock_double_array+0xff/0x310 > > > memblock_add_range+0x1fb/0x2f0 > > > memblock_reserve+0x4f/0xa0 > > > memblock_alloc_range_nid+0xac/0x130 > > > memblock_alloc_internal+0x53/0xc0 > > > memblock_alloc_try_nid+0x3d/0xa0 > > > swiotlb_init_remap+0x149/0x2f0 > > > mem_init+0xb/0xb0 > > > mm_core_init+0x8f/0x350 > > > start_kernel+0x17e/0x5d0 > > > x86_64_start_reservations+0x14/0x30 > > > x86_64_start_kernel+0x92/0xa0 > > > secondary_startup_64_no_verify+0x194/0x19b > > > > > > I don't know a lot about memblock, but it appears that it needs to > > > allocate more memory for it's regions array and returns a range of memory > > > that hasn't been accepted. When the memcpy() runs, the SNP guest gets a > > > #VC 0x404 because of this. > > > > > > Do you think it is as simple as calling accept_memory() on the memory > > > range returned from memblock_find_in_range() in memblock_double_array()? > > > > (not Kirill, but replying :) ) > > > > Yeah, we seem to be effectively allocating memory from memblock ("from > > ourselves") without considering that memory must be accepted first. > > > > accept_memory() on the new memory (in case of !slab) should be the right > > thing to do. > > Right, it should do the trick. > > BTW, Mike, is there any other codepath where memblock allocates memory for > itself? We need to cover them too. memblock_double_arrayi() is the only place where memblock allocates memory for itself. > -- > Kiryl Shutsemau / Kirill A. Shutemov -- Sincerely yours, Mike.