From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69390C369D9 for ; Wed, 30 Apr 2025 08:48:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 61CF06B00A5; Wed, 30 Apr 2025 04:48:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C69F6B00A8; Wed, 30 Apr 2025 04:48:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 440876B00C5; Wed, 30 Apr 2025 04:48:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1F7856B00A5 for ; Wed, 30 Apr 2025 04:48:01 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5DC97C0CBD for ; Wed, 30 Apr 2025 08:48:01 +0000 (UTC) X-FDA: 83390082762.28.15D85A3 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf21.hostedemail.com (Postfix) with ESMTP id 070C01C0003 for ; Wed, 30 Apr 2025 08:47:58 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=A4rpqwt+; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=WZG4kVlg; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=A4rpqwt+; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=WZG4kVlg; spf=pass (imf21.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746002879; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aJ/SU+1kzMe1oWfhizQGoaQEDlPJx/6TZT65l5Z1oSs=; b=bC2Mc+rPgAIUnkLhYt9koA6LgFFRJUixr1+nbiio8VPfY4Ov9COqr2SO1BZwe0nUSwGQ8A ZXkpFRXBZVB37ARc7FggcmCGLiEJYLKL7Egs+zPO3wnJO+KcFYubgERVnT9MTPzSk9uZ8A zihNmha+YbAoldVWCBjhnG8/1buGGjk= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=A4rpqwt+; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=WZG4kVlg; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=A4rpqwt+; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=WZG4kVlg; spf=pass (imf21.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746002879; a=rsa-sha256; cv=none; b=An5sQ2Mip4j+KN+BjgVffo/H/i9mVTB/3Yj1MLSn/uz4pYskdcJP2b4JiOC7iD5hvhE8IL iKkfIhc2IM7/Ud5ch1e0OzS4YCj0KA3MmCgtDBd1l9jT/k3NRBgSBlSuwUJ8LxxtR7gUj/ x3y1jZRVEeck9P5lk5WnApnD4YSwxSU= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 71BF3218A4; Wed, 30 Apr 2025 08:47:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1746002877; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aJ/SU+1kzMe1oWfhizQGoaQEDlPJx/6TZT65l5Z1oSs=; b=A4rpqwt+ZUyrhe2gvbZrmYQPBmY8oak9DS+v6BlekisISBVQGqXIgwwN879mbDD4/bdrIS BmsiHGmZJeqKOmL3B1eyd1lfKo4ERXc/Ar39sLDUrJxi6vZuPste89ApkEuBBOp6qwssAs j+NA7P7mpXkN669FtpOq0zdZ57iPAgM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1746002877; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aJ/SU+1kzMe1oWfhizQGoaQEDlPJx/6TZT65l5Z1oSs=; b=WZG4kVlgVpJUiUOvnC70CwQVMzuPqoivqcoiUo6QWO8VtoVyGWjx+J6X8ARygOkzNBbmbu 1jCcILSgKnILLVBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1746002877; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aJ/SU+1kzMe1oWfhizQGoaQEDlPJx/6TZT65l5Z1oSs=; b=A4rpqwt+ZUyrhe2gvbZrmYQPBmY8oak9DS+v6BlekisISBVQGqXIgwwN879mbDD4/bdrIS BmsiHGmZJeqKOmL3B1eyd1lfKo4ERXc/Ar39sLDUrJxi6vZuPste89ApkEuBBOp6qwssAs j+NA7P7mpXkN669FtpOq0zdZ57iPAgM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1746002877; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aJ/SU+1kzMe1oWfhizQGoaQEDlPJx/6TZT65l5Z1oSs=; b=WZG4kVlgVpJUiUOvnC70CwQVMzuPqoivqcoiUo6QWO8VtoVyGWjx+J6X8ARygOkzNBbmbu 1jCcILSgKnILLVBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 0235713A25; Wed, 30 Apr 2025 08:47:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id sEwsOLzjEWiiFgAAD6G6ig (envelope-from ); Wed, 30 Apr 2025 08:47:56 +0000 Date: Wed, 30 Apr 2025 10:47:51 +0200 From: Oscar Salvador To: David Hildenbrand Cc: Vlastimil Babka , Harry Yoo , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Jonathan Cameron , linux-cxl@vger.kernel.org Subject: Re: [PATCH v2 1/3] mm,slub: Do not special case N_NORMAL nodes for slab_nodes Message-ID: References: <20250408084153.255762-1-osalvador@suse.de> <20250408084153.255762-2-osalvador@suse.de> <92ff4f7f-90d2-48ab-8f7d-7fc3485276b5@redhat.com> <60ae4d6b-3ace-482b-9945-1261003f3785@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <60ae4d6b-3ace-482b-9945-1261003f3785@redhat.com> X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 070C01C0003 X-Stat-Signature: 68kby7i6q8b3xm36i5q5i857n13yfuh7 X-HE-Tag: 1746002878-110937 X-HE-Meta: U2FsdGVkX1+8+WOc7pCYF6fraLgamZSPQdGOTvH/qJCd3TS7Hp1QrUtSBeBIU1SIv/BBeEsl1vHuAl72qet7kUxi/gtSqUp9YGOvgMv1oBGsx0lF75ADoYAEw0vniO0gLbAcjxJO708gRKyXYiU+c9FM2au5gEwWAykyge9Y0oqfet9oDDTm9H22VUfcoZ4LN3bkb4ujSVLjazCaA26+sXleAIBSjXvuNPvIw+QHlU52mBcpUCJONMhCql5F9MqDPn/swbcIsC2Pl+o5QmCnDRBVW3r5Qh87J5hgodQyxVnhQlxomIeKzCUjG6SYyoCUgjKY7Qxux9zeD4F1aji1nW2VQdD/B5dGABzhmgAmnPrEdTcpAT00tQjBJoFjKId2MQnt9ShE+OkyccLr7GlOTbZONZz8nQwu0bOKkMiJ9WXsFqs+jDcoMbSnV1HtKGnAgK43F6P0pkbP0IeCmExlxPekGT7w/gWVHHuo1eDYTDomLCelUDbDPT7wYynIhltJSAL6VdAzsaEOyQODH+htc+Xt2ZrP39nJRVlx7Kj7jjQMIbsNyddu+A9uR38zuBaMmeh2muCvZSsWqvosx+OZ6JUcxAMrW3sAZeHVfjUQek7Agw3x2Gx/79b7pe0WvptV6Ima905Z9pAtVYf0SchJ/kP373i4VNie977qWBUBsE9lkvOuVAdvPfSkeJYF6py/b9TQlHo9i3RN3gfNqPCLvYs2QqFE5nG0ZZHZfT4h65lIT1lhqrq5DGZLyY/haClUK56IEgm574eJFjO5sXAeY/PyPbEUBRMPFSEPW3XtGDxg+M3r3XqSfDIGJ/kR/btGs2RzpAZEnU8GUxo2qs0blAh/nL57ItXEnS1Q6KPvBiBq4LWVcSwxVkEuLP5owSFVZkS3uV+hibPG6322VWrlP7beRnzpiaKh7dqCcs3pyB1nWtc5vxWQMflHyk29SOye2yvgD31LaMFPYOgGu+K 2CIuoqjl /d2EBv1Q9xv+h0uC7u3as8sVaRJvyo8olJFrDZZhsDE9K7hDmuB3/X/hOS5is+B3mXyMy4Z9GjKyduRxGUXsY5bEcOrWBeXDlrdEuGlHZm1I1G9xgWeyRXo43CIW/gU6D3Nlj7mLqHZaqJnWglQp3/MxAcaOWx0h/02cWkOT7YL1IPy46CbJWGFUE8bnQv8BfLf4gqwqty6eQfxsy6QDKLSgPk/ehw8+WtnsK+BoQz3S/B6gjzhY9bw1x6D/h2/+4J8NgABcDBUYhwJRiiKOnaGvftNvdKrvtRcU97j6vjp3NJpSx8ET2EWyBdeYxneGQjFC2rXMHXXE31ww= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 08, 2025 at 08:18:32PM +0200, David Hildenbrand wrote: > We could by grabbing the mutex in MEM_GOING_ONLINE and putting it in > MEM_CANCEL_ONLINE / MEM_ONLINE when a node is going online. Hi guys, After a few busy days I have been revisiting this. I checked the proposal of slab_mutex spanning GOING_ONLINE <-> ONLINE, and I did not see any issue. The only concern I had is that we might be calling some slab function from {online,offline}_pages() that also takes the mutex. I am not aware of any though, and quickly checking did not reveal anything either. If there is any will be quickly revealed though :-). So, unless there is an opposition, I can move forward and see how it looks. Thoughts? -- Oscar Salvador SUSE Labs