From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A6B6C369D9 for ; Wed, 30 Apr 2025 08:25:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C83296B00C2; Wed, 30 Apr 2025 04:25:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C31DF6B00C5; Wed, 30 Apr 2025 04:25:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD0D76B00C6; Wed, 30 Apr 2025 04:25:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9BE2B6B00C2 for ; Wed, 30 Apr 2025 04:25:29 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id EC95180BE0 for ; Wed, 30 Apr 2025 08:25:30 +0000 (UTC) X-FDA: 83390026020.07.A265E80 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) by imf08.hostedemail.com (Postfix) with ESMTP id EAA8916000B for ; Wed, 30 Apr 2025 08:25:28 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=NBI9rzh1; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf08.hostedemail.com: domain of mhocko@suse.com designates 209.85.208.41 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746001529; a=rsa-sha256; cv=none; b=eOns0HB75zF8zTm1Tk/IJVWPCRSc88QROIjaGdFrfej6Yx3Q8YE9tnr6H0J2tYDXbo9lBe bHzNJ0ZquLH1GfGNi4IoeqnpGkDXUxh2+jqB5HYNBgS30S1re2A67nMwoquLCzU/uvXV53 MQA1kcFWPqksicB7D8zq6mqJj3XjJBo= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=NBI9rzh1; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf08.hostedemail.com: domain of mhocko@suse.com designates 209.85.208.41 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746001529; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hapNsvwk/Rnf0mgmDnPu3qGgijaYgiJF1WxcjPg9iO4=; b=QPHFbiIe9hGmzg7Nh9+q4CSfkNSQtg+dy7dpodWnxdhGkBS2xLKlOd2j4I49coGEUgSjxa udjZklBsHtVGX9pKyy2s2dFa+u0yiLl+aSkgf1GPEiqE4OsenwX9FYbgmP7uVnA18133Cc 7TSdsWeyAeK5von0j/aZu0mLsk3/Sy8= Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-5f728aeedacso8351237a12.2 for ; Wed, 30 Apr 2025 01:25:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1746001527; x=1746606327; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=hapNsvwk/Rnf0mgmDnPu3qGgijaYgiJF1WxcjPg9iO4=; b=NBI9rzh1Nuuv8RhYNpdRkS3EBaJZOgSW1Q4g00fUkrcJgZHn5gmuHeplWajvM6fdI6 bUuqTfJe0/vJyKdoRtxVDNNhRrTHBjV8OMz4y8IKkbWQYb2RmguBYaU4ATvpu7m3vZTk PTuWnUNQee6a9WOUu+ktCn5D2vGxZlugp5KvKj6X+box+OET7WsR/rgIEid34EpZOy06 yHpTW4/RikmCYFCr+dt+UEGw1qjNfY0XGrWmZaPbqv1KEiRj+SSvjFO1LjIkU7uB8GHf mXfQEgQnM6+dKNNT9hPakKJSji/AD95CQSYjojINsLir3CVyLTkK6HXG8MI3MJXKmyB1 aCZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746001527; x=1746606327; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hapNsvwk/Rnf0mgmDnPu3qGgijaYgiJF1WxcjPg9iO4=; b=T54ghJwZeTMtfYn4VbMp2DXEaoM6iNcQrL12ER8uF6D67rJSLOq/KVVuSQ5q/LqSGH aLw5/diVacscc8XsL+Ydgj1xqmZzXF2W4R26H+cUwQbZZUUWQqGMlGepUeL19tl1lyzO KxPVqnqnaDyHWVqrRfw5wN2SSjnwWfyjaYjJDWAV8j9P+Mdf97C+cazuq2i3iTycIXnt r+kmMPAkCG0UlgPUL1b9E5PGME5YR7NBEq3/nlVSoZTdElO+4zky22p8jkN6y4hjIV1e 9c9aIKQ/nvrOR8Cy1j3yLmdt23SPOulllgPMu498acKwVtzNHYJ7/02vwi2Wm5G3k77c 1sxQ== X-Forwarded-Encrypted: i=1; AJvYcCXDYEE0E3N+45rMjCbIXrwW+GDeE8g3nG+cG50dwn6Jk6SON396VhtZbWTDFdov3ohlaObFn/tQ3w==@kvack.org X-Gm-Message-State: AOJu0Yyg+GqM6CzXrQUQF9DH6ZE+gnQ/KPe221b5JCOP7OT03boHjCE9 ocvtN5ocboDlVU2PffiVRGj5XCwIc7BMJoXQx6o+p55LsUkGnC+WOsqPOd4U6Xw= X-Gm-Gg: ASbGncuj4rZlSgw326uZobiyer0nDyFLPv4o2nYPAtrn5kXtuLh6ho/OjBg3crIfHns ZsYkr6iaZRsnjtYZdBGMwSk4l6W0JkOf0sJuz5POFE2p6C7xYhJ0hm1LkY3MORhHxyiHqtPDlo+ hc0StV4bJTQqh9e0n3Ob98eBBgLPtOWP/txkh5j8tA0nDvMb/P9H2tWCXu2E70oL1rYOvR4rML9 WIVVtXe9gh/eoVbmh1rIgehyUyQiRhEur8PcZ1/taF47LN7Z0tpS6682yNDDXYRK086gbRR5/2r y5Rc2W0OD00o3qNGME9klFIEZP/7NLk= X-Google-Smtp-Source: AGHT+IGtcUQ2cQc6JXumuzWFyrkuxQZag6xvpMj3QJ+YKaYVGKukb9EGVqZXQKT5u85cjhqul4Yy8A== X-Received: by 2002:a17:907:3d46:b0:ace:9ded:3292 with SMTP id a640c23a62f3a-acedc629414mr282686466b.29.1746001526755; Wed, 30 Apr 2025 01:25:26 -0700 (PDT) Received: from localhost ([193.86.92.181]) by smtp.gmail.com with UTF8SMTPSA id a640c23a62f3a-aced892712csm111462166b.161.2025.04.30.01.25.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Apr 2025 01:25:26 -0700 (PDT) Date: Wed, 30 Apr 2025 10:25:26 +0200 From: Michal Hocko To: Dan Carpenter Cc: Shakeel Butt , cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [bug report] memcg: multi-memcg percpu charge cache - fix 2 Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: EAA8916000B X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: qqgo187mz84dbs8k9yyjtphszcxfdjpx X-HE-Tag: 1746001528-341444 X-HE-Meta: U2FsdGVkX19P20osmBFqXGqo9Niys1Gh45Us/26fAW3dKfPy6subXWVZLSkQ1vU+iZ2WiUbjDxyGAuyknGROZuJhbJKhQTwfF/zH2ZLYsHkhIEtg2UOmCemSbbyzUJ449X3kK9b76BuE0tNtEYJdlBL+/VV61yRv/+EL4ZKslZotD5GRlLY/3uATHKiEe1XgEuZYvDfuNXZrd+xTDmc/l8T56qYGZxG2o/Hik6tAvxLFKbAwG/Sar+6UuWtZPdGZIXAiGB/GOEQQE5TxGtXkIp4KraHVccRZ23Qw7QfQHqcqaFEvWwBIOyS5Ig99LKMGqmAugUU5ogGvIU5qbqgcxq+EIAe57RfVADOZfICDViuuunMxD2I28VAhnJAWtg5VRoBBSeONl2MTzk2TdzdiCCoAd7P9PWClbXvud79Ksm6zwe3vNXg4sA+JaiYBk5EsAkh5tdR1R1tRiJJoJ9DRL10iFVENTjPTI1zaCk80C0q9JyFViG1FHvG0PTRvYc9gpiLWHyUx4EdJ1Uj/gNvfuggm6pYWyyeMkFZna6kcYxytJrARLdBWvw1MXJURtbEdJIexnBxvxAlkoJz3NEgtA2NKQoO5xqGkaDz+55LMv8FXze8rE24PJt+QMN+u/PFN2JckN8eGBBbjR2vbxSHkuikF5jOawXxymYgRRNBsL0PF6y+ExY82zafGL0d3J1cvOcoN1T8qOicG3H4H2Zg28sf5gfkYrIERkNtA0XMkEAXJa0pvMGB8SLUGvS4gupCYXGfZp0hUS8n94LFA1FS0hH7EQj+lkw15In2KzvlaZGP9tMiNIhpDY3YFprpGlU14tYi8U3RnIrB1eCMTmtgsdhHtRTgSMgnLkMtCkbxZBOJfBJstqDygCmpuwN3aTFOPD76mtXOxb1O1BPpdeqqfMwITaCj5P2Kj710zbFTwGcbeKY6k8gus6PPn1LcfhI2ifEd3RvSbxECZxMDE6/4 6S/jnyXz L5ApQMAPXFjDspGxzA2prc8+YUVHEPU6pPjD8uWBH6ffnDIhSq6bEnTXC4A/VpM/SZnxkvFmOt/Np/hOqWmhOECSoRqMUnDC+CrrV7fWBXuGPIYS79z7/QMpOdhIXDWt6UJ8kZFZU451p+gN4BUYczEsNOhXL3/+Q3ojOj639mkWbPBakGsGty+Ip97+JDxI6V1F3Gduzzpn8n3eSzd/3+kSuE/0Q0QQrZe0bSOnyVQTtfw3Xn0a7t5Jhhx10dRq6c/MU2/mNVVWGpokWTmBUloX7Xis4fSZXBZ78muCAZzqNPmH8SzeNPmDJm2S1YrK1Qijgk1qnBoaUuhoYCD+FfTgFdw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed 30-04-25 11:09:50, Dan Carpenter wrote: > Hello Shakeel Butt, > > Commit 1db4ee9862f9 ("memcg: multi-memcg percpu charge cache - fix > 2") from Apr 25, 2025 (linux-next), leads to the following Smatch > static checker warning: > > mm/memcontrol.c:1959 refill_stock() > error: uninitialized symbol 'stock_pages'. Thanks for the report. I believe this should be addressed by the follow up fix from Hugh d542d18f-1caa-6fea-e2c3-3555c87bcf64@google.com -- Michal Hocko SUSE Labs