From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8931C369D9 for ; Wed, 30 Apr 2025 08:09:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 972536B0095; Wed, 30 Apr 2025 04:09:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 920736B0096; Wed, 30 Apr 2025 04:09:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 79C256B0098; Wed, 30 Apr 2025 04:09:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 524A96B0095 for ; Wed, 30 Apr 2025 04:09:27 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8D19D160ADD for ; Wed, 30 Apr 2025 08:09:28 +0000 (UTC) X-FDA: 83389985616.04.930DDB5 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf21.hostedemail.com (Postfix) with ESMTP id 4B8031C000A for ; Wed, 30 Apr 2025 08:09:26 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=iFmTFgtn; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=0LzDwju8; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=iFmTFgtn; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=0LzDwju8; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf21.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746000566; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8RixjhbWpiWlGSXrYW9u22vJ3QHZVt13xlcgzXElNmU=; b=hUV53ehl11Sr0FBBBshL8+U8dmSg+Ppkhdj+qBzfOY7fcVci6HcUuLRp0+tn0AthNACi6B oae7IBpk5qXcYdaU5MGBIkBilti+RnqgB0miwGzDXCkNBKaLIxq3Yug25fwz2EJMh38Y9n mpCu1Qjacp5jHX+mehxuMiN6Iz+xF+E= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746000566; a=rsa-sha256; cv=none; b=0YlynXR5cjKluCzjqNEwAvj1Jzgn+9Ki9TEWFkj+M916/ewru6XM1RPeJ7FDx+enuPSCBA jFMg75loF5cN4TjwPXPth1sobVVuOVJCOKGQQZSKVnvl2PZlL1PXvJkRlAt4PQb4tuUQBa QOBPuG+E5O6Zw51JhgBj8bgDsncuJ8M= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=iFmTFgtn; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=0LzDwju8; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=iFmTFgtn; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=0LzDwju8; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf21.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B08F41F7C3; Wed, 30 Apr 2025 08:09:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1746000564; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8RixjhbWpiWlGSXrYW9u22vJ3QHZVt13xlcgzXElNmU=; b=iFmTFgtn8TQDhYi2ombB5TLGeuk0+IbFqcjuNjSuYrJAK1Zbv6eoiPqQFC4LwJlDE9UwLf noqXZyuNjceaM/3TO/lufDeU5I6lNO9Bdmy8AUPh2TLNb0ub1CxTnZMg+cPrpODDqA79BV HZIaHOXZkOCGh8VVsQm/fA0dAUKGcqE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1746000564; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8RixjhbWpiWlGSXrYW9u22vJ3QHZVt13xlcgzXElNmU=; b=0LzDwju8CNPrOvKKHy7ATNNorRyXLe2bNYKwUyHKwvGBu71tNM2UYuOM91eBpJwzIlEJgu TrCfWl4Ms+SVFhAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1746000564; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8RixjhbWpiWlGSXrYW9u22vJ3QHZVt13xlcgzXElNmU=; b=iFmTFgtn8TQDhYi2ombB5TLGeuk0+IbFqcjuNjSuYrJAK1Zbv6eoiPqQFC4LwJlDE9UwLf noqXZyuNjceaM/3TO/lufDeU5I6lNO9Bdmy8AUPh2TLNb0ub1CxTnZMg+cPrpODDqA79BV HZIaHOXZkOCGh8VVsQm/fA0dAUKGcqE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1746000564; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8RixjhbWpiWlGSXrYW9u22vJ3QHZVt13xlcgzXElNmU=; b=0LzDwju8CNPrOvKKHy7ATNNorRyXLe2bNYKwUyHKwvGBu71tNM2UYuOM91eBpJwzIlEJgu TrCfWl4Ms+SVFhAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 1DE3C139E7; Wed, 30 Apr 2025 08:09:24 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id TByrA7TaEWiICgAAD6G6ig (envelope-from ); Wed, 30 Apr 2025 08:09:24 +0000 Date: Wed, 30 Apr 2025 10:09:22 +0200 From: Oscar Salvador To: nifan.cxl@gmail.com Cc: muchun.song@linux.dev, willy@infradead.org, mcgrof@kernel.org, a.manzanares@samsung.com, dave@stgolabs.net, akpm@linux-foundation.org, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Fan Ni Subject: Re: [PATCH v3 4/4] mm/hugetlb: Convert use of struct page to folio in __unmap_hugepage_range() Message-ID: References: <20250428171608.21111-3-nifan.cxl@gmail.com> <20250428171608.21111-7-nifan.cxl@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250428171608.21111-7-nifan.cxl@gmail.com> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 4B8031C000A X-Rspam-User: X-Stat-Signature: 573hop113ihyibfo4ckyu9k6us994b8f X-HE-Tag: 1746000566-156997 X-HE-Meta: U2FsdGVkX19il06LdynpV/scUaPCV8LumDaM1y/jvpviXUbQ6S00T0B2RdmGiIxhi2Kac2a735pyiTlHD0UbVDfq+oJLYiW21tnIG26hpJEfemskDSYTs5D5PM8oh8T5gYpdNZslDwbbMRfsLTzvhEfPmD/I+9MD8PCLaz7Wt2vp0ZVVaU8PLyuqMyAlcs7nqiOO2OtH2baAx+A/gGzMZkXVJpk5TK2CU2E5iyQwJEFWdR50VCmOsD8z5iCVgGuqIVLz1b5Bd9OTTj5slCEENgBTh0Imp9+ASR4tvVAIO8e0FntCSDB1SiT0pY0E4iMiCWTlGwuRGk3iKCCwFrIrLGdrdLiKGSNHlJ3a6o5coLwcSb/2ypukAsIipTeA4UZgSN/6CXJw/WhWjapjGQrVJXYOEZ7pSySQVzlr7/aD2/u2U7vyNKQMs2FI7C2P9xEPOkO/WcFTy5cjC5OWMJZOQ3WZ9ZS71Hst1kqzZLXoMPseIkdlKDrwObMR1GqbponbgD5iMLiZZa42kKiQnDEvCYSjt1tRps5EWy5d3hl+r/ebQfYm4vbgeQF3729a06CER3FSP29cuNlnXTGfUWWAcsF3NxHEkwSCyn8orCe8DUWtxLAz8rZnXAaDLmBmKzZlJOPHrHSGvqfTK3m+xriE7d9FqpQJ2XeStLN4odX1PxFKk15rW4jLvwGVqxHCKWSxTdwDX+cU698mcMwOKL2z99lLNAUXUjuh941CAhLqYeWyLanBqTw7tcGO619BBwG1vg6OedQRP/BWTNlI+ygC5GC6CMXv8aWjK7+5HilVrk8KofYDkiENhJiLc605w/uZNx/K1IQXFB9NQUnOgctvTxwlLKaRd+a4Z3qLUNff3ucDM48JVnNW8vXBa+dPVWB1srRHM/c9zM+JeKXI6eUAAHdB+qfiS+wTHcLtcm+jZ8R/P5RWi0X64OBwywdC9vEIqTid6V7EdyKnNoSDMXC dV0sZc+J aAuCKlDK6JZxMTj1F9QsUygsSnpZfssa9JGkts9igsxZ9VPNjLWFA0VuXocTIB75wRz6PUDDuYrb2L3Dfo02G8rjMzr/2nPFyu4PlZdlTHXNJuvpmRKn5VbITEwJU29fzHV7HM1wkaWtcVyzsb9v7a9kgIAQqZSo1tLFlsXmB0HDo3X5Y++ov2DVuYCH+KhWcaSFiySBZvU6CEx9Hz/7YG6DrvKJhFLDrcHjOnSTxVhCoDuC+EVaBEpv6EYtyITvXl4z6PInsYFP70PRox5NYg6l/kaDhpv8v/qVJCsrKXZd0UWBu2dRee0dH9sZZPJQ6TePttC9V3313KJ8F4CPSZzEk8J4WZN3J58KPQJsw6Sae6ZRU6A/pCRhuhPqO9F2PkXGgiwtiSjxNxYSY3euWH2x0K7UjqZddNdsx68tSXizOHMRmhdXwJG8GgA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 28, 2025 at 10:11:47AM -0700, nifan.cxl@gmail.com wrote: > From: Fan Ni > > In __unmap_hugepage_range(), the "page" pointer always points to the > first page of a huge page, which guarantees there is a folio associating > with it. Convert the "page" pointer to use folio. > > Signed-off-by: Fan Ni > --- > mm/hugetlb.c | 24 +++++++++++++----------- > 1 file changed, 13 insertions(+), 11 deletions(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 6696206d556e..293c2afa724b 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -5815,12 +5815,12 @@ void __unmap_hugepage_range(struct mmu_gather *tlb, struct vm_area_struct *vma, > pte_t *ptep; > pte_t pte; > spinlock_t *ptl; > - struct page *page; > struct hstate *h = hstate_vma(vma); > unsigned long sz = huge_page_size(h); > bool adjust_reservation = false; > unsigned long last_addr_mask; > bool force_flush = false; > + const bool folio_provided = !!folio; This might be me just nitpicking but: Why not rename folio to ref_folio o provided_folio and do struct folio *folio = ref_folio; I think it is more natural than the boolean. Also you need to update the comment that references the 'reference page' and the one David mentioned. Anyway, Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs