From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83848C369D9 for ; Wed, 30 Apr 2025 07:58:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6088E6B00D2; Wed, 30 Apr 2025 03:58:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B59D6B00D4; Wed, 30 Apr 2025 03:58:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 459196B00D6; Wed, 30 Apr 2025 03:58:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1C8086B00D2 for ; Wed, 30 Apr 2025 03:58:39 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 54E721CD007 for ; Wed, 30 Apr 2025 07:58:41 +0000 (UTC) X-FDA: 83389958442.08.41FA3DC Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf12.hostedemail.com (Postfix) with ESMTP id 19B9E40004 for ; Wed, 30 Apr 2025 07:58:38 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="yz/8EJox"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=R5NEXsyn; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="yz/8EJox"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=R5NEXsyn; spf=pass (imf12.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745999919; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=K+M0v88wXkTO2lfW07pgxE5E1/OLEgDm+uJTK9nmId0=; b=rqb+NORlknflXswKdFJTjNf15+jAHStAs0Z3lK4cIb6fdtMYhxQO5TeqMj13RCUNpKP4tu 4wpi763tkRP8yMOiFUp4uvUY4ciNCqC8HbVLU4apGAlE74E04GXFiFBXAF1X8Vw+D0DNjN j/iPcoe0Fd6T0ByU3zSL/vpF0PhyPlg= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="yz/8EJox"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=R5NEXsyn; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="yz/8EJox"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=R5NEXsyn; spf=pass (imf12.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745999919; a=rsa-sha256; cv=none; b=CDFzAmg2W1grw8xjAB7iLgHuiQtOZyphPj9+RJzjOZpwKqWnb1evUZnvuBYfj7wX59ViLT bzozh6dgoQpUpfzDcj/E/PH9WU90LRVdwk0Hj7QDB+O6xmERvF+TmcsDJ9N+eOlujhxvwu 4ufoH9xdc23mmaYsI3vfDig02qylUtA= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7633D1F7C3; Wed, 30 Apr 2025 07:58:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1745999917; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=K+M0v88wXkTO2lfW07pgxE5E1/OLEgDm+uJTK9nmId0=; b=yz/8EJoxTd6DvEU+JcHbFqvWeP7IgDWih8frOXqGghRnE/VQPlcNXPr7vlDWJav7nODC0x MGFpeVCeyQ7lF4l22EGW28vzISTN0pvvr2JfxFZhMUKzovRvI3B2ioi0o4/bZJh1bghJ1a bTFNx9GxBWngadWdHOg1LecNwNRWVWM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1745999917; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=K+M0v88wXkTO2lfW07pgxE5E1/OLEgDm+uJTK9nmId0=; b=R5NEXsynJ53+34V2g4jOsXv0bPItofkgVGow2tQZV7g4U1KiMX67x/EksZ/2U9O/2ehm77 5q3SIHs/EzgfPKBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1745999917; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=K+M0v88wXkTO2lfW07pgxE5E1/OLEgDm+uJTK9nmId0=; b=yz/8EJoxTd6DvEU+JcHbFqvWeP7IgDWih8frOXqGghRnE/VQPlcNXPr7vlDWJav7nODC0x MGFpeVCeyQ7lF4l22EGW28vzISTN0pvvr2JfxFZhMUKzovRvI3B2ioi0o4/bZJh1bghJ1a bTFNx9GxBWngadWdHOg1LecNwNRWVWM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1745999917; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=K+M0v88wXkTO2lfW07pgxE5E1/OLEgDm+uJTK9nmId0=; b=R5NEXsynJ53+34V2g4jOsXv0bPItofkgVGow2tQZV7g4U1KiMX67x/EksZ/2U9O/2ehm77 5q3SIHs/EzgfPKBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D042B139E7; Wed, 30 Apr 2025 07:58:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id oZhDMCzYEWgwBwAAD6G6ig (envelope-from ); Wed, 30 Apr 2025 07:58:36 +0000 Date: Wed, 30 Apr 2025 09:58:35 +0200 From: Oscar Salvador To: nifan.cxl@gmail.com Cc: muchun.song@linux.dev, willy@infradead.org, mcgrof@kernel.org, a.manzanares@samsung.com, dave@stgolabs.net, akpm@linux-foundation.org, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Fan Ni Subject: Re: [PATCH v3 3/4] mm/hugetlb: Refactor __unmap_hugepage_range() to take folio instead of page Message-ID: References: <20250428171608.21111-3-nifan.cxl@gmail.com> <20250428171608.21111-6-nifan.cxl@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250428171608.21111-6-nifan.cxl@gmail.com> X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 19B9E40004 X-Stat-Signature: 6wnbia8hzhc94n5crnthypb4qbiwokg7 X-HE-Tag: 1745999918-607602 X-HE-Meta: U2FsdGVkX1/Y+3licCuIrQVx5JS34t0AR4VsWIPh2UwiJYdpaKF4SRo8XApTug6oB6747PQdLR7j4He+Q8Uvk7UDZDEyIHyHt0ON4QyJtHOfejQtj+iMHbcos+281eVarHvLyhXUR54OP6yxR5Zr++GEysi2W+EFUe8Oibeqv8DEeWyLxtbijIZ+k7v7UNZYs221QwnD81mb+SNScOolqzu/+rXRBXxBo4I/NWax2NCmfKZrBKWReRg4yoJx9UBxF4M40PeXQs0Q6uJIkhiIFHN0lAyVwSsgWFdg7/cd7q9MfyNzBTIq7LXYeC4O+mfNRhGvRatf9AiPDp1tZTawLH0roWS80lVyhfJL4QiVXH0xIG7CtMdFZN/p4NzkgcrpwmS1tTve+pXIGHC10lQji2Ux14CnMYUMtlUomBMwmEcKb6wDD56TWewO4uvxCpPBFRHOMrB/i5Tpq89J5W1OqXPjSkz23A22wM0uwJBYQp6kKBs7P+QOpGPv9yV7BQx6r9NOqk6V1/1Ll7T3FjpOw3xvMUxw/XAVrFE3w5jT573ZzpIdKvG/kXA3wdQX7BPLUb+Kc73YBCqERLCPYND46xz8N9M3ZNyWODjym15d+K/aeqY10hUEt/TyN9KIg5YR2/htuxfWQN90uZwY9VyhrnIvqaxIkPiZ338CwbdvM5mmkox1BMz+IvgPC61qur2J+OdOfjjTRLk0mnj4Ox3+C5db1N4j8QaskqF3JCQq2HEeuZgG954jOHRZYg/u+mwgEV1T1XHOz7qQPPSanZa+K02wziBiBigU/BcEe9qvRE6zXie1cgCwzcQLe1L08lmAn1PVKEUScsnJb1cEwBdwuWBkllsxmEX+v7v4Uw10El9oGqhT8pI4cxCcyL+fk+WoIc0CL9rsT1liUy1FhwoeeEXEqPGLVHSyjuxuCENiLZuc7i3x48my5ZbKx2YAQsLnT1JHWx2BQ4W4Q3u54pq DDjlkg4N RzHRLju96X7cmR/2KS6xsMedcJEwUZUX9cuTVXMjMmb1CDo4KciTxFkrkpnjDVY3mBbefXiwd/S12rvBHQlG+a+B+v67Ag1kQc2dIURAehiGUIhqwLGOkEWf4liLPQZdFlcHKhdoHmy0ADA6x+uo8XQaTBs+iDl+FG9O9JIM4ZBk4pKPBz89ylSHYyGNeTXP/yXTeghyS/3eJZ1L1dmO+/wMjRDf5hqic3jr5A788LG1RcBXK23yN4qdxUqNiQ5AqF83U/vaSpU0iYINMSRmDQSMhw4rNcJU9AKWehGwhZ9f8ZCSTxYJ8Jmsyyjv5ft1lXVad1E/1kVMNEsrywwteIYM5YbdtkjUiSzyjpXjsW+7Rr2/AaX5i/BSpaYigOYXvxY4d+yt10d5jLNW5WrLuM7R/APFuWgivUrcyCiASKKeT9Do= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 28, 2025 at 10:11:46AM -0700, nifan.cxl@gmail.com wrote: > From: Fan Ni > > The function __unmap_hugepage_range() has two kinds of users: > 1) unmap_hugepage_range(), which passes in the head page of a folio. > Since unmap_hugepage_range() already takes folio and there are no other > uses of the folio struct in the function, it is natural for > __unmap_hugepage_range() to take folio also. > 2) All other uses, which pass in NULL pointer. > > In both cases, we can pass in folio. Refactor __unmap_hugepage_range() to > take folio. > > Signed-off-by: Fan Ni Reviewed-by: Oscar Salvador But: > void __unmap_hugepage_range(struct mmu_gather *tlb, struct vm_area_struct *vma, > unsigned long start, unsigned long end, > - struct page *ref_page, zap_flags_t zap_flags) > + struct folio *folio, zap_flags_t zap_flags) I think we are kinda losing information here. ref_ was a good hint and... > struct mm_struct *mm = vma->vm_mm; > unsigned long address; > @@ -5885,8 +5885,8 @@ void __unmap_hugepage_range(struct mmu_gather *tlb, struct vm_area_struct *vma, > * page is being unmapped, not a range. Ensure the page we > * are about to unmap is the actual page of interest. > */ > - if (ref_page) { > - if (page != ref_page) { > + if (folio) { > + if (page_folio(page) != folio) { You have to update the comment above, since we are not passing a reference page anymore but a folio. -- Oscar Salvador SUSE Labs