From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA452C369D9 for ; Wed, 30 Apr 2025 07:51:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 798C86B00D2; Wed, 30 Apr 2025 03:51:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7205F6B00D4; Wed, 30 Apr 2025 03:51:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 573976B00D6; Wed, 30 Apr 2025 03:51:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 271E46B00D2 for ; Wed, 30 Apr 2025 03:51:01 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 7ABD31A0B22 for ; Wed, 30 Apr 2025 07:51:02 +0000 (UTC) X-FDA: 83389939164.16.D44376E Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf11.hostedemail.com (Postfix) with ESMTP id 4C59440003 for ; Wed, 30 Apr 2025 07:51:00 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=oJptAU3E; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=3NlxzIYS; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=oJptAU3E; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=3NlxzIYS; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf11.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745999460; a=rsa-sha256; cv=none; b=GpgjItBRJ5dEMGOGrLfjIFr/n3Sqa+bNpxlah1gYD7tmz84WslIFbeSbzMWSfcVFVki0JO ldEGg44Ji6XdNjoZ1yPusStleoWhHwqzhxUpVqLaDLI6eBAJr05HdIc/TV3PDrxNRBFh+5 uGkka6LBk0ksvus0HgSgGvbJvbGnCkk= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=oJptAU3E; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=3NlxzIYS; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=oJptAU3E; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=3NlxzIYS; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf11.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745999460; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SgA3FvVgjo1HyZM+9jABfYH5Ii0eOTJBo6Tbqq4m9yY=; b=TaJ/n1MWWlOtZly9DZWZfNR9KP9bnEM2R7KU6JxtvkzJXqBUG9GwzvZULTMJhthZoLgFJ4 8IFFZVpW2pZV8+zFwMoYtLeCYz3MB/tvOhpla2AuRSmQcNeyUM75wVMxjsFalGHViQiyo5 q77qUVE3A82KWLkui0MTzNKS21b5rfg= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B04DE1F7CD; Wed, 30 Apr 2025 07:50:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1745999458; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SgA3FvVgjo1HyZM+9jABfYH5Ii0eOTJBo6Tbqq4m9yY=; b=oJptAU3EmNB4qDC/4KC+4PAaz66WwfRdRR+yP2dLDgq0FwC7921UzMe5XmHY7pc9wsHYAw aJlDdFNULA2A7znBNvpnqJTtwGM019cLayP7kQVEhW/2QviYYAN1ZixJ+lGGkqsrS5nxgc MMwIyKBXr0fBMhBoVgk1tA074Z/X3gs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1745999458; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SgA3FvVgjo1HyZM+9jABfYH5Ii0eOTJBo6Tbqq4m9yY=; b=3NlxzIYSoJgr7S/kiliPJ/m81Wy7BSlXqA4NsVot7hmnCEavGbY3/RWHRfJ5rM0B/6maQj Pk2v4EF7Fta0MrDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1745999458; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SgA3FvVgjo1HyZM+9jABfYH5Ii0eOTJBo6Tbqq4m9yY=; b=oJptAU3EmNB4qDC/4KC+4PAaz66WwfRdRR+yP2dLDgq0FwC7921UzMe5XmHY7pc9wsHYAw aJlDdFNULA2A7znBNvpnqJTtwGM019cLayP7kQVEhW/2QviYYAN1ZixJ+lGGkqsrS5nxgc MMwIyKBXr0fBMhBoVgk1tA074Z/X3gs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1745999458; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SgA3FvVgjo1HyZM+9jABfYH5Ii0eOTJBo6Tbqq4m9yY=; b=3NlxzIYSoJgr7S/kiliPJ/m81Wy7BSlXqA4NsVot7hmnCEavGbY3/RWHRfJ5rM0B/6maQj Pk2v4EF7Fta0MrDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 0C0B3139E7; Wed, 30 Apr 2025 07:50:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ewlWAGLWEWiLBAAAD6G6ig (envelope-from ); Wed, 30 Apr 2025 07:50:58 +0000 Date: Wed, 30 Apr 2025 09:50:52 +0200 From: Oscar Salvador To: nifan.cxl@gmail.com Cc: muchun.song@linux.dev, willy@infradead.org, mcgrof@kernel.org, a.manzanares@samsung.com, dave@stgolabs.net, akpm@linux-foundation.org, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Fan Ni , Sidhartha Kumar Subject: Re: [PATCH v3 1/4] mm/hugetlb: Pass folio instead of page to unmap_ref_private() Message-ID: References: <20250428171608.21111-3-nifan.cxl@gmail.com> <20250428171608.21111-4-nifan.cxl@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250428171608.21111-4-nifan.cxl@gmail.com> X-Rspamd-Action: no action X-Rspamd-Queue-Id: 4C59440003 X-Stat-Signature: 75cstaxqbq1rytmd4o5he5t6n3waxxab X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1745999460-188299 X-HE-Meta: U2FsdGVkX1+/9SukVCrecDm1clAIWXZT8//lEKN/gi8meCVsKtyv2i/a67lYkNsSBmQ7ZMv/tc1++gcT6WfYpTG/jxIdMDUbpYp8dK0Gck6xwPerB+6TVYG5uscPO3MAO20a3J8h3DEc9jC2bTXlQ52m3taNCz+C8nImTN9LJ9wAZyEY12RgWJWsQuNgrYPK+qNV3UO3xuj4qGBV6PFLoIzgmTfVunBdZNrMi8S9owTxEts+5avHf5sHi8CyURsvRWmqiHkk5WbIqT0TagC1lpAvazWAEnVBH/AMuaLnlaoyzXoeIs5DZVonREWe6ySt/yVwiMa0u6z1naZVrdzIsbz2Fi7xCl+JkVbFF1pW4ZGjfMMEJpVeFG5iDq786RO53lDLHbGJm36SNP2hwSpnXgDl2UMcrd/SJhLPEm8/EGsis9mMj+DEFb/VNOa/FtEIeIqqlbm9u4Yy1ZJYM0HMFYCEEyWUos6lmvzkEXLzyU0rz4RRtsb2NxXdtcxuTIxWD+/qgSTKuxfLKwbN6v/U+TUCFc83z5tqkHjF86o7/Y7t4zktG+eZiMKsTSgHhOz0OV7OyrG9BdgvYon7x2ZLz26E4WdbkA+A81x3GsGRt0jD31WGCOWH91d5wlR2A9aOrNmTT2FWd4OllsASzi8a/0vuaEiI3l0ERpS7ZGqDlegM4BSyyOyhoYtf/M4zscpoY3KvYnBY4VKLlFLMwVDD0AAQgoq7niB3Xyp5g8YdaKOmn+KN4AsVzEQaSWByJNNTU9tw/bsxFchjaZrfZWEkFea48oOvpvSzQsCwk3DK5fEX6cIFFp4dHtMin4RTtIS6F4+hAIVs1Is6hTjOhdGg281BTXdnqXU6dQ3rdHCUPQtHMeXYRSZoLh3GCXJ8ZfSH/ICw4NfXV2d150Z0yx3n8GplNgkt9pQbhsWxayYaKZvyypvEYanB0MOKAfosYRfgHeHv5Ph3jJuVIXrSwZs Qf1in1ZL 67K0jWvB5xIPCdGJTZcbS5afElmiaNoQ2GIktgcAgMeu54gDwpxBPqzsMlQMemZGpeYCQYKvamz29ShpYD5XCF4zEgk2zs7q/kn1WFaexwLSAQUYRrD3cFhh1toM6pCXKpNGM7baYpjm9um7rRcoYhhICFvsvA8oRfDIimyGmohZx5wH3Mdtyh6JlL2+u1V1i8hfvOyD+ZAxhSWi3WZnVWTrthBabzSeT6o8nd0NbAnKBtTO5IrIkkNp81/DvuYrKW5h676iKKtGhZ+ulxFcRPppHhXb5yOtuN4MW/q/nLuVXAd8ZLnG04nx70m3wEulLH6djwhTcfjp2u+93LcoxjhI3Pe8HL7xSc88yTWFvM7ZiwToqDx8ZlWcnGJAm6lqaZvt7VKnJfHCb89TzVS1AYEgZnEWssn/+KJbdiozNSCtj6rn5/19YEl3EvxPaIQhqooQg/t+eLlZNB4I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 28, 2025 at 10:11:44AM -0700, nifan.cxl@gmail.com wrote: > From: Fan Ni > > The function unmap_ref_private() has only user, which passes in > &folio->page. Let it take folio directly. > > Signed-off-by: Fan Ni > Reviewed-by: Muchun Song > Reviewed-by: Sidhartha Kumar Reviewed-by: Oscar Salvador > --- > mm/hugetlb.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index e287d8050b40..b1268e7ca1f6 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -6039,7 +6039,7 @@ void unmap_hugepage_range(struct vm_area_struct *vma, unsigned long start, > * same region. > */ > static void unmap_ref_private(struct mm_struct *mm, struct vm_area_struct *vma, > - struct page *page, unsigned long address) > + struct folio *folio, unsigned long address) > { > struct hstate *h = hstate_vma(vma); > struct vm_area_struct *iter_vma; > @@ -6083,7 +6083,8 @@ static void unmap_ref_private(struct mm_struct *mm, struct vm_area_struct *vma, > */ > if (!is_vma_resv_set(iter_vma, HPAGE_RESV_OWNER)) > unmap_hugepage_range(iter_vma, address, > - address + huge_page_size(h), page, 0); > + address + huge_page_size(h), > + &folio->page, 0); > } > i_mmap_unlock_write(mapping); > } > @@ -6206,8 +6207,7 @@ static vm_fault_t hugetlb_wp(struct folio *pagecache_folio, > hugetlb_vma_unlock_read(vma); > mutex_unlock(&hugetlb_fault_mutex_table[hash]); > > - unmap_ref_private(mm, vma, &old_folio->page, > - vmf->address); > + unmap_ref_private(mm, vma, old_folio, vmf->address); > > mutex_lock(&hugetlb_fault_mutex_table[hash]); > hugetlb_vma_lock_read(vma); > -- > 2.47.2 > > -- Oscar Salvador SUSE Labs