From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DA8FC369DC for ; Wed, 30 Apr 2025 07:53:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0AF9D6B00D6; Wed, 30 Apr 2025 03:53:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0353B6B00DB; Wed, 30 Apr 2025 03:53:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DCCAB6B00DC; Wed, 30 Apr 2025 03:53:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B106E6B00D6 for ; Wed, 30 Apr 2025 03:53:06 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5C0A81609EE for ; Wed, 30 Apr 2025 07:53:08 +0000 (UTC) X-FDA: 83389944456.30.05DFCF2 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf02.hostedemail.com (Postfix) with ESMTP id 20C0980004 for ; Wed, 30 Apr 2025 07:53:05 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=d7DJoNY2; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=T19h8BdC; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="efpJ3/4u"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="d/Zf6MUa"; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf02.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745999586; a=rsa-sha256; cv=none; b=cNbnKKpOBjEDpOUvw71ViZ6IKaerNF2SHp0jclK1aHoyT8XPMrsKekYdCAviicAQ+G03yf 8FsXENsUZtAAfgx3aQcWf6Zygxj3fmbQ6eGy4PWEOHIwYoN+NWv/jCovjCHCFknzO/LIC6 88FR//FnYy4HvF0z45H4bNwNAjHSICI= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=d7DJoNY2; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=T19h8BdC; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="efpJ3/4u"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="d/Zf6MUa"; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf02.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745999586; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=D4GAOYL2VzrxAlQlWWCojpqxPYbLREkwNFMN+v5Oxkg=; b=e20eCAovlaxRSmuTK8fqaKrUNhcwzuV3U+++cBAAKfhmSxQIs2gPSAf+eLfE1Pe6aztD1p Xg26JR1qHclYPmqnPDtCvdTyI0cTLgVmbjVc/O8WgPtY+S/ag8JkfwI9MSqb0B8aHIn1N/ ekyd9FPxEsH1x0gu9ZwCM2Mw1g4DBzY= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 912612118E; Wed, 30 Apr 2025 07:53:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1745999584; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=D4GAOYL2VzrxAlQlWWCojpqxPYbLREkwNFMN+v5Oxkg=; b=d7DJoNY2pLlGdccIrJCVUInDbB7wBsi+cP6N898dOy60cLfUpjHoTNl0Aui6lcug2n4FRQ O5uboBzUh0xAj3EgpGt+/5pbkMwJerSUPrt5j7RJUdz4AGTiNoJ+dsMBL3TGELAZtEe9a7 UNIQOaKJWfiSpfZDFLd1dpQprNeRa8M= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1745999584; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=D4GAOYL2VzrxAlQlWWCojpqxPYbLREkwNFMN+v5Oxkg=; b=T19h8BdCrFEmYzNFGfUV3kk02PV4PSP0aPtZfDLRZOcgKY/wcZxRz0zxCZ8eJqliKYUftl KK8ZEN7b1Ba3f/Aw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1745999583; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=D4GAOYL2VzrxAlQlWWCojpqxPYbLREkwNFMN+v5Oxkg=; b=efpJ3/4uWyT/PuQux43hnUYi+ePMkR9t3DYZ0FN+KpLJL65Ym2q2UfUQmuprKkT/bOlwDG 8x5QF7fo4Rd7u1+0JaUXL8aMNzqAMNcXNzT33gv4XcIl5U/DJWUoeLYZ0fm3mSaNlasi4V b62BT++4CSjRNfBoiZyoekuLL4vSHE0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1745999583; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=D4GAOYL2VzrxAlQlWWCojpqxPYbLREkwNFMN+v5Oxkg=; b=d/Zf6MUataRL2N/k5/sEoJwldBf7J7kGKkO8riUHNG+53KJOzcWqFZgO8BMIscsn4aLK4t 2wbD9ne5WpfctRAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E9F7E139E7; Wed, 30 Apr 2025 07:53:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id WwNcNd7WEWgyBQAAD6G6ig (envelope-from ); Wed, 30 Apr 2025 07:53:02 +0000 Date: Wed, 30 Apr 2025 09:52:56 +0200 From: Oscar Salvador To: nifan.cxl@gmail.com Cc: muchun.song@linux.dev, willy@infradead.org, mcgrof@kernel.org, a.manzanares@samsung.com, dave@stgolabs.net, akpm@linux-foundation.org, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Fan Ni , Sidhartha Kumar Subject: Re: [PATCH v3 2/4] mm/hugetlb: Refactor unmap_hugepage_range() to take folio instead of page Message-ID: References: <20250428171608.21111-3-nifan.cxl@gmail.com> <20250428171608.21111-5-nifan.cxl@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250428171608.21111-5-nifan.cxl@gmail.com> X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 20C0980004 X-Stat-Signature: opfax971tkza7uptx4pisoz3z93tuxxz X-Rspam-User: X-HE-Tag: 1745999585-426960 X-HE-Meta: U2FsdGVkX19TjdJCw8ebU4NlHuDS0pk6lcic8056XslF9pQscEo8L586y+lvMNKIN2Mn3q752Ggy60XIriE41bH4WZR1RK08CsDH1XIYopDWZ0msm0iCQ3EnUKKNgpyyhvBoOi3XkIPycns9MMaGF/QxGvgSqiS2SW5IvCF7bzRCW5F5y64uIyx4ZGfOYr1xOQU20RdnuO2FThP2tEJRCTWigcHv+1kpBzj9nF7WB5i1fzby/eTu9GC73Ta08OFq13u0EVUIAnK3AwpmK1wIAcbkighW+hZSozW+yzHkMdXUQ98sT7grpT2VEo/uVLAYjyBxm9Ef8uCI4Ry2lPy3MS7r0xJ8hNRgJAn4oIAOl4FOupHUHpwyo8jJfluuchmooF1kU/KIISkjH/FAGn+0IiYSbq6hf/638SMQWR0et+04TvKfznc3+1ECAGWxuJfIlN+AU0gWHIxh7Jj0DGdeItte7FwxW26gqnYPSHH5HWVONBXmb8vneiKr+/nyUC+jUQd4RFWUiwh0ZAExYPt+7f8TYQ1pZIBMk5M6buooSSK/Ebiqfa11V+ovwXvGP79tE+SL1b1kosTfbKwbKWts10zMaXzu0ZZ50Fsapytex2MKt0CPjcv2Zvdq0m9gbAleO/qrpcUJiz01KGz3K1cwojxW9psj4Wm97PWphcjOMKBfs3ddnMZTFlJqBRaK8B3Ui3Hbfuz25uny1Xr/SGqZGFHX8KVS/wd6g7Mti85gAtIcFi6kXXy7APdNn024CqTdKRAs3nwPqgYZfvtTrq44I+ZdL0w9ei7W4Z30o28S7Q6ZR5nz1QztRc/yKM/A7iKwi/yA9cCJ+UUBjHxxVMGnf8FdxNjQ/D3Rmu8XVcELqPqbImQrZ9AgUaTg1JUZC4SGd6rOMUn/GR1YmrO5upvMiGScTO+Rx5rNwX/E3kWW+Dd7lxhQte41GHUk2VUX45xBXEQcjCLWZxSgWp3DB+r juNKWr5M Or1hrzyTF3OVuEkpjnhJhfQCtvPmtCEhl+kE516Yh85+ueAno6uqnWT5tXEUOb1yjSYTKuPlJuTKAIWTKet2RKoADWoQ+A75USQo0mFI1EAH6L/zddSSgsga4z/K+JuU17GvOSvgGlTouweDcaDLXWUi3x9CpEZdSX1KNSJuPFitpFyOgi1Y1C3g7pGtPq6RTQXxYoabjEB40UifgYR5UlqLibUzasbTP08Wu1kPK4WapU8jgso6VCiAhS3TmRvg8rQj4XQKPIMgym4FDhuwSQCh8gg95sQP9i50Lp+TjpWE815Fepvaw76dH+o++FapmXm+4B4gY+0sP/wrH/LwVtwS0o9nfCTTIsbAHqAUt26Tti3dh54QcXeEUapn6RzJuaDEVCO+GN+BWsN1k83LsSHFuHDY/M1LkvpDWRMu15T3rFmY4dOiE7GG2O6R/ZozOmqHwgMyhHiRhJck= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 28, 2025 at 10:11:45AM -0700, nifan.cxl@gmail.com wrote: > From: Fan Ni > > The function unmap_hugepage_range() has two kinds of users: > 1) unmap_ref_private(), which passes in the head page of a folio. Since > unmap_ref_private() already takes folio and there are no other uses > of the folio struct in the function, it is natural for > unmap_hugepage_range() to take folio also. > 2) All other uses, which pass in NULL pointer. > > In both cases, we can pass in folio. Refactor unmap_hugepage_range() to > take folio. > > Signed-off-by: Fan Ni > Reviewed-by: Muchun Song > Reviewed-by: Sidhartha Kumar Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs