From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7B1DC369D9 for ; Wed, 30 Apr 2025 07:48:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F1C016B00D1; Wed, 30 Apr 2025 03:48:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EC9E16B00D2; Wed, 30 Apr 2025 03:48:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D46B66B00D4; Wed, 30 Apr 2025 03:48:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AA8C76B00D1 for ; Wed, 30 Apr 2025 03:48:08 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 69C1CC0A6A for ; Wed, 30 Apr 2025 07:48:09 +0000 (UTC) X-FDA: 83389931898.13.DD48D6C Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf24.hostedemail.com (Postfix) with ESMTP id 280E518000D for ; Wed, 30 Apr 2025 07:48:06 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=hXG1Ts0W; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=VcVA7e0s; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=hXG1Ts0W; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=VcVA7e0s; spf=pass (imf24.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745999287; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=784amBfCV58CRKel//XxIbfiXvwlukaIbNyXHHSMyGQ=; b=lRpsofgTHbW+85YU0ITlf6eUE0eD+bBF74JpzGVngcJMvGG1vENrj3nwdxwQZ1yEB1TOO/ Y9Zu/aCvvhyWz/YHNs2fwG+CAyM88F7/47f3alaov3b3lTeGuFEu4GJIw8NoJn44Jm+RHD fqEWBSBY4+JHhvtX085PGzjnGkyTl6s= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=hXG1Ts0W; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=VcVA7e0s; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=hXG1Ts0W; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=VcVA7e0s; spf=pass (imf24.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745999287; a=rsa-sha256; cv=none; b=C6Gy8Oc+km86q17wKH6LMydtcjjFlD7SF7ECa2UMA8+RiIurnr19DJ/pI4IJng6vMq4ceq teAP+1QkgCaluPDp+spCBoxmroIYFsoXtPRotiDEx2UsrR5K2scjnP50qtRpT75DZFKwZU n3ipegOSwUAPQoHVE+xOpOnHdxibQFg= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3F3AE1F7BD; Wed, 30 Apr 2025 07:48:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1745999284; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=784amBfCV58CRKel//XxIbfiXvwlukaIbNyXHHSMyGQ=; b=hXG1Ts0Wgxzv8s2AJPQODebdHkhG9ERbR48Z7gV2cTqLdY+ScVO+WbVmI/i60dc6rX7eBv MgoYXTmWNOTo0/JWwqORbv7iQHdBpGH/Z3zlrXTjLdPfXXA9z1q9SNvhaP87q3Dr5zd221 IUwpG+lJ54YtBjmIIWmdOUsn7oc1PcE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1745999284; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=784amBfCV58CRKel//XxIbfiXvwlukaIbNyXHHSMyGQ=; b=VcVA7e0sAqCWvVJBxEgN/n3ZfSkHP9ItO1nUqc1M5liQHeZJt73lHILQ3dVaNB9NLkAFyy 22rEU+0Pmhqmm5CQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1745999284; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=784amBfCV58CRKel//XxIbfiXvwlukaIbNyXHHSMyGQ=; b=hXG1Ts0Wgxzv8s2AJPQODebdHkhG9ERbR48Z7gV2cTqLdY+ScVO+WbVmI/i60dc6rX7eBv MgoYXTmWNOTo0/JWwqORbv7iQHdBpGH/Z3zlrXTjLdPfXXA9z1q9SNvhaP87q3Dr5zd221 IUwpG+lJ54YtBjmIIWmdOUsn7oc1PcE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1745999284; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=784amBfCV58CRKel//XxIbfiXvwlukaIbNyXHHSMyGQ=; b=VcVA7e0sAqCWvVJBxEgN/n3ZfSkHP9ItO1nUqc1M5liQHeZJt73lHILQ3dVaNB9NLkAFyy 22rEU+0Pmhqmm5CQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 82F7B139E7; Wed, 30 Apr 2025 07:48:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id rbxdHbPVEWiMAwAAD6G6ig (envelope-from ); Wed, 30 Apr 2025 07:48:03 +0000 Date: Wed, 30 Apr 2025 09:48:01 +0200 From: Oscar Salvador To: Donet Tom Cc: Mike Rapoport , David Hildenbrand , Greg Kroah-Hartman , Andrew Morton , rafael@kernel.org, Danilo Krummrich , Ritesh Harjani , Jonathan Cameron , Alison Schofield , Yury Norov , Dave Jiang , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] driver/base: Remove unused functions Message-ID: References: <273649393600cb33ac3eec0e9a523c2d1853a47c.1745852397.git.donettom@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <273649393600cb33ac3eec0e9a523c2d1853a47c.1745852397.git.donettom@linux.ibm.com> X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 280E518000D X-Stat-Signature: j71zjomhrmzi4ugykm5mr9nozw4z5gsb X-HE-Tag: 1745999286-52543 X-HE-Meta: U2FsdGVkX18p8MKBGFa9CfApbBKiDupwQlDyauQsTYZygvEwXKfv7m8yGmpmQjJ8mFr6+Z4/DJ7xxgtI+MiJ6SHU5z4K8ZC/bA/1jd09ZcukqO4Hkcm5rGlN1JLYL8VhsVx80XqetwBeFwX77VqPQ0tKYBMZtWawiOXze4NNB6XrCgRDCm1KVxn302tzs/NO6Py36s6hT/6nLolofDUwQv91hi3flC761HqysLZzudpQiF8inXpnwWRPdXMlydGpnFCFZINj++gPdZSy6EILKpf2VLh1oC/03pywjKy+M+CD/UY9gFGzv4e5+koTrzFJjMKoHa/iUGzmIz/g/4KfJIiH0rZ1P74oOAs0kF0uueQg0lR+pnNcybiPHS89bQP4d5XRDsF6xHUJ2LGO2R/IhUjmgydv+mDpH9LCulPB9ln+xX1mOB4IgehJTUQH1/I0Ng3uBHMKCQ8UjUgqXrhRfzQa/x6AVIL0rZRvv+PZS+wslLFbfdbCrZU5taYdGITw4rdyp9dWS/SkpPAJ8YgPh9jTfjHbdbaXOsnJlz3JLUmqr5NXpvbgGAmJG91E9UmRQGMbOun5DDolvonJuW/+HCQuEK7asBdFe6YVpSw/azIfM2jOBZIJ595cLDNNW3PGr+L8TSjLyuj+MrQSd9BRnp4O09w77B3hzdpVWBV7E4hOpMVY4gNdvDGN2aPM3FIkHLpV2g56P3N+1nXUhsk1iA6WFG0Gb7bbHfg+evX+G0wda8YAFYaHueiLUmRkt8h69DDeEgg4yHWp1szvMX/4mFSzo76FXC1mhvvl52o4+Z7Q1G211jANVBkGD8rzejR72W4UDX1KvxsdRsJ3vVnX2gpPIseMrrLmg/jPIWi/GUdIGTH1tCrwPxNDgvqZySd5th6HsY71tfuN4WfMrKCfBOCszfLZDvyNSIgIEqlvfzbbYiun4z8HTfFjGt9/tcLsF0IHljCXhmhRf60zSu0 biHBH1+l ckkK7Ya119OKijmZUlAuMpiHKxoBMqJUJcXdp25BIMcGG2S7Orad0TFNsEuMlTywpxhHNTj3s0SWl8mdvvcO2zTAELMaJf1hiYhvT1FBpX+nqs7D+erojgP9O1SATBxqcKSOdldkU9xKG64q9oncRKWNPE1bkI6qqZQRyoSOrZ1745DntZx7sD9GOA9sJ9/tZlt2l0qUJrn1EfivGTgRar/d7T/PjdysdTAn+ak9y7egCh0MYnJXvxYzTeKf6W5L+WiQo2mf7c0SoSpmH2yjTIZu2VY/SpL+wWrGzMGcRn3q+NTr383Vl2KlI3jppxt07Mb1iII1cgnRqZd5njGTVQaqwZC+so1/nFPy2bbgNh5xiq84= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 28, 2025 at 10:33:47PM +0530, Donet Tom wrote: > The functions register_mem_block_under_node_early and get_nid_for_pfn > are not used, as register_memory_blocks_under_node_early is now used > to register memory blocks during early boot. Therefore, these unused > functions have been removed. > > Signed-off-by: Donet Tom > --- > drivers/base/node.c | 54 +-------------------------------------------- > 1 file changed, 1 insertion(+), 53 deletions(-) ... > @@ -895,10 +846,7 @@ void register_memory_blocks_under_node(int nid, unsigned long start_pfn, > { > walk_memory_blocks_func_t func; > > - if (context == MEMINIT_HOTPLUG) > - func = register_mem_block_under_node_hotplug; > - else > - func = register_mem_block_under_node_early; > + func = register_mem_block_under_node_hotplug; > > walk_memory_blocks(PFN_PHYS(start_pfn), PFN_PHYS(end_pfn - start_pfn), > (void *)&nid, func); So we have now: register_memory_blocks_under_node - wrt. hotplug register_memory_blocks_under_node_early - wrt. boot AFAICS, we can drop the 'context' parameter from this function because we do not need it anymore, right? The functions that get called eventually, register_mem_block_under_node_hotplug() and register_mem_block_under_node_early(), already know its context and pass it on to do_register_memory_block_under_node(). -- Oscar Salvador SUSE Labs