From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6ECE9C369D9 for ; Wed, 30 Apr 2025 07:38:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 78F666B00CE; Wed, 30 Apr 2025 03:38:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 719896B00D1; Wed, 30 Apr 2025 03:38:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 56BB46B00D2; Wed, 30 Apr 2025 03:38:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 28A776B00CE for ; Wed, 30 Apr 2025 03:38:45 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 928F4140A5E for ; Wed, 30 Apr 2025 07:38:44 +0000 (UTC) X-FDA: 83389908168.27.0B133AF Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf11.hostedemail.com (Postfix) with ESMTP id 55E3540005 for ; Wed, 30 Apr 2025 07:38:42 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=TnxU1PwQ; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=PkuMMQun; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=TnxU1PwQ; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=PkuMMQun; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf11.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745998722; a=rsa-sha256; cv=none; b=oLUYwcDyVBg1dtHTD2V5twkfSTXjG9ZmGMQ6+jfVOIAx+WvcdXkzoQtO90c3obcgR35Qpc pzP24ocBHOzXWe27fzodpWBuXBZ7ci3z3fzh9sBY8mU2WRphQVhj6tt3aUH4/eLDJnwb41 ucpPB9dfSTda7eJrTMdk9OcvCtzlPyw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745998722; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=O0Wxq+lm+JZ1Afn0Ufjma0zDuusZNEP1SWkG1+hjfJ4=; b=cqNCzVzuZCtxUzZ8GvqQRo2t6luF+Kkg0LXmwjPV0m5qtXDPaji8+xw2Z4Qfh9RCPMlk5t fR6xSt+ypl9JJcG5UO2JUmhXSOVahpG8hZb2L5kalLdDwgWh0QXYVy86zl5S+FwGsxfj1s PB88wUpDwMmHR+ufy+kV+cnGBCOMVhc= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=TnxU1PwQ; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=PkuMMQun; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=TnxU1PwQ; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=PkuMMQun; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf11.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9AEEB21259; Wed, 30 Apr 2025 07:38:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1745998720; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O0Wxq+lm+JZ1Afn0Ufjma0zDuusZNEP1SWkG1+hjfJ4=; b=TnxU1PwQyrHRVyF+pcR6yLWKS41mxzATA+bT3LLUwzcJIMdoxyNnJpZHV062EbJBqMTnvI OJC1fsJxX/K+xD3Hf3QrXwmKYLT9Aj2MVmesRtHh5F6Z/E5SVC2sbE/8OwhHG0Uzxs7wm8 kdsnXe8nzWlwU+8/aYDQ771a4XjFXNU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1745998720; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O0Wxq+lm+JZ1Afn0Ufjma0zDuusZNEP1SWkG1+hjfJ4=; b=PkuMMQun5mNMXZKTtF3Y5RmTQaEBzsPArrEG75Cnf3nK8flTcm8gW/9nAWLch2hVh6WmbN x5Mp6Y6I4yBpXcBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1745998720; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O0Wxq+lm+JZ1Afn0Ufjma0zDuusZNEP1SWkG1+hjfJ4=; b=TnxU1PwQyrHRVyF+pcR6yLWKS41mxzATA+bT3LLUwzcJIMdoxyNnJpZHV062EbJBqMTnvI OJC1fsJxX/K+xD3Hf3QrXwmKYLT9Aj2MVmesRtHh5F6Z/E5SVC2sbE/8OwhHG0Uzxs7wm8 kdsnXe8nzWlwU+8/aYDQ771a4XjFXNU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1745998720; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O0Wxq+lm+JZ1Afn0Ufjma0zDuusZNEP1SWkG1+hjfJ4=; b=PkuMMQun5mNMXZKTtF3Y5RmTQaEBzsPArrEG75Cnf3nK8flTcm8gW/9nAWLch2hVh6WmbN x5Mp6Y6I4yBpXcBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id DD88E139E7; Wed, 30 Apr 2025 07:38:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id vXZNM3/TEWhWfwAAD6G6ig (envelope-from ); Wed, 30 Apr 2025 07:38:39 +0000 Date: Wed, 30 Apr 2025 09:38:33 +0200 From: Oscar Salvador To: Donet Tom Cc: Mike Rapoport , David Hildenbrand , Greg Kroah-Hartman , Andrew Morton , rafael@kernel.org, Danilo Krummrich , Ritesh Harjani , Jonathan Cameron , Alison Schofield , Yury Norov , Dave Jiang , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] driver/base: Optimize memory block registration to reduce boot time Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Action: no action X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 55E3540005 X-Stat-Signature: 8m85fk9ideu9k6w7x7yyj57ytt7crxbx X-Rspam-User: X-HE-Tag: 1745998722-723606 X-HE-Meta: U2FsdGVkX1902UDvBzDv5uBkgcSE377daGyqu9UElL+vXj+nCKbOnfAhnUkRlQJuDWs/z4cBGGY7dIML/CQUuK/lEnOZIJ64lzZ+keOoAUQOjTEZVhhiUwe4t7v25L9GS91ZHxKzXTQih4/ucCPskboOIHGrXinsfzvtjvnUDJ45jTEIJAWuRWgX1MeLP0/TvH91MXRz03a5dpgneLGvShoNJDIn/c5/CQ3i60tZCj6Nh8QLh3Vy8XBvVZO8/EtF7jwhxYHII92yM8MCyOcnvriy0dReIeL/7WRaRdc700sFL/+AzE6cvtxe6Z5El290waVqlWK3gZPGka2rr0v/EUqes4GBR6UpJdHSxCi0QbRkzmeoUjvwMlGrjRPaK+AaANZbrhyj+Nc4fCN1/+Jn0si2tPG8P9keqnmw54TSBqa3Ldg/K2TrFPVIELB0v9YvZQHjC91UDhQybcUG+D0wSpKnMHDI2ViaGUGxP4uUhQlbv8watPxddoI7t5cnO0goWtBlGPx2aMftGuY2pLs+C64lqrP+FE38RQH9eENjJKC043Nwz2sBIxySVnECGD9VMXCmK3ppqbLLeoy/KPDIuXSmGb5he/bothTzdweG+El6/72urPpj7dhT6CACIwcsORLZbieAXoFny8WvQSRhimBWyIyOBBjPFRKjBoaCLmh8870XyAE4/lrTrgTh8aYHJLyUqvRJ3Ha4KNd3GNLXmw9LxVGLNaPdPJhEl2wQQrSZzFdp+/bHQpmkb1o2UBVpXfFAQMF9twUo4WkCdWF6cPP7Qr5c6/sCo7u55s4fytOXrDgZm1TptXXfqesseZYIPwf6gqet8+yNMsqiZxAHetiqhq2rXLYunuMSUboOPKeQdjQ3UwLXqiJfuhMbrbErtotCJmUqDh6J24IY3F0SmHn87LxlAsueu8Q2Zk7Rf5Mc9K4S0mumjCndFHfd0+ASY1AP5aB18ruobQmZHM7 LvIuy4Y5 VODaQ514/u7P3G0W0CjN1Zlph5/JSXFrZGJylvx6uGOnkB2nOhRJODvDkrnyqWaoxFHL8Zjulx/aeiFcaExZGdtAmVoV8rMu+Hfg76CjjCAeWO1Q6wCWK8N3iAcqhI0GraZ5uXtal3rcT5Y32DLiLxPaK1pPH8DBRRs7E26fqPsc90Zt2N9w2jsi6R31OC1OURpT/SYZzxkEaQMR7gq8lklPWCJ1vUDWxZmMxwDwmWJs8pGjIMRQofOdizBgKMgiUgfoHe17lK8+2DIGRnIayoHgHv515X1vPkd6A6YhoXj9KIZPvnWK4UY82NpkTLzdAK5omXpCj8wp1kya1th91HSI3lBxLMGSUNLgqN3AFPx49DCM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 28, 2025 at 10:33:46PM +0530, Donet Tom wrote: > During node device initialization, `memory blocks` are registered under > each NUMA node. The `memory blocks` to be registered are identified using > the node’s start and end PFNs, which are obtained from the node's pg_data > Hi Donet, > Test Results on My system with 32TB RAM > ======================================= > 1. Boot time with CONFIG_DEFERRED_STRUCT_PAGE_INIT enabled. > > Without this patch > ------------------ > Startup finished in 1min 16.528s (kernel) > > With this patch > --------------- > Startup finished in 17.236s (kernel) - 78% Improvement That is pretty impressive. > +void register_memory_blocks_under_node_early(int nid) > +{ > + struct memblock_region *r; > + unsigned long start_block_id; > + unsigned long end_block_id; > + struct memory_block *mem; > + unsigned long block_id; > + > + for_each_mem_region(r) { > + if (r->nid == nid) { > + start_block_id = phys_to_block_id(r->base); > + end_block_id = phys_to_block_id(r->base + r->size - 1); > + > + for (block_id = start_block_id; block_id <= end_block_id; block_id++) { > + mem = find_memory_block_by_id(block_id); > + if (!mem) > + continue; I would just mention what David already said here, reduce identation, and maybe declare the variables where they are needed. It might be clearer. > + > + do_register_memory_block_under_node(nid, mem, MEMINIT_EARLY); > + put_device(&mem->dev); I will comment on the "context" on patch#2. > +void register_memory_blocks_under_node_early(int nid); static void ... ? -- Oscar Salvador SUSE Labs