From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3875C369DC for ; Wed, 30 Apr 2025 01:30:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A0F86B00EB; Tue, 29 Apr 2025 21:30:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1DA686B00EC; Tue, 29 Apr 2025 21:30:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 02EFE6B00ED; Tue, 29 Apr 2025 21:30:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CE4FC6B00EB for ; Tue, 29 Apr 2025 21:30:08 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9988A16141E for ; Tue, 29 Apr 2025 23:01:28 +0000 (UTC) X-FDA: 83388604656.22.34D1D14 Received: from out-170.mta1.migadu.com (out-170.mta1.migadu.com [95.215.58.170]) by imf14.hostedemail.com (Postfix) with ESMTP id 913AE10000E for ; Tue, 29 Apr 2025 23:01:26 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=EZHjBjQo; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf14.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.170 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745967687; a=rsa-sha256; cv=none; b=XspfNdfa/JJhEmevYfz+iOInw4vNebJkcYyBdV9BXNCF+VvtO6Dd4l2MDoNyS9yMJ3zFpF 3pRyuJAJwUPXtJWEGDpYwdFc/iUhPSryt5tBK4j+FbjHpjxEEP6pWmDZlotQke1whJChWf T8sYlHImzvJfwJp6QheSnMeSoVQvDAw= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=EZHjBjQo; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf14.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.170 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745967687; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6RAb5lr2vH/thJQTV2RC7ZmoJupPHdWHQNQ0zWyXSsI=; b=65Pa8NLBF/66f0pYpPaIJQU06X/1wvdemgedlQc660idAyu2nw3YgsAZRL55mYzgc7Elmu xDaW2NA6S1FN1pCeeCqHncEcLJFHdaFJkauqJOiNsOzcb/E+U+T6KU0JEwBB6Wtpgph48i TVD/1ieNP5b+h6wzKxxKGOjg58x3Ul0= Date: Tue, 29 Apr 2025 23:01:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1745967683; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6RAb5lr2vH/thJQTV2RC7ZmoJupPHdWHQNQ0zWyXSsI=; b=EZHjBjQo6DtxpylzX22842xs2AXvxFH10UOZ8oD2ivBAHSHaanjZGOz327yhlK9AUaPAR2 wW7pKg9uX8wSE+XjqOZsvaSZYTK3m02h1n3uto5/q6+ZDi+AgW2z6IpFyUxnfJ/x/iNoXM rRFajoaRfrY3wAew8aOzVBLBA6G0oHc= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Suren Baghdasaryan Cc: linux-kernel@vger.kernel.org, Andrew Morton , Alexei Starovoitov , Johannes Weiner , Michal Hocko , Shakeel Butt , David Rientjes , Josh Don , Chuyi Zhou , cgroups@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org Subject: Re: [PATCH rfc 00/12] mm: BPF OOM Message-ID: References: <20250428033617.3797686-1-roman.gushchin@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 913AE10000E X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: ep7k554dry5ex3mmkd6qxdiy7trtt5t3 X-HE-Tag: 1745967686-604495 X-HE-Meta: U2FsdGVkX19QZEFfofNw9gH8kkASjkm0f/LnhZWPhMTKaFZ0yZVon1MoGZyhTBja7PehLhA+DrqKML8aUi0qXNfFE+7usOC6HmxGsgD2GORBVaBA+55dq80/RRYCgwS47sQbsxVvXIZD0jk/jMBnXTgP3G9QmTa64NDGhkFzjZwT9IjT93USOYusn7NkKWer5TcYbi5JOxQk61bdj/r8QNAjT5vGNTv9R42gCANZfeBKPHXuQLmqdRblWLX5JnLDQDXgrA8hOiNpiZAbVf97gt7T3YaA3l7/f6Afth0e/QT3r6wejv/6xBgr5/PWLA3ESTHC4dhS9QEIu56hvDqRKkH4T/nhPN4QCADRz6JzjhgbBdMIQudecESIpPfa+iTESmNnqZGWnJ4k67Xp1ki4EL28P07Thi4pXMEI7InZ9wgqjiatAI/UMrgABy0eAvGPpK0FO9+XXgBffhkNgRn63AUQDGWx7kJc0Pg+iIok1QfuGnRNEv5xPeJYLE9W7lzj1el2Y+vd6jUvwL65LmmahFQC9e2LCF5n3UrNes4UgytDKzQAw1mBbOk52FBFZOxGrXfmo8YDX+MQGBF4tUE6fxargmR43h4o+m2rzHPfGTjvdERk8iex8VA4CVKODW9+783Y7iUz73r8gNfGOJ6N6ATKuyuPVMFiM7FO+jQgj1mcAa8dOqTA28oCd6dYe8kVjBjsUtj3/iaeNuqA32RWmM+i+i5hpKPuc4qfGlRZXsvRlsGRfEe3Pjt8IeY0hczGfBaQ2LSUvqW/MQUDR+EVmEZ0CVkSRIwHx9uJxQGEwvuO7959va+Hk27MVS69iDBAAKvyU9hpw6NKdWefOXfi/AaLcwjH7BVROF/Y2hnGMKewB39wRfwFD96aWLGapXLWn/UQ+KirZQzazfKwVMuSNnYT5/6XeeAAMqJzhr72+ZCLxziZ36WccVKr11WiR1T3tx6yPswyirnYed44/Vk pqhfJU/H CTkFU2j3HUQ77coLTldlSVoRHXqb2oPjZFvMfXu7Coahy+gVtUyKxioTnG/82OQW3jrXiXCCkEhCEMdtmAA9Hw+7huN3SIoTNKFM4zs0cZSOVwjkzyG9kiQBkkVjs+oyhnHGdD5a0BFjjvR6KJgD3mvERNJq0DmZiVfnOUQO3FqgDGGAGkdWMBGJ5tjOMqMUDJh3Jy3W1IHMCcrE/XlhIYXrfekxvSt8PHX/4jvyrYWqxKSHOOJLj+5GOEheNyFCTPGejEf3ftb01Gawc7KC7pD2Gmw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 29, 2025 at 03:44:14PM -0700, Suren Baghdasaryan wrote: > On Sun, Apr 27, 2025 at 8:36 PM Roman Gushchin wrote: > > > > This patchset adds an ability to customize the out of memory > > handling using bpf. > > > > It focuses on two parts: > > 1) OOM handling policy, > > 2) PSI-based OOM invocation. > > > > The idea to use bpf for customizing the OOM handling is not new, but > > unlike the previous proposal [1], which augmented the existing task > > ranking-based policy, this one tries to be as generic as possible and > > leverage the full power of the modern bpf. > > > > It provides a generic hook which is called before the existing OOM > > killer code and allows implementing any policy, e.g. picking a victim > > task or memory cgroup or potentially even releasing memory in other > > ways, e.g. deleting tmpfs files (the last one might require some > > additional but relatively simple changes). > > > > The past attempt to implement memory-cgroup aware policy [2] showed > > that there are multiple opinions on what the best policy is. As it's > > highly workload-dependent and specific to a concrete way of organizing > > workloads, the structure of the cgroup tree etc, a customizable > > bpf-based implementation is preferable over a in-kernel implementation > > with a dozen on sysctls. > > > > The second part is related to the fundamental question on when to > > declare the OOM event. It's a trade-off between the risk of > > unnecessary OOM kills and associated work losses and the risk of > > infinite trashing and effective soft lockups. In the last few years > > several PSI-based userspace solutions were developed (e.g. OOMd [3] or > > systemd-OOMd [4]). The common idea was to use userspace daemons to > > implement custom OOM logic as well as rely on PSI monitoring to avoid > > stalls. In this scenario the userspace daemon was supposed to handle > > the majority of OOMs, while the in-kernel OOM killer worked as the > > last resort measure to guarantee that the system would never deadlock > > on the memory. But this approach creates additional infrastructure > > churn: userspace OOM daemon is a separate entity which needs to be > > deployed, updated, monitored. A completely different pipeline needs to > > be built to monitor both types of OOM events and collect associated > > logs. A userspace daemon is more restricted in terms on what data is > > available to it. Implementing a daemon which can work reliably under a > > heavy memory pressure in the system is also tricky. > > I didn't read the whole patchset yet but want to mention couple > features that we should not forget: > - memory reaping. Maybe you already call oom_reap_task_mm() after BPF > oom-handler kills a process or maybe BPF handler is expected to > implement it? > - kill reporting to userspace. I think BPF handler would be expected > to implement it? The patchset implements the bpf_oom_kill_process() helper, which kills the desired process the same way as the kernel oom killer: with the help of the oom reaper, dumping corresponding stats into dmesg and bumping corresponding memcg- and system-level stats. For additional reporting generic bpf<->userspace interaction mechanims can be used, e.g. ringbuffer. Thanks!