From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02010C369DC for ; Tue, 29 Apr 2025 16:36:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0B28C6B000C; Tue, 29 Apr 2025 12:36:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 03D236B000D; Tue, 29 Apr 2025 12:36:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DCFD46B000E; Tue, 29 Apr 2025 12:36:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C099A6B000C for ; Tue, 29 Apr 2025 12:36:39 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C4157BFA5E for ; Tue, 29 Apr 2025 16:36:40 +0000 (UTC) X-FDA: 83387634960.02.9B49BEF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 4D35040009 for ; Tue, 29 Apr 2025 16:36:38 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Stywinjc; spf=pass (imf12.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745944598; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=waEdyNuipqRc2FvA2naLTCSIIiKXgQ9HjpRrzr7KHVs=; b=AhvdZ75K1QvWuu8vl7QRu2xHDq1c3sja9dMqyKWGoF7x+DUXhi6Pcxd5BQPU71gAGQ1VYB SO/GREpWikU5qVx+L2PI2iKEZiDPZ9NgEg5aK+kjhiWHkYXQYUiuwOJjhjtB0pUqHs07PX F/e+4rCDCWxgHTEHQ8I78wi0yfjJEDA= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Stywinjc; spf=pass (imf12.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745944598; a=rsa-sha256; cv=none; b=J1NMzk60WU1beldKVjZ5B8y4Zp9vRgoWtyaNMAtFYURC7hQoNRtN+rpYf4ALbjjLCspv5J 52ha+YA8t3HwKvxie8MX0Vih8YAqyjmXbx71e62alK4NZ5DP6KtmoQbfrP8Ls+Jy+kMcM4 66/vgztJRmhUTO1ee8SIUZT3g2UwFrQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745944597; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=waEdyNuipqRc2FvA2naLTCSIIiKXgQ9HjpRrzr7KHVs=; b=Stywinjc33tKLUZAwNHyd7/dFRyzLSw6NZqYVzibb76DGnR6CEvJH1TSPhIkFo/37BMiSK 1eHqdacXK5o0k3BFRzhS6eSqgVpDaRs1gCpKDCYySQxzUyw8HwgJiYEvihdwMfmWD+L5Zq WOJopZf6DBN87GnXny+8fIT9hUMSdow= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-43-iJDJyOBXO_-DpK19IJqGtw-1; Tue, 29 Apr 2025 12:36:36 -0400 X-MC-Unique: iJDJyOBXO_-DpK19IJqGtw-1 X-Mimecast-MFC-AGG-ID: iJDJyOBXO_-DpK19IJqGtw_1745944596 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6e90b13f5c3so124324616d6.0 for ; Tue, 29 Apr 2025 09:36:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745944596; x=1746549396; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=waEdyNuipqRc2FvA2naLTCSIIiKXgQ9HjpRrzr7KHVs=; b=oDnHWTkixe3K5bFtx/QlbH7Vee4FNWWu3yZ3HoRM2oR9qRLpfeEcFbleCb181fEIRU wLja1AVh7UjN/irCzcGOxnlxGQP6jsH8AbEso9m/kD5XkGzGv6F8pa8nyKo6C3Xapjar B5ofOxdd9o1T7YjJU/3+qP1x+1HXn8/K2xx7VrOhNTocKfZX2Yf+chDhKylvaChbaJIO 2tNsj2hnfRaYY3j1EF+oxfQ5CTEt5LKqFvWm3beHZEJ0znrlJGB0BH69v5LXPmMprxhM 6x9ZZpK58lJH8773ZGiP4AkA2UsrcvMz6iNR7rX4QRFiQQqeEsP19182v/ph6JQwTolB wAfw== X-Forwarded-Encrypted: i=1; AJvYcCXv8ngUmTzYOQ4O5WCF1Nvn4rOuYfWHywQ9KKUMlbBQrGHQlGOBsXEsEa7b2EW9v7N9gXhzweBUEA==@kvack.org X-Gm-Message-State: AOJu0Yzm2HXKz7Ndy8Ojp5dzgxy/qjDYWLoywuiLK3dvHX4tXV3TS0Bb pGVjt9MhbTt35wHfjSUvMAgypFdU2GdD6Y031FT5RRieWzP+DVshe84lQhbj31jrw8jOkGSZhCS W65qxJJ+b8502k/5g4ZfTYQXfp+Lz5ZGlM2wChoLbTDvr67gq X-Gm-Gg: ASbGnctpUplX4bl8byqSTm2IhLubkLY6wjdGZYqHdL+okUNQVi0ZDW7/lDdqYKi1hHf KjdDxAkX+XYC02f0LpmBipdPaBbl8rKJjlFunea75p7vGkALbhmqXZKke5tfyeEvy7h6gCIte0Q LBb7eHALvD+CqOIxWCrSTVeqd+YRUrJKc7kPyMoIuL1vZq8nJeNL9UVWRAhn7jwgpzx1aqJ4TQF uMpUT8dlGhblPOSJRgnvBpot6NbPOdMbAoNCoUvPwyqPrRC0oeWVxpgtUjd6ED9rEBCS4h89MCi lEI= X-Received: by 2002:a05:6214:1c42:b0:6e8:feae:9291 with SMTP id 6a1803df08f44-6f4fcee30d1mr719186d6.24.1745944595665; Tue, 29 Apr 2025 09:36:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGrl8H4/5jtnrguKExXXuFCOERrcXvTboYVKeLXf20R7G+3egGDvxPBeabBwEPjBOiCsfK/vg== X-Received: by 2002:a05:6214:1c42:b0:6e8:feae:9291 with SMTP id 6a1803df08f44-6f4fcee30d1mr718716d6.24.1745944595247; Tue, 29 Apr 2025 09:36:35 -0700 (PDT) Received: from x1.local ([85.131.185.92]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6f4c0934346sm73501926d6.33.2025.04.29.09.36.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Apr 2025 09:36:34 -0700 (PDT) Date: Tue, 29 Apr 2025 12:36:31 -0400 From: Peter Xu To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-trace-kernel@vger.kernel.org, Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Pedro Falcato Subject: Re: [PATCH v1 02/11] mm: convert track_pfn_insert() to pfnmap_sanitize_pgprot() Message-ID: References: <20250425081715.1341199-1-david@redhat.com> <20250425081715.1341199-3-david@redhat.com> <78f88303-6b00-42cf-8977-bf7541fa45a9@redhat.com> <75998f7c-93d2-4b98-bb53-8d858b2c108e@redhat.com> <57f9480c-2f8c-4be8-864c-406fec917eb1@redhat.com> <4a57e772-51f5-4341-a249-dd1b8fcf23b0@redhat.com> MIME-Version: 1.0 In-Reply-To: <4a57e772-51f5-4341-a249-dd1b8fcf23b0@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: sylxy55e8CZxcJ1WWMeuU8mUydBX_jZB886jPc2xLZY_1745944596 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Stat-Signature: c915z7dcewako9arqx71gs78319de9ns X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 4D35040009 X-Rspam-User: X-HE-Tag: 1745944598-119077 X-HE-Meta: U2FsdGVkX1/aVYyacZPcUEdjyiFlf0inLsmQSaU1+SbwG3Va+jyCVw4XbnvVTXfV07uEOU8v+82eHL85TSrAlS7e+1nUevneasXkux8EtU5Yw8xozE3aNjthPlnEbeCLLrUt8HpmeoW4Du27aRCDpMJWoYC+ACn2+hiIOFBXL/7MAV/40b6itPa+z08bCQ/eGfyFHcTOvy5H0uMD9ONZrcxGTF9cDLJswjydQ+3xSITSVl1arKmPhr8SYE57e2/nt+4JFAMpvzm5p4B6TWl3Hjfo+UmqhPJDOPGU7/C8fM5qGhKJHw2CAaRYA0zGQ/3wmwwp5CSCrJsD8yl8j3hMORHk41Hz1wsMCqjXrtAan6GcJ68VEHR8c7S1f5dkz6n2P+gRvEavloUJkuutGyDUZPgl8V8OgNUrMxahNe9FFXJsnuGok7Cs/H2iItw2bYWkb0FCOfD9sjnszPh50RQrXi+bWjI9kFVakzrOmtUhjFOwlQsy+4j5VwGg1o9EC7zWmuOz5Ypzi69FXEfjkTlJxYdF2IE+uavwIyEJ2TJj6WB6LZrOJ3VtrTorKVq9+V4miKTviy7Cisbzt9D0G6l9Xb+2AgUotGvYwxkUt8pCzwVf7YHRi8T8AFslapVQyjtYrm+mHJbGQ71gyqGWtK6OSG/eaoR6FF/u5SXGWisXrOfalHCRz9qthSDxGXpY6UIEsoQVGOpi1OvE9/ZdJuHuPvPecOQTgAlcWLGyHtoE2kbV5jozplZI2DfHU750A/HdbyVeohpIjl/g41blzzD+XFwXoxlBwhHm33ga9+VRljvsvvkbJAqRCJ8kWH2YZCnXavMML9GGGjqg2XRPzGoCAkbKJx2n9NkeD6QHtjXnP2w7v4kjMJB8ceogHOLs0n2yGDR31i4b5O2AS+RybghvMgjfFGnaNIeyR/D6e0iem8qf00XxK3cv1MZR/g9NAhD90rbA0RYwwZMXPIv22V/ uK8vZksE SzBoqzHQ1Py84Ha3v9mDiDCqNKN036EJSIbJ/23zOcVymLa7N/ENC4OtDsfEnvCQSl68QBxtx19G0TixeCqhMqWEBn/ZtkF0MyQc9PzMoIX5RBgbA18o0VT6xBROtz9fEu94jTuqBjWoJxwBjPHIMmM2FnqdUNOCtkXeCSt9GaJPSfbzPznBJYgjK2bC/w3X7F3+Ijw8ZqhjTX7RyKfj7spd2NNd8ND8XqiiFmrYBYNPHOvgLiyYfIfkqobQCzPJ5aFpnd+LB6XYlxkvY/yh0RfVj1fnjrVJJI6IBgUpLRgi9AAIpUFIEE/3Y0LbT676goHeGLP25s6V8HZzM7LuFD7UVTiLsw2a1UlkfKSh0teEOfU2UxDCh0BEnGVWTaRAtoTSNNxPtsJliFGOvSteCenrZzI31mjT/eOUu X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 29, 2025 at 06:25:06PM +0200, David Hildenbrand wrote: > I do wonder why we even have to lookup the memtype again if the caller > apparently reserved it (which implied checking it). All a bit weird. Maybe it's because the memtype info isn't always visible to the upper layers, e.g. default pci_iomap() for MMIOs doesn't need to specify anything on cache mode. There's some pci_iomap_wc() variance, but still looks like only the internal has full control.. -- Peter Xu