From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2527EC3ABA5 for ; Tue, 29 Apr 2025 16:03:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA4F46B0005; Tue, 29 Apr 2025 12:03:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B79746B0007; Tue, 29 Apr 2025 12:03:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A41EC6B0008; Tue, 29 Apr 2025 12:03:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 88EF16B0005 for ; Tue, 29 Apr 2025 12:03:29 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C8E6A14093A for ; Tue, 29 Apr 2025 16:03:30 +0000 (UTC) X-FDA: 83387551380.22.D2694F5 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf19.hostedemail.com (Postfix) with ESMTP id F11D41A000E for ; Tue, 29 Apr 2025 16:03:28 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf19.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745942609; a=rsa-sha256; cv=none; b=B2wtdztMqqbWCRv4+pXL0cZSE25+7Eo5OIJByVczny4o2yc80gIxf1h/PoHfFmdhyF9hN/ fxKNEscGt2vs9vbvvnAA0Bc3P6XmzrgPV/IH3hNEYB8zORe3+gTuX7zcqZTulNAM9pLXwS KEjPSwXE4fHLujlScHNAU+kSvo9gD2Y= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf19.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745942609; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GHRYpbWevujZndWiZAgPr4mqU75yzqoBsmkBTAYGsLY=; b=RThTU6se9WdzjJDtkxK+zSrf9sqT/qS0Ap2gg5NOynZiZG3Xz90/1X4GJFGNkQlbFUQPcn EWCVzBTtnjANp8gBknmKGJm4dCFcMlFOP81qVLcU4TALcXAHWU84F4cg6WQIYdozGR/Emh c6tbsCPg1pXZyY9eGjRafe0lLTtrt8U= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D0CD25C3D3B; Tue, 29 Apr 2025 16:01:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0850DC4CEE3; Tue, 29 Apr 2025 16:03:20 +0000 (UTC) Date: Tue, 29 Apr 2025 17:03:18 +0100 From: Catalin Marinas To: Jason Gunthorpe Cc: Ankit Agrawal , Oliver Upton , Sean Christopherson , Marc Zyngier , "joey.gouly@arm.com" , "suzuki.poulose@arm.com" , "yuzenghui@huawei.com" , "will@kernel.org" , "ryan.roberts@arm.com" , "shahuang@redhat.com" , "lpieralisi@kernel.org" , "david@redhat.com" , Aniket Agashe , Neo Jia , Kirti Wankhede , "Tarun Gupta (SW-GPU)" , Vikram Sethi , Andy Currid , Alistair Popple , John Hubbard , Dan Williams , Zhi Wang , Matt Ochs , Uday Dhoke , Dheeraj Nigam , Krishnakant Jaju , "alex.williamson@redhat.com" , "sebastianene@google.com" , "coltonlewis@google.com" , "kevin.tian@intel.com" , "yi.l.liu@intel.com" , "ardb@kernel.org" , "akpm@linux-foundation.org" , "gshan@redhat.com" , "linux-mm@kvack.org" , "ddutile@redhat.com" , "tabba@google.com" , "qperret@google.com" , "kvmarm@lists.linux.dev" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v3 1/1] KVM: arm64: Allow cacheable stage 2 mapping using VMA flags Message-ID: References: <20250422170324.GB1645809@nvidia.com> <20250422233556.GB1648741@nvidia.com> <20250423120243.GD1648741@nvidia.com> <20250423130323.GE1648741@nvidia.com> <20250429141437.GC2260709@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250429141437.GC2260709@nvidia.com> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: F11D41A000E X-Stat-Signature: c7ymq4uz4drtge8dnknkqe88jpwx5o6z X-HE-Tag: 1745942608-117532 X-HE-Meta: U2FsdGVkX19VnRADV9v/B0GsFComZOxj5ftRrvn04LqIcAKkYIHze4ZoXOTHXeecqZ+x01cQYFAWpSZPqW0oGf7j3YAy97AAIFLcg3Hmd+q8lB0QbfxsmIgedS+zUkaR0iyNs+dmqiMrJ0xwN6mwqiD97D8Rbqg8RsuwgaBfjakGsv5Exb8tFsGiWo2+AIMJ1BGCC6XcUYcb8ti+vD+ZNzIKAYauCnc2eAczNLpw2Y0IKM71mpX0qxWZIdbDhcCu4acnMFkB0trZNteK8BJpWKmdQrRqdQGRCmBV675V/M4waWXnfSsGMTPuxHYYbyfQeBzDH5/dFc3SYm58CRYzBWtVq+TW2hMBjc1VQDeQzhhIYudeQ5pc1Y1DK5iV2EkZMp3AAKvZamrT5N0O9rxPui77g8l1UBQDYwFyYFIZbbcE2ayxG3EZmflaMjn454DScWB8kym1fBg1AW0TPM6vccgoknOAY2Myl7s+PC8ualiH7dYS8gXXYG93eOM71ch8fL1vmWfJCkHg3VDv3msDljzEH4Bu52LdbUVYIQUuQ4eiDqoePXLjFv9LMJwpkPhn0lwk1Ox1DErpBGQ3JKGcPPB0N+351jqC7HhquOUVGQPLORkyvWUXDQKCC5tLilsw4+PY90YvvJoJVNfpyHd8BV/urnLKfSbiB4D1AjmJijhLV43jTN9593avaEY8YH88hbb0nudb6Aail/lv6Z3/CfADnhN7kHIb8t1PjxGsxf3R2u7VoChwHacwcDe9xTcHhYodGkKwubcXOiMssqFCF0NG6c9zxd9t3dwGtk6OwKhrkIPpstRutdV6os4fkLrOO27X3ro9a5SAFvlT6M1lKWDwO9TzXrACIUH8dmJZVrCci7tdbmgpCEZuZpZwGVYecfDxZd4ihAJ3omUHf0VGHsHQImBicLj8v2Cqz/djYrqVYHdaP3BVCEGYEjh/wktUWwzoux3KecFjnutphrU VUbvGwwR xsP0fbAfZWcdpG/YNwdDtl/fX4XDSygSoE9OJvroxIuisVR3PeH+HZYT3x/Jg2alv9rs5RrdD+Y3kowqRmNksfpT7P6I+FC7L6X35opsIuTczjI1nzV53OsdnsmdQ4F5PP1SPxYYMSo9dxHwxWQUfQDMNkdQyoXQ+1aWe6/NMOrpooy16qnmBK7xxoeBBhoAoULC3CMNi1Psmk+YUUPhMeJk0b9/q/vcGf0MmIRTZCQtST1EwgJp+UIpyg+AGwZCeJpj5iqofEKL7eHMhKzXh7xS7g/NagaxfUwoHGBh6Dj/kuCm/gVi1VYZsCi25sBp2cQ+mINUGkDv8XC4GpYcInFx7M5hCltWWBy2xTmRAoBn0cRpql47PkdxYZcIqWQr6Vq0aJ8M2zJZkXTI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 29, 2025 at 11:14:37AM -0300, Jason Gunthorpe wrote: > On Tue, Apr 29, 2025 at 02:27:02PM +0100, Catalin Marinas wrote: > > BTW, we should reject exec mappings as well (they probably fail for S1 > > VFIO since set_pte_at() will try to do cache maintenance). > > To be clear the S2 should leave the mapping as execute allowed > though. Only the VM knows how it will use this memory and VM's do > actually execute out of the cachable PFNMAP VMA today. The VM will set > any execute deny/allow on its S1 table according to how it uses the > memory. If S2 is executable, wouldn't KVM try to invalidate the I-cache and it won't have an alias to do this? Unless it doesn't end up in stage2_map_walker_try_leaf() or the walk has been flagged as skipping the CMO. -- Catalin