From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14933C369CB for ; Tue, 29 Apr 2025 06:33:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 879AF6B000D; Tue, 29 Apr 2025 02:33:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 826716B000E; Tue, 29 Apr 2025 02:33:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C9C36B0011; Tue, 29 Apr 2025 02:33:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 492F86B000D for ; Tue, 29 Apr 2025 02:33:10 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E87A9C0FF7 for ; Tue, 29 Apr 2025 06:33:10 +0000 (UTC) X-FDA: 83386114140.05.1547C7C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf17.hostedemail.com (Postfix) with ESMTP id 5262240009 for ; Tue, 29 Apr 2025 06:33:09 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=sRA0wOvZ; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745908389; a=rsa-sha256; cv=none; b=0Vv/XG6yrgur2RMWbHRxyutfKyoVYYa0uuGtZGqNXDqLkcTh7BTEEfI1lHoZDD+xZWCdIk NSM2tl5wbZQJD06+UlZE4WPRhTITSu6jFRLO5bo/WwnKzYq9RdHaCqiwS1GczNz4aQSUBn QJLty6rgWY4qx8WJnx0qdfLetmkF+RY= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=sRA0wOvZ; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745908389; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aL7C6JZowizBLCWSbDB2UwP7mQchKTJDGLLEBGnYyHg=; b=gzKEc2/VR9q1yXVgA75+d+ktt8XDDG+3zlfznOSDZNi4Bu+0C8MFGHFolRRHugo8NUMrzG cjelDnEJAoM89MDOOmgJZJELfj+uEnZ9Ncfl2PVVGBmaQ4+UAGZUOOc1vBKAfrga2hAe5k p2Mw6z3oNO8aVlg7m0i5ltiV/BqW74Y= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D681A5C491C; Tue, 29 Apr 2025 06:30:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 395A7C4CEE3; Tue, 29 Apr 2025 06:33:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745908387; bh=o3uMeMDU8vBwj4IGsCzOkLDIARytjMi8U3yEpW7YFRI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sRA0wOvZthOvgBl+IMbHFcuIZWXvS/2tQg4zmj3FPa2bkpZI0pKCM/nGdINpAdWQB dYsVOwtHHSQ2e7ISoBy9DoNcqMqyXPhsHn/1gDIJhWoYH/5zXMSC9ucUvZuHqL7K2S LXT/Q5Kzax+KWY3728JuebCVbduZqHqVaer73EjA7Cm1Z+asQauZKTqQ9qMcrktGhK 5N4QWWjNJJW+Sp6PU6HqRTX/JefhWz0/l9qX41mM3zzqHHm678efcZwtuXpXFdytoW tlmCAE5eASxF/NviiqNSXh4Az/70rjrWYknWeKW9mPYlpkH9H+vWrD09gxLnSDQWg1 pWZ4Gs5DI/FoA== Date: Tue, 29 Apr 2025 09:33:00 +0300 From: Mike Rapoport To: Ye Liu Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, david@redhat.com, harry.yoo@oracle.com, riel@surriel.com, vbabka@suse.cz, liuye@kylinos.cn Subject: Re: [PATCH 1/3] mm/io-mapping: precompute remap protection flags for clarity Message-ID: References: <20250427100442.958352-1-ye.liu@linux.dev> <20250427100442.958352-2-ye.liu@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250427100442.958352-2-ye.liu@linux.dev> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 5262240009 X-Stat-Signature: 9dszkx5t7e1ktpgta5r6bfndascox4g5 X-Rspam-User: X-HE-Tag: 1745908389-728147 X-HE-Meta: U2FsdGVkX1/Dm7Tmoyt+ggkTv/65G8ZABVsnONia6ORVWuhVI8UPFronlax36w9zC9W2qZtICbOe2x7w3uBnK7UnG3m7CAeZG4iZZfnMy3g/Gh/mh/oQ1cB+jKj6JM9XMWLKZ3Mkb+2tocx77Dy/IZUvBhO/3UG0xOsC8YwNXEgx3YPTkVFH1uDpoJ4GUCHMrI8EVADvlCuJN0yzqZizlNYJ/KGzRUbKe+omZH1L30PIJtpCGSWHWjS10yP3m1FZfqZwd39ciCXOZgqDbiWc+gPbMZPSUI0xzlZ9gP4eIbcBi3pQpCZov7Wh1sPLUY+g9akkm1Ta/RRub54yKW8YRuhmM9kSc2dGHPl4wJSYD1NJtycmRu/XWBDP1HMAcFYLY+9l+uIL8ERV4h13WrxtZwzslykjhBegvaWO7eaFUpjZbXT7pgnN/6if3LawTv+q2rexgTOez0ekoVPDnezNwARP0Cq9O2KN8paWCg3WUqn3kgxVKpO7Wtlhs7LZSYoA1t62gvxjvshdRvluv1YraDzpHxb0ho1SX1swmQ8AejxvjEo32cyb6f2nkit03rejffbR51c18wi7aXkt/qAlkIV91Dp4epWA8gx3m2WzsJLqmDugiFClN4SmNCQhAO58+THxEQnEUUWTQwOVHIkhnuDqPCIEC7RI3TgntscV+wBh1y6ai+mA65pHauaBGiH8IqnmLEijArpwgcfB8dTbAlsU05qS+mCM9wPBiYczC8ieKU26nfqE6R9xfPo9Z04/VJJNW+Ih5FRb8r/ZqZoMy75We0denv+eBJTfAzEwQiADEbeBdh8KwLDPPqo4qcDXOWZhF2XMy/SHrtEerwhsvDL8Y8Tkh9lH2CgdLOtwjcjnKj0TAxKGm7lOJN0WmlK7VfWMb4dgaeNXa5+H3yLVDe/Y7GT2Kx30ljuIG+uIYe9D5qmqvfcNXgRI8EghFzodwFh4XNqmD/4eTnACNGo O9cJaCbQ /cbbwu0xecmEI66sUK5lpqQfdsAYutyMCV8l/i0/9OfvoxMeA7jXXECqD/uSVgD6uEFOv5JlpFAwaVYTiBTru5y0oEdTY1zlszh/QGoXHCwKK1rF2Tgp5OEhP3W6YbVhKIFYQtx5JDsDNNXbikK9G4XDtIzm4pY7D5COCfNyVttAVkV8CQ0vYJw4PO+IBiuIKNn1lCZbxcMfYnh/EGVBcsMFaCPENfz43731TGs+wUB4ZxnIx03sqwex6qH8pPHCAw0bp48z65ld2CiCzgCFJzPcAXg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Apr 27, 2025 at 06:04:40PM +0800, Ye Liu wrote: > From: Ye Liu > > In io_mapping_map_user(), precompute the page protection flags in a local > variable before calling remap_pfn_range_notrack(). > > No functional change. > > Signed-off-by: Ye Liu Reviewed-by: Mike Rapoport (Microsoft) > --- > mm/io-mapping.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/mm/io-mapping.c b/mm/io-mapping.c > index 01b362799930..f44a6a134712 100644 > --- a/mm/io-mapping.c > +++ b/mm/io-mapping.c > @@ -21,9 +21,10 @@ int io_mapping_map_user(struct io_mapping *iomap, struct vm_area_struct *vma, > if (WARN_ON_ONCE((vma->vm_flags & expected_flags) != expected_flags)) > return -EINVAL; > > + pgprot_t remap_prot = __pgprot((pgprot_val(iomap->prot) & _PAGE_CACHE_MASK) | > + (pgprot_val(vma->vm_page_prot) & ~_PAGE_CACHE_MASK)); > + > /* We rely on prevalidation of the io-mapping to skip track_pfn(). */ > - return remap_pfn_range_notrack(vma, addr, pfn, size, > - __pgprot((pgprot_val(iomap->prot) & _PAGE_CACHE_MASK) | > - (pgprot_val(vma->vm_page_prot) & ~_PAGE_CACHE_MASK))); > + return remap_pfn_range_notrack(vma, addr, pfn, size, remap_prot); > } > EXPORT_SYMBOL_GPL(io_mapping_map_user); > -- > 2.25.1 > -- Sincerely yours, Mike.