From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31302C369CB for ; Tue, 29 Apr 2025 06:32:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C62C06B000A; Tue, 29 Apr 2025 02:32:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C12C16B000C; Tue, 29 Apr 2025 02:32:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD97B6B000D; Tue, 29 Apr 2025 02:32:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8F6B36B000A for ; Tue, 29 Apr 2025 02:32:34 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E646CC0FDC for ; Tue, 29 Apr 2025 06:32:34 +0000 (UTC) X-FDA: 83386112628.24.E0740A5 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf08.hostedemail.com (Postfix) with ESMTP id 58069160006 for ; Tue, 29 Apr 2025 06:32:33 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=cAC1GI1E; spf=pass (imf08.hostedemail.com: domain of rppt@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745908353; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZxP10w2ysgVy5Cb/h3MelY5QDlYK+TD76feOnw8gcrY=; b=PKY976CqGdGakJycXJl8wlsJpBUN7sPgxf3otrdcrtqIwDx6Wn9QX4T5Ugbb1Cj5Bjf0oa NRJDCGC0iqpcwUI81Rlc6J37kPN6IpS4QAIAqGsC8PY00zorj2mYb/jAZDvcIEBpJZH03Q gcbJlwUTJ7z2b8KvyJ6ZEXkfKZuVR4o= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=cAC1GI1E; spf=pass (imf08.hostedemail.com: domain of rppt@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745908353; a=rsa-sha256; cv=none; b=4vaU/iCikv/mECVCwup6HnMnu4Yf4d0LJLnHwSJXQPkMTxD8ET3GSYgy7yT7xcT97BH7jH DxwS/kF37nR2LuXrxg4uSLn7Wb36zjLgc+yTJ8uC3J5P0212Pr+pxJvf8xb/MO3BD4q+yJ iFfm/zsDOC+NKns95EJAxI9PG98nK0s= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 3356161360; Tue, 29 Apr 2025 06:32:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D5D1C4CEE3; Tue, 29 Apr 2025 06:32:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745908352; bh=Vkza2O6+dGm8gXRPylVtJ0daXTiMNkYHqq4Fd861PQM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cAC1GI1EUbJ0bj0WQFTmDYTXyhM2mYU4X0xXAt/1c4Yb/6dZgS4DZ1dZE/unvU0y0 YsVZOMT78CTtPglJ3VbHzoxxrAHhfPEONSrncMGnYGaJ7D1q6vTtS41sW0friv/YaC pKVc7BZLoEdASOk1EYXDcPJ8a4SXJnfgCWkxLDtQVOsvOkkM6DMwr4eeJmcsLkIbla tFOLp6MI1dGEarQ1UWVNGxSmS5j9DiPQvF3Z2B5bMAvaBeAlX/ratPYBlYOSboESNh 8s8jG8Vbb4xJit4EeuJc9swz1jYl0iO1FE0o8571X5590mWSM2BjcIDKTyzOWA65u6 bDZ0bkdq2TV9w== Date: Tue, 29 Apr 2025 09:32:25 +0300 From: Mike Rapoport To: Ye Liu Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, david@redhat.com, harry.yoo@oracle.com, riel@surriel.com, vbabka@suse.cz, liuye@kylinos.cn Subject: Re: [PATCH 3/3] mm/numa: remove unnecessary local variable in alloc_node_data() Message-ID: References: <20250427100442.958352-1-ye.liu@linux.dev> <20250427100442.958352-4-ye.liu@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250427100442.958352-4-ye.liu@linux.dev> X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 58069160006 X-Stat-Signature: 6gqhzxep5tufkf4tes69bn1884nx5wd9 X-HE-Tag: 1745908353-942330 X-HE-Meta: U2FsdGVkX19KTES+/9qA1ler8xAxumlxTXN0A+FXwYP8Jvcpqhcm7DL1O12Lx4fYulhjkzbx1oNs38M5ZYwl/wHWPVTShnFtcQOqoEJv+Nl7/6htXzPumEejnswcWtZ9pRLsFPWWhLOeoQ9s7bBQIFtGkm8vI+FRMRFPLhsUwkQG8BVxiHBQTpWLs1YOiPDUnUaASVbqfqL3d0y4Q/zv9zmlCkbjaqhyyUVxkTcYcYPFbyPIqRV/qglgdE0XJdfB8Hq0MD700wswpqDbqfPmCwLzi9TgzK82fmvXkWwI/3//K3CVY+2Zvc7H5lKZvRq7TNWNTU9RWPbpe9DJjoug0jB78W5BZXLkAvxeNJ9JCCoQoqNYhO6HE7Ji8WkEgSZJJKMstu4hyqPmqmNoV/jYSzqskgQ1Sn4JQ6efq0+vwn/xLGjLUHR3SJzowYpexlHl+LOkpHjZ2isMv8cT9S3IhG0GJgehbmQTe5/cDerX3/P0+EtzHfv8GIorgrY6jELBgXDY4CulQs8We4WZYNoTcUyFLVGj6dlubcXa5V9Ll4t0OD0lqMbiSykLgSTTOvvy8qsncEzHy3GVBOQh+QkyEBBJ9GxxT24QQEM/LLE2yRAepW+e2f+W9Q8ydkuRRQUrkEulQJ1v0hcAnPiGV3omt3TNwN7NLk/1QBb381SQysGQ7ebyRH+ZzI1PooHY3jHYb0ejmPIQuJ+EbJhmf3td+EJQRs96J0Muk02n16v3C1Ru2Fo08p7ViJtgA79zWsOoYe/9EDfStPC3sudk8iMI/BJNOorPwAZHuifObdYc2bxA4uXuhwAC3s7vQaIuV0t1PufRGwNXxmDPZxpO4hxy+NuEeLje/FiHFcGuwyPSfEpKK4RxHs6eVJw3wbNqpnjkvTkRyuQFp0fnqto60uEofuJ5bbmmhC8Edwrd8BEhD7Gpl1DEUVHoP3JtB4eogn9OR9o9SiwbTAz3RCHGBZM I4vhs6G7 ZecnQbdtMPBfNrRHDwKk+xh3IpwHf2ogfG6Cp8eHl9C1WCB84hG5/MtMOSc6EniAWmEKsCCD8dt41j4Cm/y6LBgrLxEmtZ5bdfNc4HbLvqH3iR/br4qIJt7iSZ/vbeOo45Ib0ZTrZ1FpQU1HRTzZV6upBQXuwn0RfRM8ngCPcsJ0fyeZB+dNcg74M1ITiDCQJrJrcfFlajQrixRGMNrttp/Ts9FcZFW3XiM0NpAx6DUcWXEXrD4BquXa5sgqx+BBaViYuVYyEPfHnoSvY5vNYSh0YBUGs8ajtG2geXYJ0GHSP/IGBekaLUgYLOCwZAATRLsMM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Apr 27, 2025 at 06:04:42PM +0800, Ye Liu wrote: > From: Ye Liu > > The temporary local variable 'nd' is redundant. Directly assign the > virtual address to node_data[nid] to simplify the code. > > No functional change. > > Signed-off-by: Ye Liu Reviewed-by: Mike Rapoport (Microsoft) > --- > mm/numa.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/mm/numa.c b/mm/numa.c > index f1787d7713a6..7d5e06fe5bd4 100644 > --- a/mm/numa.c > +++ b/mm/numa.c > @@ -13,7 +13,6 @@ void __init alloc_node_data(int nid) > { > const size_t nd_size = roundup(sizeof(pg_data_t), SMP_CACHE_BYTES); > u64 nd_pa; > - void *nd; > int tnid; > > /* Allocate node data. Try node-local memory and then any node. */ > @@ -21,7 +20,6 @@ void __init alloc_node_data(int nid) > if (!nd_pa) > panic("Cannot allocate %zu bytes for node %d data\n", > nd_size, nid); > - nd = __va(nd_pa); > > /* report and initialize */ > pr_info("NODE_DATA(%d) allocated [mem %#010Lx-%#010Lx]\n", nid, > @@ -30,7 +28,7 @@ void __init alloc_node_data(int nid) > if (tnid != nid) > pr_info(" NODE_DATA(%d) on node %d\n", nid, tnid); > > - node_data[nid] = nd; > + node_data[nid] = __va(nd_pa); > memset(NODE_DATA(nid), 0, sizeof(pg_data_t)); > } > > -- > 2.25.1 > -- Sincerely yours, Mike.