From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1162BC369CB for ; Tue, 29 Apr 2025 05:10:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2F7F76B0008; Tue, 29 Apr 2025 01:10:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2A5746B000A; Tue, 29 Apr 2025 01:10:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 120616B000C; Tue, 29 Apr 2025 01:10:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E46B46B0008 for ; Tue, 29 Apr 2025 01:10:48 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3574B14081D for ; Tue, 29 Apr 2025 05:10:49 +0000 (UTC) X-FDA: 83385906618.13.B163722 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf07.hostedemail.com (Postfix) with ESMTP id 34F404000C for ; Tue, 29 Apr 2025 05:10:47 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=gBcMZfNR; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of bagasdotme@gmail.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=bagasdotme@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745903447; a=rsa-sha256; cv=none; b=wncayzbNiuS6A1ISCqEEmh2+XnijE1ppwCSTkfUgtI7K+VpsF5DJswfwLUqeGm8c2wqnkI ljs+2cxi3sSIFNDU2lP7gOYBJtE7AnfgSwWoGJ7MtEc8Ov98WGCukfsCKPQxZZZiRJeci8 8mrWFN3FNDqRSI0sJzv4gmh7Ub2u8Vg= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=gBcMZfNR; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of bagasdotme@gmail.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=bagasdotme@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745903447; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zX3Pd6vkQQ/3XX+ppdLcQfDQhkoHTDjgJ2yW/+pucr0=; b=EhI6BRGQnRbS60RxZQN923HZbJ8a3xvY0jWZmiNauw1M+3cMbZEemYQ2FiBe4YJeXNChWU 6GdsfK58WeOcLxkzjxUJogcnwdzfr0w7KNi60gwgjxG+290wPXK1rxR3bcXA3YsOuEwwZS WaNBU8jeDshanXgA1h9mSYhik6SmLpk= Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-22423adf751so55816835ad.2 for ; Mon, 28 Apr 2025 22:10:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745903446; x=1746508246; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=zX3Pd6vkQQ/3XX+ppdLcQfDQhkoHTDjgJ2yW/+pucr0=; b=gBcMZfNRpClviy8edGY3n+4ApU2corPx+l759zBFtxKWv+aJwwWZKNvUje9JRn8tNd h3TsDloaXMK4tE2wDwd+Y/6+vQ2Lla8/mQQLOKPluvDXViEcNVE7pEjbGdb95aOCIqp4 ++SZCu7yK+PBa4zatu4n0/N4/ytxrSvyMOYks2AzANxEd1GYprDRA1ujLx1IGnttIkSF 2tNCbieN+rDW/NeRD9fEi0pKOZq10LlC8k4xIVUWTiKPyjULmfVUL+9LB39ABTG4qQm6 FMiY9ZwTjpZbIwuGJQK7aT3c3TNWmLDS7Ig7JbEVo7DuIQ4mZHMy3/nZSbYkMSCZ9kYt l1SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745903446; x=1746508246; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zX3Pd6vkQQ/3XX+ppdLcQfDQhkoHTDjgJ2yW/+pucr0=; b=O8zl3T4FQ+/iLCHpSP1fphi+/e5B3Hmp2m+6iCBqKvT1wE6hjMoem5S4QZAwQpbOAe 6PGwuTDZ3zu9gq5e8syeJTTKJE6xTQsoijlYorD1CszQlgX2s0KONJ6Uqz80FPv4UTBH M9M7/J8XixpXJyUVZEzEwU6eIQYcWeDWrJQYe32WozFuADoic5YD5AEKLV9XxChi6RJ2 Q8XA3iG2VuttjyWBlAidqybrimNDkw81wIyWV1t+wta8ZWwQbRYphaBb3zCD/EVg6DX+ 6/UxvcdU+2qMgonQNdh6CWNI5Q4itqATMXIK1SNuNri7jq1MvO47YsAHREtvypukZskH vImQ== X-Forwarded-Encrypted: i=1; AJvYcCVV1xWcMN2BnewNe3zx2QYNNq6y6JCrs78Ill5ZLaKwA0uasWT1y6YhBtCu2E3pRe7GkXjeNQrDGQ==@kvack.org X-Gm-Message-State: AOJu0Yw4xrI+/+vnxJBHg7qtVxOUnTE7cMsBFAVQs1y/N1g7OHbw89L+ Mbe5Kb2ubHWlI/rkp7NrqYd3brNdiSRU8AxtYY/NQnzt0RAcjPvc X-Gm-Gg: ASbGncvmAGJn6xsna3BlgATXCssGLhK32r0H7WoxOqmoProKash5xB1/o5M/PZFtXby Awl9JfL3bN9sVjrHM/+cjy1opCuAKdeYEjBhdZADDsdFwHd+T/fIGM0eOFZBGaf/TTyulVYzDx+ KKvqk7CyDYSDC+qA/qaXI7ar09e5FRE0AC3AkQJM/Cr5f5DckZ4PEJO0IjNEZAbx7JQTJF8C8ba qxuN8hWX+HCzOq2vEo4/K8DAED54KpIK/oVxijExjj06i4KHkYq3SulTcLBQwpz6UuJy0MluHhT U7SSeBYAszF3ZpsSW34EG2jvznUXbTgCM17SrN+M X-Google-Smtp-Source: AGHT+IFkA7SJBp9SgRZ6+ivRwUkAsuFLNkKqWS5lYr05a34CF2VlAv/KjTjzxI9PfiK0PctIfZICsA== X-Received: by 2002:a17:902:ecc5:b0:221:331:1d46 with SMTP id d9443c01a7336-22de6e939e2mr24815235ad.2.1745903445803; Mon, 28 Apr 2025 22:10:45 -0700 (PDT) Received: from archie.me ([103.124.138.155]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22db4dbb204sm92921295ad.57.2025.04.28.22.10.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Apr 2025 22:10:45 -0700 (PDT) Received: by archie.me (Postfix, from userid 1000) id 28FB74050AE5; Tue, 29 Apr 2025 12:10:43 +0700 (WIB) Date: Tue, 29 Apr 2025 12:10:43 +0700 From: Bagas Sanjaya To: Nico Pache , linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Cc: akpm@linux-foundation.org, corbet@lwn.net, rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, david@redhat.com, baohua@kernel.org, baolin.wang@linux.alibaba.com, ryan.roberts@arm.com, willy@infradead.org, peterx@redhat.com, ziy@nvidia.com, wangkefeng.wang@huawei.com, usamaarif642@gmail.com, sunnanyong@huawei.com, vishal.moola@gmail.com, thomas.hellstrom@linux.intel.com, yang@os.amperecomputing.com, kirill.shutemov@linux.intel.com, aarcange@redhat.com, raquini@redhat.com, dev.jain@arm.com, anshuman.khandual@arm.com, catalin.marinas@arm.com, tiwai@suse.de, will@kernel.org, dave.hansen@linux.intel.com, jack@suse.cz, cl@gentwo.org, jglisse@google.com, surenb@google.com, zokeefe@google.com, hannes@cmpxchg.org, rientjes@google.com, mhocko@suse.com, rdunlap@infradead.org, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com Subject: Re: [PATCH v5 12/12] Documentation: mm: update the admin guide for mTHP collapse Message-ID: References: <20250428181218.85925-1-npache@redhat.com> <20250428181218.85925-13-npache@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20250428181218.85925-13-npache@redhat.com> X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 34F404000C X-Stat-Signature: dkptcbje4um3j3g7eu64gnfpk751f75k X-Rspam-User: X-HE-Tag: 1745903447-48369 X-HE-Meta: U2FsdGVkX1+eJjdBqTDE3fwd0HLsMSXvNVeMPyyWVHShdJN9rKtDpK/jIN4CZBX1+dXLI6ShIrNLntQh3JAVlowsoWqBmsIXSNV59trJgoEccWqPoD2woscdPQgB2n8epg26cXN11BNi+62sA4CE431gCEoeaunnKbzD8ZYWvOg44ckkV1z3LOYTbCCMxObJLSlGYvCe9bgHjctSZkMAPyml4CqWHf/PweLqfX5fxMM56/ayqlCCJv+bdxOovctsTmols6i9wKyqwHzx5D7fTOqAsxteItui5qRIXpcKb/qZC7Ajod63ueODmYaJ6CMRChfZf1i3ch/kAdXDdbTiVyB3TndGhB2T2HQ3AZiogKdcr8cPBEoA2MUYsgUsQnHSYmV2EAsezmCYIHWX4D9B4xkvcOOTNyx4U+x7hgrtenloXj1yPn2wEZNMcaC48MRxA8ZuMd9VYc1C6DSYsMw2/tVI1t5aZW0bRjnVFWAbrvJXZdSbkn1DOtSQnwSqzz9+D9LT1vpJCoqkBCBc2zAyiRbguhNmng4JBRI3w+5nKTvb2WxDidFA/kEfUau6PHoL/2WbpOem6NGS50h1ohVFy20MkwDWIlmJR7wiNTiPKYgBD6MYB8VKhe9oKpm0x4V6gbe/KqyLQk6wLM7G40Ns/BPQq36LZC/rkYwstJN7C6rYvC6qCGaKdl8PSaroAkPHd9J3MbipuiAEJCjrijaQ5qUN4vmoGqnqzhsXGNPXIgMYE0fF0TZ9/oo0hW7NU8D6rEhDd7aeOSoN+qA7a8tQq6f1zxrGRTWM1EK3zBSW/QvlxdKkn5zYCGLtrFxYeUm+kzNdA5xsm1ZaKF8WD5vnJIdzR/vziRBK2zkLockBaBjaRebc4XFJemHmdunRLOwBOpbJP0ynQ5xcPiXwFtAMwawp8fNr0yc8H0XIuMkW/UuIufFL4qM8Vrnh/1omrbiqIXWHqsHcQ0ZMU1zs2fT G1dsbAci VrUezjwznG6doCs+/av6aG36TNNPhqPTYusmOKmn3RvMWugHe40kVBtBXLeIo42R4Y2aD5X9RkIQnDMOz2s/cN5BsDDvB4XcLiL9X9K+RBx2hUd2m214FSBJXsIXPTj6nd0Ub2hE44m9vBrsM0FBemsD6Oftj/VCgZr4JMiWA8E4MPlrDthLNrhb7nhxu3sRyetgHf7EKU0Lo9qFtdtBFGqb0h7EQTdsQNgEoVmfLs66W2xjfBN9SkMtMjj4SS65L3xdIpYm3si8UANaqQ+b576phogWzs0KgT+w/gSNAxHI9qrY5HykbOVT1QlJw7g3U9jRMbUM9uyGUxFrNrAATcg5wwhK++A1mGVEaa6thCLIyL73c+D1ZaOJGEyDlvT8c7KxG2irOCHvJwE4qdmGPyLpuLwD/nJPM1ue0ptI/mBJTbtmZWlaL6OArxIA5lZO6ol1yyKaQRPcPdeAtmVvfTO8V+4JfQUxEqTJe X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 28, 2025 at 12:12:18PM -0600, Nico Pache wrote: > diff --git a/Documentation/admin-guide/mm/transhuge.rst b/Documentation/a= dmin-guide/mm/transhuge.rst > index dff8d5985f0f..5c63fe51b3ad 100644 > --- a/Documentation/admin-guide/mm/transhuge.rst > +++ b/Documentation/admin-guide/mm/transhuge.rst > @@ -63,7 +63,7 @@ often. > THP can be enabled system wide or restricted to certain tasks or even > memory ranges inside task's address space. Unless THP is completely > disabled, there is ``khugepaged`` daemon that scans memory and > -collapses sequences of basic pages into PMD-sized huge pages. > +collapses sequences of basic pages into huge pages. > =20 > The THP behaviour is controlled via :ref:`sysfs ` > interface and using madvise(2) and prctl(2) system calls. > @@ -144,6 +144,18 @@ hugepage sizes have enabled=3D"never". If enabling m= ultiple hugepage > sizes, the kernel will select the most appropriate enabled size for a > given allocation. > =20 > +khugepaged uses max_ptes_none scaled to the order of the enabled mTHP si= ze > +to determine collapses. When using mTHPs it's recommended to set > +max_ptes_none low-- ideally less than HPAGE_PMD_NR / 2 (255 on 4k page > +size). This will prevent undesired "creep" behavior that leads to > +continuously collapsing to a larger mTHP size; When we collapse, we are > +bringing in new non-zero pages that will, on a subsequent scan, cause the > +max_ptes_none check of the +1 order to always be satisfied. By limiting > +this to less than half the current order, we make sure we don't cause th= is > +feedback loop. max_ptes_shared and max_ptes_swap have no effect when > +collapsing to a mTHP, and mTHP collapse will fail on shared or swapped o= ut > +pages. > + > It's also possible to limit defrag efforts in the VM to generate > anonymous hugepages in case they're not immediately free to madvise > regions or to never try to defrag memory and simply fallback to regular Looks good, thanks! Reviewed-by: Bagas Sanjaya --=20 An old man doll... just what I always wanted! - Clara