From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A072C3ABC3 for ; Fri, 9 May 2025 16:09:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8CA156B00A3; Fri, 9 May 2025 12:09:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 879BB6B00A4; Fri, 9 May 2025 12:09:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 740F96B00A5; Fri, 9 May 2025 12:09:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 560016B00A3 for ; Fri, 9 May 2025 12:09:47 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7AABFB5EE4 for ; Fri, 9 May 2025 16:09:49 +0000 (UTC) X-FDA: 83423855298.21.81A05AA Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf01.hostedemail.com (Postfix) with ESMTP id A2E4540008 for ; Fri, 9 May 2025 16:09:47 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jj9Vh6d8; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf01.hostedemail.com: domain of mcgrof@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=mcgrof@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746806987; a=rsa-sha256; cv=none; b=UiaFUNx0MMNk5j74aPa8EtZK0d3rdl4pmM8bZ7eLBuKVRiKvZ4svHfjAY6xlsR+vHDm3S/ rIwuI0kJxcSUbNw35L6swfGy7Xh79cKH1/sS45mdW/ubtpou8iNd3mHV+8VCCLPWACYhu6 /IX6K8trSFFHLdWxmSFAT99ql/tKWHE= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jj9Vh6d8; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf01.hostedemail.com: domain of mcgrof@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=mcgrof@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746806987; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MKy9wSCzMuaFcyWcZipKF47wq6euSktfbc4rc4grVQc=; b=J6Lg5N355Qwaz8j72/n2ihEwy7dWD1TDNggleG7ITCV85vQNz8NR1ai0MNsrkU/n5v3uoG mceI4Y3ohgjhQw9g8evk63jH4qWPEJ4MRfyyKJkn9M8d65iuPSROldtaGojT7Pkt2w41j0 YAC2YIPYoB+OkauNDaZrGEm+bBDjUHE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id B4EFD629E2; Fri, 9 May 2025 16:09:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A4BCCC4CEE4; Fri, 9 May 2025 16:09:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746806986; bh=Zx9q53OQA04c5qmcm0DsdpJC9W96D9D2DyB30Y/gQSE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jj9Vh6d8aZ3F7OG5lDvoVMttOWKZaPPKIalxI97k/c3EO70+j54kHabw7t/ZrGoNS zrQteMjPuFQ6I8S8tIpySjMKb3PuIuBtC1BHE4w+ws+84ltQRhnM3QR3LosBoXXZ3H B6fgLxE2y40MC3ZhcfhRa+pf6qbEi+y38YjqVR1GV1p56MJWu/08UNbehTSA5ky+an iOu0l0EUXCdZM+8s8zZtK80qZUOfd6PgUInGfEwSU6Am9GvV+QzRyII9EHLDxWRm/A wmBhOtaea+Ve9EDNILiLlKDlpIqDJ3eumwOOS2UoFgZnZPckifxdwODvxcM1wnrFCG CgI54YXFKVorw== Date: Fri, 9 May 2025 09:09:44 -0700 From: Luis Chamberlain To: Joel Granados Cc: Petr Pavlu , Sami Tolvanen , Daniel Gomez , Kees Cook , Peter Zijlstra , Ingo Molnar , Will Deacon , Boqun Feng , Waiman Long , "Paul E. McKenney" , Frederic Weisbecker , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Uladzislau Rezki , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Andrew Morton , "James E.J. Bottomley" , Helge Deller , Greg Kroah-Hartman , Jiri Slaby , linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, rcu@vger.kernel.org, linux-mm@kvack.org, linux-parisc@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH 01/12] module: Move modprobe_path and modules_disabled ctl_tables into the module subsys Message-ID: References: <20250509-jag-mv_ctltables_iter2-v1-0-d0ad83f5f4c3@kernel.org> <20250509-jag-mv_ctltables_iter2-v1-1-d0ad83f5f4c3@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250509-jag-mv_ctltables_iter2-v1-1-d0ad83f5f4c3@kernel.org> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: A2E4540008 X-Stat-Signature: hi76o1uyzdbgxup7mpz9qam5r7ypnn8b X-Rspam-User: X-HE-Tag: 1746806987-733219 X-HE-Meta: U2FsdGVkX1+wm2XeFfxBe9OjuVK3ymajYTUmmszI2Byn4HL43UeodrrbE/cz5a4hbmg710gCrnwFbqtUPiWfngXSOuKQg44wEOKpBpkHmSXI4a4Oy242NOgKCDqFL2dn7PDd9RYr6SdHWXv+dboB8n5N/rCzApbPMOL9WlXERghnVNqlAm8rS+1DR6NhTPT13Hi+IRh9pukBBpDI7rN4OsCtgkHw98+E74FRKn6/kItmC77jV26s2SANwToXKMv8M/gcg61bnxICHOC0j2a1H1mGoOMWhHQLBnOQj83r7ZlTqINT8NlkJqnv04nh0+iEbGSBAx+QqZu47LGIYgtjwxBSfSwFEaQZgv1l0Q6xPCJOhmNdfGz5JYWEbb08SmVVwE7vzo3C1pAM4XT5iVVaO2ebeYX6si4ozOCCnb8TOn3wzUIZAfqx1GyMQMeFOMo+FEvTZ1WKcwJ7S/Mbln7jgCSfBNAxFvAvb6+fkmSAOm4cTLhNKGt8tXfyU7Um99olmdlkuWhY2lFxsHBSfnYGs22MuvEEw2IzYuQL8dZBv1/rDJAtYAw0bctsjtbM/yRVGAy0qm5c4wFF9KVWOr6AukhsgHulQZpYQb78rmzf4ZKW+K3pw1FMjiKXEmEsLV5FNG7r6zRnaK5Qa9qTWOpJ8Pc/YbOf0HJ4L/xuJjUyeXK5mJq+j/pPoYWNOA+oLhywd7ceJJnp3WshmcEWYFfoAFu5HGwyARxwxH7BWKTspV1DtDdtJYiqBjk8K2VLirxTRQ6SoAHkESB1FW9VOBgrDxHKKIfgrqI8xdkfcZ38m8caXE8jK1hRgYXio+ahkuEFgYz8p8dLd/vw+3qf4Mf4Vtnje/40MdD3WBgM/AdG/BVlJhgIzg7NwL/KKFt+fiy+WsHRMtDEHREgF1ep7K0/xdwxG9MCRYcIrE84jmVAHHOJkU2EZQoBgqFbQUb6tvnb464r/jaYMwAywVkDtEv JrOAiCTj UFVFGgUVK4F5OGI4j/EKArzwJxNjgcxwZf0tGCwVevMkxHslgUlCpCmEX7z69zW3L7ZY3qXzkCoXN3ygMC2HbhD0k0xGz2R+cudcFmsvCbERbjW09noEAs1zjCtlOWC58GGUJj1TOrYMi73JX96ldisUAw2OZpol5g9H2/UzR8NJ27IAgsQ5eJJPHpteLg1pmUm9WuPos8S/DNQR3FQZRsm3ahyXqsIZ2rOIr4XjX8K1b6WbFbvcOT+ExS5LvDc8LUJt7bx5gQFvsWV/tb2KTy6okm+Mdcif2OUtnH9tW0e87y6H1A0NzGsFEdeaLrue7GvHdgTDDNutcHn9IiHN7AuUZ7NavYEwhRGKa X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 09, 2025 at 02:54:05PM +0200, Joel Granados wrote: > diff --git a/kernel/module/kmod.c b/kernel/module/kmod.c > index 25f25381251281a390b273cd8a734c92b960113a..5701629adc27b4bb5080db75f0e69f9f55e9d2ad 100644 > --- a/kernel/module/kmod.c > +++ b/kernel/module/kmod.c > @@ -60,7 +60,7 @@ static DEFINE_SEMAPHORE(kmod_concurrent_max, MAX_KMOD_CONCURRENT); > /* > modprobe_path is set via /proc/sys. > */ > -char modprobe_path[KMOD_PATH_LEN] = CONFIG_MODPROBE_PATH; > +static char modprobe_path[KMOD_PATH_LEN] = CONFIG_MODPROBE_PATH; > > static void free_modprobe_argv(struct subprocess_info *info) > { > @@ -177,3 +177,33 @@ int __request_module(bool wait, const char *fmt, ...) > return ret; > } > EXPORT_SYMBOL(__request_module); > + > +#ifdef CONFIG_MODULES kernel/Makefile: obj-$(CONFIG_MODULES) += module/ And so you can drop this ifdef. Other than that: Reviewed-by: Luis Chamberlain Luis