From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC427C369D7 for ; Sat, 26 Apr 2025 08:22:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E2D56B0005; Sat, 26 Apr 2025 04:22:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 492416B0007; Sat, 26 Apr 2025 04:22:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 37FE06B0008; Sat, 26 Apr 2025 04:22:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1AC0B6B0005 for ; Sat, 26 Apr 2025 04:22:49 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BD848C2604 for ; Sat, 26 Apr 2025 08:22:48 +0000 (UTC) X-FDA: 83375504016.04.344E499 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf22.hostedemail.com (Postfix) with ESMTP id 20450C0004 for ; Sat, 26 Apr 2025 08:22:46 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=OJHaeRL1; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf22.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745655767; a=rsa-sha256; cv=none; b=Ln957vC3SBvWhYPwEpTjfT1eqb3l/tXNrjmmeFBZJICVNpMkM+GWAlbZebW50ZF2VIhaBM Xcg7+bIt5lUl/uqJFgsSpebEtUNayyebHUgKZko6r6rlUfs0Uqn/htOq4e1e9UxteoKRu3 R5nEiLH2tPlftoi008mOUZocDWhf9Dc= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=OJHaeRL1; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf22.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745655767; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=E3RXi5HW/+wA0HGDtqb8qDKwsb2kuLSH0lr7pWc2XZo=; b=1c4Wr1lzXErZQKVopU3J0u7RFmr7eeQgmv2hJ206bxdWFCRpHN0GurLpAOn4ahso7QBUIv +U7Nv9rOkAScsVQx06cYLBu7njPcDGFaw20OfC19tA5RYbUmiuRTuin1qoTd2vZdNjAgjd xb8zv10H9pWBe+ZT8tJVpxbxy5bCXds= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id EB65A5C3AF7; Sat, 26 Apr 2025 08:20:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 98959C4CEE2; Sat, 26 Apr 2025 08:22:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745655765; bh=7Bl7de4B1CcHT/qr+JjEpriesTtHJODEoTtEeQXzAkM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OJHaeRL12xwlkkkBC+jsJeEVr9fi1ApDZSdVzQ5yOExRKsw6gBHotqsfnF2oz3Lk/ ruaQsnEyhzIOfF9lwX1R0X8/HV08J/+ceGT8uPxsBd4nCnNuozq635mUBDDj+hpr3P 2n1zBihSzqe7gKpB1YMe8u5ib2FbvioCKlszUGnJenADLpkgXwddcrBYDzxjnqlfgu XDxXV0E6/YMVCctw8wNmeAqu4EVSUMJSo9wYSl7nIj3eosllzvHr+yD85QZEX6WHk/ f6VQfAvY0Kfp21TtpwnDW5PiAKqbhdpfrd+Dq7yuBvI5jBULIB/DVoBklcfTneVw3u 0XzDbQFewiNdQ== Date: Sat, 26 Apr 2025 11:22:39 +0300 From: Mike Rapoport To: "Bernardo C. Gutierrez Cantu" Cc: akpm@linux-foundation.org, dwmw2@infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lkp@intel.com, yajun.deng@linux.dev Subject: Re: [PATCH] mm: memblock: Fix arguments passed to memblock_set_node() Message-ID: References: <20250425102003.64122-1-bercantu@amazon.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250425102003.64122-1-bercantu@amazon.de> X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 20450C0004 X-Stat-Signature: o8391ksar6yo8xxhk4s8h8demk8kkrsm X-Rspam-User: X-HE-Tag: 1745655766-903468 X-HE-Meta: U2FsdGVkX1+WK6AZD3IwFeCQ9q47r5yv5dnq9vZapFcXE8TW8qdq8JWBtkJ++uVR5QoN+8PLmaL+PZT0o4PlYIc+LLCa3g0WZrDq/uft7pDiuuZ8dIIZQqKYYEOnDdcjpkxNOfz0q9ULPes/YyBTNX0FiwtQFCiHzQD3RnGBU+CeRKahNj6gLoDlx7XDQDSqj0IwYZzOc7hud0RJ75cwGnXy9tLSX5UOKBRCI3VQBMa1MgWAyBBFsQyQmPt8dMyQeqmRNJGpk/dWWvPwYER+XRVaQ73p8SVBiv+55rqXctN/yb+BUGhBLSacl/4Rpv3O9x4RDQs/sufLdu/BONmlv5FBoqVSotpapYvHRoNnO6FO9dgEzeGm4cNv06SJX+OF4vbBmftbVrVDSQ9nIp73TyrZlv1juD7fwcdQ7V7MTBuddjiYUr5ZzWaCCDX6PQadHy5R/Qu9RxsyZ6scL8F82N3LhrL2MQAtocYvRGA0bEx7UV3TQJjbCcdqoKi6tH5Wr97BO1Gam28WctaihZ+LG0f3EUTMFaqZpe8O/DdzYLGJGANKysWLGLS5zWqKkx83roMGOXd9kOGaTdkTA9gQ5YlpezqEA4iTKYYCgJ68lBze2gghe5ctSp0rjqbmB30wdk1Dn3uKve4Fi3wSEIfEdLotE380CCxJJjAsdVtcykc3rZecEhouJWOG3vkId/8OOTu6XjhVpjBHOV2VqHR65Z7b63poCOC1ESJpJRVnlUEq/Xh+ptbcnmYWAR97XWZNanePcINujazou49PgUVnt+G4zGL+KwpEHuT5mwCuG7jTaDT5X82N4fNeFTGNCfhBoGlNWtBFkTlcMiUUXWLdj63jTt8nJ/fAyqBTp1HKDzCglLmKPrQnL4HUu6IVBUs+zobZTUFPVq5fdgHpo+1pixQAFY4IbHnAXj4YDJZXDWwvQh9ykiE/A/sFbbdm7ObDUWaG9hyG2dj+jJfrZaI RJFCAxWB mlBG/zlxKBtBwEcrDpWLINn1WB6R/vWp8QMo5Zedz9XDArjw3AEPegfpe/CYwhHDR7/ES6Z4n4nD+Jw2TcWpThU2vdPJPJY1Ezas5vMBxd4Q0v9bt9iOjHOS2T4gSpl3PMe4E4+yAxa/0e5m//p1SmdWTAnKK44+KeOOXenPR4VFv4vubKGiGnJpYyaMKSkymD5TRDYqZGhAFKcrY6qaP5MAAGbwXznWx6WjpwapPMwk/J+cJ8iKiXLmMqaoVrrJlLQXb1xs/5dMB1I9NVcKIJysvCmL5Hld6hGAE6+vNQxoa8elh9ywLK0lgIKQgffN3FuS2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Bernardo, On Fri, Apr 25, 2025 at 10:20:03AM +0000, Bernardo C. Gutierrez Cantu wrote: > memblock_set_node() receives a `base` and a `size` arguments, but we are > passing the `start` and `end` of the memory regions when iterating over > them in memmap_init_reserved_pages() to set their node ids. > > This results in the function setting the node ids for the reserved memory > regions in `[base, base + base + size)` instead of `[base, base + size)`. > > Pass `start` and `size`, so that we iterate over the correct range. > > Fixes: 61167ad5fecd ("mm: pass nid to reserve_bootmem_region()") > > Signed-off-by: Bernardo C. Gutierrez Cantu There's already a fix in memblock tree: https://git.kernel.org/pub/scm/linux/kernel/git/rppt/memblock.git/commit/?h=for-next&id=06eaa824fd239edd1eab2754f29b2d03da313003 Will send PR to Linus soon. > --- > mm/memblock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memblock.c b/mm/memblock.c > index 0a53db4d9f7b..9639f04b4fdf 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -2196,7 +2196,7 @@ static void __init memmap_init_reserved_pages(void) > if (memblock_is_nomap(region)) > reserve_bootmem_region(start, end, nid); > > - memblock_set_node(start, end, &memblock.reserved, nid); > + memblock_set_node(start, region->size, &memblock.reserved, nid); > } > > /* > -- > 2.47.1 -- Sincerely yours, Mike.