From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45EEAC369C2 for ; Sat, 26 Apr 2025 01:11:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D2B1E6B0006; Fri, 25 Apr 2025 21:11:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CDA3A6B0007; Fri, 25 Apr 2025 21:11:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B7B6D6B0008; Fri, 25 Apr 2025 21:11:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 975696B0006 for ; Fri, 25 Apr 2025 21:11:02 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B462614109E for ; Sat, 26 Apr 2025 01:11:02 +0000 (UTC) X-FDA: 83374415964.21.888DC55 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf09.hostedemail.com (Postfix) with ESMTP id 128A714000E for ; Sat, 26 Apr 2025 01:11:00 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=KxqczATS; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf09.hostedemail.com: domain of mcgrof@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=mcgrof@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745629861; a=rsa-sha256; cv=none; b=Trf6j+K0G2RI3QjBS57bGG6gFQe++zhq5Is06JViRlEofQn35RAW43/cOcNkqK/eEReOT9 aLna4e/MbAXQuDLd75hxQ9t41ZTVg0a3DMyEglb4ols7ge1lq5yAHS0Ku8R4mhmCKojAGQ 62c5ti7ZqdOj68hVRiTb6+Cv/YTdsd8= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=KxqczATS; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf09.hostedemail.com: domain of mcgrof@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=mcgrof@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745629861; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vi2pnpjccu/XjMR3GqlprWeJbFeAdaR45wzAOdMIYl0=; b=LA4pCOQx+4dJurk0GRjy/O3lt+E4lgxeFwU89dQpdj23580TVIo4qS2IVP9GWvg5ZsO+cN GKe9lnmqYbsgHRIbRdRbT/GVvJm1r9IL79l5KxWTpY5tOB9k3T5lngi37DsWSdUoiVTSyw LXp3j1s4LgLIybkmFEwPZ/lVy/EIAvk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 7088EA4D70C; Sat, 26 Apr 2025 01:05:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0F060C4CEE4; Sat, 26 Apr 2025 01:10:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745629859; bh=GUs6TKtXii+/XXjYUhm5P6PA6lNQdKk+Fhn0VAcFzCg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KxqczATSjba7r4EOiuW4Y78kxeaOmUn3hrN1Qeb61Bk1IEG5UNMQYfKkJP6rYhrV7 8AmTGD/13GYjzSccgNMwsaqeRlpmwPv5meAChJXDj5Q06hhFENBCp7oBqxPzuc9ZO0 pGKSNgygnGuSGADjucID9fOYBRhKR7ry0z4g2sDjEkMTeG3qIIFlI5culzVUuXi3wA bC8BOIqRt8uMC02v1ZmTGzq2dYb7qx2Xfv5q8Rxtr63FLkVeFvfiizkWxan0m4YeBl KHc2CWUVFGRL3C1kNb40DgyDJqN6VrFEUEYi9ZwapTJakiV2SfEKCIjtwm38N6h5V5 f3X4MpEQ8rQEw== Date: Fri, 25 Apr 2025 18:10:57 -0700 From: Luis Chamberlain To: Leon Romanovsky Cc: Marek Szyprowski , Jens Axboe , Christoph Hellwig , Keith Busch , Leon Romanovsky , Jake Edge , Jonathan Corbet , Jason Gunthorpe , Zhu Yanjun , Robin Murphy , Joerg Roedel , Will Deacon , Sagi Grimberg , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , =?iso-8859-1?B?Suly9G1l?= Glisse , Andrew Morton , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, Niklas Schnelle , Chuck Lever , Matthew Wilcox , Dan Williams , Kanchan Joshi , Chaitanya Kulkarni Subject: Re: [PATCH v9 05/24] dma-mapping: Provide an interface to allow allocate IOVA Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 128A714000E X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: 4yyhu7tngwofh3bntyt3m8obtbwcuudp X-HE-Tag: 1745629860-684333 X-HE-Meta: U2FsdGVkX1+k1/P6laN81a5d53hupZU0CM3VEV3kVV4qZWyR0/Z64YKRwMZmj9NqvNDHcfBx+QfpNLG1IyepycLZHXA/VKzBL6XQgjixrDIS11DpkYUe60CtRMw/tb6mu8pjy7L6TsDvcsHC8HVVbzVr434vqx392fz5LDMpKbORYI6u8X+zBvS1g42mHyFMnK777c+5qpodv1wGI7H8Qc3QB7V/ylAXEGz6+twT6ZLiaDzZTW5ViajTGGbIhfurgx3Dz8MCshBZAgkTP80WQT8vK3zTbQdqjB/2FuX5RDQ7g+uE85jgkS5cOuUVuLVL30lVVleZ3kDmNS6KH9acnwlw9Vzo7uZzIDJDPaISv4n2iQbVL1/yFVIdYzsLfbh7rNujky/S0L7X/kN5+2abvmWpF+9YCsEbn/71OIi4zJA06HBo1VhbaxkKYIQLZdZvmktDagb8rQ1eslghMlycw4TKYsa/gTJO/G6LcDlB1l1xFSrqKeWjAUzkFrou7GnKG4kStw/3dJtgGntLch71azhwXKhfXelVtsTQkXbTQq0EZOtDfaMDfpA7cdN3ZBHiN672Rge9UlfwETp87cGIvRrlkO5whjF85rlJ++TGbj/3rvtPszxjbAZLOwC1RI+qpkGMIpc0qX7bFl2pA/ua4NEdIlr3RZv+4SY2aV9/WUsa0c/KcA5gGAT/OIDpo+NW5CoqPA25JEipwH4ZLO9yGQXYoKeinNSP9CUGIrTHkCBhHRe3bL6ulFOWnnUi+ai7HT9EspSibAFxeLAEXQ/mWc/oZcDHMkTTfmRTzB/jaB4HYn9rQFTQCwp1+lo6DameGygOkdR9tgUKZoNyObURnfSxxRiZm/gvHMPlgAvsGLa3vC5PJeSLD9+ZTSrhvPVPFm69s/0N6NHO0G5jNCp/BZ5HFPyBnpgB5PMs0YWIRNiYeJS4D6EmEzvJeU2P7cyUlLCWiCnsYfo0hTdqdIc 73FNp21l y8mv9k3m8WFncDDWcUbKZODSZLyAH437wBey4Jjw0ceLXiHxnDD1/lAEIlw91HPvSEKYmPN0vI6zYy+cxfNEq3yqRmpAtUbT8PRLMQ4hptw5nN5mO6uxSQGQl2oVylSjWck4xAgClbjrPFZkDI0/cLLVpkiWA32MXzjsyVUO2OqH8sq6cv5blfwiIterHde608QGvyPmTWyWHEBi/RPO8SZAiV49qzjt+tRejqsS7IYGdbfo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The subject reads odd, how about: dma-mapping: Provide an interface to allocate IOVA > +/** > + * dma_iova_free - Free an IOVA space > + * @dev: Device to free the IOVA space for > + * @state: IOVA state > + * > + * Undoes a successful dma_try_iova_alloc(). > + * > + * Note that all dma_iova_link() calls need to be undone first. For callers > + * that never call dma_iova_unlink(), dma_iova_destroy() can be used instead > + * which unlinks all ranges and frees the IOVA space in a single efficient > + * operation. > + */ Probably does't matter but dma_iova_destroy() doesn't exist yet here. Other than that: Reviewed-by: Luis Chamberlain Luis