From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAF31C369D1 for ; Sat, 26 Apr 2025 00:34:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 60B3C6B0006; Fri, 25 Apr 2025 20:34:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B9896B0007; Fri, 25 Apr 2025 20:34:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 458BA6B0008; Fri, 25 Apr 2025 20:34:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 269816B0006 for ; Fri, 25 Apr 2025 20:34:20 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 82F7580F0B for ; Sat, 26 Apr 2025 00:34:20 +0000 (UTC) X-FDA: 83374323480.04.2AAB6FC Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf08.hostedemail.com (Postfix) with ESMTP id BD37C160002 for ; Sat, 26 Apr 2025 00:34:18 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=k5REWfbH; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf08.hostedemail.com: domain of mcgrof@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=mcgrof@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745627659; a=rsa-sha256; cv=none; b=iyPHZRUnsCXahd7un0kLmEo3G/SpcpdbMqqr8JlNwrGvyLjUUVq2POt8bKmOF/TCfDUbIA UgyqhewZl3xIkP2Y5jtI7892kQycsEbAJktiE2BFHGAZIgxW3HQKBwbin9B3i4D2iiczJ9 4Vir8ONjZ4+elT0pApZaE6zwhdrOCTc= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=k5REWfbH; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf08.hostedemail.com: domain of mcgrof@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=mcgrof@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745627659; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sE3j07Wu6HWpAty2P7Jg20vlFta/zTQ2qMS7NINOz0M=; b=R/RM0Q0AgRp1CJUJ69tQlQf8Qoa0mcT0aVWlL8XZGheUo77m1FSJi0iYkjYesG3Alklqdl v7eDfrmMgs2Z8JK5m6mms3THnVsiXKE45YsLiFLD/eqSBVPHb/mCQ9rE7tbVz4Sw2oTHi6 qV9lQL/8l2I9cARdXpiV7LpPu/up0WQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 9EAC843F30; Sat, 26 Apr 2025 00:34:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 610E9C4CEE4; Sat, 26 Apr 2025 00:34:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745627657; bh=gP3gwxgNw7FZrnmpPmzzPgN9aXPBN23+6+4ANBvGC9w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=k5REWfbHKSUvcglP1TpsrQx/rq1FAKn2v2KHy+BXjjaPljIS5n6SQK9pVphFinRnx iiZmWQcYqMCRenOrXGgkymILO6xDnjVdTIYpTwlC3124iJI/lqBnVkjVDeyHa3k2Zi AonqUn2JHmINYqVkRLWYeWOCDjqFjcathYX0Qq+u6FkpKKd0j1WSGxWchvgjaJDyxN 2P31MVsu9VM6jv5ZklMDygNJJkrtglm54XJC2zPLQA1Asos5rowVnKiOk52+CPyCFW vYxLICwro5pr/DvALNKeCg7BcMKkO1MMGoCQvVAYmjFgzzR23x5OnOOsuVFqTivGU6 Jb/EjtzwtiErw== Date: Fri, 25 Apr 2025 17:34:14 -0700 From: Luis Chamberlain To: Leon Romanovsky Cc: Marek Szyprowski , Jens Axboe , Christoph Hellwig , Keith Busch , Jake Edge , Jonathan Corbet , Jason Gunthorpe , Zhu Yanjun , Robin Murphy , Joerg Roedel , Will Deacon , Sagi Grimberg , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , =?iso-8859-1?B?Suly9G1l?= Glisse , Andrew Morton , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, Niklas Schnelle , Chuck Lever , Matthew Wilcox , Dan Williams , Kanchan Joshi , Chaitanya Kulkarni , Leon Romanovsky Subject: Re: [PATCH v9 02/24] dma-mapping: move the PCI P2PDMA mapping helpers to pci-p2pdma.h Message-ID: References: <493a6ab31fdd73e84e16662578858f194e9f87b9.1745394536.git.leon@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <493a6ab31fdd73e84e16662578858f194e9f87b9.1745394536.git.leon@kernel.org> X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: BD37C160002 X-Stat-Signature: 3xf5uh8bi5enyrm4gqbuith6rdgxdsqs X-Rspam-User: X-HE-Tag: 1745627658-425002 X-HE-Meta: U2FsdGVkX18Wov+HZaQJSzGiFLFEXeM186ijdBldUh/R+ByFkGaHYPYgWiFtcJb6g3wRDiyf7/SUx5i4fDM2V8Nr6R44bZpA3Vn0ixqF9Z0iMDwNejqssGnoSPbhZucoKNox6rvOHJ1aqjr1bytqBQ4ZG1Sd6Hq8snT/y8K9RMd7oR4WsxITvDqXClnU45e5gSz3qW0iaYvNvfQqryMIDtgttACOp8215qSJ6HDS+IqApEKsOgRPt94lsaqWqP7LRBIMCqOWI2egCZhRyxzbrRwBBDfw3btOflWEMqz6XVLMG2tmB4WVLU1OOm01/Cl2gjCoH0HPuOfUjPFVMqxuXRJMW/mWufjgiLhDxTOfpDvW+FrLnTXvPeU2tvIPYOTgrGWaBZuMrJuRIOQTatfzt7/nn2faKOmPEKiwp3qFqESrX4worXYsBglRNay/IjiLPaugQITpOrAQDXsbXLAxrgw0h1M7D3n6jBtIF2utsBPvXNbDyh3c5Nd1u6BAOQXVsojKZbtKYYKrLdg5O88bXCqIx/VCKXdjAEkxUTsgtPFXG7svJpE542AA4r3RenhbNCzm102kyzbo61UZHpy5OhWTpEQU8D1qeleYM/TI4n9d8DFFXN186xy+JqAsyyJznkgj7r9ABUKeZttv0VFr/JCx7SkVhXinunXvP7sM12Cm7gmvx9tSB/85dA3iiq3Qf7EMRk0aSwcOhNI/uXh/y7ttx/z/cpRkvANbxjv8GOLKi09AlpVY8is7Fa/XfdNYJp/5Sk5Y8OtQQn+bNbFoMHgiKQsohGN4DR8586UIZakMojo/P3g654QedlPvxtdcrhTganyP9FdnHoAbBwbUn30gm+sJE08qPJ0ZMw4lbfhfo7Yc/s4rC9ODnbstHZGz9rVBwDBLLovuVD4i1vQJzJCQnTn84tWKjrRyrxJBTP97mScZcULmXK5GIbR/4OWS6nuW5alEN8uGDNn1EUv ODfH6ZQG O83toPOzd+rddY07n7eKVi+waJqCg0P1laZ+a2kBknx9sDgCW9zhQPvkam3SL61gOVeGyflUpvN9q2NS/9f52tgeJ559DzyKIxrbOhg+f9mpMN7uYnz27m9gTHFESFLSHYA7RVUDV4TgR2ic/vSYoqmdZ0ylkaQ03dRaJcrhZ2H7vqQKAYf305CGqzG+/yI7ujdaU92Mqb1akyW9a+yX95tn3a2bdHA7EPDYHV6Hx8k2eCew= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 23, 2025 at 11:12:53AM +0300, Leon Romanovsky wrote: > From: Christoph Hellwig > +enum pci_p2pdma_map_type { > + /* > + * PCI_P2PDMA_MAP_UNKNOWN: Used internally for indicating the mapping > + * type hasn't been calculated yet. Functions that return this enum > + * never return this value. > + */ This last sentence is confusing. How about: * PCI_P2PDMA_MAP_UNKNOWN: Used internally as an initial state before * the mapping type has been calculated. Exported routines for the API * will never return this value. > + PCI_P2PDMA_MAP_UNKNOWN = 0, > + > + /* > + * Not a PCI P2PDMA transfer. > + */ > + PCI_P2PDMA_MAP_NONE, > + > + /* > + * PCI_P2PDMA_MAP_NOT_SUPPORTED: Indicates the transaction will > + * traverse the host bridge and the host bridge is not in the > + * allowlist. DMA Mapping routines should return an error when > + * this is returned. > + */ > + PCI_P2PDMA_MAP_NOT_SUPPORTED, > + > + /* > + * PCI_P2PDMA_BUS_ADDR: Indicates that two devices can talk to You mean PCI_P2PDMA_MAP_BUS_ADDR > + * pci_p2pdma_bus_addr_map - map a PCI_P2PDMA_MAP_BUS_ADDR P2P transfer Hrm, maybe with a bit more clarity: Translate a physical address to a bus address for a PCI_P2PDMA_MAP_BUS_ADDR transfer. Other than that. Reviewed-by: Luis Chamberlain Luis