From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96C0BC369C2 for ; Sat, 26 Apr 2025 00:22:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 83E136B0006; Fri, 25 Apr 2025 20:22:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7C6856B0007; Fri, 25 Apr 2025 20:22:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 665FF6B0008; Fri, 25 Apr 2025 20:22:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 46B066B0006 for ; Fri, 25 Apr 2025 20:22:04 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 39E5EC0D95 for ; Sat, 26 Apr 2025 00:22:05 +0000 (UTC) X-FDA: 83374292610.02.AD5CFC2 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf12.hostedemail.com (Postfix) with ESMTP id 8BAF540002 for ; Sat, 26 Apr 2025 00:22:03 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=uSx9KLDJ; spf=pass (imf12.hostedemail.com: domain of mcgrof@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=mcgrof@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745626923; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=N9OKLboyRSWd9iZcPYqjA5xqgR2wK92sFoH7sofxhbE=; b=zXla31XkwPn5utPbK6D0SPFuIApZGeSvLcvUGXDzP6JH1Rae55ynm9Iyy9EghI+e4p6vRw 1QIxZBuCz7/ii65BOwr+uJpbt8ZRheIrSgDe+owONevWUi81p9jLNqhvxwJ+hPjseex7nE SXErScXWrK5ESNOu9wQr+oa3755DqMc= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=uSx9KLDJ; spf=pass (imf12.hostedemail.com: domain of mcgrof@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=mcgrof@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745626923; a=rsa-sha256; cv=none; b=becvyKybWjbnggdUFWIet406623xyHQekfhy1qCXMy3E4yAEqY/Rto4TQKY2O2xCiHyIJK SgNRftTQxjqFLbx3ZFiySkrIcfv1CSrxFTr68LAkbTOMxttDeHndPX9wZ8q+y+E/zMEhiE yZjySqoE7tFWH4QQYUThhnaIAuMePdk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 1E5D95C6C9A; Sat, 26 Apr 2025 00:19:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B6A96C4CEE4; Sat, 26 Apr 2025 00:22:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745626921; bh=h50G9mpEZaBwJcj8NBjbBVE9qsIsc9fyuWGRd2gmBsM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uSx9KLDJxnN6lYn0LOZiC4gIIRTMcevzUKTtv7QtHq94vnzWzXAWCWK4YS8t/lvCv alHXKJFiqiZH5uLDlN+4stNQPEDcFlWuzLtnpyGxFQaHCXmY/sJ3NasmNfPQ10XOsD wUw2k76EwWqC8e0qBP5fC1orpyG4CQVrSTzu1rraBPS49Yf+gV2ATcRoe77STUECZ4 KJl2G7PvDJa9oNMl3b9jsvgxkMxCD7AlH1dhdpNSZwOELkRM++Hgq3UOE+eTSBx7Az pefT0sVbAaXyzhhHb4ziaDfP3nFsriO8NgoukTNrsqDiCzAfPrcBbyGzvg66JNeo6z O2DMUdv81udLg== Date: Fri, 25 Apr 2025 17:21:59 -0700 From: Luis Chamberlain To: Leon Romanovsky Cc: Marek Szyprowski , Jens Axboe , Christoph Hellwig , Keith Busch , Jake Edge , Jonathan Corbet , Jason Gunthorpe , Zhu Yanjun , Robin Murphy , Joerg Roedel , Will Deacon , Sagi Grimberg , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , =?iso-8859-1?B?Suly9G1l?= Glisse , Andrew Morton , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, Niklas Schnelle , Chuck Lever , Matthew Wilcox , Dan Williams , Kanchan Joshi , Chaitanya Kulkarni , Leon Romanovsky Subject: Re: [PATCH v9 01/24] PCI/P2PDMA: Refactor the p2pdma mapping helpers Message-ID: References: <3a962f9039f0265de939f4c81924ee8208fc93a6.1745394536.git.leon@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3a962f9039f0265de939f4c81924ee8208fc93a6.1745394536.git.leon@kernel.org> X-Stat-Signature: q13iisfgrg8siss7sbkinnhi4dux7ix9 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 8BAF540002 X-Rspam-User: X-HE-Tag: 1745626923-888548 X-HE-Meta: U2FsdGVkX18RKkFEXlIEKpB/x9PSgJgPsMsTIYrVayPTYJqzY5kI8XJMOqQbjPZBBnvjzDeLnvFNvCcvCkytaG7WfjL5Sh3ZQE7sLdTfjrBBKcfsaj8FEOlFEOtT1ZO1adBoyEFI36xPEJAw0g+Pj84GVRIJj2weDEvzRjsYHnzt6/YsM/E0Zl15Dej53mZJZHpFBOnCONnZDjROTvE/rweJtCdEUqjSvlOE6mOmd7uEEoOqAKu1HWEBrlFrMk+jagxOph59PvXABSIkXdczqsSgb4pq1Bxvjc5TnCm5YGBDjudYCIqaSzbESgzZ7UTu31KUtKkbEnGoD3avuwo5GKISrW6AptOgLqKgcDEfo61/X0LDgfOa0P75Km7kg7kM61ckyEBXI+RBFk4E4EB293roq87yrcMOjq/2mbLcBcBF0V3R88WCK7b2NANGQF/eJNUegJfstfOjzg4N9zrQBybx3qsf1ABHkaiWt66nQrT9wj5Gnk5GjYlk5/FI6LuKOOHgnRjaYdYgVNTGdk3tWghzsR4IeqQ0TeISPD2Okt81xwfQrCoa2TNqhvtCc/INxQrKEU6eAkyYVrsZ82LAucAS7POjX3BuaQ9gvZ9ixhL+EUurdTlo0iUxhsH57I2dTSo3Vl3Ze7VDIVd07ziKgcwbX4k8U0Ho8maDowoNS78V20+stQbqWyYpYGhGLlY04aoOrYFCqijaApjQX+s99we1LmdSxDrq+e2fg/MaDSCZnNAhmAir2omv2mJdTzn7yX3mPJJ13bRg6guoFTcxR9i35bq9MhbQAG7ItrgYCSX9vWlsgjtDFFf5egimk7O8YG19+ajv+swnO5bViYnaVIC4wGJAVGxn+umw3RFK7RF+cH0xKktVhSirhPZ3lR3M2I6blZAPUerIA6NDWkZkpRLWRQ+gDTZI+ZMURW2lBJshdj1ydx4rRS3FtlggTqrPDkC1N3u76zFrqeTt1VF UGhvG1eI A4Vub225VcCb5a3IyX+6ML9uS+9QXh1wS8lAJtT2mIbOqY4a9b5rPx+SNYXNqjMuSB7IlDNtXaNUUGAx3sa0109+BzTS1eD5RYDj06dZ0ezxcajXkVM+pYmXQF98diNHda/Ecq4w3uB8LD/0qwziT47Hwkltf4WXxhELoWx9m9vv2TJ8dppMllVj92rWvdtSo2u0X6oXZQ9GiY3Vexi7yPgCTNaGXkoCmTeXQqMhB9oR/gE4TI2rL5xw6rqdsqbIXtedqQ4S8qhtXE9reR20CLPHcMpr432cKchWRXpMcYdP+gLtFI+5fnJyxjYdYyP6pEC4YNUCugDAnvaYcbxu73Jv8ylJJDKTYsnc32FjQWaRzSN0TOTkGCs4K4WoSGlXsGSip X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 23, 2025 at 11:12:52AM +0300, Leon Romanovsky wrote: > From: Christoph Hellwig > > The current scheme with a single helper to determine the P2P status > and map a scatterlist segment force users to always use the map_sg > helper to DMA map, which we're trying to get away from because they > are very cache inefficient. > > Refactor the code so that there is a single helper that checks the P2P > state for a page, including the result that it is not a P2P page to > simplify the callers, and a second one to perform the address translation > for a bus mapped P2P transfer that does not depend on the scatterlist > structure. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Logan Gunthorpe > Acked-by: Bjorn Helgaas > Tested-by: Jens Axboe > Signed-off-by: Leon Romanovsky Might make it easier for patch review to split off adding __pci_p2pdma_update_state() in a seprate patch first. Other than that, looks good. Reviewed-by: Luis Chamberlain Luis