From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E579DC369D7 for ; Fri, 25 Apr 2025 20:00:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A02206B0007; Fri, 25 Apr 2025 16:00:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 98A3D6B0008; Fri, 25 Apr 2025 16:00:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7DCCF6B000C; Fri, 25 Apr 2025 16:00:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5FBE36B0007 for ; Fri, 25 Apr 2025 16:00:53 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D49B31CC4E6 for ; Fri, 25 Apr 2025 20:00:53 +0000 (UTC) X-FDA: 83373634386.27.F58B9F2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 4730C1C000C for ; Fri, 25 Apr 2025 20:00:51 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iXtT7s57; spf=pass (imf21.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745611251; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T8/4HYJEyKL0BmypDXzpIvuA602T0FZNtumDp2Gucts=; b=pPckpefbGD6jexs1wIliR5hRtb9zATTu5kEIAaYS41+JIFySeMmMygzCJcT/207p2qAT+c UPcrLSd8s7lMWyzAWgUgqCFOOYOuiHytKWcz82L59aYIC7F9Yhn42OWex3rdqk6Xt3uK6P Tv/zeqAly/QJ3G7lLYBXXaWGU6gJeTk= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iXtT7s57; spf=pass (imf21.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745611251; a=rsa-sha256; cv=none; b=ZAvfaLmZIUNjWE6a0pgfCoFdhWdhW8dBg6CNjphxzYjzZ4ikXADVn3+RYSA4nSV2GwkW6I 0aAGkXRzLiKcwcAMNkvlHeO3b9+v9sdrQFGix+hxx98qsSCtG4YiP3WQlf4V/DGPrh6p/8 zyJNr3XZPZZI2LkpZkED6ZsuTERWSRs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745611250; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=T8/4HYJEyKL0BmypDXzpIvuA602T0FZNtumDp2Gucts=; b=iXtT7s577mkzm/URNdmNBL3vPvvqSA2o0lwXIl+Ay6hJJSYCzLC+ZDR4iHAm6gFUiZA9P0 ertYWBnw4P1I67vi7tx78bf7nNqEGhsbEv38GRuojkgAp3PaFzhbROlKCj3k7E9zXCSrsx 2sBIAg/7QPyrKfTfQ/hPBFIsWOamvyI= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-58-RgjIUsPkPSq-ryh8rAXvjA-1; Fri, 25 Apr 2025 16:00:49 -0400 X-MC-Unique: RgjIUsPkPSq-ryh8rAXvjA-1 X-Mimecast-MFC-AGG-ID: RgjIUsPkPSq-ryh8rAXvjA_1745611248 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-7c9255d5e8cso464221385a.1 for ; Fri, 25 Apr 2025 13:00:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745611248; x=1746216048; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=T8/4HYJEyKL0BmypDXzpIvuA602T0FZNtumDp2Gucts=; b=mcOaeKCee8bH4uGiu0XQVGR07ErHkSAsLzmwvw8MCfj6f+ylpiWIH2sMHbZrz/rdoO kJ4diCuzF3Idsd0HUvtFkaQBZDDxs8P1c8zqgOF6GkUPs8jKPH7KaBoDiIrieQGsfKQf KbYJQzaLV9dR+KqjlFRpmN6O3As47MVOLTDQuGODruoZEhhdFh9BC0P0Pvlj6gMDRLPI kDTTw7WcRuMREq60TFQmHk4D8k8mqRRrB83tmxg7Qpe1lybrRR0C/xzeQ4UoXVO8koyY ph3Y1tQoQo84e/8kSoJ9Q5ttB+08Kz657xcJ5gayOtP7DPzC3neP9aqSgCA15+faLmcV GIsA== X-Forwarded-Encrypted: i=1; AJvYcCVgR/jxmjOhLVPqfdDg/6i2Y1AstygNN22p7ytKbTbkx9maYAR6zKrapszmeOlG1igCqQb7QqWaJw==@kvack.org X-Gm-Message-State: AOJu0Yz90xG7Rarz3wErRW9eG226L3TzfQg/ORKSiBVlQKK46U1fBFOc W8cSlSL6adShUm51HOddS9B8yqiv6OqeQBpwzSRwAU/NXfSG7U2Oge4IVpoLAxtBYOM7r90MJqC fpiVyVUlyEGtnsI3O5zB9zR/kPuQ6GgcyUwCedyVjGDSeZs+J X-Gm-Gg: ASbGncuPsHK/V+ZmGFCAL4qmXJ02RakavBBmJicYnZ5eVxyLJJFf0ZJV74LlaBCN3Jh 1xGiqzQgQkI+x0glDeVz6NlqPYzKmJjASAdY+fi/jEP1474RNUX4tQqwaZ7UeKcy6hZlmK3rdLE x1ZxQxLqff7sIpeJlRAP4jJ4wC9F3FMd1XNn0acK8VN7wOEyfutaJbVaG+fMR/ZL+3BnE0kOpp5 i15LIKtXtdMV2gCef8Alp0eB1DhfylIpnPjb/RzMynCBLYz9dkBm89LpwV2k3KDoaZ9YvS3rJFH Mbo= X-Received: by 2002:a05:620a:24ca:b0:7c5:dfe6:222a with SMTP id af79cd13be357-7c960793e41mr556092485a.42.1745611246989; Fri, 25 Apr 2025 13:00:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHp9AqScyuP//w2WTf2DZKa+eTenWSA/B8rLTtbznOGZp/n+4SX/uHlViZL3kDCGa1T/CH6wQ== X-Received: by 2002:a05:620a:24ca:b0:7c5:dfe6:222a with SMTP id af79cd13be357-7c960793e41mr556088285a.42.1745611246549; Fri, 25 Apr 2025 13:00:46 -0700 (PDT) Received: from x1.local ([85.131.185.92]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c958cbe651sm258957185a.47.2025.04.25.13.00.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Apr 2025 13:00:45 -0700 (PDT) Date: Fri, 25 Apr 2025 16:00:42 -0400 From: Peter Xu To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-trace-kernel@vger.kernel.org, Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Pedro Falcato Subject: Re: [PATCH v1 04/11] mm/memremap: convert to pfnmap_track() + pfnmap_untrack() Message-ID: References: <20250425081715.1341199-1-david@redhat.com> <20250425081715.1341199-5-david@redhat.com> MIME-Version: 1.0 In-Reply-To: <20250425081715.1341199-5-david@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: aQ0rXfveAXRd8k2zhUup5auiADmtVs1tnwEhn6XQDM0_1745611248 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Stat-Signature: s4wbcazfeuox1eoa1mmurctc6hwdpeyd X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 4730C1C000C X-Rspam-User: X-HE-Tag: 1745611251-579170 X-HE-Meta: U2FsdGVkX187pEgFxHdD22x10B+GM7LCJqEMV0abq7fviw59N03QCkZ8blVfve791jI4FMTpeqpOEXapQyA1Ubv7H3K5kLuqT9JpTQJ2Wc5DjWkjSMjg4gVIm8z3cXT1QabCigNX8sniFXWNxczlGjnxEBanh0pQXUJUFRcrZbzRT2CLPIcOwd8gtNINHn3yKQ+EmDoFkLz8Slyrllj4XRhRT7GoqrESPPdmdO+buZbPpJVUC4/CoTx7YWvj3bCcPqpvHq5J6QnrhQwQpC7PyQ4TcOm0B1BqQPpS1twA5YkSOmdqbxPfhv80QqXmfwfECfDEuLGvhh2kg4pwdYWcwWF+xY3hgKoJO0FcXdnnVtjer5Rb8HUIRuu/2qJ2VH4dXL2y0igsx/glHygC2diR65xgdvMnR9BbSxB3Um25hqTCPN3Rs+9SuMp1C29RuNUHuik2uKlEML/cAIoiO5wxRpdhc49OYeOMKw/6Mrua0Drx5UFECkK/q+/7juVbbwUyTBlW2x59FmShbJDsjoZV5qjm345MaAQiLTkzbmf07ZGrnFBEyaVfERp6EVgaUEU3/NUxbXXI9RlUMD9lPx4l5pZ/OVJyI0BEFPJi30CycnHgG/CHL15fv55PtmmXdGGXnctQLetzDO6rsILJCvM1kVb6+OlDX84YhtRrTPJLjNQlH6JH/3X7JLOU8HSaDtuF1rPB1LjG5+Sla3vL237mpmkzJk5okxpa1eF6rf5ZZtv7hbk13FmKm96GnSCIyU2rW2B/Of6NOva1I6u/SIjcpJ+fz3RtFLWc32Qr1tMX1KuyGXGFRfiXjW4v/rWSPva5yuTDnFYChbphhpCALOdCwDGI+bJgaMBWuFctMjfBPxIZA/G5NSYZahLK9b1C1R401vd9MB1/H+6b8dRdkD4HZ5xT/TKrH3hdhxOPu+QtpzEPDwpa4MmYZ0szAyS4E2tCaHnmJj1ab/QWU0t4Dob Yv9zy05b 5A6/WO8tCc1L4kMbEe0ixgmx9U51w23w29xcNhLRsoYJ/BdX5YfVgpiffn0rbXDaLgZ3LhoMEyScfkzHPaYatKt2JLdcJ5UC8MzUTP4K/mYAxrP3XE92OloHWrL4JSlQOEh7kqPR4VkZvQEmJwOmOMW+5PCndpGkor6OFRPDdeXZ/JpIxGpHd53tPWENd68u5SlWZbI/2txH3eYcbujqCH5nR08jL242Fy/Po01JNPow9Xp1ULnjsQ4BlAyKFKX7eervVqrPUvJ8D49hnww37J0J9Xp00MK+sXWWz99pJOpTm7DvmZWKa7PGPFpKky8eWMu7DrZj5+2znWlbkeSQkkWDT1qDu+tTwmnO0vvmEMgIiSuhv1OgUiXilba6iTuSJ/zFc3b/AIFAGA0emwvC3J+JbQx5lZ6CoNwNw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 25, 2025 at 10:17:08AM +0200, David Hildenbrand wrote: > Let's use the new, cleaner interface. > > Signed-off-by: David Hildenbrand > --- > mm/memremap.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/mm/memremap.c b/mm/memremap.c > index 2aebc1b192da9..c417c843e9b1f 100644 > --- a/mm/memremap.c > +++ b/mm/memremap.c > @@ -130,7 +130,7 @@ static void pageunmap_range(struct dev_pagemap *pgmap, int range_id) > } > mem_hotplug_done(); > > - untrack_pfn(NULL, PHYS_PFN(range->start), range_len(range), true); > + pfnmap_untrack(PHYS_PFN(range->start), range_len(range)); > pgmap_array_delete(range); > } > > @@ -211,8 +211,8 @@ static int pagemap_range(struct dev_pagemap *pgmap, struct mhp_params *params, > if (nid < 0) > nid = numa_mem_id(); > > - error = track_pfn_remap(NULL, ¶ms->pgprot, PHYS_PFN(range->start), 0, > - range_len(range)); > + error = pfnmap_track(PHYS_PFN(range->start), range_len(range), > + ¶ms->pgprot); > if (error) > goto err_pfn_remap; > > @@ -277,7 +277,7 @@ static int pagemap_range(struct dev_pagemap *pgmap, struct mhp_params *params, > if (!is_private) > kasan_remove_zero_shadow(__va(range->start), range_len(range)); > err_kasan: > - untrack_pfn(NULL, PHYS_PFN(range->start), range_len(range), true); > + pfnmap_untrack(PHYS_PFN(range->start), range_len(range)); Not a huge deal, but maybe we could merge this and previous patch? It might be easier to reference the impl when reading the call site changes. > err_pfn_remap: > pgmap_array_delete(range); > return error; > -- > 2.49.0 > -- Peter Xu