Re: [RFC v1 0/2] slabinfo: sheaves statistics support

[Harry Yoo <harry.yoo@oracle.com>]

On Wed, Apr 23, 2025 at 04:28:59PM +0200, Vlastimil Babka wrote:
> On 4/7/25 06:37, Harry Yoo wrote:
> > On Mon, Apr 07, 2025 at 01:18:08PM +0900, Harry Yoo wrote:
> >> With this series, `slabinfo -r` now prints sheaves statistics (if enabled).
> >> Written on top of slub-percpu-sheaves-v4r0 [1] branch.
> 
> Thanks!
> 
> >> Q1: Vlastimil, do you want to integrate this into the sheaves series or do
> >> you want me to send it as a follow-up series after sheaves land mainline?
> 
> I think it's fine to do patch 2 a follow-up.

Alright.

> As for patch 1 I will instead
> export sheaf_capacity as part of the initial support.

Thanks! 'sheaf_capacity' sounds fine to me.

> >> Q2: 'sheaf_swap' does not fit into the table because SLUB swaps sheaves both
> >> at alloc and free. Probably split the counter?
> 
> I'm considering just dropping it instead as it's not that useful as a
> measure of caching efficiency? Probably sheaf_flush_main also doesn't need
> to be a separate counter as it only happens in corner cases.

No strong opinion from me.
Not adding it will be fine as we can add it later if needed.

> Due to ABI becoming set in stone we should be conservative.

Agreed.

> > Q3: Having 'Add sheaves to the barn' & 'Remove sheaves from the barn' counters
> > might help better understand the behavior? (just like 'Add partial' /
> > 'Remove partial' pair in the normal SLUB path).
> 
> Yeah that could make more sense instead I think,

-- 
Cheers,
Harry / Hyeonggon