From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87E37C369AB for ; Fri, 25 Apr 2025 01:11:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6E1D26B0028; Thu, 24 Apr 2025 21:11:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 66AB96B0029; Thu, 24 Apr 2025 21:11:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E5466B002C; Thu, 24 Apr 2025 21:11:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2E22B6B0028 for ; Thu, 24 Apr 2025 21:11:39 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 52245B71F1 for ; Fri, 25 Apr 2025 01:11:39 +0000 (UTC) X-FDA: 83370788718.28.23A4BD6 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by imf22.hostedemail.com (Postfix) with ESMTP id 7037BC0002 for ; Fri, 25 Apr 2025 01:11:37 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=E7JulyvX; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of nifan.cxl@gmail.com designates 209.85.210.169 as permitted sender) smtp.mailfrom=nifan.cxl@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745543497; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ge8Fe+xXUeyc8wI+dZ+opA/vYyipM6Dv3T3b1JEHI1Y=; b=Tj/twhz7W58Pwf5am/Q6L6rIgNbphK9a8aVBRxKGhiYs86thoScvQYbFKBDsqaAKKI0Eim VJFsVjinXt2DCJIxMvRIEzfL4iBHAQbcYAsVEkZxNJ0T2ovRtbdzZTsN0kvbUa0jRugJhp +lp7z7MowqztTbvwIen57hEKi2iiZtk= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=E7JulyvX; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of nifan.cxl@gmail.com designates 209.85.210.169 as permitted sender) smtp.mailfrom=nifan.cxl@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745543497; a=rsa-sha256; cv=none; b=1yN0r5MwMJWvECSjxeOy+a9M0R/+CRJClI0CPK0Bx5hZ80qdI8FLoiMmfVsTKxcOh7h8hC 6RPXu94SxeRjqXClTYzdLRWbHNXroBT/ed1EoUo+rKfdjxUnR+ryuOHCbpWntS6Sq3IYzp djZsKnklaAZgRUYrc68ebjs52/56ctM= Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-736b34a71a1so1925011b3a.0 for ; Thu, 24 Apr 2025 18:11:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745543496; x=1746148296; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=ge8Fe+xXUeyc8wI+dZ+opA/vYyipM6Dv3T3b1JEHI1Y=; b=E7JulyvXU7+9TIxJYZdBjelPm0AR9PMBuw9Yy2HVk9jNicmLBY7A7kNCCyZCCYQA8v u1YlwLU8C4xUnGjZljVcVVy1VqNLj8Cm2UNrPkGaBI+s/8Cq2CbSWddc1xcUBl/ZjnJ6 ijNE8l07JjggdYPZhxdGa+FxKdwhBoEUKBCzS/Jw7+pvidnuFJMCLr0ulT/OoC+PrOo4 9w3/JKF9t65SKnIP0/it7yX9uGUfNT8DHR0r1UmgZ3N6+3xb2zVM3BwImyRD24HyXO5q nVFtDVUV98BOpQ6GlDzuYOvULhYHMq7aTcswlgYSICXge7yShSvrdvUWeLKZtC6BgIOG hTLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745543496; x=1746148296; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ge8Fe+xXUeyc8wI+dZ+opA/vYyipM6Dv3T3b1JEHI1Y=; b=EPSCbZMo4z6c26KPUQw/nlJfTSKEM9yMmgSkSIfonEt15/7pKu8lX7iY9hQnyQ6aeH aWOF7hAvwb+4GceHc8kCbuniBWA9bQAPVAubGymCThhURG6H+GWxjNnO1Ufc+L5gFeBG JkMTF8wFMSDqFEg5NbAxBlrdAt1cXR4IX9j6enRk95TW9uN2lQZYIQFXxyu4UhJW17vB knQk7YvmJF7lZOzeI9oDEJ32rqvTduEca1ERa4Z9tHGHPAcH52uyLfYM7yPSHb0btjLw Gm7Dw3n3rT/OYkdwm6sYas4dBNOOf+pHwESzceMldeY28Ou3hzOMmDU4Ma2Js3UgRbve 5Xtw== X-Forwarded-Encrypted: i=1; AJvYcCUbVwGLeZq/iq5+ZmmrSUOe0wld5+WcQhPOsfgmarE6fhJwb2vIcuR4GJT2gTjXNHTiBbA/tg4FMQ==@kvack.org X-Gm-Message-State: AOJu0YxDeX5qDP1pfNTNqE1ENwbEYL9oO8BSJS3yKtz3b/BqehOyZisO 7C2RNPQ5rudoI62Z8WNbPde2GdLoUrrptMaotdyHEav299SfGDgB X-Gm-Gg: ASbGnctBJkmpOdiZeFyWWNcTRv7B/ziSTeSHlgDCPVNP02NcQHvcnWfVc+ltXy7yGYA pQgxArpweODy2at72DXkzIUkjxRCfWmNk6dgmCa4ZI6u+nAZbfob+vIkAe0y6KzKnak6u0pF49o 4h9BRXhtME2rIiLNsvs7+kl+E2VYGmgmNy1T6ms6nyUMAKkj7sGJaTtev8naoCs13NiiEC8Re// 1/arvAIcbeo93OmbYKteDGIjNQjbwtoYm2fxltHkOTgVDw2TYJ0ukw9rZSRqbHfdzeUojOPpBP5 eMBdbF2xcH+JCAzsI5yC6yLMKbCnRPf+z/7+ X-Google-Smtp-Source: AGHT+IEku+l/IAsrFLZrckNIk23qa9ncCWxvsS8RMhYBbtiMTQqeoYXstndm8reR/eyupZgVm+GazA== X-Received: by 2002:a05:6a20:12ce:b0:1f5:6b36:f56c with SMTP id adf61e73a8af0-2045b9f19bcmr467470637.39.1745543496340; Thu, 24 Apr 2025 18:11:36 -0700 (PDT) Received: from debian ([2601:646:8f03:9fee:5e33:e006:dcd5:852d]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b15fa908a40sm1868105a12.47.2025.04.24.18.11.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Apr 2025 18:11:35 -0700 (PDT) From: Fan Ni X-Google-Original-From: Fan Ni Date: Thu, 24 Apr 2025 18:11:33 -0700 To: Matthew Wilcox Cc: nifan.cxl@gmail.com, muchun.song@linux.dev, mcgrof@kernel.org, a.manzanares@samsung.com, dave@stgolabs.net, akpm@linux-foundation.org, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sidhartha Kumar Subject: Re: [PATCH v2 1/4] mm/hugetlb: Refactor unmap_ref_private() to take folio instead of page Message-ID: References: <20250418170834.248318-2-nifan.cxl@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: 7oqr6qc4tm4nxeuinkwpp649mcbecy9q X-Rspamd-Queue-Id: 7037BC0002 X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1745543497-606536 X-HE-Meta: U2FsdGVkX18EEiCcRNevPqsI2X4Oy7GUMivRGkePH9ByZ8fFGFcJjgVOoUW7xaiSBNH1HxJErujyEcfcO8DhgLouyoC341+zGVBSzUCJ1mCr5iRow/Cv/gDniYwJS46Ymt2XqRiN9PjkvRAUzN+qxyA0UuPMhY7fZ0wW69RIR04UgUDE2W8aH79+ANZFy4j2UFX+Fom0XT/djDLdbxPGFeraTt9E9cPCJxIV9iTlBaskYFjwOF8AoJL5XuOyeMH275mMeeQjtETZRIV8LvN/b64KUuTmy86bPoU02fk20U669xD03xvJ30eSPbm50aG6XyOqrFlfmAmw7hgVJzAiHPdAO0m6FZMxhB1lpXgRP/4MZp51N7zGDMgxybSfi/pyFyLeSG0TK1jKA30MlI93WvcNx3/tcESsgAM0WR0dqSwVeB4383krxWpvb27jB2HISjM54dRohsO/cywWu0Zia+7GWQaeAOp4EYSvTiLNbrNSyhOGoqRzYs309iwoyMfpj6WuDYAP4aC5haYOrpPDPyUf6LpZWy0bPPD/WzSo4S+LKV2uXoIB7jxdXINubuj4sN45P3xtI5qAX7zWhg+JxpW27+ZntIKWQTjQ4UpJS+YEUWDxsSa/vraUZQQgm8662vECiY5qoM2xp/oaxCrcXbxap9s4y5arsoLpE0iaga8eFQtS5dDobd9dM67vd1yKGY8BKZxDJBZFmn9NaN1a/uVJGFIZic2fM3KTrx0lpvo9I16I9X2nLLDnDobootZ7XvoiuTrjBlYhs8kcwKpkfkxHk2WYi88RTpTTwItI6SzUQkMx9KOfaEqnGe+Z3e80MU4U+GhicSDhOgjIZGm+TV78t3rqYBJRYdrnHjrSAtaY1hu8vCDwEKpIYLk3kMo2LE8+FJcQZhTwEnKR8EX2jXLKcvM69SoGGjy+EUtuCacyQoEaI0EVUUVypwdS69GnLwp9A8kxbwiFkgbnKyO AW/wIt26 7mBvKSC5CzfulKZRVnLXascqzbtHa1O6119ezgI1PYbm7iRk0V8A75pQUFEkKZnDaAbyaJ2JqoOSVv6Gk2EaN2Kzsumxip/3+jp1Dk+s8xzDqjWXuq2SQR3VvvYSADhkkfcmWwjBuDLN7sxfyOP2GOVaRn7lRi1W/9Cru2pqEMIrMt9oXwTdpLChahB1cU4hHis9UouGBWn2FlBE4UCJHgdLIhOtWiXivGpW1u60LjRl5a55qbAYTBLc19jOoZPDWogbUypYhy+vEEu1hRVcVo1WdWWoY04Qtyqk5qXrvAo6ubjWERsMSGtK+hrF6bqOSlXAyTAQnHCXAVl1o4/qqXFqNitu9n74ZxfXSZbDpPU49rPZgHMwc3Un5JVx3PpNMXf8wjbbZL8mKBL/k/Q9K4YE/M2x2WjFZpeyTImqAbj9t88BbQiK467D3d2az3CChEsZOmiUOTH0dR+tw1Vcxug/5NIZBOHywOwYKuSIszdjzASrpZNP64jFXXTb/FnRIoMS5Rxg/7H/YBCj+4ST5flYHumlgAeQlEOtnZiQKurDKNuygb8fGI7MWuF25nchXFz0L1QsxDt5T6P0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 23, 2025 at 04:17:25AM +0100, Matthew Wilcox wrote: > > With regard to the Subject: line, you're not "refactoring". You're > passing a folio to the function. Hi Matthew, Thanks for the review. Are you suggesting something like "Passing folio instead of page to unmap_ref_private()"? We do not change the behavior of the function, but only the interface, it is kind of "refactoring" to me. Fan > > > @@ -6108,7 +6108,8 @@ static void unmap_ref_private(struct mm_struct *mm, struct vm_area_struct *vma, > > */ > > if (!is_vma_resv_set(iter_vma, HPAGE_RESV_OWNER)) > > unmap_hugepage_range(iter_vma, address, > > - address + huge_page_size(h), page, 0); > > + address + huge_page_size(h), > > + folio_page(folio, 0), 0); > > As previously, use &folio->page here. > >