From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E052CC369CB for ; Wed, 23 Apr 2025 22:14:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4731B6B0008; Wed, 23 Apr 2025 18:14:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3FB926B000A; Wed, 23 Apr 2025 18:14:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 274A26B000C; Wed, 23 Apr 2025 18:14:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 03F2A6B0008 for ; Wed, 23 Apr 2025 18:14:41 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C7BDCB616A for ; Wed, 23 Apr 2025 22:14:41 +0000 (UTC) X-FDA: 83366713962.08.FB9B613 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 81483100002 for ; Wed, 23 Apr 2025 22:14:39 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CvxriTvY; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745446479; a=rsa-sha256; cv=none; b=5a6bDqLluIDltOeue1n+3/vzPrOqhZnNTqYcII8CHcipCpS76OBVjoeuJI6kBK9CTte8Kg 2wrb28+Fp5j4UDTwcCdwUPNN2a2mNyLKC1fcEdhqiHVUnd/DbfNCUJNV4J8SpYkI6+nolJ LdmD+9RdTF/2zkh09kESgb6u2E9I3nY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745446479; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X+SVN4y1JKQSP55HTLXPO4iRpA3jkVvTn+JT+tIaCQk=; b=DjADvm9BCKPaPQENsIgUR/eWIuViCIvEou8Mt6oxNBhH1mNkbSmVS+27/B4QRtfaouWt5t 6NBr9orcrdteVWPKP8KAsUtep/48sSWa+jq/DU3PnBDMoefGJQJJbgXV2rHrMfWqAoO3Bl OtAWaQRagY2FGp8oBsqUA2/HB5ZBVhc= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CvxriTvY; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745446478; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=X+SVN4y1JKQSP55HTLXPO4iRpA3jkVvTn+JT+tIaCQk=; b=CvxriTvY/g1g/pPQTzhPYnTHthl7lA2QU3ibSnqNec0w9zvszuh92hS07jDQywcdVRrgei qgSUggNirP7AAGKIyJLvGxzKYicYNf/T/Q6FGkYjpAWoww3CdJthT6JajjECJQuSHk+Vh0 H3Q0YG7F35yv1a18lXUEJgacOSB/0Us= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-691-5ae1yF4jPuCd4XqLNHpXcw-1; Wed, 23 Apr 2025 18:14:37 -0400 X-MC-Unique: 5ae1yF4jPuCd4XqLNHpXcw-1 X-Mimecast-MFC-AGG-ID: 5ae1yF4jPuCd4XqLNHpXcw_1745446477 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4767e6b4596so4934631cf.2 for ; Wed, 23 Apr 2025 15:14:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745446477; x=1746051277; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=X+SVN4y1JKQSP55HTLXPO4iRpA3jkVvTn+JT+tIaCQk=; b=JLXM6/U2FGf0nKJYvsNhXyH7mvzEAO3n06HsDOb/9SH7muQktZS5sPPy+BfgDOpaUc uevAeu4IEar8CCx8kORsF+BySGASyZ6Dfp30exlVVp0dozwDoIUdJ9WyybOJkTTkx9gc rX6wGREMo8jy1t1wObomTiHG5akx80T5Qf58ND2zRndDtiMU/I4WgfVrIqQs76OExc4R NH2fdmgP/OJWNlzljNzgSiiNRUJamx6wWh7mfa/78NH+2Q/mQxU1khIeCH2N2JbK/Znk RPcRC7d7UDQ5OInv+CFbuLqf3yzmAs9dWm1OZbnyJumKUbVl+m2RB6e8lJLEBQ1KR2Bw KNog== X-Gm-Message-State: AOJu0Yyao22RNj6SvOXd2Rc0Dtz39Fe9MsTl0U5qCCBL+zkY4TweSz5X WzW+uV2VwX6JvdAJgaH2w1Zoiz2iuNVkDamyKMZELOMJoEpMVMgl3dqs+O5xHsrS20cxtudnnck 3sYEqNqtr2nRj5qqjpEpEDLAR8CveR0F0SSqbfB2rfvFjLkWh X-Gm-Gg: ASbGnctjoq+4L1TD0Cc8EmPpCOmYDSv1cHTZ7VLRNXJ1jXKd1SzEcbOSXLaZ+2jrbuQ qBbv+x5r9ZZqi5eWATFMYfHtpqwKbmefs7Lf2TXjpYoR/cTKGg+q+iV0d5TeJaNWrVRt53Re0ic POXP3KUcqD35DzCrNmyftpBuKCap20oeRJPkBKqqpLL0Ddl77bx7R31zTGSIjcnqk5gv17tbGQn z3TQ0SoKj0l8phdbw2M6cXMDoJt4verPBoOxAnkTfiyII5lJPdps3q1HKKX36I+66X6pGuXyVak 350= X-Received: by 2002:ac8:7d96:0:b0:477:d00:b46f with SMTP id d75a77b69052e-47eb52b3fdemr2212361cf.43.1745446477115; Wed, 23 Apr 2025 15:14:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGQUt9OkSCwidgJV/Cvb/1qDknNRPIdRwt+RzGozQl9XpNN2HI+ThdD0/kcioZXw7xqh3K5DA== X-Received: by 2002:ac8:7d96:0:b0:477:d00:b46f with SMTP id d75a77b69052e-47eb52b3fdemr2212111cf.43.1745446476829; Wed, 23 Apr 2025 15:14:36 -0700 (PDT) Received: from x1.local ([85.131.185.92]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-47e9efda31fsm1710991cf.18.2025.04.23.15.14.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Apr 2025 15:14:36 -0700 (PDT) Date: Wed, 23 Apr 2025 18:14:32 -0400 From: Peter Xu To: Marty Kareem Cc: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "akpm@linux-foundation.org" , "shuah@kernel.org" Subject: Re: [PATCH v2] mm/selftest: Fix race condition in userfaultfd dynamic address allocation Message-ID: References: MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: NEu-dtMr1jz4cG4WrwnMEEIwRnhsur8qPmnkqnhfVnM_1745446477 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 81483100002 X-Stat-Signature: iejyxgyf1hx64pirfutu1nebi7q4efjo X-Rspam-User: X-HE-Tag: 1745446479-927530 X-HE-Meta: U2FsdGVkX1/RK5hVa8r57s2uP2U2E4WnioOV37/EqPvRh287pTqwj4vm8AvqQe8KJr+PRN1CMtafVn+XJaU6ekOujyMGJuRUEqDcAomZvMsDY65erGKgD1x2AF86k0GLlBnqKXrrRhv9SvHNIsHjaTSBeGX/axUCCAgftixOudrE85M52CwS3sq0t1Eq02Kllhq3PpERMyQps96gL1ogS2+L9edOnx3zl1ocyzlhpw5ErqHp6mDMx0PFycky61gmHYPGclkyJ3iiqZ3rI5lCEm4shlufIV7IMMpwdN5flrtjZUnfctRZMRF8DeAhR9JOFZjV8lv+iKa7rP/1Fz+lo3tFso356QJX6q1LOlgMOH73ekGNixOXvXYaP2jCqg9Rd0Uc9njTdvCLqh5KYQHV6SwEpkYnvKeWEnu9TvChFhbxm6VD04bmt8nPiRRiQRYtY+3vn7Zi6GyzH2+Mz5TIUkGWu+kUCiCpcwmcCoWaJt2/EqUSgli3T76pOJ7+2Ebqjj/Qh5ZZCrpDfQZYe6ZRQHLGD0cfiQcpE+PyW//Czrl0ycAq2iwg178KAHEdauZBB/vbIAYA5WHQQlEqkHVVyOyA2M9hTlXJ6zBzbClWg3xcYzC5S53DXeRsoKfhilKnolvP+Qd9rdqf59b2rmipb4HqlL6Ydtq6uil834zw/RCGKMTfrJU0SC2BVqaSSFW9kn71tGEiYgc/OKplqQ20Pw8CFl1fn4bUFN/AelqZmE6uGwV308gss7UupYiiQ3XiTOZp6ONnnAzlakcFs862G98Hi1gcwh3N718rT2r4tj08y5gjvZb4nBB5Ba9USWkQKNCG4FUxzsRlDhXU8UB+WQjZ5muBJdnCLAL0qW6DvUMN7btPy0Z5OWYxueNm4x76e88gJd6oipaA1XIAHx44Z3aJbiwWgSa3fwMw5DSn6G+UKrQQrknUU2cBCEda9cCwgQJ0niJKBtrbMDJswVz pMjUTcaJ JGFLpK8ZEHmRDRaXCIMQyPOKkpSACjTag7z+bhvxzpbzsROnxu3Syi5TC2FUS9f6kcPJHn8IQLrthtev1lftqICjm3199OHecLE6bxxSaswAjm0f0Cz/ghiXMv/8tkDHBl/ZKIwN7FPxdrH8AfFcrAg7qLMDVFhFGN5idA3e3+PD/nkX9edz+OTmRzvs+CwaIyq4wvCPt4FYLjlkTATUOphf3u24EmR0rfKqNPhQlqumKLW2oFrYGDBBz0bVDg1i5T9756h9+wfqQwV/HsrlCTRCVMEv1bdK/qtRHcXegeYT5KhQy5Asrxw+RJx77sgTd4+5DdY6SA9bpMqmhlG+yqQCpJKiw3axZF6Vt5hriZ0LdEEXX53euQTev+zexWFZi7NWXNeyzqWf49J7zGGD2axXDdM199ShTbOMU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 17, 2025 at 06:18:55PM +0000, Marty Kareem wrote: > Hello, Hi, Apologies on the late response. I was on a very long leave, and your email by accident arrived right after I left. > > I'm writing to follow up on the patch I submitted regarding improved dynamic address allocation in userfaultfd tests. The patch aims to prevent race conditions by keeping temporary PROT_NONE reservations active until they can be atomically replaced with MAP_FIXED mappings. > > I sent the patch through git send and I was wondering if you've had a chance to review this submission and if you have any feedback or questions about the implementation. As mentioned in the original submission, this approach makes the tests more reliable, especially when running in parallel, with minimal performance impact. > > Thank you for your time. I look forward to hearing from you. Your patch v2 doesn't look like to apply to akpm's branches. Are you sure you generated on top of a correct base commit? Meanwhile, please consider sending it separately instead of replying to your other versions. You can send a fresh new v3. Thanks, -- Peter Xu