From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBAF0C369D1 for ; Wed, 23 Apr 2025 16:33:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 489EC6B0083; Wed, 23 Apr 2025 12:33:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 43A776B0085; Wed, 23 Apr 2025 12:33:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3275A6B0088; Wed, 23 Apr 2025 12:33:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 13FB66B0083 for ; Wed, 23 Apr 2025 12:33:55 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C5C65B9A6E for ; Wed, 23 Apr 2025 16:33:55 +0000 (UTC) X-FDA: 83365855230.25.C3DB402 Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) by imf17.hostedemail.com (Postfix) with ESMTP id BBA2B4000B for ; Wed, 23 Apr 2025 16:33:53 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=IUgsdMCW; dmarc=none; spf=pass (imf17.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.174 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745426033; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bCNtGsQ5GiTaIBuJArPjLavQ92rjl64A1xom0cF912I=; b=e/hmAnIA24U+MPp63d0gRSZSBpOgf+rBQD7A5wGWS7QgvvqXa2tq8Mr7pqwv6GoVfEYiXo zIe2HppGBfMDBibD+RjAw4Zxz5aaqVp0GjLFNDNSINcz47YEoDKD3tEPpzc20bkiO28KXX URRlZ4tzRRuuIrwOoy200ysqkvdG55Q= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=IUgsdMCW; dmarc=none; spf=pass (imf17.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.174 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745426033; a=rsa-sha256; cv=none; b=3zojk8AsyX6FZOSFRfkj704uaLwwPsUuTeRivFtl4tUu4EwTKmKHYoGlgGfUKnTz6NbP2x BrYOvwYjGESei9utLEYYjPJ8Gi10zLfF+o9kDoSZiWiXXF2FzPJhiWyUtDbUicFc7r0/Hu IBQaewS5HRq/X93Qs8dlhhaZoiO4icg= Received: by mail-qk1-f174.google.com with SMTP id af79cd13be357-7c922734cc2so7570485a.1 for ; Wed, 23 Apr 2025 09:33:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1745426033; x=1746030833; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bCNtGsQ5GiTaIBuJArPjLavQ92rjl64A1xom0cF912I=; b=IUgsdMCWjfv3iJhFLKcrKXjeqQf3bAQljEyDa3SebXlOTi3eHaNLQk9Ku+3YtxpFuw N7CEzl6lqSYu+VD9gOs7e6yTp6qZARter78vAecH3mp6HYEUG/d5vbkzjh3oMjxU3JIP 9hfsZRMnoPkb/G/cRyvTKdtzjUgsBMgmbCIF7wqP5Tv/czPZZvAzBejjIuDd732N1b3x BHZy+Xd9F3J0B8IBk1m2uDCI00Hie9WwCaIGR9cU892zFJzQSpuKJdQFrfKXA6Yxrewm VNbperC8ZxMIyCBLAaK29iIOJj+OzouOuJWK4tCvNIKIByAt04tvCytie8QhY3+GjGgV DcMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745426033; x=1746030833; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bCNtGsQ5GiTaIBuJArPjLavQ92rjl64A1xom0cF912I=; b=OX8A6tDkADV+oqPysKM9RG0SkDhfkaj/cMmCNytjfjGGKUybtGAdUyf08bKNxBSYnZ jk1UoNrCUndjDo+SiqIQJm8DBdbRCbKSSlxklwGI+iVvo/j3koKBuWjWjLyohyee/v0c g8MsYZwHvMnA9RQAgvv9E45GKBbN43v86oA51C0K7YZN6A2KA6Hmr2Wg/rH27rWGdCSW x0D8QTRw2AsCVaYfaMt1TWCmKqilBkHObUqwSRid+Fgy/SIkX9RSCAazhdOi6hNcDqg1 XPtEI+3eH1h2itupmlEPNhUty7mfGgzWaVRp5ijvwneezZ/TfIyDOYQdKBxlsPzKdpBN 28Gg== X-Forwarded-Encrypted: i=1; AJvYcCUyG+fbYaOQvLAMvmhFVL6gY98yB9NR8dlQzU+EdHdalsDpFwBNdPhcrq8gKZH5E5WOxQb9CQEFig==@kvack.org X-Gm-Message-State: AOJu0YzlZ4q9WueqsUwRrFqYTTidjqlrFRleK7+tlVXxKy/+aZO36rKE qlEwdFBJwG1bztBsM2824Wfm0d+khvz7xlk+K5VEiqXwT57oF1serFNp/ERl3Cg= X-Gm-Gg: ASbGncuLX42+MuGbk25Eobv/q7rG8IPGK8oGityE3KOclTeW3PepIAMVDfS4NCyqaye 3doLyDON42RB0CEWDlpNlLYUj9YFrZq3rvZv9lbzAd6RwrctwIyf+5MEoZBYFLgEg/7SBjbFihE ojpmLVeK8XAPYi/Va9MDalpl44jvmkH7UhwC01/siqdxmi3IThBsKZsc7FPPpzYxGISn6yg++Zm xnks+l3in4XtvsAQ2wMxbSHjW62CkaxrZFUwMHPGnrFI1nk8b5teSWiPg9kD6GetM/n1WwzQbf4 mMlLfp5zGSRXGuan+9w7J4fvA/kqOJWBBE1Ia9tYDI/P+IpOcsUMdoqpnLqwDWXWsXqhFzu0dG3 vpqpgtL6ENsurLeruSrXp3VaiFli+2wzGdw== X-Google-Smtp-Source: AGHT+IEXXa/SP1vcBYCngnvdcxcDUG3M7rtCWaP8VHBCa5k1RUmFf/E+UnlXZTp1S7EeoNVsSxUnVw== X-Received: by 2002:a05:620a:d86:b0:7c7:a536:66d1 with SMTP id af79cd13be357-7c94d813726mr525145285a.6.1745426032758; Wed, 23 Apr 2025 09:33:52 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c925b6e10dsm697314785a.108.2025.04.23.09.33.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Apr 2025 09:33:52 -0700 (PDT) Date: Wed, 23 Apr 2025 12:33:50 -0400 From: Gregory Price To: Dan Carpenter Cc: Rakie Kim , Andrew Morton , Honggyu Kim , Dan Williams , Joshua Hahn , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH next] mm/mempolicy: Fix error code in sysfs_wi_node_add() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: bsohcirg981kd7aa6z49yc3ktssa9bup X-Rspamd-Queue-Id: BBA2B4000B X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1745426033-487988 X-HE-Meta: U2FsdGVkX18UFCqu0kTC9QISQiVMLzwAhW6kAe7OPhh8wemTW+Hvc7t+j1kZPg29NgLEtey3CAhG4l/SHE0UuHj9gIsjux9Wk1acolQob1p9kxZIJ8/bogPxlvd+x6D57kgFYaAgnDBM0cEFcgU61eQoZ0wLLYJ1LEwxgvjIw0ufVUrRA3zs+uu+P0/d7JtKiCzbSOdiwGUM722RfoBMLE90BNVuo6NUy2ZD28nwKQGj7xOqJjtG+sB3rZt6Erzzm5hDGov1K7Vyei8/6WydVrETcvxh2uNJmK0YIPWPX1N5PlfS4tFhhoEHHPvOrmGdId2pFyTJM5xgsCN9y0ccOomcAaN2VyBTfTQnmZBzN/f+NapihyMRtrbeMBUBM8BGaZ21oDWghnvyVhjvwxT3+knBjSArGOV6Jebel5xlfPrjo8r/Drh8dLoYnnD5b6rbHA7LnXF+2+BX3TBJdvfFfwVJDWY47jxBYDhCFFsXeqN1d0YzQ1HFRIpurwf/llHc7Lk9dEe2mk8Vdmaheml+637ehFnvAUSotckc/zkiZui11vf02Ot/1ZyEYnQaKc9uIteCFPUqSrlIEQkE3zmGE7q+Su6PrW1ToY7eVoEg4qJm3H9h0NC251cwzdi5ZQLtP9gzuKL1O+GSN/TO1GaWV8/h79kWokbRWADVHe0tumdUys1T6colwQaNBBoeVdOc18/Az4giQgfGdD0M5g8TmDy6b/Kwtqn7+xqJAKuo9SFfQwhPfVSYMcrjgVP0TzLgtHgaz88iHtMnuqF8PrsqBQ3IJYrzE3hbaaRgFQbI92SHyeJ2p2wRjJBtBUdz4Sj8OpPqTFOLR9T5k8odvUVOpWaC9uGa61X8t+ExMWJPTbkwgwEiRKJbGtlfYD3vKib1wDPwzzBDp3qgVOaLqc/0WTGW07oKhGzAwGlB/u4I17moztJBVpYdBJYEOlYsEOC1hG+0OB9kOost6WxHEGW 73TDuWYQ 2YNr/IzEDhv1BWO64WFhbpDcqySL//rLjXDZtYGkC/w6r8GbHmY4b9yDAK6wDP5e9GbadKLelRy6dUQLF72rNDBRW3pZBvpmanxFs2dYaTaG2MF676QYDVJ4oIKp/1DiAbG5eOu4zKQquTpcMNwv1Rs75TEfhlb02+z4AR6PHJGqFvCOJxEoOZLBtLcg+fTIHRBqyyVciFWe5n7CmJXd0UVnkuy7QzF/QGeskqz7umErQcXD6GYMe+8wxUj5+lK71xUOFgDOnd8+9+FayjNWi53JK27ROZxOU+2j+gs3BwLmLh6/wUzyfe4o5yRkM29qI6zhAjSaF3INPn0kAzC705pI0rnjfjcZQxtD3luvGmVTC8r5iuYURIcBVQd41a0NBXfHmsaGRI9DNPb7B2p1X/l1DtDdN7OcKD6Rcou+pbFkHuVVHjJIbkoujruH0fVR5ncnupOM0IpKR1U/0VdIWSVeJut42u590pa5OVpP5OaozPGbzo69rztfaCg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 23, 2025 at 11:24:58AM +0300, Dan Carpenter wrote: > Return -EEXIST if the node already exists. Don't return success. > > Fixes: 1bf270ac1b0a ("mm/mempolicy: support memory hotplug in weighted interleave") > Signed-off-by: Dan Carpenter > --- > Potentially returning success was intentional? This is from static > analysis and I can't be totally sure. I think this was intentional to allow hotplug callbacks to continue executing. I will let the SK folks who wrote the patch confirm/deny. If it is intentional, then we need to add a comment here to explain. ~Gregory > > mm/mempolicy.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > index f43951668c41..0538a994440a 100644 > --- a/mm/mempolicy.c > +++ b/mm/mempolicy.c > @@ -3539,7 +3539,7 @@ static const struct kobj_type wi_ktype = { > > static int sysfs_wi_node_add(int nid) > { > - int ret = 0; > + int ret; > char *name; > struct iw_node_attr *new_attr; > > @@ -3569,6 +3569,7 @@ static int sysfs_wi_node_add(int nid) > if (wi_group->nattrs[nid]) { > mutex_unlock(&wi_group->kobj_lock); > pr_info("node%d already exists\n", nid); > + ret = -EEXIST; > goto out; > } > > -- > 2.47.2 >