From: Matthew Wilcox <willy@infradead.org>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: trondmy@kernel.org, linux-nfs@vger.kernel.org,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org
Subject: Re: [RFC PATCH 0/3] Initial NFS client support for RWF_DONTCACHE
Date: Wed, 23 Apr 2025 16:22:22 +0100 [thread overview]
Message-ID: <aAkFrow1KTUmA_cH@casper.infradead.org> (raw)
In-Reply-To: <c608d941-c34d-4cf9-b635-7f327f0fd8f4@oracle.com>
On Wed, Apr 23, 2025 at 10:38:37AM -0400, Chuck Lever wrote:
> On 4/23/25 12:25 AM, trondmy@kernel.org wrote:
> > From: Trond Myklebust <trond.myklebust@hammerspace.com>
> >
> > The following patch set attempts to add support for the RWF_DONTCACHE
> > flag in preadv2() and pwritev2() on NFS filesystems.
>
> Hi Trond-
>
> "RFC" in the subject field noted.
>
> The cover letter does not explain why one would want this facility, nor
> does it quantify the performance implications.
>
> I can understand not wanting to cache on an NFS server, but don't you
> want to maintain a data cache as close to applications as possible?
If you look at the original work for RWF_DONTCACHE, you'll see this is
the application providing the hint that it's doing a streaming access.
It's only applied to folios which are created as a result of this
access, and other accesses to these folios while the folios are in use
clear the flag. So it's kind of like O_DIRECT access, except that it
does go through the page cache so there's none of this funky alignment
requirement on the userspace buffers.
next prev parent reply other threads:[~2025-04-23 15:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-23 4:25 trondmy
2025-04-23 4:25 ` [RFC PATCH 1/3] filemap: Add a helper for filesystems implementing dropbehind trondmy
2025-04-24 21:30 ` Mike Snitzer
2025-04-23 4:25 ` [RFC PATCH 2/3] filemap: Mark folios as dropbehind in generic_perform_write() trondmy
2025-04-24 21:30 ` Mike Snitzer
2025-04-23 4:25 ` [RFC PATCH 3/3] NFS: Enable the RWF_DONTCACHE flag for the NFS client trondmy
2025-04-24 21:31 ` Mike Snitzer
2025-04-23 14:38 ` [RFC PATCH 0/3] Initial NFS client support for RWF_DONTCACHE Chuck Lever
2025-04-23 15:22 ` Matthew Wilcox [this message]
2025-04-23 15:30 ` Chuck Lever
2025-04-24 16:51 ` Mike Snitzer
2025-04-24 16:59 ` Chuck Lever
2025-04-24 21:29 ` [PATCH 4/3] NFS: add RWF_DONTCACHE support to LOCALIO Mike Snitzer
2025-07-14 6:22 ` [RFC PATCH 0/3] Initial NFS client support for RWF_DONTCACHE Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAkFrow1KTUmA_cH@casper.infradead.org \
--to=willy@infradead.org \
--cc=chuck.lever@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trondmy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox