From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 811D2C369CB for ; Wed, 23 Apr 2025 14:59:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7AB6B6B00A1; Wed, 23 Apr 2025 10:58:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 70DA56B00A2; Wed, 23 Apr 2025 10:58:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D5E16B00A3; Wed, 23 Apr 2025 10:58:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3C2956B00A1 for ; Wed, 23 Apr 2025 10:58:59 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7BC0980D57 for ; Wed, 23 Apr 2025 14:58:59 +0000 (UTC) X-FDA: 83365615998.15.E73FBA5 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf03.hostedemail.com (Postfix) with ESMTP id C854720015 for ; Wed, 23 Apr 2025 14:58:57 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=rNAIeayX; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf03.hostedemail.com: domain of kbusch@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=kbusch@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745420337; a=rsa-sha256; cv=none; b=gSkEw/hBesjXuX+6j5M1htHeTs471i/1RgfocbirwTsgQTklsopDcFkb7nz1pnKuqAH+OL ZWqf7RdTDPCJxM03XTOYAziP0lb5QAFqwzEKxjRHxXTSDHcC9fBRIE2VXAkuYf95zP7Awg IcG3BwYasMK2ty23g9mDHTaNN8wBfSE= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=rNAIeayX; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf03.hostedemail.com: domain of kbusch@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=kbusch@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745420337; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=01f5gBau2cIUg3e6dlBkZrq8kUYqCcrB3MHd0HW32sc=; b=09OfAqx7CC5c1+dkmWHfkKNaQA59mdtDwyOm19IV3osQm3NX07XgBAQ8VID7CrbKIloZyo u4pb5OcBqarl2nRXE71rQTxtbr8TIwUSxJ9JHY9q0cE+1MuRwGHrUXfEG2a35vBMmBGo8c Y4mCIUr+1JRYKSwumGtfdslZHbO3qLk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 03AAA614B6; Wed, 23 Apr 2025 14:58:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3E6EEC4CEE3; Wed, 23 Apr 2025 14:58:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745420336; bh=Cq/9ebClxlVbVqFqG5/6zORZ18/N3r0Ih3h4rsgmibY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rNAIeayXStayTh+kdSzMXaruBcLJXQoaQdrPfgYfteRcWk5W3bpzX/9lOPNmTRawT 3Js8n/jzA0KcrggLtIDYykZlPj6Dez+Yrx3Z9APc1t4hhfKysBTJkG0duPuNwBnGks 0sGpxPSNXrScaZ1ZIlrdsqsiEWDsoZMPg15dosv1MW/ySTAaOgCmQLtKdBwGsHiVTZ 1SBYhdxbfYY3VuqejbFMedI1znQqqlAc4ideI8ClyIhmPZGcJE6eB6IQ4iR3ICvNqX aQmYnghFpNOVpmT0E+j6DR29WFQtH/r3ajJ27yThOcM7hr5AG84maPgUId3dJkxSan aVj53L0H7Llpg== Date: Wed, 23 Apr 2025 08:58:51 -0600 From: Keith Busch To: Leon Romanovsky Cc: Marek Szyprowski , Jens Axboe , Christoph Hellwig , Jake Edge , Jonathan Corbet , Jason Gunthorpe , Zhu Yanjun , Robin Murphy , Joerg Roedel , Will Deacon , Sagi Grimberg , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , =?iso-8859-1?B?Suly9G1l?= Glisse , Andrew Morton , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, Niklas Schnelle , Chuck Lever , Luis Chamberlain , Matthew Wilcox , Dan Williams , Kanchan Joshi , Chaitanya Kulkarni , Nitesh Shetty , Leon Romanovsky Subject: Re: [PATCH v9 23/24] nvme-pci: convert to blk_rq_dma_map Message-ID: References: <7c5c5267cba2c03f6650444d4879ba0d13004584.1745394536.git.leon@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7c5c5267cba2c03f6650444d4879ba0d13004584.1745394536.git.leon@kernel.org> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: C854720015 X-Stat-Signature: xgos84k6p3csyytxtawozphfwd6rhuc6 X-Rspam-User: X-HE-Tag: 1745420337-363828 X-HE-Meta: U2FsdGVkX19R5foLCKHGJRTXxH1cHtsXoLL6d3jArjZjna4Ob4h4SJmyBs+Vd5WB4SiJw+S4yo9UdE849dIAMrjFl4F2rPVUTdvY9q8qWEwlUnOEnA4WTd7Plbx4qorEY2pPWGCLf6fmREfEzt+tjzjtUvyIWf5JtljI+CxTkBvzF2v7ZJVfGKH7r2tG0cbXs+bDxi2lBjT1YFmHPnFCXHJyHsOx0KigFN4MML98SaJBfFZYTWSKMdyRKm9Y67MSAlY/2N3e9Ev9B/XGlzh1FXCFmy4AfPOzPo9ZKv+SMvxI3Y8QRRSu0s+7xFB2LY3jJI4Zjm6IxXDpe2TxbQ2DVthrp/pdX/z/eMKsWyvL07u+5QeNBvQK1jyISEciFc5axOGvWVGOD69Zd3EG8p3+rcl7MmjksUnqP8E8ygfMOeP1ZwciNwacKMfX/e6SDlJy0fqGjjStfqQuUTYNcuoJeVSw5NyJkK30KIvzJdQcu6ph7KrhUNbOAmM2BQrb6LSGTy6bzmQgQIPyhp0z+enM8V0E0OW8Sg1i5EC2TJXA5db0xoAslQrFbcpP+HarQaYOdabFkNERQ2XMmFJPWVJNPBK4RbaQvHLLMAmC1xhfPB6pIrXqOAMqpdakh7+Aksg45ywQZZ6qtEhunJeYg+af4asA3zD9BJPFJxSYnrkRmQIaH8i82GBjwQH45xToN6piz+nMqpLY1+CqtlS1adygTpvn4i+8j1G4sITyZ67LCs4GRnvVt2fShpfuGk1ZTyofwTuUH1tyos0TeW5UslNHmLeXjWDPaQ1qDGTvZdYW9c8vwG5BM4/7SpiVX+GJu5SqMqfy1/x/67rB/FnzQo6g5dwS3upV2eckgIqMZ0cQllpQu/ourfTwALKL2DVF33QnTIEY32LPXvCPI71ylgbKT4S4n/Wbxrx6GhJCmIkmdZLFJEgUbw2hs8NUrjvl5SDm/1PjGyXip04qvxIRdIr f69ufeUx RkDSLAIXus1rXqSrz+0uVU9t2cErr78MjzOBIaq1i5clTdpxtfa+lJweCLSyJRrXTZffX+5y4m9tTOJdk4ZDJT7jlb8AD7jqMIHNF1UrSZ9+X1V+nI4gKwE6y4g7PlatNkoS7F0dijUCagYVHkR6hwtoeDokXgSfzMKUvx9teqfsiOTkIJA3HtvJOcK4BYm15w2YHl1ntu9GBcNSQCnDe1GY/zRi9tgCOEoLts1i613eje/w5fVElDJCJUX2iCoaESo+cGMGu7r22jvc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 23, 2025 at 11:13:14AM +0300, Leon Romanovsky wrote: > +static bool nvme_try_setup_sgl_simple(struct nvme_dev *dev, struct request *req, > + struct nvme_rw_command *cmnd, > + struct blk_dma_iter *iter) > +{ > + struct nvme_iod *iod = blk_mq_rq_to_pdu(req); > + struct bio_vec bv = req_bvec(req); > + > + if (IS_ENABLED(CONFIG_PCI_P2PDMA) && (req->cmd_flags & REQ_P2PDMA)) > + return false; > + > + if ((bv.bv_offset & (NVME_CTRL_PAGE_SIZE - 1)) + bv.bv_len > > + NVME_CTRL_PAGE_SIZE * 2) > + return false; We don't need this check for SGLs. If we have a single segment, we can put it in a single SG element no matter how large it is.