From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23A76C369D3 for ; Wed, 23 Apr 2025 11:14:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0248C6B000A; Wed, 23 Apr 2025 07:14:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EEBD86B008A; Wed, 23 Apr 2025 07:14:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D1AD96B009C; Wed, 23 Apr 2025 07:14:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A35606B000A for ; Wed, 23 Apr 2025 07:14:26 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C49961C8D4C for ; Wed, 23 Apr 2025 11:14:26 +0000 (UTC) X-FDA: 83365050132.10.56ABA27 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf03.hostedemail.com (Postfix) with ESMTP id 3D66F20008 for ; Wed, 23 Apr 2025 11:14:25 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=YQ5nyM23; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf03.hostedemail.com: domain of rppt@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745406865; a=rsa-sha256; cv=none; b=oKpf8NAC1zejK5oaG/omAUtCyMcoIvmo5rr1L995EfKijhjPZnGtfqrNtVTx7l/B+IHwz3 7QZg05SeGFMtD/zAe//cFmE2UC4ct9TpKZKk8WfeQgXuB2LZy23U9qvg7hGx+61WJ0MuyH RMkx1Lj2qfGfCZB7nbQ9WVCY3nlJePM= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=YQ5nyM23; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf03.hostedemail.com: domain of rppt@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745406865; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PY125ErN3/M8lwOZlBVVABb23iCS1LCPtq9Z/AmQGvc=; b=3h1AoEqm9nSm7UUDyDNIeeQs37N7dSqI+U0LhCpoMS3JqT3GXgR7smmP6ikqF4QTrYJzE6 O4FUeGoBgtFhjG6J0wJgVU9VolsFDH618Q1kG2cEvn97XX3iRQzLmsPIT5jHDjz66WcJl6 zaIBV7l/ZYqFSfUdou+hGgTdfipj4pc= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id C7B55615E9; Wed, 23 Apr 2025 11:14:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3D3D1C4CEEB; Wed, 23 Apr 2025 11:14:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745406864; bh=OXIT2Mkp/X1FfEchdqAzjOM5PYg0vflOSJBG7v9Aedw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YQ5nyM23wz9ka7GGbET2QYg8DsE98EZupnkR/JcsxsgSQazsyxKH8ikhqvsaIHste O0Py5pCACuZp+UTH9JTXs4gmWeSyncmjD9VXWVHM5AClBTcCTQ9OP0M8w2xr0TDjOU LCnMBd/4GcmXm+g7k9JTR2NrOQ/W9lAiX6hdPi4WHfrRds1oA4f9PqvShPiIRY7Lc8 AknZKbth2cHCDBzYAxZHhCpZvPTzicdQZhYvCOOwvayh8pSmj756RIs8I3HzzN7qFo v+V763+IrJMEvGePqKJ0Ize7tYzouTcooirZSmUU+x2cbGLR1qqTr3MJeBNN3fb4nQ p3XqyRWHL3yBw== Date: Wed, 23 Apr 2025 14:14:15 +0300 From: Mike Rapoport To: David Woodhouse Cc: Andrew Morton , "Sauerwein, David" , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , David Hildenbrand , Marc Zyngier , Mark Rutland , Mike Rapoport , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Ruihan Li Subject: Re: [PATCH v3 7/7] mm/mm_init: Use for_each_valid_pfn() in init_unavailable_range() Message-ID: References: <20250423081828.608422-1-dwmw2@infradead.org> <20250423081828.608422-8-dwmw2@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250423081828.608422-8-dwmw2@infradead.org> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 3D66F20008 X-Stat-Signature: zxc7jo15yf1ktirgm6tefj8admeuxxgb X-HE-Tag: 1745406865-105797 X-HE-Meta: U2FsdGVkX1/n6CniA11jSEc4k1M8GVd9cVEkkSyCODRU6AS2h5d87xhvpqgdKbsuT/awtLNl/TMNOVD1QIwLgKIYzOHtXuRtOgfr6pqeoHYUicgE5wz3mYkNwJIN9ncfVsv28VxiYuJKCcsQFVLno/WkygevqOazFAeidWmuXGDfrCRYojkDkvoNkuJMg9Vbws7nXms5qIQCa5qBx2j4B2C+J8KVUnbGIQrcy75HIpiekyXimeuJxXNwbKfQwlMQQ9W7Ys6Ks97RUOwvDHcl+djVXe+acv4ber76l3i71FATWRI14hMXFRLbWWAQMYzV2t0MUWTXwdsiRYNE7zP/HX2OPO3ARa7Nj4o7skLAW3MMG6JF+HXqnK5/7tc9i35Wv84fILYApZ8GLIJIEPiksErYMb/nbZwZdAm9ZChEpWKbDqyAtX94VXxCCiJMqTDwS/DHGynhJ9duTVNyoHL6LOQeFa9KJcst8usGaBesehcQg0ZAXtnUn/q47RNnqNuoKf666EGMPJQFw3yJYQrD8hL3ldbxppI8BcAuDLuFNcKLMwdOdLs9LsqA1TiE94DZD/cgMvXI5aW+bWwfXP+zfpNWrT6tbmeGC6QorWvfK48YcMNkSG+rpCsOUWHNZyNeD12ONkL7V0a98QjwWWb1uLXMn0FRxGjkhx4EWFnrlRKEF9vgzA3l9nQIQnmPfvr3ALhEj+IpH9nUlYkD1Pn3VOVdetlrAy07OkDMw+zUTS24r/Rkg668H4kGcDO5h4pY2LibBlnhnfpTre1wt8sl9EFKC565AiWgNdoQxHZPh9ZaXEqewKa5la4yAUCWYX6kV/7VsISGL57JbOBOkvT0oZTXQmHIo6cWKETIh0faE1rbDXkKSPL2f97Dk0JzTmUlCUp88ZknrsNCcdrqtejqGMcc3DuUZkanfKLOZwXFZf2zFtiWnfOVCJSpBuEjKKEq+1uJIHgBjZK6NVOTzR1 A7Eb4/aq gBkpzlyOx3+TOulGgSQFn9plcy+CMyRegFgaec5H7kssMZnEuOY517CFphCnOGzsxMSxeMTT2HTm6sKTF7fDFoKaoEj2DEhPqjOdCXGJ/oVCA0dcLHqsS5oatnoKbYk6IvTGfXPjN5p/gfXA+hpXu7r0XFAVRkAhvcuXgNO8WbV7CUYgyda10vmqB5sZLrcvhKFU9JwBEx/mU7s2DxEgSlmcKsgUui2gnyzF8xu8q38MZA+AB3Rj96Md7B5vSgLGehkvukbA8SeHFQHaZeAv8EMcIHfMQtJLMh3HOAWxpQFA9Ask5coIQpCVTfKboIzH+zEMBCDLsZkJx55uiZUUxTDyXx6JWQRtwkiMH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 23, 2025 at 08:52:49AM +0100, David Woodhouse wrote: > From: David Woodhouse > > Currently, memmap_init initializes pfn_hole with 0 instead of > ARCH_PFN_OFFSET. Then init_unavailable_range will start iterating each > page from the page at address zero to the first available page, but it > won't do anything for pages below ARCH_PFN_OFFSET because pfn_valid > won't pass. > > If ARCH_PFN_OFFSET is very large (e.g., something like 2^64-2GiB if the > kernel is used as a library and loaded at a very high address), the > pointless iteration for pages below ARCH_PFN_OFFSET will take a very > long time, and the kernel will look stuck at boot time. > > Use for_each_valid_pfn() to skip the pointless iterations. > > Reported-by: Ruihan Li > Suggested-by: Mike Rapoport > Signed-off-by: David Woodhouse Reviewed-by: Mike Rapoport (Microsoft) > --- > mm/mm_init.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > -- Sincerely yours, Mike.