From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 494D8C369CB for ; Wed, 23 Apr 2025 08:25:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8889E6B00A8; Wed, 23 Apr 2025 04:25:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 80CF06B00A9; Wed, 23 Apr 2025 04:25:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6AF656B00AA; Wed, 23 Apr 2025 04:25:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4C3A76B00A8 for ; Wed, 23 Apr 2025 04:25:06 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1F98881867 for ; Wed, 23 Apr 2025 08:25:06 +0000 (UTC) X-FDA: 83364623412.28.FC79178 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by imf14.hostedemail.com (Postfix) with ESMTP id 1B6CC10000E for ; Wed, 23 Apr 2025 08:25:03 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b="BoTG/xNu"; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf14.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.49 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745396704; a=rsa-sha256; cv=none; b=o6c7RcAjBa9/rzvdH0F2kyi1EGwzUn/NU7SjcWICHhq0SPGRvTaBUpALkbG0tgey/XBUlL hQ6rJDQg2RkjBdbHnlZ21/01dRBvSmSXZPV/aA5nsUMtclFiTQF39d9QOPLAdKEE3V7pa2 L7LKksf9/4ypk82Luoh1t/tRjt2DOtI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745396704; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=mZ2BajsrO1xtArLAi+wn8MeS8GL5ES9k/0bb/t3RE8U=; b=wZZ54xNMf0t73DXdASiQr5+2DTWvLmqWgHNDiEkZ3OVys7vjETNZuql5divmHFG7BSFpFv 5cnuLe5Q1XKLayC5Rpo/6oMbWXc2rp/QkHhEaHnPc/pgRwQTBZ0y6UeWH3vvOrmgRPbERN zaYIhX6ukAftZBVhYJQdHf53dmL74qA= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b="BoTG/xNu"; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf14.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.49 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-43cf034d4abso56089885e9.3 for ; Wed, 23 Apr 2025 01:25:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1745396702; x=1746001502; darn=kvack.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=mZ2BajsrO1xtArLAi+wn8MeS8GL5ES9k/0bb/t3RE8U=; b=BoTG/xNua6pfK6BePFsKyA3NTfcxprv902mdwRzF/2cJbN3rlA6bMgItjJfHRuo5to Yc4bsFsICWysbVb1rup6WK+nFHG/+3MxVE8+1+LwyUPlbrEueI4ciheKzQGu2nTuFzXQ 7VA5LJK2Yksgmae71s5hjOl8eJxrcraaNgw+OyIG2NGTqgWDKIYBC3Jon97UqGL4QXGz DwQCsXqc52IuU/R4NOhj31sXhc8/DRcg6pZuSvDxCvd2FjYdDlHe/YYSU9GSO5hCIfQ4 EgrXm9NUUU2gEs7w2WtuSJ7B6q6DKNvIhnU07pLmAHnz4KjNv83qZG93/5fP3T/eaNdR Cu0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745396702; x=1746001502; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mZ2BajsrO1xtArLAi+wn8MeS8GL5ES9k/0bb/t3RE8U=; b=SvacZGMLth7Y3ur6AA7cekeO88vgESo/AUvowjSxcRpSr7uAIQj5VHFTcIiTh7QNae 2ihNeWFz2mfMQ8mD7zsj1rpCcXnLT1adQbWSc25H63HhTOGZ0d5BlO76qdQq3SQz726I gn0A01CgoInBXVOdN7pjp8sDGKxRUZPMEk1qUxqsjy1trLa+tZzs4OViD732fM0Zp0Wo SC2M5vkHxP25f7LENHCFTcPykFeoJYS2yHRlWR0Xt2cV38m1Fhlp/LHOtvC04hgg4nci 7hODr6SZMkADAmcvGq3TvEVrZRRk/Kh63Y7h+dpGQWXWDTmbxpekqYCHs6yyFyHiAwKb GMEQ== X-Forwarded-Encrypted: i=1; AJvYcCXXEF0ytM0+MEfr1rL4zaJuYoyMfz5041tMwmCZFAdBsPlqkubt5+gxe73LG6U9mncNQ0JDqPLnaA==@kvack.org X-Gm-Message-State: AOJu0YxoYl5XFVasibH72AB78rDraty+i4ueKQcbsIqtYt5fHpNNM+3R HiSgms0hH1lbPuQ2umKMqyo7lPOT5g2zqS+HB38bY0rmDe6ya28vpg5jVooOw5Q= X-Gm-Gg: ASbGncvjGg/VMKO3mYy16SnHHvFkd6MK+utWtAf0voxz/LNbIy4t0NnTkVZV1iCdMJ1 EHw1IKBQPGMKWceu/D8j6dpqUBPfTw/G9W10rGEyfWLHSpms8mPvnKqIjJNDnUjnN9HvXieZMgd LXV6OZC1kW6FbOTst9mMUPRaAMcloBwnZpuOj3+781YDT0C8pRq5IVylc+C+5kM7iO2s6rQxrOW QMtEJFDjEGqfiiEPFvfj9FlY7Aspj22MMXSIDK6fyPU0OSCHzXBW9QSRXQCSz/9UQL6uwgzQW4V l4p/ihSKQbSkAm/ik+vY+2EKwPxZgRsXyEDS3dJDShAnEw== X-Google-Smtp-Source: AGHT+IEOsr2GYu8CB0C6z+X52cXEurZZkRfa4SYjeQ2F18Db0W+Om64FqFyMx1yp67irQ95BN9CpFw== X-Received: by 2002:a05:600c:a009:b0:439:9b2a:1b2f with SMTP id 5b1f17b1804b1-4406ab8144bmr182156015e9.3.1745396702371; Wed, 23 Apr 2025 01:25:02 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-39f069df9fcsm12706005f8f.16.2025.04.23.01.25.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Apr 2025 01:25:02 -0700 (PDT) Date: Wed, 23 Apr 2025 11:24:58 +0300 From: Dan Carpenter To: Rakie Kim Cc: Andrew Morton , Honggyu Kim , Dan Williams , Joshua Hahn , Gregory Price , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH next] mm/mempolicy: Fix error code in sysfs_wi_node_add() Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 1B6CC10000E X-Stat-Signature: 8ziyf3nxxuyxr745ugj8b7435g7w8e1b X-Rspam-User: X-HE-Tag: 1745396703-222929 X-HE-Meta: U2FsdGVkX193zD1IeeXkdO7zpL+dkAdEgx0s6a/KeUV3e2jhneLeCjX84RkHsE6GUviw8x+wUfCQXYNOP0hlVQCL8nsutr4p7oiSrh8XybfkXwRNyLLfofho/u0ktymieGxKLI4efn2epyNFiVEScEm/SH44dU2Q4WeFjM0/NyLiI1aAj+sYF8RFAWym4qqyeAoRQZZAQBMj+uMcEVqyYMZWpjNlbvFaGwdG4rgzZZR2XP2hKwsgYszjXj2zsgW8Y0dZaC6IZf9V/fqJYsUlzFx+rQJ7MX2YP8XtkcyyeBxBrIE7EbaUx+V0NtYA1BE24wV4C7TfYg5i7Wjml4xl+jfzrEW0CDUS73LdXIfgIh3ID5EJt1P55J1cJRXEY65u/E5haMjd2gMCbZviyW7HUk1GLHQ9U3ZidiUN3yfRbd9AmTy55CAGGMQu180/wDpiR5KXwXMA+e3A9t7M9UPCbqGqxpMq+2p5VhERxTm+2x2fkWbdg/xzMKV6KHfjSubeNR1vk9oVdvacxf2+gDopbwR291xF9ZUZ1vOiQ1q7h9Da2QInihOU7cHY7rL2ZRjQ5bxnWLuzGarc8erBKQZYA3cOL7rlVAoGEynz0K5L/IXXtesfAbvruzCcdgemCHOFkyl8YFo8DzDZ2k4fMYnth7HJDcfPiVQ+WY535nVJWwS7a79fDg3qMW0BF1lHUujnnLzvtuwGfP008TPOuMtGH6jGLDqIoxJ/IjgDu9qVcZakZlT+F+9Yx2V1+27SUjlAc1Ymuk3tHud3ep6mws+xrdBlbdMkilKa4osj01p53XpjgTIVp6HgPnqsr6BYiJnlfzRFo37KXEj/JeTvy/5A/CdYjN1zpAEXtl+XxIO/yJuUGFp3dV7kYEhumw5zYurEmLF89oUa3DgX35kMZhttdS1jyFz3RGVPWvdJWkQn52XcbPYI/VNyVKCBtUxSjxs9bk/ipaME84DTk49w9Uv 7Yucj5yO 19AR5yBtnVwhZvAbF+jm63tKWbqvr1nWYJ3l1W4z6Fd25JUs8K81XPkhQtQ7uDsEOtCrBGccmzKq5WEgrAX2rC3MeD8YK/Y+MirgGcRmWV5+wn0GgoogIlhN9eH2NlPAQ2fEzo5tB08ul9g6Pccf9es/nZ/5JXF1918iaY5BfSNSLoIDYsSmbEgkTQzm96kcXEGc2rljg2Vyv2KMvR1LSdi0pXgJ65/98yqzr1w0h3ugk9JAZv3LZUdvEow7JKhKyGgvh4E0HCqIE3xYDSwDuAFtWzmi120+YlAT3K0GQiL6YoR/XAORfN1lr2IA5Z4sF+tlt9u9/LIm4J2K+xnOqw+4GHDio6U4u6utXYzSnPBSLlyrpYECH2YwFDOhJr0fO6bT80R2DSJ1Uyn14SyCpXEWR4kDS8p8+TQ7HEHxlVrxjPLZq0gNFOSYwmJNURtrBeKbJuz1yp42KEyM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Return -EEXIST if the node already exists. Don't return success. Fixes: 1bf270ac1b0a ("mm/mempolicy: support memory hotplug in weighted interleave") Signed-off-by: Dan Carpenter --- Potentially returning success was intentional? This is from static analysis and I can't be totally sure. mm/mempolicy.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/mempolicy.c b/mm/mempolicy.c index f43951668c41..0538a994440a 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -3539,7 +3539,7 @@ static const struct kobj_type wi_ktype = { static int sysfs_wi_node_add(int nid) { - int ret = 0; + int ret; char *name; struct iw_node_attr *new_attr; @@ -3569,6 +3569,7 @@ static int sysfs_wi_node_add(int nid) if (wi_group->nattrs[nid]) { mutex_unlock(&wi_group->kobj_lock); pr_info("node%d already exists\n", nid); + ret = -EEXIST; goto out; } -- 2.47.2