From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D3FBC369C2 for ; Wed, 23 Apr 2025 03:22:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 702786B0005; Tue, 22 Apr 2025 23:22:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B1B46B0007; Tue, 22 Apr 2025 23:22:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A0816B0008; Tue, 22 Apr 2025 23:22:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3C0846B0005 for ; Tue, 22 Apr 2025 23:22:50 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 57E3DC0BA6 for ; Wed, 23 Apr 2025 03:22:51 +0000 (UTC) X-FDA: 83363861742.02.6A63CBC Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf17.hostedemail.com (Postfix) with ESMTP id B2F1D40004 for ; Wed, 23 Apr 2025 03:22:49 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=XJjV1sa1; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745378569; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xkzgZ+DaZiB29pk0Yhq/GUakbOMzDh1a7aFUoZGdCKc=; b=pIiFH8JRMMeNUHLYhhFQ9ukHRAFcDfW9ZxO8hpNNYY9CQVY0yI2YLvXESeq1eIFD7rzEnN qeshY04gwD2xZNDdXn0ahMmoUrb1LkRyj0oReelv9ztNJZGkuHkoUUbKhHzZWrnLWTDwcf AWQDDWveO62PXBtwehdRvT1UlHBlz2U= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=XJjV1sa1; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745378569; a=rsa-sha256; cv=none; b=BJr9FfRL7LAZK00v6a9+HqCt6cYiu8+baP4AU35C3oloEloI1rWMv3Xtyv5wGZ/mDHzt27 WiJLApgdUNM+wE1K43nZgjk4EaCCOvJGw2bkbSnmULjtdi8QSpzpqQYjLGlFUsYkSXPYxD GrVniGHnUPH4SSLBMI955vHeC6jiLmw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=xkzgZ+DaZiB29pk0Yhq/GUakbOMzDh1a7aFUoZGdCKc=; b=XJjV1sa1y/OQytxXFZdaylM38v FVs85+dePF5/WdhKlfhpiB5Nqq5K03nPZ0/8hVOHN91uyOqZS7IynrSfoLm8zmLTJHUrWHI5jJwIQ lL6pjEwY4K5l8HAOznRImgFrDQZCcihtUxZEXMreOGQy+mABl5viucFe9SsjVPoThrmY2hWayN636 aczOtEfw3oVvDGRHT6IcKspxs/meVl8OztNIJ8UMOcLZTrj+TQTg69KUz8DsCkVgXHGkyaIZ3+4jL kQOfDfNfWv3lYDWqR2mGg1+5+OjSvbG2D/0hNANQobYBvw4/KxcwG8lO/alIc97ypk0p6M474TPaa ET2UT78Q==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1u7Qh8-000000070XE-2SJk; Wed, 23 Apr 2025 03:22:42 +0000 Date: Wed, 23 Apr 2025 04:22:42 +0100 From: Matthew Wilcox To: nifan.cxl@gmail.com Cc: muchun.song@linux.dev, mcgrof@kernel.org, a.manzanares@samsung.com, dave@stgolabs.net, akpm@linux-foundation.org, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Fan Ni Subject: Re: [PATCH v2 4/4] mm/hugetlb: Convert use of struct page to folio in __unmap_hugepage_range() Message-ID: References: <20250418170834.248318-2-nifan.cxl@gmail.com> <20250418170834.248318-5-nifan.cxl@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250418170834.248318-5-nifan.cxl@gmail.com> X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: B2F1D40004 X-Stat-Signature: 7mki5u4i43mzqfhtmoxkw1g7derndo8j X-HE-Tag: 1745378569-506534 X-HE-Meta: U2FsdGVkX1+GuKmuSWEr8jPaD1CfPsK1ZpDVKG5hK+PETD2W+3VLaiRt6UzU1dNPmOY2QKScWl2FsU6mG62v06jtZjauEG57SsmNKwx+ZDoJxpoj2ve9om47bc/XFxSc47VqDXNNyyNIljW1udFRkX58gB5SLr3K3fShUT2B0XfBU85sU/e3y3tTt2spq9qAxlrMEy7rU43kDcDhEQ1LRszNJ9iFepVFl0yqeQAssZwGMIIXBhcyrzTigq6q2lvO6/aC0Aq1iQKJw+6Q2BTl9zSoC4rb63iRCabWYJgo7KptZvfBhECt+v7BItQpaKf1VuE7oB86idUArsQ06FnKvM3iIcISQZz+HynynZ5CdutaeZi0DwAuccdyXDTHtogB4O68C30Y2W8HJf1zwgoMM2lyHb4/9Xok2O4PnipHf+fWaJRsnWmS2FHi9W1oE5v+JuVWaKlxTX4tP2Jw6V1dZYzG7Njqj2yVgDbnpdnm7/2YL+LCShyjq2UM1oY+mZs1EgHj+SMZOjfah/R2498PrNFkvF4ia/18b2al3odsC/hKSYeZ9UIsisPwM0vhSQX0oFiqtj334c+t4svPhU6XHC9SB6hHagCzDKGgxtk0lfdenBQdnO2FtT2ZblRQsVEslf4yFVXV5RSTHqfmOMnpYKH2EaBsZOxWPrjNNQMb4t6DOPPFmFTaERz/b5yHFQnLCL2aUJf3gG32rHT421nCnz4ys59bvo9trF2M3ViKcFxfidhAWB2xlf8RKQLxaZkV0bWV8LA5URVZ0Fw8o+ELYNZ4pTX3xepd0O7IiYDDQeNHx8V4VieZPTxy7cENBYQdjvmTnKOsMLXGG4RRTK6WqNONjgrJQ3iBYCBBRw4Zh6ev0kqQ62g0Lcwjq2x4Dzova47/KQmFGmK81bS37QK3nuZPK1P+39up/nqa5WkU5A9XxECdTnlFhSK20kAYVQK7wZlRrnDyUlqdDfszsOb Du+5TcGm p2U48Z0dk5egv1yx0Q9dDuRyWqXpbYfqsClEqOgfw/yMtE6bwLK5cvIOtRgkoJAwnMFeyBlvEEOaMrizE9sNwme26tCiogjj269mAg0yKCdqZEBAeDvRd27Bzmb494i/g2NmzzmogmO5WqbftPafmiedicySFNPo8cPSItjz/3/444St9F6YNb3XkF4szhMfSYaiffvKG3sDVSfsR0WMEoC4GwM8jx2NmYMnNNa4W+3A6Zuqa0M39AvOP79TTlUV0v+w7IdEzbpsZpCB+KDU7wYXOqMco0wQ7mtUAZ8F34mQswGiCyFHZHSyxtkhsEZD4EOE1FwHEEO/XIqUmnQxmdDYIbtln1clM5NrhbSiclYpEM/NgH9QOMzqTlK0QB950WR3UpuWf2C5KtFg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 18, 2025 at 09:57:42AM -0700, nifan.cxl@gmail.com wrote: > > - tlb_remove_page_size(tlb, page, huge_page_size(h)); > + tlb_remove_page_size(tlb, folio_page(folio, 0), huge_page_size(h)); Surely this should be: tlb_remove_page_size(tlb, folio_page(folio, 0), folio_size(folio));