From: Matthew Wilcox <willy@infradead.org>
To: nifan.cxl@gmail.com
Cc: muchun.song@linux.dev, mcgrof@kernel.org,
a.manzanares@samsung.com, dave@stgolabs.net,
akpm@linux-foundation.org, david@redhat.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Fan Ni <fan.ni@samsung.com>
Subject: Re: [PATCH v2 4/4] mm/hugetlb: Convert use of struct page to folio in __unmap_hugepage_range()
Date: Wed, 23 Apr 2025 04:22:42 +0100 [thread overview]
Message-ID: <aAhdAgeOXx1S_Z6g@casper.infradead.org> (raw)
In-Reply-To: <20250418170834.248318-5-nifan.cxl@gmail.com>
On Fri, Apr 18, 2025 at 09:57:42AM -0700, nifan.cxl@gmail.com wrote:
>
> - tlb_remove_page_size(tlb, page, huge_page_size(h));
> + tlb_remove_page_size(tlb, folio_page(folio, 0), huge_page_size(h));
Surely this should be:
tlb_remove_page_size(tlb, folio_page(folio, 0), folio_size(folio));
next prev parent reply other threads:[~2025-04-23 3:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-18 16:57 [PATCH v2 1/4] mm/hugetlb: Refactor unmap_ref_private() to take folio instead of page nifan.cxl
2025-04-18 16:57 ` [PATCH v2 2/4] mm/hugetlb: Refactor unmap_hugepage_range() " nifan.cxl
2025-04-22 8:52 ` David Hildenbrand
2025-04-22 8:55 ` David Hildenbrand
2025-04-23 3:15 ` Matthew Wilcox
2025-04-18 16:57 ` [PATCH v2 3/4] mm/hugetlb: Refactor __unmap_hugepage_range() " nifan.cxl
2025-04-22 8:56 ` David Hildenbrand
2025-04-23 3:19 ` Matthew Wilcox
2025-04-18 16:57 ` [PATCH v2 4/4] mm/hugetlb: Convert use of struct page to folio in __unmap_hugepage_range() nifan.cxl
2025-04-21 15:08 ` Sidhartha Kumar
2025-04-22 9:00 ` David Hildenbrand
2025-04-23 3:22 ` Matthew Wilcox [this message]
2025-04-23 22:17 ` Andrew Morton
2025-04-22 8:50 ` [PATCH v2 1/4] mm/hugetlb: Refactor unmap_ref_private() to take folio instead of page David Hildenbrand
2025-04-23 3:17 ` Matthew Wilcox
2025-04-25 1:11 ` Fan Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAhdAgeOXx1S_Z6g@casper.infradead.org \
--to=willy@infradead.org \
--cc=a.manzanares@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=dave@stgolabs.net \
--cc=david@redhat.com \
--cc=fan.ni@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=muchun.song@linux.dev \
--cc=nifan.cxl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox