From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5525BC369C2 for ; Wed, 23 Apr 2025 03:19:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 761316B0005; Tue, 22 Apr 2025 23:19:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7106C6B0007; Tue, 22 Apr 2025 23:19:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D9486B0008; Tue, 22 Apr 2025 23:19:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3F5AE6B0005 for ; Tue, 22 Apr 2025 23:19:52 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 198865D34A for ; Wed, 23 Apr 2025 03:19:53 +0000 (UTC) X-FDA: 83363854266.16.DB97DC0 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf27.hostedemail.com (Postfix) with ESMTP id 745C840007 for ; Wed, 23 Apr 2025 03:19:51 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="qyoBogs/"; dmarc=none; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745378391; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GOEAeA0iNQB0WJTvoODPlKE3a9wUo6bhm6L3qDNptjU=; b=JvZZghbhodzvSq3cTIutkLSJjXUuwesnNF+yZ2EA6b6N14NoPjchhnIrdFlyjLwvWlUPZR /YjGlDPDBhq++JFuqaYXp/WjdImoIcYTERh/J99FmSF1UTzjDa4TtedRogTbz6xtZgoU9b KcHsnCgv1/siOmO8LlkVaBsKCUAlk4c= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745378391; a=rsa-sha256; cv=none; b=khZ+YtfYgWlJKeWMJ/gadAoqi7x6cik2RgivGkLDepOV/lpAF8M20uISCGHywFXv47GnYn WGkD792du59jGjT0EgZqiLD43qMmzpdzpxG4khnC9weOSU3bZmengmcnluOqzpTDTJ5IwA E4pR5eZvOj4gXPaYG+AkZkj+a1Az/mA= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="qyoBogs/"; dmarc=none; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=GOEAeA0iNQB0WJTvoODPlKE3a9wUo6bhm6L3qDNptjU=; b=qyoBogs/v/YnUdE2249xqnwrDA Xu/jaCg4c4zmLnJyVibwOJBDur7LOUzpwiohXb6iZTVrjhjEG/2dYgWExfjt9hYBJHaFVik3+qufE ThvM68Uu0rYTnrz5jQloUeBanVcEXgueDt6A0eFt9ZlsXD+unmGGr44hvA1TNcinJJlNXEHbK52uL RLbsbolGa7t+6EMKT0eUFJFsQ79c62G+92oPSQnFJuDvbVR+HMAwH9FFo/BoOsTIpMPkUsPnj2zZa unKd06D8nlWsLUgnqH6mUiFSvmgZmSrFXgHNVe5dMaGG86PQ+YU02NqOFVUSGf+RT0QhwihuuT19c gwKV/GDA==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1u7QeJ-00000006zyM-1i2W; Wed, 23 Apr 2025 03:19:47 +0000 Date: Wed, 23 Apr 2025 04:19:47 +0100 From: Matthew Wilcox To: nifan.cxl@gmail.com Cc: muchun.song@linux.dev, mcgrof@kernel.org, a.manzanares@samsung.com, dave@stgolabs.net, akpm@linux-foundation.org, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Fan Ni Subject: Re: [PATCH v2 3/4] mm/hugetlb: Refactor __unmap_hugepage_range() to take folio instead of page Message-ID: References: <20250418170834.248318-2-nifan.cxl@gmail.com> <20250418170834.248318-4-nifan.cxl@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250418170834.248318-4-nifan.cxl@gmail.com> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 745C840007 X-Rspam-User: X-Stat-Signature: tgcjpagktz99hxt69dbjwxpoqyangynu X-HE-Tag: 1745378391-222354 X-HE-Meta: U2FsdGVkX19mjKUHm6Tq0y8LhpVLqj9jLxqM4g6sGZk9rEEgfujBfaZ+G4pAwJrhrw9q/JMLRrGP7wfsRdPlqcjfa8V8ICnJP1ds1ovNawtdEbCZaO5eFDvgUhkCQpla0aYiIrpalrcMrhsPAfSJXkTuMCl/gpCOm/FIhAwYNSciMfwx0Dd3OdWhrwnAEbuJbKsCFgr5pq/RkxTMTAfmKrYQh6koewgaaacMg85Yztn+OweETHj2eUPD8dD3xlpkdNv4RFdNBj7K3VBFk7vb87B+CVHwXuK//KUUrVxxwzCrlYCYnCZRz8EAIbh5XvHC9wNI010LEoP8+0BCcEuVZr4pdrrsgDjpBvzPv4McdegGdWHRymASkMRbQEmhsBM0GS+9v2L9UkG0dzr44v9haFlTsKT9RTBhATqemfqmSLYDGkKQiPl8YAj+YBntTYOdMpCcq1eETEk8yqpDa1XTy/L5yPX0aAY2Cg81lz3JjMVger7eSr9jEo7lh6pb+/efObW1hcIwOC5x5YfAXpdnUVBzUb1pLuAhK5WMPyNbg82jqJnbHiph6YAtwKImrMckDFS1G4pmQ8uatnPi3CVAg6H3aI5lSeGj7jvFcnkWhR1tUEBAMCwKz6d+MTYE5y5iFAnzyAkdYwzTabbrUF+u2zJZBv5ZSrw7GBE3ld1zptZPbVHaCRHxgcwkOetNkf06QJPCz1Qxavy9t0ligfvkWE2veUNDOlxoW074DV1PKgyEf3cUhxsI8vlOkP0r76YfOXaiS7t76WqiFAKvfpHvl4XuVubfxnXO/HCouMSGy3PR8uRZvfhLSDLp9gIe3C67SVUDd5TDMC0P8Cy3PAUHUSgKeN+OavMhNfLujCU/hGuYlRvTYKkumyLyDQHnRMQvisye8RtkNm1EinkGSytWNpQgk0DesIQJ+4SiP8M3Qqq7tNsrEwuzY5sTRzYlQ6iQ7bqQrtWs3b0wn93OPMF qLxJ01xD xJOfUHFMsBgUAGTUmlAgBzjR/s5fmOwZVsnWjHRNPZ5dWpqwnVy8RKvjUxDeQ+nKyyht7y/vP3c0FIno0tFLWALz01Ot4D6WLEk2lomC6tkaWt99UzeWsPWjIMRaixf36ETj9cMyOIiH6defsqbiOxYIcsa2lKyt9IIuOJ//Od3YVvpu7TERm8cDYospDGwDGFf68NdUV92PAPUNZHj0DiylO6y+R+UjGjpEGakDYzKgJ5r3TvI6SUYFtfF61sge01Gi+79E9WoVb+1DS4RwA26You4iq+BcawGMEQUUZQQHwQJHHO1nM4XXgrk45C4Igvauaf7D5MHq9btVUqpmbltF0B3ig6ZzT5WjQmyroGCdIGLrkkmm/vXYFwQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 18, 2025 at 09:57:41AM -0700, nifan.cxl@gmail.com wrote: > @@ -5910,8 +5910,8 @@ void __unmap_hugepage_range(struct mmu_gather *tlb, struct vm_area_struct *vma, > * page is being unmapped, not a range. Ensure the page we > * are about to unmap is the actual page of interest. > */ > - if (ref_page) { > - if (page != ref_page) { > + if (ref_folio) { > + if (page != folio_page(ref_folio, 0)) { I think this is actually wrong. Shouldn't it be: if (page_folio(page) != ref_folio) so that it doesn't matter which page in the folio we found; we just need to know if the page belongs to the same folio or not?