From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82731C369C2 for ; Wed, 23 Apr 2025 03:17:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D9F706B0005; Tue, 22 Apr 2025 23:17:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D27DA6B0007; Tue, 22 Apr 2025 23:17:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC84C6B0008; Tue, 22 Apr 2025 23:17:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9DCE96B0005 for ; Tue, 22 Apr 2025 23:17:32 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3B3B5BECA0 for ; Wed, 23 Apr 2025 03:17:33 +0000 (UTC) X-FDA: 83363848386.14.CFF16C7 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf14.hostedemail.com (Postfix) with ESMTP id 9CED8100007 for ; Wed, 23 Apr 2025 03:17:31 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=JplOFHJs; spf=none (imf14.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745378251; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XrzL/ywGQWwa3UfFOg9DzphBj+qv1CvmcEybCBgX6GU=; b=WtgSQNW1FUTttGBRPdcSGnWMkh1crdjdTA7ZjJ5aw+8SV0temHb7iUYwYdUWOKhpNuoKCy 9hQAXU1tA84H03RWc34OwEIii06oyl4oqp/cODm3j8ABI3fp4EglrIzbRH3tNg6OIFZWIZ T3ciyz/7YxTx1103ut2GaSVgiUpkOUw= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=JplOFHJs; spf=none (imf14.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745378251; a=rsa-sha256; cv=none; b=j4iCo7iqootCRRnSX9sQi7CRT7bAXAYSWDa+bbKh5Zhn0aM/HoU2wBXcN4t4K/ZLDKhep9 06OCjLVp2rbDX4Q1KWOJz4UKBYuoDXl03pdhj+FKvBlzW28+6SLgQgBChLj8bSjG7bOy1n TaFqGROlGCbd6oGemAS7z+NcQpfeuC0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=XrzL/ywGQWwa3UfFOg9DzphBj+qv1CvmcEybCBgX6GU=; b=JplOFHJsJ5gwbq5eZLH2Re+L6Q 2qklporZ5OHRhoNmbd9SXgWA4glfxr5sNbHPvrVnwXDc5guBfLxRYKjMGb9mENFaeVcDevlFe9Sjm 5bDC6PBEBgbIJyM4ZVemJRDmp4Txl537j33eqOuOCDUg/DZotdjof5umqTHleBQUIT6S9Cgdg0KTH /I8m8VUiV16oec+Y2Fd9iDbiW/f6fFczCQb+4qAs+T+mJ5V+YTA3cGs9DtUliw7yfwag7w2XBxmJd FA95CPJXzlCpDJRqF8Av8dE1swubnoskvLRrQeLtF1kjMYD+D0RJu7uRbTeCA/hditMi5FnUE3yRM kPrtm/9Q==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1u7Qc1-00000006zVt-3IsM; Wed, 23 Apr 2025 03:17:25 +0000 Date: Wed, 23 Apr 2025 04:17:25 +0100 From: Matthew Wilcox To: nifan.cxl@gmail.com Cc: muchun.song@linux.dev, mcgrof@kernel.org, a.manzanares@samsung.com, dave@stgolabs.net, akpm@linux-foundation.org, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Fan Ni , Sidhartha Kumar Subject: Re: [PATCH v2 1/4] mm/hugetlb: Refactor unmap_ref_private() to take folio instead of page Message-ID: References: <20250418170834.248318-2-nifan.cxl@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250418170834.248318-2-nifan.cxl@gmail.com> X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 9CED8100007 X-Stat-Signature: m6u3eb5ga3s4onwkx777u57kjj51muhh X-HE-Tag: 1745378251-577464 X-HE-Meta: U2FsdGVkX19TE5ro3WkvRlj1JjV/SN5/SZZ9x2kq+9aIQHgfLwrJfqRJH0naU+QNgSfN5f2Pwp03cJ1ZOX0DmMl7CQKdRYQ93UwCTJUVbRg6vSexTtZlr3S20sfAZdIof8vCLTW/HPZ0laifaPOZRuYbgIcjqFRo/8ushUsrOds+Qrj5nU6aJWfvBQVbvnryr/t28/ST6z0vS6DUeS5lq3XRHFY1Trzw358hcVCOyjZTjlSCddWGd5Ji79WtD28OaI2JOgcffTUguIDUWEL9MFuQ1vtINn68nDm73NNvefDs2pvllLHGc42a9Pf5+b2WhTF4Y4iuTcGdo4WYeCjek7A+F7cFaYXct5QHojvpMJzGsCMGQvq2o8TGw4rUWa+3zo1HrqZAxxaa8UFPcweUGXvrnsq0Qg89CK5gcQfE2IpaOrEnN6KrLjgVWJ0jUvOJqPqvE6RPuAZuVhV8z2sh/6xY5oF3QfDstyg5Y/OuJD2pcttFi76JgdIsbxftrT7uW0ZEWUOlpA0ySCK1UbbXI0n397usFtVXfrEUtey1JEW3uQnOzbBlzbMwrueReOd5ljz83bzuvoTE/DEi4CK+lFgRAAzgzZ+y6e8iz5k4upuP2Rb3iM+vCLhHKsJBesMLw6MYPxAOaoE2EI37e9JWf3nhmuWSB+eR6cN7rY7jDf68AAe0xs9DbjhmOLHIaMzFAaLYY/wXqithL61W6IbAQ9NT9CfgenQViclvXHSntDcy+3R8dHPdDtZzBOXxiRNNV00/vzPEtVs/h9BKa1GvLU3VnP6pwYKSxdn2i9zMF8rAShqbqXRH6+GhtczH59QyyICamXrTFc06diKSNww+shfdIVx+XnjuaXT2lUE9elZ5+vexLC+pMPBQHMaT9wVyVpD7oFZYfRD6bPx7FQYI/eg/CkzGNAg3lsiFnCkNRPVF9/LCne73ks2F0FF+7Lq2USbbEP2aZQ79ssNldm1 3s33BAOl su9pJeiytwOdYKprLIYywlk+Wz9NnPFxqsiAu1pnb++J/QS8sFE9jQ7JpYCbWU20vNZmhgNoH80yCB+C3F1gSufRVuZSdTUl/A02EYgetSL9qUcIF7XSeD+sUohWcvXQKNA8geK81mlbG6W406TPcN4on+8FBfChTSxQcAakiSWLOdmmUUjD0/GuwAsiTIorlpggwUtoGh+aJMxIceLffgCDtu7mBrDdNSwFJ2b3uSRphjnzeDTwmMAm8JrusZD+vsXgnuu+EX5Tcou+IqCIIvDcoY+mNoVH6bFnupVBIIdioTkTHTCexfCAM6BfVjAvxFaCqExFivO0mCGVrGf7s+uxaH2jWj5Rlx28nuWOF/sBNxu8ilQMwlyHcZQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: With regard to the Subject: line, you're not "refactoring". You're passing a folio to the function. > @@ -6108,7 +6108,8 @@ static void unmap_ref_private(struct mm_struct *mm, struct vm_area_struct *vma, > */ > if (!is_vma_resv_set(iter_vma, HPAGE_RESV_OWNER)) > unmap_hugepage_range(iter_vma, address, > - address + huge_page_size(h), page, 0); > + address + huge_page_size(h), > + folio_page(folio, 0), 0); As previously, use &folio->page here.