From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0365EC369C2 for ; Wed, 23 Apr 2025 02:07:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CF4396B0005; Tue, 22 Apr 2025 22:07:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CA4B46B0007; Tue, 22 Apr 2025 22:07:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B92376B0008; Tue, 22 Apr 2025 22:07:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9C9B36B0005 for ; Tue, 22 Apr 2025 22:07:40 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 859821A063F for ; Wed, 23 Apr 2025 02:07:41 +0000 (UTC) X-FDA: 83363672322.18.0CA8660 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf02.hostedemail.com (Postfix) with ESMTP id 9384280003 for ; Wed, 23 Apr 2025 02:07:39 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=XVljt1Mx; dmarc=none; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745374059; a=rsa-sha256; cv=none; b=JilGHxx57QATsd4VSewSqLwb/ttlRob6VlDckHqWNlsb9ZSKt7F5nhBlF/y6HWSV6G1HtE Q6qslQ6lQhzrqz/Bo0LYJVYnonDekZzVQehqq34sjm5JDDlao8VxvifXWthP+4FeDqSPpq LA0lq7n1GvMU+/c8BlFWwQGRIobCuT8= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=XVljt1Mx; dmarc=none; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745374059; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=K3bvHhOuzFDWG21uSveSS4IlmdR6tNlM7Eg3Pt1CNJQ=; b=YGHoL+A2f0umhgge8TdKHGK7GP7NhzWGBuLMFBaljpOyUbPbEdW+nnXGimtMMS/L2gGCoN 9gleGMOOBBVJ6CJoIjv7e/QAEnK2HyBmcQ0iH9IvZK3nMkG3/dVeW3JJjP7fVUzRJUPihA R5OhzX2yDsDGbKCtb/ZXYv35X/6/ERo= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=K3bvHhOuzFDWG21uSveSS4IlmdR6tNlM7Eg3Pt1CNJQ=; b=XVljt1MxBfBaQS0j7G3ARlX46X XQd0euqi1MvW3hy5nnMwaXu1DdBkHCwC/f/3IZrX7Yw37eFiwiqaLL8WeIoghv7j758UL+35nKK6I Kd5M536psondnaVNg8Rg2eotJVZ8mDuc45baWhyMs0nX9xLTHUeNZybjJlL6FRTfty9BqVjBQs9A+ pXXJCkwHzHEV7d7keWUeuGQlq4K2Y1Dc1t51WmaYR5Th1+Vh5sXtzW7xyKUlwY+6YWFk1CbL6fVZy 4maL93cgQShcP0QYBIFpLhqwxxqxdllg7qZvKt9ONVmCHctNOvbxHXeHil3EAa837EOXAO1y2ZAhp EIkWn7Ag==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1u7PWQ-00000006lwV-2N5S; Wed, 23 Apr 2025 02:07:34 +0000 Date: Wed, 23 Apr 2025 03:07:34 +0100 From: Matthew Wilcox To: Pedro Falcato Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sebastian Andrzej Siewior Subject: Re: [PATCH] mm: workingset: Simplify lockdep check in update_node Message-ID: References: <20250421-workingset-simplify-v1-1-de5c40051e0e@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 9384280003 X-Stat-Signature: 5ekuk9ktcfu3fhejgqe8r7czxsezrtwb X-Rspam-User: X-HE-Tag: 1745374059-562359 X-HE-Meta: U2FsdGVkX18IoAZoiQ24Bu5KvJT6zafzLGLgtXPGVPRaxtZeh7Ua5v/9SgWKTBn/FsW7IsQ2r/qSxqhIXkh1gbC00/raqGrRS7yQx6EwRtOOqcDwT1yYch9b+TIDQkw2aohw0OES6GSqJ0y6Rf1ewWNoXmKYUWqNpe9HMMC3Ij0/hzCYBOniIBmYgkWvhzwrFoAZpDpC/3/WxviVbJgrIGLZm+Oj6XyiVhr4Aeak179wt6S/4UY23mL5UbsMJ6tS17cpoVdc7SoHw2G3sTMLDiZ2m4U3I7S2BjHyrWDJPQ8o0FH9j8LuME454/KqOvlslBY7iMbhZVZU0WpeL8hZUHYiQhdBDzDEIV2XpPCkKpU8gyUGsSgDus5K6Ca15inKBoIUK2GzAwZhwM73Ez6o+nkWsseeosMKlFFZmrVyq89N7tlax+3AitQd6dLbGvguAJ4wUkUC1ViXEuHY/5+a6B6pwdvCwN12x/+JDwhvHQSWnSWdmp4YJf3w3P+rJjQYlviJZ+Fn4BhqtL6pYMGNpbsMm/HqZLW8wxhLpM11EJ9vqA9uidpNJdl5GV2jChmDNYxuzITLYQDK3X8WTU5f9j9meTh+K1S1JNwNySd8J24lua4kwD5WUBrQPrunsh55N0V7PCU9mO8islxUDg3EBo6eEJ5ZxrJ7RoFx5jNopFdbQEgb+pUebyYQkEQ49FNl/hsc+lzhz2BE0zk24uEeYLw4ybnScUFWagBkw8PRYHP2SiwpnoqAMDNBRkgI+S/6hV7+BnVn4ddS+SQbvwEmIC5x6UzJTbdqacQ/r5XXF3ifc0tgDcC+Ra51m8QcBCQclOvRQKdbWBYAepmdWtGyiSCfvaL+Ggu0bfyNjSSTMbwTJA4UmDvd+F/tQX1aojyF2AFzFMfxZ5Wn3W58h/RJYD2YQBQBhUlfbmpRmsw/dz+G6pB5D5jDEOJ3fyzRNIWrX2gz15as9JlWuttj9T0 D05yG/fb HN63Sjyxx7wtXq2a/gk/rwUxsxKUBa216Ose+4aS0jMdR6XDdEuiqlc+NTHraKQs25WA3Uv96RuOIjmLVIG8oKLD8JRR+UZksGHFdnUcGGoprKCYeFxlYWTcI7U7JVYOPE1yXB8EbaDziZPMHhD4eoqTmk2bwjtfVohUSytJgOuWhLXYD5w6PlgPbcSoYsnFfh/xVN2e4W7t0CFqWNcL9GzKoHEvZkL7dfbtFeL4X36QIQpOoU1cX/9JXNFY412SfH8/KvZh4GFGaBFtjQt0Zzlvu7PZ1XXk6cH60eceplsW38tWxyjojfuJ1mDtR6dE4XQ+qttNxqQBWhyiC1OrEAXsZKpUdboLG0GdrMPei23v/1rs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 21, 2025 at 06:39:53PM +0100, Pedro Falcato wrote: > Actually, not sure if this is wanted given the original code is a little more > explicit on what the lock is. +CC the original author > > If people think this is worse, just drop the patch, I don't really care - was just > checking out the function for other purposes and found this bit a little confusing. I think it's clearer. Reviewed-by: Matthew Wilcox (Oracle)