From: Matthew Wilcox <willy@infradead.org>
To: Pedro Falcato <pfalcato@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: Re: [PATCH] mm: workingset: Simplify lockdep check in update_node
Date: Wed, 23 Apr 2025 03:07:34 +0100 [thread overview]
Message-ID: <aAhLZgLT6qPNK4lz@casper.infradead.org> (raw)
In-Reply-To: <bmzzod73cuumphqg6nyhegogc6wciyw7oewydljexni7tgdcni@32hathqdj7qo>
On Mon, Apr 21, 2025 at 06:39:53PM +0100, Pedro Falcato wrote:
> Actually, not sure if this is wanted given the original code is a little more
> explicit on what the lock is. +CC the original author
>
> If people think this is worse, just drop the patch, I don't really care - was just
> checking out the function for other purposes and found this bit a little confusing.
I think it's clearer.
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
next prev parent reply other threads:[~2025-04-23 2:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-21 17:16 Pedro Falcato
2025-04-21 17:39 ` Pedro Falcato
2025-04-23 2:07 ` Matthew Wilcox [this message]
2025-04-24 19:17 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAhLZgLT6qPNK4lz@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pfalcato@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox