From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6F5CC369D7 for ; Tue, 22 Apr 2025 08:53:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AA5766B0023; Tue, 22 Apr 2025 04:53:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A53AC6B0024; Tue, 22 Apr 2025 04:53:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 91C2B6B0025; Tue, 22 Apr 2025 04:53:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7561B6B0023 for ; Tue, 22 Apr 2025 04:53:15 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9687ABA04C for ; Tue, 22 Apr 2025 08:53:16 +0000 (UTC) X-FDA: 83361065592.20.6F0521D Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by imf14.hostedemail.com (Postfix) with ESMTP id A6DA3100008 for ; Tue, 22 Apr 2025 08:53:14 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mWSqqjSR; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745311994; a=rsa-sha256; cv=none; b=fOcBsPdPmIFTkVoTHgLTz52d3mQg3dLdJIugSceNaqma/fAbrcOn+DW4Ov4Bm25hIM5eIM gnuSDY0gdjGVAxl0kvI7UBgV691o1pEQ+e7wMtQ0iXIkwyu54WpAuCDX8fHfe9GSuM6Ysf 4WzJF8Nt9UGkr53B3ZqpPH8RIVUuQgg= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mWSqqjSR; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745311994; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=B107IeEBYcdTeNa+0WuZ0QSN98QiHvhvMbSv+mGPRVo=; b=D2Ys2MFTaveeG1aj9WWub1eSPiH5/5YAgIVUYS5DJ6gMUggNPW7fCO4gCwNe2k6miZjSqe bgkH+e/VC2O0EL/nFzzokVtJiPReFlU7ID2yVIO34CuRZw2KzKKjfB208mNPof8e3yhdAL dMNTCO51Ct/MqGIPi2i27b0Edx1Jyhs= Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-54b166fa41bso5401524e87.0 for ; Tue, 22 Apr 2025 01:53:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745311993; x=1745916793; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=B107IeEBYcdTeNa+0WuZ0QSN98QiHvhvMbSv+mGPRVo=; b=mWSqqjSRWBe5dNFAHZxSrXsjsJ2UlsMhoeg2LF7O/+VuksHZU4ItAvNB2vcf9wGfMm v/47e7/SnoAZOzVk8P+IraYu8eDzEg14OGDHLI95/wFB2IhwDcpHKx8FU6vvZ8X5QfqY +7ixpEdB64q/Ica/MaiWSnFwUGfXWD9lOcPpcuDLbbc94CvJjmL4Q/tzu0EGDtyORM8W v8X6hlY0gDuW1KyNiIBZb9qrn/9JXOJHCEAfEJUP3cJmMTBztP4dfqIjWqzr+dyOUwUP rub0Tp4rEhHLSkElnOwSRoXnuqfVr+sLRnunoHlqxjkwi7SZiQVAPwoqcnEtFes4Fg8W KFXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745311993; x=1745916793; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=B107IeEBYcdTeNa+0WuZ0QSN98QiHvhvMbSv+mGPRVo=; b=XYXSrHNULXUAoyWG7r4rMU7NQlvyPnhyy9ONkXRAoJhH0+geVEPIfyH6/dji5E33+s if5moru3OT61DtXMbOr1XtDo/nnWjSZj/qD+hA6YBuvUD2sCHuluZDmq5Wxm/gKqy6Ok gFL/rPpDQ9YcTPYkHUa5JeoDVuVpLZ4KD4u4i1G4vv8FeOc83yDzoFB9ZuFVGAiN3KGV PPySdTjVWi2f/A0JhGP/wc+UbBT6CO+Jhw4jq/q28wfkEnXQEeS4TtpevTviGFmY4TAc 8Be3t4eWRouWBMW8JbrPuD/+NkL/Y5c98810T6AR7RZBrqYPBqomx8XWUy72824PjUX+ 2xkA== X-Gm-Message-State: AOJu0Yz9eDNEM9dqNP+/kWyTiHsUORzsp+/0JE6LVvx4nbSToDsTLKCl wmwhBRX4pSuzqbi2TGQdq0xUqVFZlVntPaUiktH2H9ndV78XQ0dK X-Gm-Gg: ASbGncu3gAzYOCAzqHAA/m1KugK9kehmeF1ox/P+WYfUIZaMvuDuhSr8PiTl0+fe5m2 tPTsHrx+xTdrgDNneGYoJAzLNxJtNJMUfK3jzyS+ZmNxuIM7Jz/6N59/Tmo7xViIOhUjO4Jg3Fg UpMiHkl3fA3JsatTJGVfpUXUx9EQInY8WWicwuGm89DUSJAZO+6MQXYQHWjayas7SQWJ23Hldx2 +s64A2gbdTJm+h8n4r4O+/Sq+rl1VcuEjrC1f1HdjfRHDyfN62pE93AweP89JiVA/CsCxf3oZk4 KSKJVylNhFf2eOrHWSOjLjw7BncSJ0P5GaA+Ef2YumpTytE= X-Google-Smtp-Source: AGHT+IHAzgi8kGpVE7gevRvjayWFRsuXzx8hOLHXEi1ai4Wwn6M2n3mAJLfRBCBCN3H/dFgyt5Lr2Q== X-Received: by 2002:a05:6512:39c5:b0:54a:cbfb:b647 with SMTP id 2adb3069b0e04-54d6e6589fdmr3933538e87.37.1745311992492; Tue, 22 Apr 2025 01:53:12 -0700 (PDT) Received: from pc638.lan ([2001:9b1:d5a0:a500:2d8:61ff:fec9:d743]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-31090826cf5sm15574721fa.87.2025.04.22.01.53.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Apr 2025 01:53:11 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Tue, 22 Apr 2025 10:53:10 +0200 To: Baoquan He Cc: linux-mm@kvack.org, akpm@linux-foundation.org, urezki@gmail.com, shivankg@amd.com, vishal.moola@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/5] mm/vmalloc.c: code cleanup and improvements Message-ID: References: <20250418223653.243436-1-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250418223653.243436-1-bhe@redhat.com> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: A6DA3100008 X-Stat-Signature: 471hbfn65nt5iy6na6by6wq53gyxn3d4 X-Rspam-User: X-HE-Tag: 1745311994-410944 X-HE-Meta: U2FsdGVkX191wv0yHLx/3/LmCitk57nrMGZNBEz9eYdm+UeNVTLj+p3/dNnwr9IcCg1TVz8IsFJcQ3w9Z9OL9psysqWJb57js4ONtM0iseoimuRxmXNO94/6pzWIWhpnWQUvIF184rXfObRA3QRAR8L+oxunV7GMQdnGBt5+LI6yos1fzeCXOLaK/UKpN5nNnNNNldyNvs3SknIS+oWkRYyjcAyNEqSbOg0cJabwBrUfKH07eXD+tgVmRQ71go4ixC5a6mVOFBjk4lu3YjJW0C1DhMvT1Ddi/bX7rSvmwEdQTsfMng8BIflhpKL+EeBQoPSYr5s+0JfZKszeJ5jGFSDf7jH6oswmniGtZQk6JIx1sUH56cJS0e+HYwMxP0/q7gRMXqQawJuuA3BdJaIDS6lncXSmEVNeQ1MlVyy/BR12aHnm395tuggpGXlJDFpNJEI+kuMTVd4J1vEwj5f7FMoiP0A0yidd5ASssD1i5fxD5WsYyLXeSDT5fn4Ym7GtgScJYBRowkz65x9Ep/HbDdf0+5J1KTh2o0JfSp0RAmMq3Y+uNIyBQBIGPHaz1+z9AC+FgrLikzLZsgTbNtg1EJFpN0kdnIB9plgqwTddEBR3ox4wR1WWsi8xTHXigPDSADJLU7wAAgXbv3HGesiDb/gq3hdTjIKHKO8Giw4Mmyz352JoMrKE+G5v7CE+rmHYrULwXg40MonEytaCT4GjKdWIuLr+njYKQcnMxbf9VBPxGO+K8Y2+gxYjKCkJ60obI4HCmAl3ySwdeeUs695H0VfRFKZcuKmyjtOA+KqgZDnbsBJYd+SqXA82+tpqoM/RXkPIkX2ePLSHqgpmoYHK5uZRxqDscTZApa79RgwGI5Rq2jCsiXJynW2ocYCoJGQGhcsd4FZWbapAYdT6AuyN77SzOENkYXHHKxDWr366DqHkZTxQ/fioZ0EfBjrqXY24TDztvoK/zctAaXiqegm sUbo8ehc M/5thm1FlaMunm6B9nk3Lu0X9P3eWkn5tuJV9lR+9taxE1Mns018dLHk6rUEmrGTFMc7UMuf8TNDXOZ+sQMlT8uAIGPp3UZMwFEtj3FIldGWaHsYYdeXemC4HrzHKbvuLvVDh0muaIEX7HInB2astUSqvUf8qOTw/6oVrJRZuYagoMrrORuUTyq72i26jrXGgxGkvftlXhvJHY5WqmhunDXUvVsjzIe9S5jnGVI2/RzKwTMOGDZxRD5+ANj90EXSps0NODY4x200zS+Xolvop4tc0Az/pDpl3PpT7KvosXoIJ72+xtCaM9Dbx/bESv6qB15m8SrlU3HHAHDtP7UsXtDx84TPESiLD3VVSLeyujqRaFKn2t1guTf9YwRG74jszQ/JEuNz5dJ6GFtoL/zWewHVd3YJZOm3XF7hs7gpg+GAfxKbhQ5nw/OY/dxeXCjgScA73nrGZyqOZJUM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Apr 19, 2025 at 06:36:48AM +0800, Baoquan He wrote: > These were made from code inspection in mm/vmalloc.c. > > v1->v2: > ======= > - In patch 3: > - made change to improve code according to Uladzislau's suggestion; > - use WRITE_ONCE() to assign the value to vn->pool[i].len finally, > according to Shivank's suggestion. > In patch 5: > - add back the WARN_ON_ONCE() on returned value from va_clip() > invocation, and also add back the code comment. These are pointed > out by Uladzislau. > > - Add reviewers' tag from Uladzislau, Shivank and Vishal. And I only add > Shivank's tag in patch 1, 2, 4 according to his comment because patch 3 > and 5 are changed in v2. > > Baoquan He (5): > mm/vmalloc.c: change purge_ndoes as local static variable > mm/vmalloc.c: find the vmap of vmap_nodes in reverse order > mm/vmalloc.c: optimize code in decay_va_pool_node() a little bit > mm/vmalloc: optimize function vm_unmap_aliases() > mm/vmalloc.c: return explicit error value in alloc_vmap_area() > > mm/vmalloc.c | 61 ++++++++++++++++++++++++---------------------------- > 1 file changed, 28 insertions(+), 33 deletions(-) > > -- > 2.41.0 > LGTM for whole series: Reviewed-by: Uladzislau Rezki (Sony) -- Uladzislau Rezki