From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20052C369AB for ; Tue, 22 Apr 2025 01:00:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 255E96B0005; Mon, 21 Apr 2025 21:00:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2066E6B0007; Mon, 21 Apr 2025 21:00:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A7066B0008; Mon, 21 Apr 2025 21:00:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E02F36B0005 for ; Mon, 21 Apr 2025 21:00:54 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2BF37BF3BE for ; Tue, 22 Apr 2025 01:00:55 +0000 (UTC) X-FDA: 83359875270.28.A69EFBD Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) by imf15.hostedemail.com (Postfix) with ESMTP id 4638BA000D for ; Tue, 22 Apr 2025 01:00:53 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=YPvZ1dFC; dmarc=none; spf=pass (imf15.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.172 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745283653; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=90WqYzTUohl7lOp7C5Tba3PcsVTn1W7MH0EIP3L7DLY=; b=P+r5TepkMalvbEJZ0NV4O0g0vfqs8+Mro9LO+LwlR0Z+dRXPeW1tOh/nMnkh3Pup1tjDw0 g+AQIz6DWNYs7sfd5WOfmH1Hn4+GzKdU6OaCLCDtgt4w7dLopmIBZXM017eNYq3gOjSlNP F1/kWFTnnfmg2NqKhKSMrRuC77LHZqI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745283653; a=rsa-sha256; cv=none; b=FytBU7uS/ijV6Q4OtMYBItSHLhoxWvclnOMG1OTCTgViMpEa74EyDw+HBFX+xNBddw9VhZ mEdz3NXsc1HxI5Zry0qoyTI+YYbRdMKwu9as97YWnurb7PjGqMb7F7N91Bot5XfRLvt0ob 2EO40kP+ifpOGj1XKXhTeZ2aH4zOGGY= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=YPvZ1dFC; dmarc=none; spf=pass (imf15.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.172 as permitted sender) smtp.mailfrom=gourry@gourry.net Received: by mail-qk1-f172.google.com with SMTP id af79cd13be357-7c53b9d66fdso626199985a.3 for ; Mon, 21 Apr 2025 18:00:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1745283652; x=1745888452; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=90WqYzTUohl7lOp7C5Tba3PcsVTn1W7MH0EIP3L7DLY=; b=YPvZ1dFC2Q18lG5YG9gmSszBIHWQYqEo21jEeAAC8SZueOo2aZyRSobuuiYVyfZlXg 9zSeiHkPC7/UzJLoQCQ6qjJVDPmTXqd5knL5QrRHCG8Dhq6IASvkYh62Zg9s1GXXjAxU +rnXGvO5nDvkMnI01u+Ip1OJCOnC5H6yNTwBbmhxfAWxBzkt0JaPIwRnHJQ6O7+clYfn CF86Ioy1R8jThsq2QjDymj+QSGtcU3Kds0JgPATOT97Jd8z67Ew+Etr3hs73ZdwhiMYA Le7tGPBwoE65jCT4pxyqz9pQa4j9Ww5UCMbx5QePF4/tiUlgdkajR2HHKGRYDzYtvxUB lrfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745283652; x=1745888452; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=90WqYzTUohl7lOp7C5Tba3PcsVTn1W7MH0EIP3L7DLY=; b=tieG9lXWVvMeoWxmXwKVU8MwNao4UYLyXm0LIz06B7RxvLZswFwYpGwuQ7kpfapfTi olqHOFCLS9qtgz50uSM5vxIMxJz0i5CdY3xeSwFw60hJ31/Gvh8yAScobdVStVtBs4Cv y2y2EgfTVGQgm7+CWuf6tBAUx9RkrELzEo/o/n2bpmriRaSFdg3bKkq9v9IcTELK8eKq fC8KD+oShu0C9uDdiN7mJgFjcOdJxAZoMPgW+yg2FL/ls2irZPF3Y6dOG6L3r2pezy3N fbIqPQAhRp+EcwVw2wCovWyqEdnkvT6TVuS6Ch7ghtEiOaz2mgZuQR0i4kw0FwELE4Gh m6OA== X-Forwarded-Encrypted: i=1; AJvYcCXBS68/zSUd+Ys62dYSwKbM9A4ONYqVjB9v5BabiL+PFFq4Y4lx8gOdrrgMLutNjE4wAEV5Z8t8dQ==@kvack.org X-Gm-Message-State: AOJu0YzK8PHBOKiNiOF6rCS1obI3uYUq/sWMX8CDnZR9KfPL0J1fsMdh tZXYL/f2Un6AfJqyxQ0r9Mrlrqn9G0i9kDh4ByDh1PC8+K1QqXfstumbQsC+csE= X-Gm-Gg: ASbGncu3/+5GN0Eih25MtNw6IoZwa01vIRFEFls5xKdjgMs1qOQXDkk8wzY88PFtfsh SZ2SNl6bi21fg2BGdYiVf2WMr4y/aCCQrCmCE1hTjnwoQX06Klw1vDdhBaLYNrVZ4AdT+W3ErUE IPAT7P28UItqSRpL8Z/Gr3rGMRosDclebhaGlNweCt+uwv5fYSVWnIMJiOgPCC/zroW+jN+iVRJ lhCer30JrkAhb0HANiR/rQIDPAMGknY+4T9v6s7HaylMAKVix1IFLIvLTzkj4awU0vn4fgibE2k H0Up0IOL3rm8rsDVkmS+QtDmW5WmeNCGUE6IbTDhO5akV8rEuJDEYQ+jub6tB0GeE9Pxw2+Wbp/ wE8iBnbQ8mdd6ltNTdH5a0nc= X-Google-Smtp-Source: AGHT+IHiMCQ4CKaumf1ZfYJE8F7xvKHLhb4koX3kikt1CtQaYhbu+kCRWDD9oQA1oGd7re3S+fS3Og== X-Received: by 2002:a05:620a:2588:b0:7c3:ca9d:210b with SMTP id af79cd13be357-7c927f67bedmr2112823885a.6.1745283651624; Mon, 21 Apr 2025 18:00:51 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c925a6e7casm486458085a.10.2025.04.21.18.00.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Apr 2025 18:00:51 -0700 (PDT) Date: Mon, 21 Apr 2025 21:00:49 -0400 From: Gregory Price To: Waiman Long Cc: Shakeel Butt , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, muchun.song@linux.dev, tj@kernel.org, mkoutny@suse.com, akpm@linux-foundation.org Subject: Re: [PATCH v3 2/2] vmscan,cgroup: apply mems_effective to reclaim Message-ID: References: <20250419053824.1601470-1-gourry@gourry.net> <20250419053824.1601470-3-gourry@gourry.net> <7dtp6v5evpz5sdevwrexhwcdtl5enczssvuepkib2oiaexk3oo@ranij7pskrhe> <6e7806a7-9ffd-4c7c-b247-934b206088c7@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6e7806a7-9ffd-4c7c-b247-934b206088c7@redhat.com> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 4638BA000D X-Rspam-User: X-Stat-Signature: yc9j5ymzfte7tkftyr8eenjm9mcc4ms3 X-HE-Tag: 1745283653-190147 X-HE-Meta: U2FsdGVkX19a/C5aUJ+mk3a50I91oFYrx1DxkSx/PaEfn9pHhztlrmvWs2x1qAAe94zK0Flthch0/iBdFlqMqZBPPQ1rtqxBSQ278QiX/MfS2wWyidIijWmPyCD5CPY/i6iNqzJYTNe8mpj86+7Kb+mcVaaGXCRKgW/JNRtXsnrPYSW3mi2f+KPy8E6VBpHvfOTZaRPaY8wz8J+2yK1mp/HQVdr3RX9Y26oTEvxdhD37g0xid8US0YUWghaZGuWvdbnd0IgaxCSezpkXTwXid06u6+RJ2Ovv/GCYDwGPO4sBPMnu3yuxAEWzyO6xRZsQbx/gxy1n/HmNLPUGcDKO1YpJTURLxs+ixVK1+c7FAmSe7FMR9J/lLLYWNFE5vNOh8arFy7TZ8rCyGIIqg19Xiz6yfR/2bfRZx9zm41KS5C5rCS6r+uhdwektTRJO9vBzsCb5632B9XyAUre0g5w72/bVrqEzLMzl5skC1zx6RxEjH5vpGA6MBtSYoiFDzgnTUzimKU01YVEgzx8ZZPAOUfc9DsErQzLELZgIApLUPeSXSaDQu60uz+QxdPC+/F+J3kFe7vxnFOuirI0dS18iRRKQ6dLJ6WH2OkGGF8bvVqOeCaoMSbR6j2UfL/2R2r+k6M7d4RyzxWaug+Dez5kukjDz6N5/H2DUpFf8LbAEjZOkTkd70GBNT+NUWzBm0K3imzqXUZZ1t03pBcwQlXceiwsD5mZ42Wt9FtVqHmiEzYmL2zYj+NjMl6M1tFpJ6sJbMVm7T5eRSMyV8nXUcZLn4xAzrGShzxTSwF+U1I391FtiZAU7G9arqs1QUdR/uZR+TU8PT8GARujolzhcGmH5ktpOmsY9ziG31qGqssCKGLbxuNbt17cnNJ0pCjfXAphU/lQPBhiN1fGeofCUnwShRH71YksFeWVbFP+yiKztGfBghR0BYxt+COKyOYNDUiVSxtlATC04wUaaqYItc4r MiyC1fGE OIvB7ezKQ/CM1ECVA6lzURnnnZGfertWY8HUbqgH+FI9bCsy6Avm/ASOXQRkL4zsNQgvfpF8smxEfQUnP7zx+xY65Ci8pPYfKyjJ3SgCEnnRVyiwC36n5A0eKFlCDZ46IiuhLGpfnP1SFZY4+2GBI/JWKIhYvD3KOC1j4jCLZzUB/RnfNq/n1j3sCJJPew+ouX6Cr4SgT4hIraSg0eZEyWOu08cpHaBfiXZu6CSWQc7rsVJFPBYzb4RM9sD49bXETGb7rNSmkxDVMuYUjV5R7IL80fE5+5VJnUY6voXPJg0r7OsPdFxRsG8+exnp3f65nxERVH1KzhsTCv00iIdyy7AF49Zqp0x/TkSqaz3xt1r0wZLFWtXewMrpspkIzSqhj8u5U X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 21, 2025 at 08:35:15PM -0400, Waiman Long wrote: > > Your current patch is ignoring v1 as css will be NULL. It only works for v2 > with a unified hierarchy unless some users explicitly force cpuset and memcg > v1 to be in the same hierarchy. You can certainly ignore v1 by using > cpuset_v2() check. > I'll whip this up and get it out this evening. ~Gregory