From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E1FCC369D5 for ; Mon, 28 Apr 2025 21:01:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E17506B0023; Mon, 28 Apr 2025 17:01:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DC5A76B0028; Mon, 28 Apr 2025 17:01:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C66C96B007B; Mon, 28 Apr 2025 17:01:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id AA91F6B0023 for ; Mon, 28 Apr 2025 17:01:49 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3D38E81502 for ; Mon, 28 Apr 2025 21:01:50 +0000 (UTC) X-FDA: 83384674380.06.3E6F24A Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id 478551C0006 for ; Mon, 28 Apr 2025 21:01:48 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="j/Rg4j83"; dmarc=none; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745874108; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FEO8loLQSHaJvJb6sb7v0d/G7pXWvP0/bwDA8Txbzyw=; b=uEhbiS2VhwOK4WzmZJqRIgWaqXjHdpu13uQn44KMUkV2yUEngcOb1OY2n1w9sq/kSiFhVS m7vNZGXDx3QQ5G7oYudtw+MwO0kIuk94AW0d/XOjyLTP8AIaWNzkZF7zyAJcfJ8bQb1MWD p0KWSiIye4iJVJaZuFxQWA6pFOMo+vc= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="j/Rg4j83"; dmarc=none; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745874108; a=rsa-sha256; cv=none; b=vKnKQ9ir0LC5kSXXaSB8DsiHeRZJ+li/qDt00TIaPR4v3JajZRxCK6fbypu7CjPjaCf10L Zqe9PWbE+Bx8iwhDs+xPDW/GDUnU9elwqbBRIV0K7AsMUB+z+I7X/EAxzEWZHLS5m+VQIk EjyvcoA0QktPHWjPdNGGFV7zKIox+nU= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=FEO8loLQSHaJvJb6sb7v0d/G7pXWvP0/bwDA8Txbzyw=; b=j/Rg4j83JRIcf7GbBnG3cUzfbs c9OddhkqJjZnJDT7nvbDTUbuYupdFKkU/NIhj2whYPR2NY48im2NyyqC7FQtMJmifNEBNoqwF+Y/H X/Q9gVLgUE0QYN3DQ/NI7iTIuGRbcFEgbZ35XbalOxYAkwaFe+4923QEti+YPhkHenOeHX+ZTNnUA 9O9s8H552/f1UBjnYB4uoGGGTGPwpN/p/+GVWvIHFtLEW0HjA8HVQ5bRnjrOXOUzqzsN+aJKEldyG xJAc2aSxNysvEHNHRo1L51/m1zDa4XJBI3mtDRSI5VjAHiyyH9gziOPDxLOTrl0aOtFWswB2uXNxX bpXrvCNQ==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1u9Vbc-0000000DmjI-3qEQ; Mon, 28 Apr 2025 21:01:36 +0000 Date: Mon, 28 Apr 2025 22:01:36 +0100 From: Matthew Wilcox To: nifan.cxl@gmail.com Cc: muchun.song@linux.dev, mcgrof@kernel.org, a.manzanares@samsung.com, dave@stgolabs.net, akpm@linux-foundation.org, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Fan Ni Subject: Re: [PATCH v3 0/4] mm/hugetlb: Let unmap_hugepage_range() and Message-ID: References: <20250428171608.21111-3-nifan.cxl@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250428171608.21111-3-nifan.cxl@gmail.com> X-Stat-Signature: rjec3imckxkaewibhgjm5r4rz9ux11ua X-Rspamd-Queue-Id: 478551C0006 X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1745874108-906543 X-HE-Meta: U2FsdGVkX187OK8EO9D6Qtvp+gOAXdYHdxfHujm0ojo9p8aSInEelvMHUxGHYA8ymsfh3Y896h8O5Uqsc+9As/HR2Ak5C+Zk14YsP3d6FkcJJU7Xc55mB/ljzqz46X2gQOZzgusKaCmEC/5H1zAktUhw7eYGlkNAeT2CjEuTH8XodiIrYHPRpoRlgHXlCBgIIqn5JwmZJjKobUm7i7jM9iPMdp5/rcXj7VjhoreS+iS4I13MnLswKFfYs4Xa7Pd2zV82TySyGeMHEbvDQLRbuJEGVY35RLqDPjuHLShdInUdgRoS95SBz5QFCAF5cQIv9fuULjtWdP4+725OWuYwCdqrkzLJ9NBidVec0d0xX9d4aQT7gXJU7th8hADwf0Biq7OsTWJxVat/UVgdr9awYliQfvUQmBKA+8iP7eiflpQOdAxp5lT1mr/oXx8yPB+y6Nqu4S4GbsKN99q4+I06u9K+IDpK4j7gEUewjvOUFGImiJiA9SsQzyrF0QO/NEjobauPwdmR4EhB/trRZwPcw6LfpdXq9FYfnO0HxG/9ZK6jcZPxFYEUpnzQnbeeGJAm1fHjcH975idcIBdfYTUV0X0TN/ZfBfIpIT7Ni9J7bBAp7fQruy1inpfvDv8XXBg7NNEEhIgWmim2wYiSNU9KS9OAixar7oeyelFAW/umuhjLom8JFreuJNqz9gWNIenSnnI7V8MyCMobGHxyrByx4VYVwU8WFtjKfynJ1+4OJfTszHKop/uPYxgOxI/3gRvFCH45h/5yPY9PTBmokT97TvrBIn9KnlhhIaa7NoeLwbrhaUkQbcJsn2i6q7de1TZxawCPIVkwAFFpGnzJetIYRg3jB0VyqFXBxwKKFmpZHx9IpGQaT2spo4mZ2XZPNjeShyvtPI+XluwaThdZKWKe/8kTLiwb/4fr/E2XeCtlauugUlWrpFp+ugSX4pUqCvfk2PZm2TD841r0O9gSgTN 5WNyyL3U 6SWXFP6ouqdS5S3b4w/I3TcmrH0Ye4+TuOFEw2rvaTD7mm9fh+LPqmJPiygd7QXyT8EOvGZUgrooPcknWfdqUjwhK0eEZfN751rzlLdZew7TAIi53o1PgBLw3ZNVysxE1o6nul4jR/+0BgATR1O5/hIlDQzPrgXjEUawZTb0T/ch/R2Lz0UfBWEonDmNJRKlb2r6WWKGk2Ztjrf/B2g8lzUj4GhMeZLyc7pS+i0eNSrmiSO1GpBO9KxZpbv/9skjeYvJ6F9ObqmbKGPnnanlIz/zYkdLCJOYFBgAHXpGfA+H4pSsZ1z1ggRu3ZGBznnSNaKkwjAsfAxr1xTQAR+bX0q14xpY11oTWTxM/SjQbYsE9xWE6JnRdkvVVdCDsh/Sakp2MfPSoktIKtqBkqPC8W8ZoJDJI6M48Ezmx3r/y/zchFH0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 28, 2025 at 10:11:43AM -0700, nifan.cxl@gmail.com wrote: > From: Fan Ni When you're sending v2, send the same cover letter as you did for the first one; don't make people go and look at v1 for the cover letter. Put what was changed in v2 after it, so they have some idea what to look at when reviewing. > Changes compared to v2, > > Patch 1: > 1) Update the commit log subject; > 2) Use &folio->page instead of folio_page(folio) in unmap_ref_private() > when calling unmap_hugepage_range(); > > Patch 2: > 1) Update the declaration of unmap_hugepage_range() in hugetlb.h; > 2) Use &folio->page instead of folio_page(folio) in unmap_hugepage_range() > when calling __unmap_hugepage_range(); > > Patch 3: > 1) Update the declaration of __unmap_hugepage_range() in hugetlb.h; > 2) Rename ref_folio to folio; > 3) compare folio instead of page in __unmap_hugepage_range() when folio is > provided when calling __unmap_hugepage_range(); > > Patch 4: > 1) Pass folio size instead of huge_page_size() when calling > tlb_remove_page_size() by Matthew; > 2) Update the processing inside __unmap_hugepage_range() when folio > is provided as sugguested by David Hildenbrand; > 3) Since there is some functional change in this patch, we do not pick up the > tags; > > v2: > https://lore.kernel.org/linux-mm/20250418170834.248318-2-nifan.cxl@gmail.com > > Fan Ni (4): > mm/hugetlb: Pass folio instead of page to unmap_ref_private() > mm/hugetlb: Refactor unmap_hugepage_range() to take folio instead of > page > mm/hugetlb: Refactor __unmap_hugepage_range() to take folio instead of > page > mm/hugetlb: Convert use of struct page to folio in > __unmap_hugepage_range() > > include/linux/hugetlb.h | 8 ++++---- > mm/hugetlb.c | 39 +++++++++++++++++++++------------------ > 2 files changed, 25 insertions(+), 22 deletions(-) > > -- > 2.47.2 >