From: Matthew Wilcox <willy@infradead.org>
To: nifan.cxl@gmail.com
Cc: muchun.song@linux.dev, mcgrof@kernel.org,
a.manzanares@samsung.com, dave@stgolabs.net,
akpm@linux-foundation.org, david@redhat.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Fan Ni <fan.ni@samsung.com>
Subject: Re: [PATCH v3 0/4] mm/hugetlb: Let unmap_hugepage_range() and
Date: Mon, 28 Apr 2025 22:01:36 +0100 [thread overview]
Message-ID: <aA_ssINhIDuxCYP6@casper.infradead.org> (raw)
In-Reply-To: <20250428171608.21111-3-nifan.cxl@gmail.com>
On Mon, Apr 28, 2025 at 10:11:43AM -0700, nifan.cxl@gmail.com wrote:
> From: Fan Ni <fan.ni@samsung.com>
When you're sending v2, send the same cover letter as you did for the
first one; don't make people go and look at v1 for the cover letter.
Put what was changed in v2 after it, so they have some idea what to look
at when reviewing.
> Changes compared to v2,
>
> Patch 1:
> 1) Update the commit log subject;
> 2) Use &folio->page instead of folio_page(folio) in unmap_ref_private()
> when calling unmap_hugepage_range();
>
> Patch 2:
> 1) Update the declaration of unmap_hugepage_range() in hugetlb.h;
> 2) Use &folio->page instead of folio_page(folio) in unmap_hugepage_range()
> when calling __unmap_hugepage_range();
>
> Patch 3:
> 1) Update the declaration of __unmap_hugepage_range() in hugetlb.h;
> 2) Rename ref_folio to folio;
> 3) compare folio instead of page in __unmap_hugepage_range() when folio is
> provided when calling __unmap_hugepage_range();
>
> Patch 4:
> 1) Pass folio size instead of huge_page_size() when calling
> tlb_remove_page_size() by Matthew;
> 2) Update the processing inside __unmap_hugepage_range() when folio
> is provided as sugguested by David Hildenbrand;
> 3) Since there is some functional change in this patch, we do not pick up the
> tags;
>
> v2:
> https://lore.kernel.org/linux-mm/20250418170834.248318-2-nifan.cxl@gmail.com
>
> Fan Ni (4):
> mm/hugetlb: Pass folio instead of page to unmap_ref_private()
> mm/hugetlb: Refactor unmap_hugepage_range() to take folio instead of
> page
> mm/hugetlb: Refactor __unmap_hugepage_range() to take folio instead of
> page
> mm/hugetlb: Convert use of struct page to folio in
> __unmap_hugepage_range()
>
> include/linux/hugetlb.h | 8 ++++----
> mm/hugetlb.c | 39 +++++++++++++++++++++------------------
> 2 files changed, 25 insertions(+), 22 deletions(-)
>
> --
> 2.47.2
>
next prev parent reply other threads:[~2025-04-28 21:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-28 17:11 nifan.cxl
2025-04-28 17:11 ` [PATCH v3 1/4] mm/hugetlb: Pass folio instead of page to unmap_ref_private() nifan.cxl
2025-04-28 20:49 ` David Hildenbrand
2025-04-28 21:02 ` Matthew Wilcox
2025-04-30 7:50 ` Oscar Salvador
2025-04-28 17:11 ` [PATCH v3 2/4] mm/hugetlb: Refactor unmap_hugepage_range() to take folio instead of page nifan.cxl
2025-04-28 20:50 ` David Hildenbrand
2025-04-30 7:52 ` Oscar Salvador
2025-04-28 17:11 ` [PATCH v3 3/4] mm/hugetlb: Refactor __unmap_hugepage_range() " nifan.cxl
2025-04-28 20:51 ` David Hildenbrand
2025-04-30 7:58 ` Oscar Salvador
2025-05-04 21:35 ` Fan Ni
2025-05-05 7:01 ` David Hildenbrand
2025-04-28 17:11 ` [PATCH v3 4/4] mm/hugetlb: Convert use of struct page to folio in __unmap_hugepage_range() nifan.cxl
2025-04-28 20:53 ` David Hildenbrand
2025-04-30 8:09 ` Oscar Salvador
2025-04-28 19:31 ` [PATCH v3 0/4] mm/hugetlb: Let unmap_hugepage_range() and Andrew Morton
2025-04-28 19:41 ` Fan Ni
2025-04-28 20:54 ` David Hildenbrand
2025-04-28 21:30 ` Fan Ni
2025-04-28 21:01 ` Matthew Wilcox [this message]
2025-04-28 21:33 ` Fan Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aA_ssINhIDuxCYP6@casper.infradead.org \
--to=willy@infradead.org \
--cc=a.manzanares@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=dave@stgolabs.net \
--cc=david@redhat.com \
--cc=fan.ni@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=muchun.song@linux.dev \
--cc=nifan.cxl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox